Re: [pgadmin-hackers] [pgAdmin4][PATCH] To handle "char" type in column node

Thanks - applied. On Mon, Feb 6, 2017 at 10:20 AM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to handle "char" type while creating columns in Column node. > > Issue: simplejson parse '"char"' as valid json, hence when we perform >

[pgadmin-hackers] pgAdmin 4 commit: Fix handling of "char" columns. Fixes #2152

Fix handling of "char" columns. Fixes #2152 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c96da34c28aa6c705ae005d542022e48b0c6a65a Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

Hi On Fri, Feb 3, 2017 at 9:56 PM, Atira Odhner wrote: > Hi Dave, > > Here is a new patch which includes the following: > - randomized ports > - delete the acceptance_test_db database in setup in case a prior run failed > - fixed size browser window Definitely getting there

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

Hi On Mon, Feb 6, 2017 at 12:57 PM, Harshal Dhumal wrote: > Hi, > > Please find attached patch for RM 1983. > > This issue only occurs when database encoding is other than utf-8 > > Also other issue was when we use connection of database with encoding other >

[pgadmin-hackers] Patch from RM1983 [pgAdmin4]

Hi, Please find attached patch for RM 1983. This issue only occurs when database encoding is other than utf-8 Also other issue was when we use connection of database with encoding other than utf-8 to retrieve data from cluster table/s which has encoding utf-8 (e.g. pg_database) then data was

[pgadmin-hackers] [pgAdmin4][PATCH] To handle "char" type in column node

Hi, PFA minor patch to handle "char" type while creating columns in Column node. *Issue:* simplejson parse '*"char"*' as valid json, hence when we perform simplejson.loads(request.args) operation '"char"' gets converted to 'char' I had to handle it manually as of now, I did not find any other

[pgadmin-hackers] pgAdmin 4 commit: Fix display of graphical query plans for UPDATE/DELET

Fix display of graphical query plans for UPDATE/DELETE queries. Fixes #2133 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4d8683e13ac9988b99fa345a7ddf40dfa2711ffe Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries

On Mon, Feb 6, 2017 at 10:33 AM, Murtuza Zabuawala wrote: > Hi Dave, > > With Same query I am getting proper output same as pgAdmin3. > Can you hard refresh browser & try again? That's really weird - it's working now. It was a single-file change, and when I

[pgadmin-hackers] pgAdmin 4 commit: Compatibility fixes for newer versions of Jinja2 (e.g

Compatibility fixes for newer versions of Jinja2 (e.g. 2.9.5+). Fixes #2156 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ec930770407a23e4ca48cc55a42f9591732c5f56 Author: Murtuza Zabuawala Modified Files

[pgadmin-hackers] pgAdmin 4 commit: Bump version for release.

Bump version for release. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5abd62389decefdedd7dc837602cb019ccca44dc Modified Files -- web/config.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) -- Sent via

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

I agree that we should rename the test. We've renamed it to "template_selection_feature_test". Your other suggestions are captured in our backlog as future improvements. We definitely can and should do those things but I think it would be valuable to go ahead and get this suite in and give other

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

Hi Dave, -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Feb 6, 2017 at 6:48 PM, Dave Page wrote: > Hi > > On Mon, Feb 6, 2017 at 12:57 PM, Harshal Dhumal >

[pgadmin-hackers] pgAdmin 4 commit: Update translation files.

Update translation files. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2dc0eab057d797a1fecb9947239be5638b442c5d Modified Files -- web/pgadmin/messages.pot | 3118 +-

[pgadmin-hackers] pgAdmin 4 commit: Fix column addition regression test.

Fix column addition regression test. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3ea8a7b211351b57646f7aec108f57623a40bb26 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

Thanks, applied. On Mon, Feb 6, 2017 at 6:12 AM, Murtuza Zabuawala wrote: > Hi Dave, > > Please find a fix for the same, attribute length was set to False instead of > None. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com >

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries

Hi On Mon, Feb 6, 2017 at 5:40 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue with Graphical Explain plan functionality which > was breaking for INSERT/UPDATE/DELETE explain plans. > RM#2133 > > Issue: It was due to typo in imageMapper