Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-03-31 Thread Ashesh Vashi
Hi Joao & Sarah, I have asked Murtuza to review the patch today. He will update me by EOD. If all goes well, I will commit the patch. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

[pgadmin-hackers] pgAdmin 4 commit: Fixes #2304, #2145 - Resolve the issue for restoring

2017-03-31 Thread Ashesh Vashi
Fixes #2304, #2145 - Resolve the issue for restoring the table from the backup. Earlier - implementation was generating the backup code like as below: XXX/pg_restore.exe --host "x.x.x.x" --port "" --username "osboxes" --no-password --dbname "test" --data-only --verbose --table "tt.test2" "XX

[pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2291 - Error highlighting broken

2017-03-31 Thread Khushboo Vashi
Hi, Please find the attached patch to fix RM #2291: Error highlighting broken. Murtuza / Akshay, Can you please review the patch? Thanks, Khushboo diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.py index f08b02e..0444377 100644 --- a/web/pgadmin/tools

[pgadmin-hackers] [pgAdmin4][Patch] RM #2232 Add the ability to gray-out/disable the "Save Password" option when creating a connection to a server

2017-03-31 Thread Akshay Joshi
Hi Please find the attached patch to fix RM #2232 Add the ability to gray-out/disable the "Save Password" option when creating a connection to a server. Please review it. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2232.patch Descr

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

2017-03-31 Thread Khushboo Vashi
Hi, On Mon, Mar 27, 2017 at 9:57 PM, Dave Page wrote: > On Mon, Mar 27, 2017 at 7:49 AM, Khushboo Vashi > wrote: > > Hi Dave, > > > > I have fixed the issue and the patch for the same is attached, but the > > Binary path options are not translated properly. > > Thanks - committed. > > > We regi

[pgadmin-hackers] pgAdmin 4 commit: Dialog Help was broken in case where query tool/Debug

2017-03-31 Thread Akshay Joshi
Dialog Help was broken in case where query tool/Debugger opens in new browser tab. Fixes #2310 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08ff9d7422aef7e1bdd46c5d71f5965ee5e36ab4 Author: Murtuza Zabuawala Modified Files -- ..

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix dialog help in browser tab/window

2017-03-31 Thread Akshay Joshi
Thanks patch applied. On Thu, Mar 30, 2017 at 7:54 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where "Dialog Help" was broken in case where > query tool/Debugger opens in new browser tab. > RM#2310 > > *Note:* > Object help might not wor

[pgadmin-hackers] [pgAdmin4] [RM2305] unable to set comment with non ascii characters on objects.

2017-03-31 Thread Harshal Dhumal
Hi, PFA patch for RM2305. Issue: Generic function qtLiteral was not adapting values properly which contains non ascii characters. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/utils/driver/ps

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

2017-03-31 Thread Akshay Joshi
Hi Navnath I have run the updated patch. It is working fine with Python 2.7 but I am facing following error with Python 3.5, can you please look into it: == ERROR: runTest (pgadmin.feature_tests.connect_to_server_feature_test.Co

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-03-31 Thread Murtuza Zabuawala
Hi Ashesh, Patch looks good to me. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi wrote: > Hi Joao & Sarah, > > I have asked Murtuza to review the patch today. > He will update me by EOD. >

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-03-31 Thread Murtuza Zabuawala
Hi, PFA minor add-on patch for README. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Ashesh, > > Patch looks good to me. > > -- > Rega

Re: [pgadmin-hackers][patch] Move to Alembic migration system

2017-03-31 Thread George Gelashvili
Hi, We've updated Murtuza's README change to be more consistent with other instructions - adding a colon and newline. -Matt and George On Fri, Mar 31, 2017 at 10:47 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor add-on patch for README. > > -- > Regards,

[pgadmin-hackers] pgAdmin 4 commit: Add message catalog builds to CI, and run all tests f

2017-03-31 Thread Dave Page
Add message catalog builds to CI, and run all tests from a runner script to enable test/build addition purely from the source tree. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b6fa5f5b3356cb07e84e5b1c263bbff8a59d4daf Modified Files ---

[pgadmin-hackers] pgAdmin 4 commit: Make sure each build/test starts in the correct direc

2017-03-31 Thread Dave Page
Make sure each build/test starts in the correct directory. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac1637f281d320ef727c23eef135d332ee6eb8cd Modified Files -- ci/build_docs.sh| 3 ++- ci/build_pip_wheel.sh | 3 ++-

[pgadmin-hackers] pgAdmin 4 commit: Include translation message catalogs in CI build/test

2017-03-31 Thread Dave Page
Include translation message catalogs in CI build/test runs. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a1bb8863a8759263636b0b8aa77ad462f3ce4d4 Modified Files -- ci/ci_runner.sh | 1 + 1 file changed, 1 insertion(+) -- Sent v

[pgadmin-hackers] pgAdmin 4 commit: Update CI script output for parsing with the Log Pars

2017-03-31 Thread Dave Page
Update CI script output for parsing with the Log Parser plugin in Jenkins Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4e50c186df14d57d8d9d4f49138e5557d1e8e3dc Modified Files -- ci/build_docs.sh| 4 +--- ci/build_pip_whee

[pgadmin-hackers] pgAdmin 4 commit: Add missing bracket

2017-03-31 Thread Dave Page
Add missing bracket Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f3e6fe5b642886bf55fe28b4ae5865f2f283bf7f Modified Files -- ci/update_messages.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

2017-03-31 Thread Dave Page
Update Babel version. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7fc21e3bb28ef782ccb1d251108b2d079e719fe Modified Files -- requirements.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgadmin-hacker

[pgadmin-hackers] pgAdmin 4 commit: Add missing semi-colon.

2017-03-31 Thread Dave Page
Add missing semi-colon. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a4fd3133717d04dfd5df3cee4162e43be628617a Modified Files -- ci/update_messages.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hac

Re: [pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

2017-03-31 Thread Devrim Gündüz
Hi Dave, On Fri, 2017-03-31 at 21:03 +, Dave Page wrote: > Update Babel version. Uh, this is the version on Fedora 25. RHEL 6 comes with 0.9.4, and RHEL 7 comes with 1.3. Just a FYI. Regards, -- Devrim Gündüz EnterpriseDB: http://www.enterprisedb.com PostgreSQL Danışmanı/Consultant, Red H

Re: [pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

2017-03-31 Thread Dave Page
On Friday, March 31, 2017, Devrim Gündüz wrote: > > Hi Dave, > > On Fri, 2017-03-31 at 21:03 +, Dave Page wrote: > > Update Babel version. > > Uh, this is the version on Fedora 25. > > RHEL 6 comes with 0.9.4, and RHEL 7 comes with 1.3. Just a FYI. > Doesn't really matter - the bug in questi

Re: [pgadmin-hackers] pgAdmin 4 commit: Update Babel version.

2017-03-31 Thread Devrim Gündüz
Hi, Ok,.got it. Thanks! Regards, Devrim On April 1, 2017 12:34:35 AM GMT+03:00, Dave Page wrote: >On Friday, March 31, 2017, Devrim Gündüz wrote: > >> >> Hi Dave, >> >> On Fri, 2017-03-31 at 21:03 +, Dave Page wrote: >> > Update Babel version. >> >> Uh, this is the version on Fedora 25. >

[pgadmin-hackers] pgAdmin 4 commit: Remove debug code.

2017-03-31 Thread Dave Page
Remove debug code. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ba9269a88a055bd151cbf5929b0d660d2843ef2 Modified Files -- web/pgadmin/browser/templates/browser/js/browser.js | 3 --- 1 file changed, 3 deletions(-) -- Sent via

[pgadmin-hackers] pgAdmin 4 commit: Fix error highlighting in the query tool. Fixes #2291

2017-03-31 Thread Dave Page
Fix error highlighting in the query tool. Fixes #2291 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=efb077b7f77f6313bb4b67aa3ffb27a65e296330 Author: Khushboo Vashi Modified Files -- web/pgadmin/tools/sqleditor/__init__.py

Re: [pgadmin-hackers] [pgAdmin4] [RM2305] unable to set comment with non ascii characters on objects.

2017-03-31 Thread Dave Page
Thanks, applied. On Friday, March 31, 2017, Harshal Dhumal wrote: > Hi, > > PFA patch for RM2305. > > > Issue: Generic function qtLiteral was not adapting values properly which > contains non ascii characters. > > > -- > *Harshal Dhumal* > *Software Engineer* > > EnterpriseDB India: http://www.e

Re: [pgadmin-hackers] [pgAdmin4][Patch] RM #2232 Add the ability to gray-out/disable the "Save Password" option when creating a connection to a server

2017-03-31 Thread Dave Page
Thanks, applied. On Friday, March 31, 2017, Akshay Joshi wrote: > Hi > > Please find the attached patch to fix RM #2232 Add the ability to > gray-out/disable the "Save Password" option when creating a connection to a > server. > > Please review it. > > > -- > *Akshay Joshi* > *Principal Software

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2291 - Error highlighting broken

2017-03-31 Thread Dave Page
Thanks, applied. On Friday, March 31, 2017, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix RM #2291: Error highlighting broken. > > Murtuza / Akshay, > > Can you please review the patch? > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @p

[pgadmin-hackers] pgAdmin 4 commit: Generic function qtLiteral was not adapting values pr

2017-03-31 Thread Dave Page
Generic function qtLiteral was not adapting values properly when they contain non ascii characters. Fixes #2305 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9acf3404005333daaa9658c4e2c22ad58ad1f99b Author: Harshal Dhumal Modified Files ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.

2017-03-31 Thread Dave Page
Hi On Friday, March 31, 2017, Khushboo Vashi wrote: > Hi, > > On Mon, Mar 27, 2017 at 9:57 PM, Dave Page > wrote: > >> On Mon, Mar 27, 2017 at 7:49 AM, Khushboo Vashi >> > > wrote: >> > Hi Dave, >> > >> > I have fixed the issue and the patch for the same is attached, but the >> > Binary path op

[pgadmin-hackers] pgAdmin 4 commit: Add the config option ALLOW_SAVE_PASSWORD to allow ad

2017-03-31 Thread Dave Page
Add the config option ALLOW_SAVE_PASSWORD to allow admins to disable saving of passwords. Fixes #2232 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6a861f7a914ab5c33cf9e04aae6fa4aa5bf96a53 Author: Akshay Joshi Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Properly handle truncated table names (> NAMEDATALEN)

2017-03-31 Thread Dave Page
Properly handle truncated table names (> NAMEDATALEN). Fixes #2277 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bb0bd8acc5d6899ed514159e344928e6453faa63 Author: Aravindraja Thinakaran Modified Files -- .../server_groups/servers/