Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi Murtuza, Currently nodes are sorted in case sensitive manner it should be case insensitive. See current Server group order is A, Servers, a1, a​2. It should be A, a1, a2, Servers. Similarly check sorting order for server and database nodes -- *Harshal Dhumal* *Sr. Software Engineer* Ente

[pgadmin-hackers] [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

Hi, This patch contains following changes: 1) When a new row is added, allow to delete if changes are not saved. 2) Disable new row selection if primary key is not given but changes are saved on server. 3) Copy and paste one or more rows, then add new row doesn't work(entered value doesn't appe

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi Harshal, We are using https://github.com/javve/natural-sort for sorting nodes which is implemented by Ashesh. @Ashesh, Any suggestion on this? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 15, 2017 at 1:07 PM, Harshal Dh

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Ashesh is out this week. As long as new nodes are sorted with the same algorithm as existing ones, that's fine. On Mon, May 15, 2017 at 8:48 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Harshal, > > We are using https://github.com/javve/natural-sort for sorting nodes >

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi Dave, Yes, It is existing one only, We did not touch on any part of sorting algorithm in this patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 15, 2017 at 1:24 PM, Dave Page wrote: > Ashesh is out this week. As long

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

So is the last patch considered good? On Mon, May 15, 2017 at 9:11 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Yes, It is existing one only, We did not touch on any part of sorting > algorithm in this patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseD

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

Hi On Mon, May 15, 2017 at 7:14 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to add object validation in table node for SQL and > Properties tab . > RM#2395 > I don't see how this relates to the issue reported which is related to dropping a schema

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

Hi Dave, As there were no proper steps given in RM to re-produce the issue, I assumed that user tried to delete schema and then click on the table, hence he got that error. So I checked the code notice that validation was missing at a location of error trace mentioned in RM, it assumed that we alw

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Hi Dave, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 15, 2017 at 1:43 PM, Dave Page wrote: > So is the last patch considered good? > Except one thing, when user renames server group (note that serve

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

Hi Hmm, OK - well I still can't reproduce it (using a table), but the change is clearly an appropriate check so I'll get it committed. Thanks. On Mon, May 15, 2017 at 9:53 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > As there were no proper steps given in RM

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in table node

And... done. On Mon, May 15, 2017 at 10:10 AM, Dave Page wrote: > Hi > > Hmm, OK - well I still can't reproduce it (using a table), but the change > is clearly an appropriate check so I'll get it committed. > > Thanks. > > On Mon, May 15, 2017 at 9:53 AM, Murtuza Zabuawala enterprisedb.com> wro

[pgadmin-hackers] pgAdmin 4 commit: Validate table presence in SQL and Properties route h

Validate table presence in SQL and Properties route handles. Fixes #2395 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ad14b379e0458fda10e3f710cb4d88c40425da3 Author: Murtuza Zabuawala Modified Files -- .../server_groups/server

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

OK, that needs fixing then... On Mon, May 15, 2017 at 9:59 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, May 15, 2017

[pgadmin-hackers] [pgAdmin4][runtime][patch]: Fix compilation error for QtWebEngine

Hi Dave, While building runtime with QtWebEngine, we found 2 compilation errors which was introduced due to previous commit in runtime. - We set "setNetworkAccessManager" in WebEnginePage which was only required for Webkit so removed that statement. - "triggerAction" on WebPage is only r

[pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

Hi The regression test cases for 'copy row' was failing. This patch was assuming that each selected row will have primary key due to selection was not working. Fixed. Please find revised patch. Thanks Surinder Kumar On Mon, May 15, 2017 at 1:13 PM, Surinder Kumar < surinder.ku...@enterprisedb.c

Re: [pgadmin-hackers] [pgAdmin4][runtime][patch]: Fix compilation error for QtWebEngine

Thanks, applied. On Mon, May 15, 2017 at 10:48 AM, Neel Patel wrote: > Hi Dave, > > While building runtime with QtWebEngine, we found 2 compilation errors > which was introduced due to previous commit in runtime. > >- We set "setNetworkAccessManager" in WebEnginePage which was only >requ

[pgadmin-hackers] pgAdmin 4 commit: While building runtime with QtWebEngine, we found 2 c

While building runtime with QtWebEngine, we found 2 compilation errors which were introduced in a previous commit in runtime: We set "setNetworkAccessManager" in WebEnginePage which was only required for Webkit so removed that statement. "triggerAction" on WebPage is only required for Qt > 5 wit

[pgadmin-hackers] pgAdmin 4 commit: Bump version in preparation for release.

Bump version in preparation for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0e78309cb413f76d5e7650e1f57e48de0ba Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4

[pgadmin-hackers] pgAdmin 4 commit: Ensure object names are properly escaped for external

Ensure object names are properly escaped for external process management. Fixes #2405 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1cb2a62fa8cc130fcc6a64b5aa4f16e85cb397b6 Author: Murtuza Zabuawala Modified Files -- web/pgadmi

[pgadmin-hackers] pgAdmin 4 commit: Mac build fixes:

Mac build fixes: - Rebuild Python packages from scratch so we know what libraries they use - Ensure the backports Python module has an __init__.py file. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=001e0ce1cf7e9cd5beb754a964810791b8089020

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #231

See Changes: [Dave Page] Mac build fixes: -- [...truncated 257.36 KB...] runTest (pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_get.S

[pgadmin-hackers] pgAdmin 4 commit: Ensure that there's an __init__.py file present in th

Ensure that there's an __init__.py file present in the backports module directory on Windows Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa554eb767547a82d894025dfe1c141c157c6451 Modified Files -- Make-MinGW.bat | 3 +++ 1 file

[pgadmin-hackers] pgAdmin 4 commit: Various improvements to the NULL/DEFAULT handling in

Various improvements to the NULL/DEFAULT handling in the data editor. Fixes #2399 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d7d4bf475bc5b131d9a76376ebfc87e004d92333 Author: Surinder Kumar Modified Files -- web/pgadmin/tools

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

I've committed a modified version of this patch following some discussion on IM with Surinder. Thanks Surinder! On Mon, May 15, 2017 at 10:56 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > The regression test cases for 'copy row' was failing. > This patch was assuming that

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #121

See Changes: [Dave Page] Ensure that there's an __init__.py file present in the backports module [Dave Page] Various improvements to the NULL/DEFAULT handling in the data editor.

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python26 #232

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure all required directories are created before we

Ensure all required directories are created before we start logging. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be42b67f790de7f5cc84b978c5a664ad1d515bd5 Modified Files -- web/pgadmin/__init__.py | 9 - 1 file changed, 4

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python27 #122

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Include backports.csv as a python dependency in the w

Include backports.csv as a python dependency in the wheel. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4817b3774270dfa360dddec9f6d36e6b608984a1 Modified Files -- pkg/pip/setup_pip.py | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

Hi hackers, We were checking out the selection functionality after this commit--looks like selection no longer works for single cells. If you press a cell in the grid the following message is console logged: sqleditor.js:869 Uncaught TypeError: Cannot read property 'indexOf' of undefined at

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

Aww, nuts. I thought we had tests for that? Did we miss that particular case? Anyway, copying of a single value still works (with Cmd+C), so I'm not inclined to re-wrap everything for this unless someone can get a patch to me by ~9AM UK time tomorrow. Surinder? On Mon, May 15, 2017 at 4:50 PM, Jo

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

Hi, Issue caused because variable temp_new_rows was access before it was initialised. Attached patch fixes this issue. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 15, 2017 at 9:28 PM, Dave Page wrote

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

Hi Joao, The single cell selection works for me using Cmd+C. Not reproducible for me. Please provide steps to reproduce. On Mon, May 15, 2017 at 9:58 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Issue caused because variable temp_new_rows was access before it was >

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

Hi, The array temp_new_rows is used to keep track to new added rows in View data. It is used to add 'disabled_row'class for new rows to highlight when grid renders after delete/copy/add row operation. Please find attached patch. On Mon, May 15, 2017 at 10:14 PM, Surinder Kumar < surinder.ku...@e

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

We were commenting on the disabled state of the copy button, so nevermind/ we are currently working on an update to the copy functionality of the grid. Thanks for the fixes! On Mon, May 15, 2017 at 1:31 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > The array temp_new_rows

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi, On Sat, May 13, 2017 at 12:35 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > We were only able to apply the patch on 1f903ba2 (were seeing patch does > not apply due to sqleditor.js conflicts) > The javascript tests passed, but we were unable to copy rows or column

Re: [pgadmin-hackers] [patch] upgrade slickgrid

On Mon, May 15, 2017 at 1:35 PM, Joao Pedro De Almeida Pereira wrote: > Hello Hackers > > We upgraded SlickGrid to the latest version + 53ee34. We upgraded since we > are working on some changes to the query results functionality, including > improvements to column selection and shortcuts. > > Thi

Re: [pgadmin-hackers] [patch] upgrade slickgrid

Hey Merlin Yes, we are using the 6pac fork. We've found Ben (6pac) to be very responsive. He accepted two PRs we wrote to the SlickGrid in a very timely manner. Thanks, Matt On Mon, May 15, 2017 at 4:46 PM Merlin Moncure wrote: > On Mon, May 15, 2017 at 1:35 PM, Joao Pedro De Almeida Pereira >

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in FTS dictonory

Hi, PFA patch to fix the issue in FTS dictionary as below, 1) Strip the quotes from the options. 2) Template is not shown in properties views if it is not in a system schema. RM#1126 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in FTS dictonory

++ Attaching patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 16, 2017 at 12:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in FTS dictionary as below, > 1) Str