Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Joao, Please apply patch RM_2400v2.patch first then apply Feature test cases patch. On May 26, 2017 7:42 PM, "Joao Pedro De Almeida Pereira" < jdealmeidapere...@pivotal.io> wrote: Hello Surinder, Thanks for updating the patch. After looking into the updated version, we found the following

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hello Surinder, Thanks for updating the patch. After looking into the updated version, we found the following issues. The tests looked flaky. We ran the tests three times and each time we had timeout issues. It failed twice in the location mentioned below. It also failed because the row1 cell2

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi, These patches really don't look like they were created in the normal way: (pgadmin4)snake:web dpage$ git apply ~/Downloads/1-upgrade-slickgrid.patch /Users/dpage/Downloads/1-upgrade-slickgrid.patch:126: trailing whitespace. /Users/dpage/Downloads/1-upgrade-slickgrid.patch:129: trailing

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Please find updated patch. On Fri, May 26, 2017 at 3:15 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Surinder, > > We are having issues running the tests, this is the error that we are > getting: > > File >

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Joao, On May 26, 2017 8:33 PM, "Joao Pedro De Almeida Pereira" < jdealmeidapere...@pivotal.io> wrote: > > Hi Surinder, > You are right, nevertheless that was not the only error we had on the flaky tests. Okay, please send stack trace where test case fails.. Thanks Surinder > > Thanks > Joao &

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #243

See Changes: [Dave Page] Add feature tests to ensure that data types are properly rendered in the [Dave Page] Pass the database ID to the query tool when using the Script options. [Dave Page] Ensure

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PG Data-types in Query Tool

On 26 May 2017 20:17, "Dave Page" wrote: Thanks - patch applied. I added your notes about the reason for the sleep as a comment in the code. Thanks Dave. On Fri, May 26, 2017 at 3:13 AM, Khushboo Vashi wrote: > Hi Dave, > > Please find the

[pgadmin-hackers] pgAdmin 4 commit: Import the ordereddict module for Python 2.6

Import the ordereddict module for Python 2.6 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8aabee352c70a54ea777bc21033233a72122cd30 Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Order columns in multi-column pkeys correctly. Fixes

Order columns in multi-column pkeys correctly. Fixes #2417 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dba64e77f133c332c339421e3a4844639ea6767e Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Feature test for PG Data-types in Query Tool

Thanks - patch applied. I added your notes about the reason for the sleep as a comment in the code. On Fri, May 26, 2017 at 3:13 AM, Khushboo Vashi wrote: > Hi Dave, > > Please find the attached updated patch with little modification. > > Thanks, > Khushboo > On

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python26 #245

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Allow creation of ENUM types with no members. Fixes #

Allow creation of ENUM types with no members. Fixes #2426 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c9af4784e1423779c3f4a91a867d6408105ddff Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Allow user to create ENUM type without any label

Thanks, patch applied. On Fri, May 26, 2017 at 7:59 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to address below, > 1) Allow user to create ENUM type without any labels. > 2) Allow user to add new label to existing enum type which do not have any >

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python36 #124

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #244

See Changes: [Dave Page] Allow creation of ENUM types with no members. Fixes #2426 -- Started by an SCM change [EnvInject] - Loading node environment variables.

[pgadmin-hackers] pgAdmin 4 commit: Improve docs on patch creation

Improve docs on patch creation Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6abc4c239a8eabca04f4429aeb056f910623cd16 Modified Files -- docs/en_US/submitting_patches.rst | 11 +++ 1 file changed, 11 insertions(+) --

[pgadmin-hackers] feature test timeouts

Hello Hackers, We are running tests including feature tests in Circle CI, and have been seeing some flakiness due to what we believe are insufficient wait-for timeouts. This shouldn't increase the overall test time, but only allow waiting longer for an element to appear, if needed. We've also

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi That fixed the JS tests, however, the feature tests are completely broken now - the browser fails to load the app, so they just timeout: == ERROR: runTest

[pgadmin-hackers] [pgAdmin4] [PATCH] Allow user to create ENUM type without any label

Hi, PFA patch to address below, 1) Allow user to create ENUM type without any labels. 2) Allow user to add new label to existing enum type which do not have any existing labels. RM#2426 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi OK, so we're getting somewhere now :-). Here's what I found: - The grid looks and feels great now. Selection works nicely, and copying rows seems to work well. - Patch 5 doesn't apply - but only to slick.grid.js. I manually fixed it for testing, but the patch really doesn't look like it was

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

On Fri, May 26, 2017 at 11:23 AM, Joao Pedro De Almeida Pereira wrote: > Maybe we should update the website with this information to help future > committers. I've committed a change showing some other ways to create patches with new files, including binary:

[pgadmin-hackers] [pgAdmin4] [PATCH] To fix issue in UPDATE Script and Primary key order when view data

Hi, PFA patch to fix the issue in table node, 1) In 'UPDATE Script', '?' is missing with last column. 2) If there are multiple primary keys in table then the order of columns is incorrect in view data ORDER BY clause. RM#2417 Also fixed minor issue in Materialized view which I found during