Re: [pgadmin-hackers] [pgAdmin4] Patch: Added new Control SqlFieldControl

Hi Surinder, [Please do not forget to "Reply All" (and, not reply to me personally)..] On Wed, Feb 3, 2016 at 4:37 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Please find the patch with suggested changes. > I've updated the patch with some minor changes. Please test

Re: [pgadmin-hackers] PATCH: To fix issue in NodeAjaxControl formatter

On Wed, Feb 3, 2016 at 4:25 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix issue in NodeAjaxControl formatter causing malformed > string when string has special characters in it. > Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB

[pgadmin-hackers] PATCH: To fix issue in NodeAjaxControl formatter

Hi, PFA patch to fix issue in NodeAjaxControl formatter causing malformed string when string has special characters in it. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fix_formatter_node-ajax-control.patch Description: Binary data

[pgadmin-hackers] pgAdmin 4 commit: Modified the variable jinja2 macros to allow to set/r

Modified the variable jinja2 macros to allow to set/reset multiple options in a single command, instead of multiple commands. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=79cd9d518c777873fb254436eb8670a25e7b86d7 Author: Murtuza Zabuawala

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

Hi, New patch looks good to me. All the features are working fine. Ashesh - If possible, can you please review it ?. if it looks good then you can commit it. Thanks, Neel Patel On Wed, Feb 3, 2016 at 3:41 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Neel, > > Thanks

Re: [pgadmin-hackers] Updated patches

-- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Wed, Feb 3, 2016 at 2:47 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for database node. > > I have fixed almost all issues reported by Neel. > > -- > *Harshal

Re: [pgadmin-hackers] pgAdmin 4 commit: Update the runtime to properly support Windows.

Hi On Wed, Feb 3, 2016 at 5:24 AM, Neel Patel wrote: > Hi Dave, > > Below two minor changes. > > - We have added below statement two times in Qt project files so removed > the duplicate entry. > PY2_VERSION = $$find(PY_VERSION, "^2") Oops - my bad. > -

Re: [pgadmin-hackers] Added variable macro for generic db objects

Hi Ashesh, PFA updated patch for generic variable macro as per Neel's suggestion, now it will take collection instead of single key/value pair. For example, options_collection = [ {*name*: 'Option-1', *value*: 'Value-1'}, {*name*: 'Option-2', *value*: 'Value-2'}, {*name*: 'Option-3', *value*:

[pgadmin-hackers] pgAdmin 4 commit: Fixes an issue in the backform schema generation logi

Fixes an issue in the backform schema generation logic to allow to use the NodeAjaxOptionsControl in the subnode grid. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e90fef7b5b20a5f4b78189e9b534da6ac4e3102a Author: Khushboo Vashi

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

Hi Murtuza, Please find below review comments. - "Location" and "Variables" fields are not getting display under Properties Panel. - When we remove/add the Variables fields, we are executing query individually for each parameters. We should execute it in single query as below. e.g.

Re: [pgadmin-hackers] PATCH: NodeAjaxOptionsControl in Subnode

Hi, With the previous patch *'Modified SQL'* tab was included in the sub-bode control, which is now fixed in the attached patch. Thanks, Khushboo On Wed, Feb 3, 2016 at 12:08 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > When we are using NodeAjaxOptionsControl in

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

Hi Khushboo, Please find below review comments. - Reverse engineering SQL generation is not implemented for domain node. - "Length" and "Precision" fields should be enabled/disabled based on the selection of "Base Type" value. - Query is not getting generated properly. Some of the parameters

[pgadmin-hackers] pgAdmin 4 commit: Fixed the NodeAjaxOtionsControl formatter, which was

Fixed the NodeAjaxOtionsControl formatter, which was causing malformed string, when have special character. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=359dff0f78dc448aae6364d2874579239db06580 Author: Murtuza Zabuawala

Re: [pgadmin-hackers] [pgAdmin4] Patch: Added new Control SqlFieldControl

On Wed, Feb 3, 2016 at 5:51 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > > > On Wed, Feb 3, 2016 at 4:58 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Surinder, >> >> [Please do not forget to "Reply All" (and, not reply to me personally)..] >> > Ok I will

Re: [pgadmin-hackers] [pgAdmin4] Patch: Added new Control SqlFieldControl

On Wed, Feb 3, 2016 at 4:58 PM, Ashesh Vashi wrote: > Hi Surinder, > > [Please do not forget to "Reply All" (and, not reply to me personally)..] > Ok I will remember. > > On Wed, Feb 3, 2016 at 4:37 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: >

[pgadmin-hackers] pgAdmin 4 commit: Remove a duplicate code line and add Windows environm

Remove a duplicate code line and add Windows environment setup info. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a06d5bd54db8e6b60c3e8b3203745916b455cac Author: Neel Patel Modified Files -- README

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

Hi Neel, Thanks for reviewing my code, I have fixed the issues mentioned, Please find attached updated patch for table space node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Feb 3, 2016 at 2:42 PM, Neel Patel

Re: [pgadmin-hackers] PATCH: NodeAjaxOptionsControl in Subnode

Thanks - checked-in! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Wed, Feb 3, 2016 at 3:57 PM, Khushboo Vashi <

Re: [pgadmin-hackers] Added variable macro for generic db objects

On Wed, Feb 3, 2016 at 3:37 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Ashesh, > > PFA updated patch for generic variable macro as per Neel's suggestion, now > it will take collection instead of single key/value pair. > > For example, > > options_collection = [ >

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi, New patch is working fine. Ashesh - Can you please review it? If it looks good then we can commit the extension module. Thanks, Neel Patel On Thu, Feb 4, 2016 at 11:40 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Neel, > > Please find the patch with following changes:

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi Neel, Please find the patch with following changes: 1. Removed Whitespace from files. 2. Fixed an issue in which json object converted into [object object] string. 3. Fixed python3 issue of unicode type where code breaks at "isinstance(SQL, str)" in python3 if str is unicode, because python no

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

Hi Neel, PFA updated patch. Added one more condition to check PG version post and pre 9.1. Please review it. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Feb 3, 2016 at 4:41 PM, Neel Patel

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

Hi Surinder, While applying the patch, we are getting below warnings. extension_v3.patch:362: trailing whitespace. This function will generate sql for sql panel extension_v3.patch:646: trailing whitespace. -- Extension: {{ conn|qtIdent(data.name) }} warning: 2 lines add whitespace

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

Thank you Murtuza. New patch is working fine with all supported PG version. We should use this latest tablespace patch. Ashesh - Can you please review it ? If It looks good then we should commit this patch. Thanks, Neel Patel On Thu, Feb 4, 2016 at 12:36 PM, Murtuza Zabuawala <