Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

2016-02-10 Thread Dave Page
Hi On Wed, Feb 10, 2016 at 12:14 AM, Sergey Busel wrote: > Dave, > > Here is a patch that does display the query tab name in the title bar of > the output pane. It seems to work with loading and saving the perspective, > too. The trick is to restore the original text on the

Re: [pgadmin-hackers] New macros for sequence node [pgadmin4]

2016-02-10 Thread Harshal Dhumal
Hi, PFA patch for schema macros for security and privilege. Now I have moved macros related to schema and its child object under schemas/templates/macros/schemas folder -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Wed, Feb 10, 2016 at 5:41 PM,

Re: [pgadmin-hackers] Backup and Restore dialog documentation updates

2016-02-10 Thread Dave Page
lol - thanks, patch applied. On Wed, Feb 10, 2016 at 3:10 PM, Susan Douglas < susan.doug...@enterprisedb.com> wrote: > > On Feb 10, 2016, at 9:49 AM, Dave Page wrote: > > > > On Wed, Feb 10, 2016 at 2:01 PM, Susan Douglas < > susan.doug...@enterprisedb.com> wrote: >

Re: [pgadmin-hackers] Patch sequence node [pgadmin4]

2016-02-10 Thread Harshal Dhumal
Hi, PFA updated patch for sequence node. *Changes:* Updated sql files to refer macros from schemas/templates/macros/schemas folder instead of servers/templates/macros -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Wed, Feb 10, 2016 at 5:46 PM,

Re: [pgadmin-hackers] New macros for sequence node [pgadmin4]

2016-02-10 Thread Harshal Dhumal
+ Usage of macros Way to use in template: *1] Security labels:* SECLABLE.SET(conn, object_type, object_name, provider, security_label, object.schema) SECLABLE.UNSET(conn, object_type, object_name, provider, object.schema) *2] Privileges:* PRIVILEGE.SET(conn, object_type, grantee,

Re: [pgadmin-hackers] Backup and Restore dialog documentation updates

2016-02-10 Thread Dave Page
On Wed, Feb 10, 2016 at 2:01 PM, Susan Douglas < susan.doug...@enterprisedb.com> wrote: > > > On Feb 10, 2016, at 6:56 AM, Dave Page > wrote: > > > > Hi, > > > > I think you maybe sent the wrong patches? These seem to be ones for > > PEM (they use a different OS for

[pgadmin-hackers] pgAdmin III commit: Update docs for the restore/backup dialogs.

2016-02-10 Thread Dave Page
Update docs for the restore/backup dialogs. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=12b8bf8b1f1c81cd58a9f0ba4e8428c31d5ee696 Author: Susan Douglas Modified Files -- docs/en_US/backup.rst

[pgadmin-hackers] pgAdmin III commit: Update docs for the restore/backup dialogs.

2016-02-10 Thread Dave Page
Update docs for the restore/backup dialogs. Branch -- REL-1_22_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ba1cede91930c6b342a71499f1abfba801ba00dc Author: Susan Douglas Modified Files --

[pgadmin-hackers] Privilege control: disable with grant ops if grantee is public [pgAdmin4]

2016-02-10 Thread Harshal Dhumal
Hi, PFA patch for privilege control. *Issue fixed:* Disable all with grant options if grantee is public. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/web/pgadmin/browser/server_groups/servers/static/js/privilege.js

Re: [pgadmin-hackers] PATCH: Schema/Catalog Node [pgAdmin4]

2016-02-10 Thread Neel Patel
Hi Murtuza, Please find below review comments. - Remove the whitespace from the patch file as we are getting below warnings while applying the patch file. schema_catalog_node_v1.patch:1500: trailing whitespace. FROM pg_namespace nsp schema_catalog_node_v1.patch:1501: trailing

Re: [pgadmin-hackers] patch for cast module

2016-02-10 Thread Akshay Joshi
Hi Sanket Most of the review comments has been resolved but I found some issues with this patch - When select some system cast it is showing wrong query, for example when select "abstime->date" in pgAdmin3 it is showing "AS ASSIGNMENT" and with your code it is showing "AS IMPLICIT".

[pgadmin-hackers] pgAdmin 4 commit: Fixes the qtIdent function in the psycopg2 driver abo

2016-02-10 Thread Ashesh Vashi
Fixes the qtIdent function in the psycopg2 driver about not taking care of double quote within it. The 'replace' function of immutable type string do create a new instance of type string, which needed to be reassgined to the variable 'value'. Reported By: Murtuza Zabuawala Branch -- master

Re: [pgadmin-hackers] Backup and Restore dialog documentation updates

2016-02-10 Thread Dave Page
Hi, I think you maybe sent the wrong patches? These seem to be ones for PEM (they use a different OS for the screenshots, and talk about the PEM client). Thanks. On Mon, Feb 8, 2016 at 5:34 PM, Susan Douglas wrote: > Hi All, > > I've attached updates for the

Re: [pgadmin-hackers] New macros for sequence node [pgadmin4]

2016-02-10 Thread Harshal Dhumal
Hi, Here is updated patch for macros. I have added required validation in macros. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Wed, Feb 10, 2016 at 1:06 PM, Ashesh Vashi wrote: > On Tue, Feb 9, 2016 at 3:48 PM,

Re: [pgadmin-hackers] Patch sequence node [pgadmin4]

2016-02-10 Thread Harshal Dhumal
Hi, Here is updated patch for sequence node. As macros are changed for security and privileges. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Tue, Feb 9, 2016 at 4:19 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA patch

Re: [pgadmin-hackers] Backup and Restore dialog documentation updates

2016-02-10 Thread Susan Douglas
> On Feb 10, 2016, at 6:56 AM, Dave Page wrote: > > Hi, > > I think you maybe sent the wrong patches? These seem to be ones for > PEM (they use a different OS for the screenshots, and talk about the > PEM client). > oops... let me fix that! Thanks! -- Susan >