[pgadmin-hackers] PATCH: Updated catalog names [pgAdmin4]

Hi, With this minor patch we will update catalog objects names in browser tree same as pgAdmin3 (for EDB PPAS servers). dbo -- to --> Redmond (dbo) sys -- to --> Redwood (sys) Thanks -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi Dave, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, Mar 17, 2016 at 4:13 PM, Dave Page wrote: > Hi > > On Thu, Mar 17, 2016 at 10:08 AM, Murtuza Zabuawala > wrote: > > > - If I click

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

Hi I tried that, but get the attached error when testing. I'm on a clean tree, with the WIP tables patch (which, by the way, doesn't look much like Arun's design so is likely to need a lot of layout work). I've restarted, refreshed etc. [image: Inline image 1] On Thu, Mar 17, 2016 at 6:04 AM,

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

Hi, You missed the second from last as well, but I got that for you :-). Thanks, committed! On Thu, Mar 17, 2016 at 6:31 AM, Neel Patel wrote: > Hi Dave, > > Please find attached patch file with all the reported issues fixed (except > last). > > Thanks, > Neel

[pgadmin-hackers] [pgAdmin4][Patch]: Added Support for the Domain Dependencies

Hi, Added support for the Domain Dependencies, earlier it was coming as a Type. Please find attached Patch for the same. Akshay, Can you please verify the patch, as you have implemented this functionality. Thanks, Khushboo diff --git

Re: [pgadmin-hackers] patch for cast module

Thanks - committed. On Wed, Mar 16, 2016 at 7:22 AM, Sanket Mehta wrote: > Hi, > > I forgot tot mention bugs in previous mail. > > > 1. System cast field was showing Yes even if the cast was not a system cast, > which I have resolved. > 2. In Dependent and

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

On Wed, Mar 16, 2016 at 1:18 PM, Ashesh Vashi wrote: > On Wed, Mar 16, 2016 at 6:32 PM, Dave Page wrote: > >> Hi >> >> On Mon, Mar 14, 2016 at 12:21 PM, Murtuza Zabuawala >> wrote: >> > Hi Dave, >> > >> >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added Support for the Domain Dependencies

Thanks, applied. On Fri, Mar 18, 2016 at 10:41 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch for the same. > > Thanks, > Khushboo > > On Fri, Mar 18, 2016 at 4:02 PM, Dave Page wrote: >> >> Can you rebase please?

[pgadmin-hackers] pgAdmin 4 commit: Updated the jQuery-contextMenu to 1.9.2 (latest stabl

Updated the jQuery-contextMenu to 1.9.2 (latest stable) version. Also, added the missing license information about it in the libraries.txt. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=96b33d1aa882ddd2297b0a895bf113a595846d92 Modified Files

Re: [pgadmin-hackers] Subnode grid row close issue [pgAdmin4]

Hi, Here is updated patch. In initial patch I fixed this issue in only Subnode control while Type node uses unique collection control (which is special case of subnode control). Now I have fixed in both control. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB

[pgadmin-hackers] Fix PSQL Console plugin for OS X

The PSQL Console command has been broken for a long time on OS X. Could you please fix it? This is how the command should look like: Command=/usr/bin/osascript -e 'ignoring application responses' -e 'tell application "Terminal"' -e 'activate' -e 'do script ""' -e 'do script

[pgadmin-hackers] [pgAdmin4][Patch]: Backgrid Textarea Cell

Hi, Introduced Backgrid Textarea cell. Please find attachment for the same. Thanks, Khushboo diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css index 7f25dca..fdefc74 100755 --- a/web/pgadmin/static/css/overrides.css +++

[pgadmin-hackers] Speed up node animation in pgAdmin4

Hi, I've attached a patch to speed up the expansion/collapsing of nodes. I've found it sluggish when testing, so I suggest we make it feel more responsive. I've also changed the speed of scrolling to an item. I don't know if we use this anywhere, but in case we do, I don't think we want it as

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

On Fri, Mar 18, 2016 at 11:41 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > The error is at line 84 in primary_key.js (from screenshot). > > In primary_key.js it requires MultiSelectAjaxControl. I guess patch of > MultiSelectControl was not applied correctly. > > Can

[pgadmin-hackers] pgAdmin 4 commit: Support textareas in backgrid.

Support textareas in backgrid. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3df180831f161f96cf0a2d251606c720114b4733 Author: Khushboo Vashi Modified Files -- web/pgadmin/static/css/overrides.css

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi On Mon, Mar 14, 2016 at 12:21 PM, Murtuza Zabuawala wrote: > Hi Dave, > > Thank you for reviewing my patch. > > I have made changes according to your feedback. > > Please review updated patch. OK, I think it's in pretty good shape now. Here's what I hope

[pgadmin-hackers] pgAdmin 4 commit: Resolved an issue related to not able to select grant

Resolved an issue related to not able to select grantee in the privileges control. It was a regression introduced in the commit - '4adea4dc2596fb495c4df8129745b87c35b062a6'. Branch -- master Details ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

Thank you dave for the change. In Version 6 patch file, I made the same change but don't know why were you not be able to see the object type with space ( may be depends.js was not updated ). After your comment i thought you want with underscore so i again change the logic. :) Thanks, Neel Patel

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added Support for the Domain Dependencies

Hi, Please find the attached updated patch for the same. Thanks, Khushboo On Fri, Mar 18, 2016 at 4:02 PM, Dave Page wrote: > Can you rebase please? > > (pgadmin4)piranha:web dpage$ git apply > ~/Downloads/pgAdmin4_dependencies.patch > > error: patch failed:

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

On Wed, Mar 16, 2016 at 6:32 PM, Dave Page wrote: > Hi > > On Mon, Mar 14, 2016 at 12:21 PM, Murtuza Zabuawala > wrote: > > Hi Dave, > > > > Thank you for reviewing my patch. > > > > I have made changes according to your feedback. > > > >

[pgadmin-hackers] Server side session management using the SQLite (per session) database

Hi Dave/team, As discussed, I have implemented the server side session management using the SQLite database. Implementation: * It creates/reuses the sqlite database per session. * Stores the key (as text)/value (as blob) in the sqlite database. * Needs to provide the session directory, where you

Re: [pgadmin-hackers] PATCH: Updated catalog names [pgAdmin4]

Thanks - pushed with a minor change to remove the localisation from "Redwood" and "Redmond", as they should never be translated. On Fri, Mar 18, 2016 at 2:14 PM, Murtuza Zabuawala wrote: > Hi, > > With this minor patch we will update catalog objects names in

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

Hi On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi wrote: > Hi, > > Please find the updated Domain Module Patch. > > To test this patch, please apply Backgrid Textarea Cell Patch before this. Thanks. I believe with the following fixes, we'll be done :-) -

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

Hi Dave, I have a query regarding your below feedback : * - Default values should be auto-quoted when necessary (ie. strings, on a text-based domain).* To resolve this, I have checked the typcategory field from pg_type for the base_type selected for the Domain. If the typcategory is String type

[pgadmin-hackers] pgAdmin 4 commit: Add support for Foreign data wrappers, servers and us

Add support for Foreign data wrappers, servers and user mappings. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3969e915630d2e566575be5dac99d2b79b5093b3 Author: Neel Patel Modified Files --

[pgadmin-hackers] Subnode grid row close issue [pgAdmin4]

Hi, PFA patch for Subnode grid row close issue. Issue fixed: 1] Close any existing row while adding new row. 2] Close any existing row if we edit new row. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git

[pgadmin-hackers] pgAdmin 4 commit: Adding a timeout of 5 seconds (while fetching the lat

Adding a timeout of 5 seconds (while fetching the latest pgAdmin version), it stucks at rendering the main page (browser.html) in the broken network. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=328428ab22599f9297d55441ac35e17eaa3b82c9

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi On Thu, Mar 17, 2016 at 10:08 AM, Murtuza Zabuawala wrote: > > - When editing a type, I cannot select a Grantee on the Privileges tab. > > This is general issue with privilege control. > [We will add it in TODO list] OK. > - When adding a composite type,

[pgadmin-hackers] pgAdmin 4 commit: On Python 2, use urllib2 instead of urllib, which all

On Python 2, use urllib2 instead of urllib, which allows us to specify timeout parameter. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=09bdf1fab7001cd9d880109dbe3a224421b331fc Modified Files -- web/pgadmin/browser/__init__.py |

[pgadmin-hackers] pgAdmin 4 commit: First pass at improving the dialogue borders.

First pass at improving the dialogue borders. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=05e527505da507758ff407e6ccb5c45c679f63a3 Author: Arun Kollan Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Log exceptions raised under the servers module.

Log exceptions raised under the servers module. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1448a8f551c9e592f5e48d16b1a2c51866a418e7 Modified Files -- web/pgadmin/browser/server_groups/servers/__init__.py | 7 +++ 1 file

[pgadmin-hackers] pgAdmin 4 commit: Resolved an issue using wrong variable name for backb

Resolved an issue using wrong variable name for backbone-model, while triggering events. Thanks Khushboo Vashi for reporting. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=84c5c29b926bc926279640c920a81761223ad90b Modified Files

[pgadmin-hackers] Control for displaying "auto vacuum" fields into grid

Hi, PFA control for displaying auto vacuum fields into grid. This control is common for Materialized View Node and Table Node. *Usage:* { id: 'vacuum_table', label: '{{ _("Vacuum Table") }}', model: VacuumTableModel, editable: false, type: 'collection', canEdit: true, group: '{{

[pgadmin-hackers] pgAdmin 4 commit: Support "show system objects" in casts.

Support "show system objects" in casts. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=71badac203f3199e58eac1f45654d41a1bf52812 Author: Sanket Mehta Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Renaming a server, when it was connected, should not

Renaming a server, when it was connected, should not lose the existing connections. Thanks Neel for reporting the issue. Also, resolved an issue related fetching properties of all the servers. Branch -- master Details ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added Support for the Domain Dependencies

Can you rebase please? (pgadmin4)piranha:web dpage$ git apply ~/Downloads/pgAdmin4_dependencies.patch error: patch failed: web/pgadmin/browser/utils.py:424 error: web/pgadmin/browser/utils.py: patch does not apply On Fri, Mar 18, 2016 at 4:03 AM, Khushboo Vashi