Re: [pgadmin-hackers] [pgAdmin4][patch] : cStringIO and StringIO module compatibility in python

Thanks - Committed with some modification. On Fri, May 13, 2016 at 10:40 AM, Neel Patel wrote: > Hi, > > Please find attached minor patch file to fix the import error regarding > the StringIO module in python2 and python3. > As StringIO and cStringIO module is no

[pgadmin-hackers] pgAdmin 4 commit: Fixed cStringIO and StringIO module compatibility in

Fixed cStringIO and StringIO module compatibility in python Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e4e1640e7eefcf7721c35e3c9d64b77c23371dc Modified Files -- web/pgadmin/misc/bgprocess/process_executor.py | 4 ++--

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

*1)* If we delete one inherited table and add another one It generated drop columns sql for that inherited table which throws error, for example "Test123"."TEST" has col1, col2 in it, once we remove table see the wrong drop column sql. SQL: ALTER FOREIGN TABLE pem.asdas DROP COLUMN col1;

[pgadmin-hackers] [pgAdmin4][patch] : cStringIO and StringIO module compatibility in python

Hi, Please find attached minor patch file to fix the import error regarding the StringIO module in python2 and python3. As StringIO and cStringIO module is no more exist in python3. Do review it and let us know for comments. Thanks, Neel Patel stringIO.patch Description: Binary data --

[pgadmin-hackers] Error messages displayed with pgAdmin4.py when user done latest git pull for pgAdmin4

Hi, Following error message displayed pgAdmin4.py when user done latest git pull for pgAdmin4 on Ubuntu 14.04 64 bit: - python pgAdmin4.py Traceback (most recent call last): File "pgAdmin4.py", line 56, in app = create_app() File

[pgadmin-hackers] pgAdmin 4 commit: Adding a background process executor, and observer.

Adding a background process executor, and observer. We will be using the external utilities like pg_dump, pg_dumpall, pg_restore in background. pgAdmin 4 can be run as a CGI script, hence - it is not good idea to run those utility in a controlled environment. The process executor will run them in

[pgadmin-hackers] pgAdmin 4 commit: 'pgadmin.utils.storage' has been renamed to 'pgadmin.

'pgadmin.utils.storage' has been renamed to 'pgadmin.utils.paths'. Resolved the typo. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=512e11c47c663387e04b7982afe5d714591a0a84 Modified Files -- web/pgadmin/__init__.py | 4 ++-- 1

Re: [pgadmin-hackers][pgAdmin4][Patch]: File Manager & Backform FileControl

Hi Surinder, Thanks - it was committed! As discussed personally, there are few improvement needed. * Do not show non applicable buttons, whenever no files/directory available in the storage root directory. * In crate mode, use dimmer with the overwrite warning, so that - it does not allow to

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Add support for Dropzone file upload library in pgAdmin4

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, May 12, 2016 at 4:33 PM, Surinder Kumar <

[pgadmin-hackers] pgAdmin 4 commit: Added support for the server side file manager, which

Added support for the server side file manager, which will be useful in selection, creation, upload/download files/directories resides on the server side. This will be useful for file selection/creation for different server side utilites like pg_dump, pg_dumpall, pg_restore. Branch -- master

Re: [pgadmin-hackers] Change server password [pgadmin4]

Hi, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, May 12, 2016 at 4:16 PM, Ashesh Vashi wrote: > On Thu, May 12, 2016 at 4:14 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Harshal >> >>

Re: [pgadmin-hackers] Change server password [pgadmin4]

Hi, PFA updated patch. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, May 12, 2016 at 4:14 PM, Akshay Joshi wrote: > Hi Harshal > > Below are my review comments : > >- Facing error unexpected identifier

[pgadmin-hackers] PATCH: Fixed typo in Tablespace node (pgAdmin4)

Hi, PFA patch to correct the typo in tablespace node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fixed_typo_tablespace.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To

Re: [pgadmin-hackers] [PATCH] Fix of elapsed time string generation in query window

Hello! It's OK to me to leave this as is, just wanted to note that it's still reproducible. At least for me. I'm on pgAdmin3 1.22.1 (Mar 29 2016, rev: REL-1_22_1) from postgresql-9.5.2-1-windows-x64-binaries.zip Thanks, Szabolcs 2016-02-11 11:39 GMT+01:00 Dave Page : >

Re: [pgadmin-hackers] variable scope issue in server js [pgadmin4]

On Thu, May 12, 2016 at 7:47 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Akshay, > > Murtuza hasn't fixed it in all places. He missed in following tow functions > > connect_server and disconnect_server > > > Thanks - Committed > > > -- > *Harshal Dhumal* > *Software

[pgadmin-hackers] pgAdmin 4 commit: Fixed variable scope issue in server.js

Fixed variable scope issue in server.js Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=180630ce0e6046aa59825876321a54d58cc48082 Author: Harshal Dhumal Modified Files --

[pgadmin-hackers] PATCH: CREATE Script Initial patch (pgAdmin4)

Hi, PFA patch to add CREATE Script functionality for database objects. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company CREATE_Script_v1.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] variable scope issue in server js [pgadmin4]

Hi Akshay, Murtuza hasn't fixed it in all places. He missed in following tow functions connect_server and disconnect_server -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, May 12, 2016 at 7:38 PM, Akshay Joshi

Re: [pgadmin-hackers] variable scope issue in server js [pgadmin4]

Hi On Thu, May 12, 2016 at 5:05 PM, Harshal Dhumal wrote: > Hi, > > > PFA patch for server.js. Replaced ";" (semicolon) with "," (coma) in > variable declaration. > > Issue: This was changing scope of all the variables declared after ";" > (semicolon) from

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, I have started reviewing the patch but the basic functionalities are breaking on python 2.7. Please test the patch on Python 2.7, fix the issues and resend the patch. Thanks, Khushboo On Thu, May 12, 2016 at 6:03 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > > -- >

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Tue, May 10, 2016 at 6:37 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Harshal, > > Pending issues to be fixed which I tried but not able to fix in > Constraints node, >

Re: [pgadmin-hackers] PATCH: Added "Named restore point" functionality (pgAdmin4)

Thanks - Committed On Thu, May 12, 2016 at 5:27 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for mentioned enhancements. > > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise

[pgadmin-hackers] pgAdmin 4 commit: Added input validation and title of the prompt for 'N

Added input validation and title of the prompt for 'Named Restore point' functionality Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83b6a04763ec0bd87cec39394cebdae42e238646 Author: Murtuza Zabuawala

Re: [pgadmin-hackers] PATCH: Added "Named restore point" functionality (pgAdmin4)

Hi, PFA updated patch for mentioned enhancements. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, May 12, 2016 at 4:45 PM, Akshay Joshi wrote: > Hi Murtuza > > Below are my

[pgadmin-hackers] variable scope issue in server js [pgadmin4]

Hi, PFA patch for server.js. Replaced ";" (semicolon) with "," (coma) in variable declaration. Issue: This was changing scope of all the variables declared after ";" (semicolon) from *local* to *global* and therefore affecting all other *local variables *with same name at different place in

Re: [pgadmin-hackers] PATCH: Added "Named restore point" functionality (pgAdmin4)

Hi Murtuza Below are my review comments - Please change the title from "AlertifyJS" to "Restore point name" - Please change the string from "Enter the name of the restore point" to "Enter the name of the restore point to add"(pgAdmin3). On Thu, May 12, 2016 at 11:20 AM, Murtuza

Re: [pgadmin-hackers] PATCH: FTS configuration node

Hi, PFA the revised patch. Please do review it and let me know if anything is not proper. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Thu, May 5, 2016 at 8:19 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > + patch link > > >

[pgadmin-hackers] [pgAdmin4][Patch]: Add support for Dropzone file upload library in pgAdmin4

Hi, Please find patch to "add support for Dropzone file upload library in pgAdmin4". It is used in FileManager. Thanks Surinder Kumar add_dropzone_js_in_libararies.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to

Re: [pgadmin-hackers] Change server password [pgadmin4]

On Thu, May 12, 2016 at 4:14 PM, Akshay Joshi wrote: > Hi Harshal > > Below are my review comments : > >- Facing error unexpected identifier 'change_password: function(args)' >in js file. >- Please correct the spelling of password in the menu item. >

Re: [pgadmin-hackers] Change server password [pgadmin4]

Hi Harshal Below are my review comments : - Facing error unexpected identifier 'change_password: function(args)' in js file. - Please correct the spelling of password in the menu item. - Title for alertify dialog showing "Change password for servers" it should be only "Change

[pgadmin-hackers] pgAdmin 4 commit: Destroy the existing Select2 object before rerenderin

Destroy the existing Select2 object before rerendering the control. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=585daddce2ef6b95c927d239605fec458b11d73d Author: Harshal Dhumal Modified Files --

[pgadmin-hackers] Destroy select2 controls before re-rendering [pgadmin4]

Hi, PFA patch for select2 controls. Change: Destroy existing any select2 controls before re-rendering them. Otherwise this was causing wired dialogue UI hang issue. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git

[pgadmin-hackers] pgAdmin 4 commit: Do not validate the attributes on saving, because - s

Do not validate the attributes on saving, because - sometimes it results into an error, and does not call the callback - 'success/fail' internally. And, that will not close the property dialog in those cases. Reported by Harshal Dhumal. Branch -- master Details ---

[pgadmin-hackers] pgAdmin 4 commit: Remove all the object view control within the subnode

Remove all the object view control within the subnode control, whenever we remove it. It will remove all the events, controls, elements, etc associated with the subnode control. Branch -- master Details ---

[pgadmin-hackers] Object cell editor remove/destroy issue [pgadmin4]

Hi, Currently we only hide and removing html part of subnode form. This does not remove/destroy controls of subnode. And therefore any listeners of control(s) triggers even though subnode is in closed state. To fix this properly remove/destroy Dialogue form when subnode is closed. This will also

Re: [pgadmin-hackers] Change server password [pgadmin4]

Hi, PFA updated patch. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, May 12, 2016 at 1:27 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > This patch needs a rebase. (as "Named restore point" patch is committed.) > > -- >

Re: [pgadmin-hackers] Change server password [pgadmin4]

Hi, This patch needs a rebase. (as "Named restore point" patch is committed.) -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Wed, May 11, 2016 at 12:35 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA patch for changing

Re: [pgadmin-hackers] PATCH: Fixed sql execution issue (pgAdmin4)

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, May 12, 2016 at 1:18 PM, Murtuza Zabuawala <

[pgadmin-hackers] pgAdmin 4 commit: Check for the connection status before executing the

Check for the connection status before executing the statement for checking the 'server in recovery' information. Thanks Khushboo for reporting the issue. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=40a949038290e21d9952591cdaa9efff678603fe

[pgadmin-hackers] pgAdmin 4 commit: Use the same cursor object of a connection object onl

Use the same cursor object of a connection object only from the same server. Current implementation keeps the cursor object in the 'g' (current request context) object identified by the connection-id. But - it fails to identify a different connection object request, when we have same database

[pgadmin-hackers] PATCH: Fixed sql execution issue (pgAdmin4)

Hi, PFA patch to fixed the issue which was introduced with "Named restore point" functionality in get_nodes function. Issue: SQL was getting executed without checking database connection causing invalid node status. Thanks to Khushboo for reporting the issue. -- Regards, Murtuza Zabuawala