[pgadmin-hackers] [pgAdmin4][Patch]: Added Filemanager library url in libraries.txt

Hi, We have used the File manager code https://github.com/simogeo/Filemanager in File manager module. I forgot to mention that. Here is the patch for that. Thanks, Surinder

[pgadmin-hackers] pgAdmin3 patch for pgFunctions.cpp

Hello, between the time I wrote the last set of patches for Greenplum, and the last release, some code in pgFunctions.cpp was changed and now raises an error in Greenplum. The attached patch fixes this problem. Thanks, -- Andreas 'ads' Scherbaum German

[pgadmin-hackers] pgAdmin 4 commit: Get the configuration for the documentation from the

Get the configuration for the documentation from the main web app. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4d47e23c8955a21d6edf334c1181219f3cc260ca Modified Files -- docs/en_US/conf.py | 13 + 1 file changed, 9

[pgadmin-hackers] pgAdmin 4 commit: Use a 2 part version number. We never used the first

Use a 2 part version number. We never used the first digit in 13 years of pgAdmin 3. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=50c134c4f121bb18f115e3e27fea75c00ca2ebcb Modified Files -- docs/en_US/conf.py | 4 ++--

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi Harshal, Below are my review comments: I got below warning when I tried to apply the patch for table node as mentioned below: Table creation: - Trailing white spaces warnings $ git apply /projects/patches/pgadmin4/Table/table_14_May_V6.patch

[pgadmin-hackers] pgAdmin 4 commit: Remove testing code

Remove testing code Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7d5d6dad28fd359c3fe05eee24f02a95dc3c3e7d Modified Files -- web/pgadmin/test/__init__.py | 87 -

Re: [pgadmin-hackers] Stalled post to pgadmin-hackers

Hi Surinder, Please find my comments as below for latest v2. patch, 1) In CREATE mode, Removing Owner & Schema fields causes SQL to break CREATE OR REPLACE VIEW ""."test view" AS select * from table1; ALTER TABLE ""."test view" OWNER TO pem_agent; Steps to re-produce, - enter name -

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

On Tue, May 17, 2016 at 4:52 PM, Dave Page wrote: > > > On Tuesday, May 17, 2016, Sandeep Thakkar < > sandeep.thak...@enterprisedb.com> wrote: > >> Hi Dave >> >> I have fixed the issues. Attached is the updated patch. >> >> The docs are built as part of 'appbundle' target,

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

On Tuesday, May 17, 2016, Sandeep Thakkar wrote: > Hi Dave > > I have fixed the issues. Attached is the updated patch. > > The docs are built as part of 'appbundle' target, there is no separate > target in Makefile for this. I observed that it requires the

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hello Dave, Attached is the patch for pgAdmin4.py to autocreate database configuration if does not exist. On Tue, May 17, 2016 at 4:24 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Hi Dave > > I have fixed the issues. Attached is the updated patch. > > The docs are built

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi Dave I have fixed the issues. Attached is the updated patch. The docs are built as part of 'appbundle' target, there is no separate target in Makefile for this. I observed that it requires the python modules to get this built. We create virtual environment as a part of 'appbundle' target

[pgadmin-hackers] pgAdmin 4 commit: Fixed issue of getting/setting preferences options fo

Fixed issue of getting/setting preferences options for 'Explain' Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8312efe927bd38615f1071608504d9a2987e1530 Modified Files -- web/pgadmin/tools/sqleditor/__init__.py| 12 +-

Re: [pgadmin-hackers] PATCH: CREATE Script Initial patch (pgAdmin4)

Hi, PFA patch to add CREATE Script functionality for foreign table objects. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 16, 2016 at 12:27 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Fri, May 13, 2016 at

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, PFA add-on patch to Ver.6 patch, Which will add CREATE/SELECT etc Script support into table node. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 17, 2016 at 11:48 AM, Surinder Kumar <

Re: [pgadmin-hackers] PATCH: FTS configuration node

Hi Sanket, Please find my review comments below: 1. In create mode it generates wrong sql. CREATE TEXT SEARCH CONFIGURATION test.asdf ( COPY= ); steps to reproduce: a] Fill up any necessary fields in general tab. b] On definition tab set Copy config filed and navigate to SQL tab.

Re: [pgadmin-hackers] [pgAdmin4]: Initial patch for Import table

Hi, I have fixed some of the issues observed during testing and as per your feedback added "Export" functionality as well. I have tested it on both linux and windows and it is working. Please find attached updated patch. Do review it and let me know for any modifications. Thanks, Neel Patel On

[pgadmin-hackers] pgAdmin 4 commit: Fixed issue change 'Auto Commit' option from preferen

Fixed issue change 'Auto Commit' option from preferences not reflacted properly on UI and also not set the class variable Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=216b6b16b5026404516613ec407564a31f53bbd3 Modified Files --

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, Please find attached add-on patch for table's subnode rule. Apply this patch at end after applying previous patches in email thread. *Issue fixed*: "Do Instead" on Rule node under View/M-View node not working in properties mode. Unable to generate proper SQL. On Mon, May 16, 2016 at 7:02