Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi Thom, Can you please create RM cases for the same, it will be easy to track those issues? We're using "https://redmine.postgresql.org/projects/pgadmin4/; for the same. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 25 May 2016 at 02:00, Thom Brown wrote: > On 25 May 2016 at 00:29, Thom Brown wrote: >> On 24 May 2016 at 19:09, Ashesh Vashi wrote: >>> >>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala >>>

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 25 May 2016 at 00:29, Thom Brown wrote: > On 24 May 2016 at 19:09, Ashesh Vashi wrote: >> >> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala >> wrote: >>> >>> Hi, >>> >>> PFA patch, which will fixes below

Re: [pgadmin-hackers] server and database node type check in is_connected check [pgadmin4]

Hi Harshal, I've committed a fix for the same. Please take a look at the commit-id: 748497916e71134d891e4b6f37f7b61749f9c878 for details. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

[pgadmin-hackers] pgAdmin 4 commit: Honour the node type (if provided) in the menu item,

Honour the node type (if provided) in the menu item, and disable it on any other nodes. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=748497916e71134d891e4b6f37f7b61749f9c878 Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Defined SwitchDepsCell in the schema javascript modul

Defined SwitchDepsCell in the schema javascript module, because - it will be loaded before every other javascript module requires this Cell. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d20db0f43ec8a4c486a3ef8a81c17f0d3e1350fa Modified

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Materialized view issues when run on PPAS server

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Wed, May 25, 2016 at 12:29 AM, Surinder Kumar <

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1207 - Unable to comments on materialized view

Fixes #1207 - Unable to comments on materialized view with Postgres Plus Advanced Server. Made changes in the query templates for create, view-id, and update to make it work properly with it. Branch -- master Details ---

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1213 - Dropping the materialized view using a

Fixes #1213 - Dropping the materialized view using an non-super user results into an error - "list index out of range". Using correct variable name while accessing parameter from an dictionary. Branch -- master Details ---

[pgadmin-hackers] [pgAdmin4][Patch]: Materialized view issues when run on PPAS server

Hi, Following are the issues fixed in this patch: 1. RM#1213 - "list index out of range" message displayed if try to drop materialized view with non root user. This issue is the result of copy paste issue in views delete method. 2. RM#1207 - Unable to comments on materialized view with PPAS

Re: [pgadmin-hackers] pgAdmin3 patch for pgFunctions.cpp

On 24.05.2016 14:38, Dave Page wrote: Thanks, applied. Thanks for applying the patch. Are there any plans for a next release for pgAdmin3? Regards, -- Andreas 'ads' Scherbaum German PostgreSQL User Group European PostgreSQL User Group - Board of Directors

Re: [pgadmin-hackers] [pgAdmin4][Patch]: [RM#1217] view data option should also be added for materialized view

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, May 24, 2016 at 6:20 PM, Surinder Kumar <

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1217 - Added support for the context menu - 'V

Fixes #1217 - Added support for the context menu - 'View Data' for the Materialized View. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d4644428e6adcf643c48e8108abc4ab2e203409d Author: Surinder Kumar

Re: [pgadmin-hackers] Patch for pgAdmin4 docs

> On 24 May 2016, at 18:29, Susan Douglas > wrote: > > >> On May 24, 2016, at 12:02 PM, Dave Page wrote: >> >> Hi >> >> This seems to be missing the images. Did you remember to git add them, >> before diff'ing? > > I think the .png's are

Re: [pgadmin-hackers] PATCH: Fix the issue when server group already exists (pgAdmin4)

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, May 24, 2016 at 5:06 PM, Murtuza Zabuawala <

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1136 - do not to allow create a server group w

Fixes #1136 - do not to allow create a server group with same name. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c81977d441870ce23748d321610cbdcaac11a5d0 Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] PATCH: Fix the issue while dropping a Role (pgAdmin4)

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, May 24, 2016 at 4:10 PM, Murtuza Zabuawala <

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1135 - resolved an issue dropping a role with

Fixes #1135 - resolved an issue dropping a role with special characters. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=42a3b784ba20cc41a8a620d445ee254634000f52 Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Add support for CREATE, SELECT & INSERT functionality in View and Materialized view

Thanks - committed with some formatting change. Also - fixed one issue related showing the trigger definition. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

[pgadmin-hackers] pgAdmin 4 commit: Added support for the CREATE script for View and Mate

Added support for the CREATE script for View and Materialized View, and SELECT & INSERT support for the Materialized View Node. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3b3cf7502ba892d809c158a6521a36c410045b9f Author: Surinder Kumar

Re: [pgadmin-hackers] [pgAdmin4][Patch]: [FileManager] ReferenceError: assignment to undeclared variable t_res

On Tue, May 24, 2016 at 1:44 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > > > On Tue, May 24, 2016 at 1:35 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Tue, May 24, 2016 at 1:34 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> On Tue, May

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch, which will fixes below mentioned issues, > Committed. > > - Fixed all the review comments given by Dave on tables & its child nodes. > Can you please list down, what has not yet

[pgadmin-hackers] pgAdmin 4 commit: Fixed all the review comments from Dave.

Fixed all the review comments from Dave. * Moved the Columns, and Constraint to its repective tabs. * Ensure all the labels only have a capital letter on the first word (except for keywords or acronyms). * Resolve the typo in string - 'System table'. * Error messages on fields should not be

Re: [pgadmin-hackers] Patch for pgAdmin4 docs

Hi This seems to be missing the images. Did you remember to git add them, before diff'ing? On Tue, May 24, 2016 at 4:21 PM, Susan Douglas wrote: > Hi All, > > I've attached a patch that updates the Foreign Table dialog - this patch does > not address all of the

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Hi Attached is an updated patch in which I made some minor changes, most significantly, to stop the build script from over-writing my configuration file (again)! There are a couple of important issues to be resolved: 1) It doesn't work. When testing on Karen's machine (which is new, and doesn't

[pgadmin-hackers] pgAdmin 4 commit: Fix a couple of file references.

Fix a couple of file references. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8c077bc2dfd2dda4bd3b5e1338a6d60b404ba78f Modified Files -- docs/en_US/code_review.rst| 2 +- docs/en_US/submitting_patches.rst | 2 +- 2 files

[pgadmin-hackers] [pgAdmin4][Patch]: [RM#1217] view data option should also be added for materialized view

Hi, Issue: *view data* option in context menu is missing. Now support for *view data *is added in materialized view. Please review the attached patch. Thanks, Surinder Kumar add_support_for_view_data_in_material_view.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] pgAdmin 4 commit: Various doc updates.

Various doc updates. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0a3bdc588d77612134766addf861297baca18a0 Author: Susan Douglas Modified Files -- docs/en_US/cast_dialog.rst

Re: [pgadmin-hackers] Patch for documentation update

Thanks, applied. On Mon, May 23, 2016 at 4:26 PM, Susan Douglas wrote: > Hi All, > > I've attached a patch for the pgAdmin documentation - the docs are still a > WIP, but are updated to include recent feedback from Dave, and new filenames. > > Thanks! > > --

[pgadmin-hackers] pgAdmin III commit: Fx an issue with funtions on Greenplum

Fx an issue with funtions on Greenplum Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=61c76ab68efcce2f5b04c5752b4ae12bec25c6bf Author: Andreas 'ads' Scherbaum Modified Files -- pgadmin/schema/pgFunction.cpp

Re: [pgadmin-hackers] pgAdmin3 patch for pgFunctions.cpp

Thanks, applied. On Wed, May 18, 2016 at 1:44 AM, Andreas 'ads' Scherbaum wrote: > > Hello, > > between the time I wrote the last set of patches for Greenplum, and the last > release, some code in pgFunctions.cpp was changed and now raises an error in > Greenplum. > > The

[pgadmin-hackers] PATCH: Fix the issue when server group already exists (pgAdmin4)

Hi, PFA minor patch to fix the issue when server group already exists and user try to create new with same name. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1136.patch Description: Binary data -- Sent via pgadmin-hackers

[pgadmin-hackers] PATCH: Fix the issue while dropping a Role (pgAdmin4)

Hi, PFA minor patch to fix the issue while dropping a role when it has special characters in role name. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1135.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] PATCH: To fix issue in Updating comments in sequence node (pgAdmin4)

Hi, PFA minor patch to fix update comments issue in sequence node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1118.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To

[pgadmin-hackers] [pgAdmin4][Patch]: Add support for CREATE, SELECT & INSERT functionality in View and Materialized view

Hi, Please find attached patch to add support for CREATE, SELECT & INSERT functionality in view and materialized view. The option for CREATE, SELECT & INSERT is available in Object menu and context menu on view and materialized view node. Please review the patch. Thanks, Surinder Kumar

Re: [pgadmin-hackers] [pgAdmin4][Patch]: [FileManager] ReferenceError: assignment to undeclared variable t_res

On Tue, May 24, 2016 at 1:35 PM, Ashesh Vashi wrote: > On Tue, May 24, 2016 at 1:34 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Tue, May 24, 2016 at 12:35 PM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi >>> >>>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: [FileManager] ReferenceError: assignment to undeclared variable t_res

On Tue, May 24, 2016 at 12:35 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > *Issues fixed:* > *1. *ReferenceError: assignment to undeclared variable t_res in > FileManager > *2.* Add missing default case in switch statement. > *3.* code improvements. > What are those, can

Re: [pgadmin-hackers] [pgAdmin4][Patch]: [FileManager] ReferenceError: assignment to undeclared variable t_res

On Tue, May 24, 2016 at 1:34 PM, Ashesh Vashi wrote: > On Tue, May 24, 2016 at 12:35 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> *Issues fixed:* >> *1. *ReferenceError: assignment to undeclared variable t_res in >> FileManager >>

Re: [pgadmin-hackers] server and database node type check in is_connected check [pgadmin4]

On Tue, May 24, 2016 at 12:26 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Ashesh, > > For change server password we have added check is_connected() in > server.js. Also same function is also available in database.js. So it was > causing change server password menu to enable

Re: [pgadmin-hackers] PATCH: CREATE Script Initial patch (pgAdmin4)

Thanks - Committed. On Wed, May 18, 2016 at 4:01 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add CREATE Script functionality for foreign tables objects > which will also have INSERT/UPDATE/DELETE scripts instead of CREATE/SELECT > only. > > > > -- >

[pgadmin-hackers] pgAdmin 4 commit: Added Insert/Delete/Update script functionality for f

Added Insert/Delete/Update script functionality for foreign table objects Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa1c283514d61dd9949eaaed06cfe2e80648f1d4 Author: Murtuza Zabuawala Modified Files

[pgadmin-hackers] [pgAdmin4][Patch]: [FileManager] ReferenceError: assignment to undeclared variable t_res

Hi *Issues fixed:* *1. *ReferenceError: assignment to undeclared variable t_res in FileManager *2.* Add missing default case in switch statement. *3.* code improvements. issue #1 is reproduced on mozilla browser of ubuntu machine when FileManager is opened for the first time in Backup server

Re: [pgadmin-hackers] server and database node type check in is_connected check [pgadmin4]

Hi Ashesh, For change server password we have added check is_connected() in server.js. Also same function is also available in database.js. So it was causing change server password menu to enable on database node as well if database is connected. This issue will appear for any other menu if that

Re: [pgadmin-hackers] server and database node type check in is_connected check [pgadmin4]

On Tue, May 24, 2016 at 12:06 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > > PFA patch for server and database node: > > Issue fixed: Added node type check in is_connected check. > Can you please describe the situation, when these functions are being executed outside

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1218 - Backup table not working.

Fixes #1218 - Backup table not working. Send parameters in proper format to work it well with table backup. Thanks Fahar for reporting it. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dca6951e745c7b8a363a55ec6ca42c4aa359c459 Modified

[pgadmin-hackers] server and database node type check in is_connected check [pgadmin4]

Hi, PFA patch for server and database node: Issue fixed: Added node type check in is_connected check. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/js/databases.js

Re: [pgadmin-hackers] PATCH: To fix condition checking in Backup utility (pgAdmin4)

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, May 24, 2016 at 11:57 AM, Murtuza Zabuawala <

[pgadmin-hackers] pgAdmin 4 commit: [Backup] Checking for 'only_data' parameter before ac

[Backup] Checking for 'only_data' parameter before accessing it. Reported by Neel Patel Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0840e6af2dc089e7e640e2f1dc38c5119cebf47e Modified Files --

[pgadmin-hackers] PATCH: To fix condition checking in Backup utility (pgAdmin4)

Hi, PFA minor patch to fixed condition checking in Backup utility. Thanks to Neel for reporting this. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Backup_updated_condition.patch Description: Binary data -- Sent via

[pgadmin-hackers] pgAdmin 4 commit: Initialize the msg to None as we may not have msg ava

Initialize the msg to None as we may not have msg available, when current version, and latest released version is matching. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=98fa93413d5db14434c0144b3a3d7bfcb69bba80 Modified Files --