Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

2016-05-27 Thread Paresh More 
Hello Dave,

Make.bat usage is change to

Make.bat x86   // It would generated 32 bit installer
Make.bat adm64 // would generated 64 bit installer
Make.bat clean   // Will cleanup all output it creates in normal mode

Now Make.bat would generated 32/64 installers as per selected.

- Avoids trashing a pre-existing config_local.py, and creates a very simple
one in the staging directory.
DONE

- Various tidy-ups of Make.bat.
Tried to clean up code and added some information to the scripts

- Change the default path to %ProgramFiles%\pgAdmin 4\v (added the
v, as  on it's own looks weird)
DONE - Based on 32 bit or 64 bit it would install accordingly

- Make.bat should take a "clean" parameter, to cleanup all output it
creates in normal mode.
DONE

- The package name in the installer should be set from config.py as the
version is.
DONE

  psycopg2 issue is resolved.

- As far as I can see, the Helpfiles are not built or bundled (talk to
Sandeep about this)
DONE - Helpfiles are added to installer

- No Start Menu icon is created.
DONE

- Why is 3rd_party_licences.txt included? We don't need that.
Removed it is not required

- pkg/win32/installer.iss should be added to a .gitignore file.
DONE

- SplashScreen.bmp doesn't seem to be used (though it is referenced from
the installer config file.
Splashscreen would be now displayed during installation

- Based on 32/64 python27.dll would be shipped

- The Add/Remove Programs entry text should be: "pgAdmin 4 v1", thus
allowing v1.1 to be a bug-fix release, and 2.0 to be the next major version.
DONE

- Any pre-existing pgadmin4.db is being shipped.
DONE

- Any pre-existing *.pyc files are being shipped.
DONE

I have tested on 32 bit machine only and its working fine, for 64 bit all
changes are in place, Make.bat amd64 would generate the desired installers.


Attached is the updated Patch.


On Thu, May 26, 2016 at 7:13 PM, Dave Page  wrote:

> Hi
>
> On Fri, May 20, 2016 at 9:33 AM, Paresh More  > wrote:
>
>> Hello Dave.
>>
>> Attached are two patch for pgAdmin4-windows
>>
>> pgAdmin4_createDB.patch
>> - patch for pgAdmin4.py to autocreate database configuration if does not
>> exist.
>> - Now pgadmin.db would be not be bundled with installer, it would be
>> created if pgAdmin4.py is executed for the first time.
>>
>
> This is committed.
>
>
>>
>> *pgAdmin4_windows.patch*
>> - Environment variables once set will over ride the existing script
>> variables.
>> - Issue related to path with quotes are removed.
>> - New Readme.txt is added.
>> - Modified Error reporting.
>> - Python check was missing related to which requirement file it should
>> pick for creating private environment based on python version is also fixed.
>>
>
> Attached is an update to this patch, which modifies the following:
>
> - Avoids trashing a pre-existing config_local.py, and creates a very
> simple one in the staging directory.
>
> - Various tidy-ups of Make.bat.
>
> - Change the default path to %ProgramFiles%\pgAdmin 4\v (added the
> v, as  on it's own looks weird)
>
> Please update further to address the following issues. I need this
> completed ASAP, thanks:
>
> - Make.bat should take a "clean" parameter, to cleanup all output it
> creates in normal mode.
>
> - The package name in the installer should be set from config.py as the
> version is.
>
> - I see the following error:
>
>   error: [Error 183] Cannot create a file when that file already exists:
> 'build\\bdist.win32\\wheel\\importlib-1.0.3.data\\..'
>
>   
>   Failed building wheel for importlib
>
> - And the following error:
>
>   C:\Users\dpage\AppData\Local\Programs\Common\Microsoft\Visual C++ for
> Python\9.0\VC\Bin\link.exe /DLL /nologo /INCREMENTAL:NO
> /LIBPATH:c:\python27\Libs
> /LIBPATH:c:\users\dpage\documents\pgadmin4\pkg\win32\release\ve_python\libs
> /LIBPATH:c:\users\dpage\documents\pgadmin4\pkg\win32\release\ve_python\PCbuild
> /LIBPATH:c:\users\dpage\documents\pgadmin4\pkg\win32\release\ve_python\PC\VS9.0
> /LIBPATH:C:/PROGRA~1/PG/pg95/lib ws2_32.lib advapi32.lib secur32.lib
> libpq.lib shfolder.lib
> build\temp.win32-2.7\Release\psycopg\psycopgmodule.obj
> build\temp.win32-2.7\Release\psycopg\green.obj
> build\temp.win32-2.7\Release\psycopg\pqpath.obj
> build\temp.win32-2.7\Release\psycopg\utils.obj
> build\temp.win32-2.7\Release\psycopg\bytes_format.obj
> build\temp.win32-2.7\Release\psycopg\connection_int.obj
> build\temp.win32-2.7\Release\psycopg\connection_type.obj
> build\temp.win32-2.7\Release\psycopg\cursor_int.obj
> build\temp.win32-2.7\Release\psycopg\cursor_type.obj
> build\temp.win32-2.7\Release\psycopg\diagnostics_type.obj
> build\temp.win32-2.7\Release\psycopg\error_type.obj
> build\temp.win32-2.7\Release\psycopg\lobject_int.obj
> build\temp.win32-2.7\Release\psycopg\lobject_type.obj
> build\temp.win32-2.7\Release\psycopg\notify_type.obj
> build\temp.win32-2.7\Release\psycopg\xid_type.obj
>

[pgadmin-hackers] Alpha vs. Beta

2016-05-27 Thread Dave Page 
So the plan is to wrap the first pgAdmin 4 packages next Friday (or
possibly the following Monday).

Originally, they were going to be suffixed as alpha1, however, given
that we're feature complete (well, 99.5%), I'm thinking the release
should be beta1.

Thoughts?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Compressed version of patch

2016-05-27 Thread Dave Page 
On Fri, May 27, 2016 at 3:59 PM, Susan Douglas
 wrote:
>
>> On May 27, 2016, at 10:02 AM, Dave Page  wrote:
>>
>> Hi
>>
>> On Fri, May 27, 2016 at 2:44 PM, Susan Douglas
>>  wrote:
>>> Hi All,
>>>
>>> I meant to send that patch in a compressed format...
>>
>> I can't apply this, as it's trying to create a number of files that
>> already exist in the repo. Did you do a git pull or git rebase before
>> running git add and creating your patch? If I had to guess, this was
>> created against the repo prior to me committing your last patch.
>
> Can you try this one please?
>
> Thanks!

Thanks - linked to the dialogs and applied.

-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Additional documentation pages for dialogs.

2016-05-27 Thread Dave Page 
Additional documentation pages for dialogs.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b482ba6ce972ed356bb631c1ad077ee6579c1dde
Author: Susan Douglas 

Modified Files
--
docs/en_US/check_dialog.rst|  45 ++
docs/en_US/collation_dialog.rst|   4 +-
docs/en_US/column_dialog.rst   |  73 +
docs/en_US/exclusion_constraint_dialog.rst |  64 +++
docs/en_US/foreign_key_dialog.rst  |  91 +
docs/en_US/function_dialog.rst |  12 ++-
docs/en_US/grant_wizard.rst|  55 +
docs/en_US/images/check_definition.png | Bin 0 -> 34079 bytes
docs/en_US/images/check_general.png| Bin 0 -> 28979 bytes
docs/en_US/images/check_sql.png| Bin 0 -> 65429 bytes
docs/en_US/images/column_definition.png| Bin 0 -> 35010 bytes
docs/en_US/images/column_general.png   | Bin 0 -> 28129 bytes
docs/en_US/images/column_security.png  | Bin 0 -> 30244 bytes
docs/en_US/images/column_sql.png   | Bin 0 -> 29326 bytes
docs/en_US/images/exclusion_constraint_columns.png | Bin 0 -> 26720 bytes
.../images/exclusion_constraint_definition.png | Bin 0 -> 34689 bytes
docs/en_US/images/exclusion_constraint_general.png | Bin 0 -> 25166 bytes
docs/en_US/images/exclusion_constraint_sql.png | Bin 0 -> 52080 bytes
docs/en_US/images/foreign_key_action.png   | Bin 0 -> 28666 bytes
docs/en_US/images/foreign_key_columns.png  | Bin 0 -> 36577 bytes
docs/en_US/images/foreign_key_definition.png   | Bin 0 -> 36472 bytes
docs/en_US/images/foreign_key_general.png  | Bin 0 -> 25659 bytes
docs/en_US/images/foreign_key_sql.png  | Bin 0 -> 71752 bytes
docs/en_US/images/grant_wizard_step1.png   | Bin 0 -> 111417 bytes
docs/en_US/images/grant_wizard_step2.png   | Bin 0 -> 59158 bytes
docs/en_US/images/grant_wizard_step3.png   | Bin 0 -> 102645 bytes
docs/en_US/images/index_definition.png | Bin 0 -> 47470 bytes
docs/en_US/images/index_general.png| Bin 0 -> 34003 bytes
docs/en_US/images/index_sql.png| Bin 0 -> 42084 bytes
docs/en_US/images/primary_key_definition.png   | Bin 0 -> 41403 bytes
docs/en_US/images/primary_key_general.png  | Bin 0 -> 28487 bytes
docs/en_US/images/primary_key_sql.png  | Bin 0 -> 39778 bytes
docs/en_US/images/rule_definition.png  | Bin 0 -> 31587 bytes
docs/en_US/images/rule_general.png | Bin 0 -> 25498 bytes
docs/en_US/images/rule_sql.png | Bin 0 -> 61917 bytes
docs/en_US/images/trigger_code.png | Bin 0 -> 19989 bytes
docs/en_US/images/trigger_definition.png   | Bin 0 -> 30785 bytes
docs/en_US/images/trigger_events.png   | Bin 0 -> 29824 bytes
docs/en_US/images/trigger_general.png  | Bin 0 -> 20826 bytes
docs/en_US/images/trigger_sql.png  | Bin 0 -> 38226 bytes
docs/en_US/images/unique_constraint_definition.png | Bin 0 -> 49886 bytes
docs/en_US/images/unique_constraint_general.png| Bin 0 -> 33265 bytes
docs/en_US/images/unique_constraint_sql.png| Bin 0 -> 65040 bytes
docs/en_US/index.rst   |   9 +-
docs/en_US/index_dialog.rst|  73 +
docs/en_US/primary_key_dialog.rst  |  48 +++
docs/en_US/procedure_dialog.rst|  10 ++-
docs/en_US/rule_dialog.rst |  46 +++
docs/en_US/trigger_dialog.rst  |  67 +++
docs/en_US/unique_constraint_dialog.rst|  48 +++
.../domains/templates/domains/js/domains.js|   2 +-
.../tables/column/templates/column/js/column.js|   3 +-
.../check_constraint/js/check_constraint.js|   1 +
.../js/exclusion_constraint.js |   1 +
.../templates/foreign_key/js/foreign_key.js|   1 +
.../index_constraint/js/index_constraint.js|   5 ++
.../tables/rules/templates/rules/js/rules.js   |   1 +
.../triggers/templates/trigger/js/trigger.js   |   1 +
58 files changed, 646 insertions(+), 14 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-27 Thread Dave Page 
On Fri, May 27, 2016 at 4:48 PM, Dave Page  wrote:
>
>
> On Fri, May 27, 2016 at 1:11 PM, Sandeep Thakkar
>  wrote:
>>
>> Sure. Thanks.
>>
>> There is a typo in pkg/mac/build.sh. i.e
>>
>> s/HTML_HELP/HELP_PATH/
>>
>>
>> On Fri, May 27, 2016 at 5:26 PM, Dave Page  wrote:
>>>
>>> Not entirely - we definitely need to improve it. I'll review the code as
>>> it is now though.
>
>
> OK, review time :-)
>
> - The appbundle name should be created from APP_NAME.app in config.py, e.g.
> 'pgAdmin 4.app'
>
> - The DMG name should be created from
> to_lower(remove_spaces(APP_NAME-APP_VERSION)) in config.py, e.g.
> pgadmin4-1.0-dev.dmg
>
> - Use #ifdef Q_OS_MAC in the QT code for Mac-specific code. There's no need
> to define another macro.
>
> - Please add "MINIFY_HTML = False" to config_local.py (and have Paresh do
> the same on his packages). This works around a code issue with the docs that
> I'll log a bug for.
>
> - In testing, I found that running the app from within the DMG doesn't seem
> to work the first time - it prompts for the path, then exits. Once I save
> the path it offers, it's fine on subsequent runs.
>
> - Once copied to my laptop, I saw the same issue as above.
>
> Once these issues are resolved, I think we're good to commit.

Oh, a couple more things:

- There should not be a copy of the app bundle in dist/ following the
build. Only the dmg should be there.

- I think mac-build/ should be removed following a successful build,
rather than waiting for make clean (please talk to Paresh - his code
should do the same).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-27 Thread Dave Page 
On Fri, May 27, 2016 at 1:11 PM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.com> wrote:

> Sure. Thanks.
>
> There is a typo in pkg/mac/build.sh. i.e
>
> s/HTML_HELP/HELP_PATH/
>
>
> On Fri, May 27, 2016 at 5:26 PM, Dave Page  wrote:
>
>> Not entirely - we definitely need to improve it. I'll review the code as
>> it is now though.
>>
>
OK, review time :-)

- The appbundle name should be created from APP_NAME.app in config.py, e.g.
'pgAdmin 4.app'

- The DMG name should be created from
to_lower(remove_spaces(APP_NAME-APP_VERSION)) in config.py, e.g.
pgadmin4-1.0-dev.dmg

- Use #ifdef Q_OS_MAC in the QT code for Mac-specific code. There's no need
to define another macro.

- Please add "MINIFY_HTML = False" to config_local.py (and have Paresh do
the same on his packages). This works around a code issue with the docs
that I'll log a bug for.

- In testing, I found that running the app from within the DMG doesn't seem
to work the first time - it prompts for the path, then exits. Once I save
the path it offers, it's fine on subsequent runs.

- Once copied to my laptop, I saw the same issue as above.

Once these issues are resolved, I think we're good to commit.

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] PATCH:Treeview item sorting (pgAdmin4)

2016-05-27 Thread Murtuza Zabuawala 
Hi,

PFA patch, To address RM#1244.

Now we are sorting all collection nodes based on it's labels.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1244.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Compressed version of patch

2016-05-27 Thread Dave Page 
Hi

On Fri, May 27, 2016 at 2:44 PM, Susan Douglas
 wrote:
> Hi All,
>
> I meant to send that patch in a compressed format...

I can't apply this, as it's trying to create a number of files that
already exist in the repo. Did you do a git pull or git rebase before
running git add and creating your patch? If I had to guess, this was
created against the repo prior to me committing your last patch.


-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] User management functionality patch [pgadmin4]

2016-05-27 Thread Harshal Dhumal 
Hi,

PFA initial patch for User management functionality.


-- 
*Harshal Dhumal*
*Software Engineer *



EenterpriseDB 
diff --git a/requirements_py2.txt b/requirements_py2.txt
index a442e36..f3d8622 100644
--- a/requirements_py2.txt
+++ b/requirements_py2.txt
@@ -44,3 +44,5 @@ unittest2==1.1.0
 Werkzeug==0.9.6
 WTForms==2.0.2
 sqlparse==0.1.19
+flask-marshmallow-0.6.2
+marshmallow-sqlalchemy==0.8.1
diff --git a/requirements_py3.txt b/requirements_py3.txt
index 233b14f..6a6fea4 100644
--- a/requirements_py3.txt
+++ b/requirements_py3.txt
@@ -38,3 +38,5 @@ Werkzeug==0.9.6
 wheel==0.24.0
 WTForms==2.0.2
 sqlparse==0.1.19
+flask-marshmallow-0.6.2
+marshmallow-sqlalchemy==0.8.1
\ No newline at end of file
diff --git a/web/config.py b/web/config.py
index 36f1632..712ee2b 100644
--- a/web/config.py
+++ b/web/config.py
@@ -150,7 +150,7 @@ MAX_SESSION_IDLE_TIME = 60
 
 # The schema version number for the configuration database
 # DO NOT CHANGE UNLESS YOU ARE A PGADMIN DEVELOPER!!
-SETTINGS_SCHEMA_VERSION = 10
+SETTINGS_SCHEMA_VERSION = 11
 
 # The default path to the SQLite database used to store user accounts and
 # settings. This default places the file in the same directory as this
diff --git a/web/pgadmin/__init__.py b/web/pgadmin/__init__.py
index f04897e..6d1a9b2 100644
--- a/web/pgadmin/__init__.py
+++ b/web/pgadmin/__init__.py
@@ -16,7 +16,7 @@ from flask.ext.security import Security, SQLAlchemyUserDatastore
 from flask_security.utils import login_user
 from flask_mail import Mail
 from htmlmin.minify import html_minify
-from pgadmin.model import db, Role, User, Version
+from pgadmin.model import db, Role, User, Version, ma
 from importlib import import_module
 from werkzeug.local import LocalProxy
 from pgadmin.utils import PgAdminModule, driver
@@ -189,6 +189,7 @@ def create_app(app_name=config.APP_NAME):
 
 # Create database connection object and mailer
 db.init_app(app)
+ma.init_app(app)
 Mail(app)
 
 import pgadmin.utils.paths as paths
diff --git a/web/pgadmin/model/__init__.py b/web/pgadmin/model/__init__.py
index b8bb256..0aefbf9 100644
--- a/web/pgadmin/model/__init__.py
+++ b/web/pgadmin/model/__init__.py
@@ -20,9 +20,11 @@ things:
 
 from flask.ext.sqlalchemy import SQLAlchemy
 from flask.ext.security import UserMixin, RoleMixin
+from flask_marshmallow import Marshmallow
+from marshmallow import fields
 
 db = SQLAlchemy()
-
+ma = Marshmallow()
 # Define models
 roles_users = db.Table(
 'roles_users',
@@ -46,6 +48,12 @@ class Role(db.Model, RoleMixin):
 description = db.Column(db.String(256), nullable=False)
 
 
+class RoleSchema(ma.ModelSchema):
+"""Define a role schema for serialization"""
+class Meta:
+model = Role
+
+
 class User(db.Model, UserMixin):
 """Define a user object"""
 __tablename__ = 'user'
@@ -58,6 +66,23 @@ class User(db.Model, UserMixin):
 backref=db.backref('users', lazy='dynamic'))
 
 
+class UserSchema(ma.ModelSchema):
+"""Define a user schema for serialization"""
+class Meta:
+model = User
+exclude = ('password', 'roles')
+
+# Convert list of user roles to role.
+# There will be only one role associated with user.
+role = fields.Function(
+  lambda user: str(user.roles[0].id) if len(user.roles) else None
+)
+
+is_admin = fields.Function(
+  lambda user: True if (len(user.roles) and user.roles[0].name == 'Administrators') else False
+)
+
+
 class Setting(db.Model):
 """Define a setting object"""
 __tablename__ = 'setting'
diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css
index 55d83e0..719a989 100755
--- a/web/pgadmin/static/css/overrides.css
+++ b/web/pgadmin/static/css/overrides.css
@@ -1121,7 +1121,7 @@ button.pg-alertify-button {
   margin: 0 0 10px;
   overflow: auto;
   padding: 5px 10px;
-  word-break: break-all;
+  word-break: keep-all;
   word-wrap: break-word;
 }
 
@@ -1129,6 +1129,11 @@ div.backform_control_notes label.control-label {
   min-width: 0px;
 }
 
+.backform_control_notes span{
+  white-space: pre-wrap;
+  word-break: keep-all !important;
+}
+
 form[name="change_password_form"] .help-block {
 color: #A94442 !important;
 }
@@ -1232,3 +1237,15 @@ form[name="change_password_form"] .help-block {
 visibility: hidden;
   }
 }
+
+.subnode-footer {
+  text-align: right;
+  border-color: #a9a9a9;
+  border-style: inset inset inset solid;
+  border-width: 2px 1px 0;
+  margin-top: -10px;
+}
+
+.subnode-footer .ajs-button {
+  margin: 2px 2px 0;
+}
diff --git a/web/pgadmin/tools/user/__init__.py b/web/pgadmin/tools/user/__init__.py
new file mode 100644
index 000..e7cac5a
--- /dev/null
+++ b/web/pgadmin/tools/user/__init__.py
@@ -0,0 +1,307 @@
+##
+#
+# pgAdmin 4 - PostgreSQL Tools
+#
+# Copyright (C) 2013 - 2016, The pgAdmin Development Team
+# This software is

[pgadmin-hackers] [pgadmin4][PATCH][PATCH]: RM 1113: casts should be alphabetical order

2016-05-27 Thread Sanket Mehta 
Hi,

Please find the patch for pgadmin4 RM 1113 attached with this mail.
Please review it and commit.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
diff --git a/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/sql/9.1_plus/nodes.sql b/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/sql/9.1_plus/nodes.sql
index 87f331f..8e9f3e9 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/sql/9.1_plus/nodes.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/sql/9.1_plus/nodes.sql
@@ -20,4 +20,5 @@
 WHERE
 {% endif %}
 ca.oid > {{datlastsysoid}}::OID
-{% endif %}
\ No newline at end of file
+{% endif %}
+ORDER BY st.typname, tt.typname
\ No newline at end of file

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-05-27 Thread Dave Page 
[Adding Devrim]

On Fri, May 27, 2016 at 1:55 PM, Sandeep Thakkar
 wrote:
>
>
> On Mon, May 9, 2016 at 6:35 PM, Dave Page  wrote:
>>
>> Hi
>>
>> Initial eyeball review comments below...
>>
>> On Fri, Apr 22, 2016 at 11:57 AM, Sandeep Thakkar
>>  wrote:
>>>
>>> Hi Team, Dave,
>>>
>>> Attached herewith are two patches.
>>>
>>> pgadmin4-rpm.patch - This is the main patch that includes scripts,
>>> makefiles and spec to create RPMs for RHEL6/RHEL7/F-22/F-23/F-24.
>>
>>
>> Can we keep the directory names in lower case?
>>
>
> Sure. Will do that.
>>>
>>> It will create two RPMs i.e pgadmin4 and pgadmin4-web. The  pgadmin4 tpm
>>> depends on web and the web rpm depends on the python packages. I have
>>> commented the list of packages which are not available on some systems so
>>> that Devrim can build them.
>>>
>>> The installation path for pgadmin4 is "/usr/pgadmin4-." and
>>> pgadmin4-web is the site-packages/pgadmin4-web
>>
>> Shouldn't the -web package also have the major.minor version number in the
>> path, to allow side-by-side installation?
>
> Right. Now that we don't have major/minor, so, will it be /usr/pgadmin4-v1
> and pgadmin4-web-v1 ? Or?

I think that's fine.

>>
>>
>>>
>>> pgadmin4-server-ini.patch - This is the patch for runtime/Server.cpp. As
>>> said pgadmin4-web and runtime installation directories are different and
>>> that means web does not exists in parallel to runtime like in sources.
>>>
>>> I observed that the location of application settings was not defined in
>>> Server.cpp. As per QSettings doc, the default location on Unix is the
>>> $HOME/.config//.conf. Here, $HOME depends on the user
>>> that runs the application. So, I thought why not to define the application
>>> settings in application directory itself. RPM then knows where to define the
>>> ApplicationPath. I tested it and it worked fine with me. I haven't done this
>>> change for platform dependent.
>>
>> Doesn't that prevent non-root users from changing the settings? Or (if you
>> widen the permissions on the ini file), allow one user to mis-configure the
>> app for others? I think what is needed here is a search path change, much
>> like you added for the Mac app bundle.
>>
> Right. Will use python command to find the site-packages path and then
> concatenate pgadmin4-web directory name.

OK.

>> Other thoughts:
>>
>> - Please rename the README to README.txt
>>
>> - The code to build the RPMs should be entirely confined to pkg/rpm. A
>> Makefile target should be added to /Makefile to build/clean the targets
>> (this mistake was made with the Mac package too, but was one of the original
>> requirements).
>>
>> Please resolve these issues and I'll take another look.
>>
> Sure. Will share it with you soon.

-> Devrim please :-)

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable

2016-05-27 Thread Surinder Kumar 
Hi

Please find updated patch with following changes:

   1. Replaced the outdated code for *Backgrid Sizeable Columns plugin *with
   https://github.com/FortesSolutions/backgrid-sizeable-columns library
   because the updated code is available here.
   2. I have figured out to calculate *offset* using the parameters of
   listener provided, so we need not to tweak the original library code.


On Fri, May 27, 2016 at 5:00 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

>
>
> On Fri, May 27, 2016 at 4:43 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Fri, May 27, 2016 at 12:07 PM, Surinder Kumar
>>  wrote:
>> > Hi
>> >
>> > Added support for Columns resizable in query tool. It allows user to
>> resize
>> > the table columns as much as needed.
>> >
>> > We are using Backgrid Sizeable Columns plugin:
>> > https://github.com/WRidder/backgrid-sizeable-columns
>> >
>> > with one change in library on line no 185:
>> > moved the following trigger event out of if condition:
>> >
>> > if (newWidth != oldWidth) {
>> >
>> > }
>> >
>> >
>> > and added one additional parameter offset.
>> > //Trigger event
>> >
>> > view.columns.trigger("resize", columnModel, newWidth, oldWidth, offset);
>> >
>> >
>> > We are listening to this trigger event in sqleditor.js file where we
>> need
>> > offset
>> > to calculate new table width on every resize event.
>>
>> Please ensure any changes to third party libraries are submitted upstream.
>>
> yes, sure.
>
>>
>> > hence, here is the patch attached.
>>
>> ENOATTACHMENT!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>


column_resizable_in_query_tool_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

2016-05-27 Thread Sandeep Thakkar 
On Mon, May 9, 2016 at 6:35 PM, Dave Page  wrote:

> Hi
>
> Initial eyeball review comments below...
>
> On Fri, Apr 22, 2016 at 11:57 AM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> Hi Team, Dave,
>>
>> Attached herewith are two patches.
>>
>> *pgadmin4-rpm.patch* - This is the main patch that includes scripts,
>> makefiles and spec to create RPMs for RHEL6/RHEL7/F-22/F-23/F-24.
>>
>
> Can we keep the directory names in lower case?
>
>
Sure. Will do that.

> It will create two RPMs i.e pgadmin4 and pgadmin4-web. The  pgadmin4 tpm
>> depends on web and the web rpm depends on the python packages. I have
>> commented the list of packages which are not available on some systems so
>> that Devrim can build them.
>>
>> The installation path for pgadmin4 is "/usr/pgadmin4-." and
>> pgadmin4-web is the site-packages/pgadmin4-web
>>
> Shouldn't the -web package also have the major.minor version number in the
> path, to allow side-by-side installation?
>
Right. Now that we don't have major/minor, so, will it be /usr/pgadmin4-v1
and pgadmin4-web-v1 ? Or?

>
>
*pgadmin4-server-ini.patch* - This is the patch for runtime/Server.cpp. As
>> said pgadmin4-web and runtime installation directories are different and
>> that means web does not exists in parallel to runtime like in sources.
>>
>> I observed that the location of application settings was not defined in
>> Server.cpp. As per QSettings doc, the default location on Unix is the
>> $HOME/.config//.conf. Here, $HOME depends on the user
>> that runs the application. So, I thought why not to define the application
>> settings in application directory itself. RPM then knows where to define
>> the ApplicationPath. I tested it and it worked fine with me. I haven't done
>> this change for platform dependent.
>>
> Doesn't that prevent non-root users from changing the settings? Or (if you
> widen the permissions on the ini file), allow one user to mis-configure the
> app for others? I think what is needed here is a search path change, much
> like you added for the Mac app bundle.
>
> Right. Will use python command to find the site-packages path and then
concatenate pgadmin4-web directory name.

> Other thoughts:
>
> - Please rename the README to README.txt
>
> - The code to build the RPMs should be entirely confined to pkg/rpm. A
> Makefile target should be added to /Makefile to build/clean the targets
> (this mistake was made with the Mac package too, but was one of the
> original requirements).
>
> Please resolve these issues and I'll take another look.
>
> Sure. Will share it with you soon.


> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Sandeep Thakkar

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable

2016-05-27 Thread Surinder Kumar 
On Fri, May 27, 2016 at 4:43 PM, Dave Page  wrote:

> Hi
>
> On Fri, May 27, 2016 at 12:07 PM, Surinder Kumar
>  wrote:
> > Hi
> >
> > Added support for Columns resizable in query tool. It allows user to
> resize
> > the table columns as much as needed.
> >
> > We are using Backgrid Sizeable Columns plugin:
> > https://github.com/WRidder/backgrid-sizeable-columns
> >
> > with one change in library on line no 185:
> > moved the following trigger event out of if condition:
> >
> > if (newWidth != oldWidth) {
> >
> > }
> >
> >
> > and added one additional parameter offset.
> > //Trigger event
> >
> > view.columns.trigger("resize", columnModel, newWidth, oldWidth, offset);
> >
> >
> > We are listening to this trigger event in sqleditor.js file where we need
> > offset
> > to calculate new table width on every resize event.
>
> Please ensure any changes to third party libraries are submitted upstream.
>
yes, sure.

>
> > hence, here is the patch attached.
>
> ENOATTACHMENT!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

Re: [pgadmin-hackers] PATCH: graphical explain

2016-05-27 Thread Sanket Mehta 
Hi,

I will start working on it once I will complete PEM 6.0.1 issues.
Now there is only 1 issue remaining in that bucket which I am currently
working on

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, May 27, 2016 at 4:44 PM, Dave Page  wrote:

> What is the status of this Sanket? I'd really like to see it completed
> before alpha.
>
> On Thu, Apr 21, 2016 at 3:07 PM, Dave Page  wrote:
> > This looks awesome, and is MIT licenced:
> >
> >
> http://www.jqueryrain.com/2016/01/imageviewer-jquery-zooming-and-panning-plugin/
> >
> >
> > On Wednesday, April 20, 2016, Sanket Mehta <
> sanket.me...@enterprisedb.com>
> > wrote:
> >>
> >>
> >> On Wed, Apr 20, 2016 at 6:12 PM, Dave Page  wrote:
> >>>
> >>>
> >>>
> >>> On Tuesday, April 19, 2016, Sanket Mehta <
> sanket.me...@enterprisedb.com>
> >>> wrote:
> 
>  Hi,
> 
>  On Mon, Apr 18, 2016 at 5:38 PM, Dave Page  wrote:
> >
> >
> >
> > On Monday, April 18, 2016, Sanket Mehta <
> sanket.me...@enterprisedb.com>
> > wrote:
> >>
> >> Hi Dave,
> >>
> >> Regarding your second comment,
> >> Almost all the libraries that I have checked uses Jquery UI which is
> >> quite heavy.
> >> Please share your comments about using these libraries.
> >
> >
> > What have you found?
> 
>  Below are the libraries I have checked out which uses JQUERY UI.
> 
>   -
> https://github.com/princejwesley/minimap/blob/master/src/minimap.js
> >>>
> >>>
> >>> That one would work wound't it? Assuming it can do x and y movement.
> >>
> >> I have tried to implement the same but it is not working properly as
> >> scrolling in minimap was not there and sometimes it was not showing the
> map
> >> itself.
> >>
> >>>
> >>>
> >>> --
> >>> Dave Page
> >>> Blog: http://pgsnake.blogspot.com
> >>> Twitter: @pgsnake
> >>>
> >>> EnterpriseDB UK: http://www.enterprisedb.com
> >>> The Enterprise PostgreSQL Company
> >>>
> >>
> >
> >
> > --
> > Dave Page
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
> >
> > EnterpriseDB UK: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] PATCH: graphical explain

2016-05-27 Thread Dave Page 
What is the status of this Sanket? I'd really like to see it completed
before alpha.

On Thu, Apr 21, 2016 at 3:07 PM, Dave Page  wrote:
> This looks awesome, and is MIT licenced:
>
> http://www.jqueryrain.com/2016/01/imageviewer-jquery-zooming-and-panning-plugin/
>
>
> On Wednesday, April 20, 2016, Sanket Mehta 
> wrote:
>>
>>
>> On Wed, Apr 20, 2016 at 6:12 PM, Dave Page  wrote:
>>>
>>>
>>>
>>> On Tuesday, April 19, 2016, Sanket Mehta 
>>> wrote:

 Hi,

 On Mon, Apr 18, 2016 at 5:38 PM, Dave Page  wrote:
>
>
>
> On Monday, April 18, 2016, Sanket Mehta 
> wrote:
>>
>> Hi Dave,
>>
>> Regarding your second comment,
>> Almost all the libraries that I have checked uses Jquery UI which is
>> quite heavy.
>> Please share your comments about using these libraries.
>
>
> What have you found?

 Below are the libraries I have checked out which uses JQUERY UI.

  - https://github.com/princejwesley/minimap/blob/master/src/minimap.js
>>>
>>>
>>> That one would work wound't it? Assuming it can do x and y movement.
>>
>> I have tried to implement the same but it is not working properly as
>> scrolling in minimap was not there and sometimes it was not showing the map
>> itself.
>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable

2016-05-27 Thread Surinder Kumar 
Hi,

forgot to attach patch.
Please find attached patch.

On Fri, May 27, 2016 at 4:37 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> Added support for *Columns resizable in query tool*. It allows user to
> resize the table columns as much as needed.
>
> We are using Backgrid Sizeable Columns plugin:
> *https://github.com/WRidder/backgrid-sizeable-columns
> *
>
> with one change in library on line no 185:
> moved the following trigger event out of *if condition*:
>
> if (newWidth != oldWidth) {
>
> }
>
> and added one additional parameter *offset*.
> //Trigger event
>
> view.columns.trigger("resize", columnModel, newWidth, oldWidth, offset);
>
> We are listening to this trigger event in *sqleditor.js* file where we
> need *offset*
> to calculate new table width on every resize event.
>
> hence, here is the patch attached.
>
> Please review.
>
>
> Thanks,
> Surinder Kumar
>


column_resizable_in_query_tool.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable

2016-05-27 Thread Dave Page 
Hi

On Fri, May 27, 2016 at 12:07 PM, Surinder Kumar
 wrote:
> Hi
>
> Added support for Columns resizable in query tool. It allows user to resize
> the table columns as much as needed.
>
> We are using Backgrid Sizeable Columns plugin:
> https://github.com/WRidder/backgrid-sizeable-columns
>
> with one change in library on line no 185:
> moved the following trigger event out of if condition:
>
> if (newWidth != oldWidth) {
>
> }
>
>
> and added one additional parameter offset.
> //Trigger event
>
> view.columns.trigger("resize", columnModel, newWidth, oldWidth, offset);
>
>
> We are listening to this trigger event in sqleditor.js file where we need
> offset
> to calculate new table width on every resize event.

Please ensure any changes to third party libraries are submitted upstream.

> hence, here is the patch attached.

ENOATTACHMENT!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable

2016-05-27 Thread Surinder Kumar 
Hi

Added support for *Columns resizable in query tool*. It allows user to
resize the table columns as much as needed.

We are using Backgrid Sizeable Columns plugin:
*https://github.com/WRidder/backgrid-sizeable-columns
*

with one change in library on line no 185:
moved the following trigger event out of *if condition*:

if (newWidth != oldWidth) {

}

and added one additional parameter *offset*.
//Trigger event

view.columns.trigger("resize", columnModel, newWidth, oldWidth, offset);

We are listening to this trigger event in *sqleditor.js* file where we need
*offset*
to calculate new table width on every resize event.

hence, here is the patch attached.

Please review.


Thanks,
Surinder Kumar

[pgadmin-hackers] PATCH: To fix the issue while adding first server (pgAdmin4)

2016-05-27 Thread Murtuza Zabuawala 
Hi,

PFA patch to fix the issue when we add first server in pgAdmin4.
(RM#1104)

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Fixed_adding_first_server.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Updated the Alertify to use latest version 1.7.0

2016-05-27 Thread Ashesh Vashi 
Updated the Alertify to use latest version 1.7.0

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f247153920d4d51fb1a7d36df6f7c654d1d91696

Modified Files
--
libraries.txt  |   2 +-
web/pgadmin/static/css/alertifyjs/alertify.css |   4 +-
web/pgadmin/static/css/alertifyjs/alertify.min.css |   6 +-
web/pgadmin/static/css/alertifyjs/alertify.rtl.css |   4 +-
.../static/css/alertifyjs/alertify.rtl.min.css |   6 +-
.../static/css/alertifyjs/themes/bootstrap.css |   4 +-
.../static/css/alertifyjs/themes/bootstrap.min.css |   4 +-
.../static/css/alertifyjs/themes/bootstrap.rtl.css |   4 +-
.../css/alertifyjs/themes/bootstrap.rtl.min.css|   4 +-
.../static/css/alertifyjs/themes/default.css   |   4 +-
.../static/css/alertifyjs/themes/default.min.css   |   4 +-
.../static/css/alertifyjs/themes/default.rtl.css   |   4 +-
.../css/alertifyjs/themes/default.rtl.min.css  |   4 +-
.../static/css/alertifyjs/themes/semantic.css  |   4 +-
.../static/css/alertifyjs/themes/semantic.min.css  |   4 +-
.../static/css/alertifyjs/themes/semantic.rtl.css  |   4 +-
.../css/alertifyjs/themes/semantic.rtl.min.css |   4 +-
web/pgadmin/static/js/alertifyjs/alertify.js   | 289 ++---
web/pgadmin/static/js/alertifyjs/alertify.min.js   |   7 +-
19 files changed, 288 insertions(+), 78 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Fwd: [pgadmin-hackers] [pgAdmin4][Patch]: Node issues under catalogs

2016-05-27 Thread Surinder Kumar 
Hi

PFA patch with following fixes:
1. Introduced a new function *'is_security_group_under_catalog' *which
return false if node of *type: group* is under
catalog otherwise true.
2. In security group, group-id is simple string.
3. Fixed indentation in schema.js.
4. Also set *parent_type* of sequence node to *catalogs *which i missed in
previous patch.

Please review the patch.

On Thu, May 26, 2016 at 8:57 AM, Ashesh Vashi  wrote:

>
> On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>>
>> Following are the issues fixed in this patch:
>> 1. Nodes not expanding under catalogs
>> *Issue: *Check for setting schema was missing. schema should set only if
>> node is in create mode.
>>
>> 2. Error fetching node's properties.
>> *Issue: *Node attribute *parent_type* is not set to catalogs.
>>
>> 3. Don't show create rule option in table create menu if it is under
>> catalog.
>>
>> 4. Security tab of node should be hidden under catalogs.
>> Every node with controls *privilege and security labels* must be under *type:
>> group*
>> to keep them hide when node is listed under catalogs.
>> This code is implemented in backform.pgadmin.js
>>
>> *For Example:*
>>
>> *schema:[*{
>> id: '*security*', label: '{{ _("Security") }}',
>> *type: 'group'*
>> },{
>>id: 'acl', label: '{{ _('Privileges') }}', *group: '{{ _('security')
>> }}'*
>>
> This is wrong - you should not put the group-id as i18n string.
> It should be a simple string. i.e. group: 'security'
>
>> },{
>>   id: 'seclabels', label: '{{ _('Security Labels') }}',
>>   model: SecurityModel, type: 'collection',
>>   *group: '{{ _('security') }}'*
>>
> Same as above.
>
>> }*]*
>>
>> Please find attached patch and review.
>>
> I also found - we're not consistent about showing ACL on all the node.
> For some node, we're not showing ACLs in properties mode.
>
> Please send patch with above fixes.
>

> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>>
>> Thanks,
>> Surinder Kumar
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>


hide_security_grops_under_catalogs.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: To fix issue in updating comments (pgAdmin4)

2016-05-27 Thread Murtuza Zabuawala 
Hi,

PFA patch to fix the issue in updating comments in foreign data
wrapper/foreign table.
(RM#1143)

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1143.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: To fix issue in removing comments in edit mode (pgAdmin4)

2016-05-27 Thread Murtuza Zabuawala 
Hi,

PFA patch to fix the issue in function/procedure/trigger-function node
while updating comments.
(RM#1142)


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1142.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers