[pgadmin-hackers] pgAdmin 4 commit: Load the collection node sorted on order by 'label'.

Load the collection node sorted on order by 'label'. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af1e70ba4fed709e3b0ae2361e0c1703e112e424 Modified Files -- web/pgadmin/browser/utils.py | 15 --- 1 file changed, 12

[pgadmin-hackers] pgAdmin 4 commit: Do proper validation of the server node.

Do proper validation of the server node. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8313bc9b8aeba2eb564622094c1ac4d03494e119 Modified Files -- .../servers/templates/servers/servers.js | 42 +++--- 1

[pgadmin-hackers] pgAdmin 4 commit: Select parent node when deleting/dropping the last ch

Select parent node when deleting/dropping the last children. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=57f3cbfa3b01277ae99d7eb39b0a330b4ceaf547 Modified Files -- web/pgadmin/browser/templates/browser/js/node.js | 7 ++- 1

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1104 - Load the first level node properly, whe

Fixes #1104 - Load the first level node properly, whenever we add first node under it, and select that node. This fixes the problem of adding first server. Branch -- master Details ---

Re: [pgadmin-hackers] PATCH: pgAdmin4 debian installer

Devrim only works on Redhat, so I'll take a look at this myself. Thanks. BTW - I need the completed and working Windows build scripts tomorrow AM, my time! On Thu, Jun 2, 2016 at 5:16 PM, Paresh More wrote: > Hello Dave and Devrim, > > > Changes are done as per

Re: [pgadmin-hackers] PATCH: pgAdmin4 debian installer

Hello Dave and Devrim, Changes are done as per discussed with Sandeep. There are some python modules which are not available on ubuntu (through apt-get) which is mentioned in the sheet here , We could find some packages on web and the URLs of same have been updated in the sheet. For the

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

Hi Devrim, Hi Dave, I have updated the patch. The earlier patch may fail because of app bundle commit in git. For testing, you may define the source tarball location as : Source0: http://bugatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz Known issue that I'm still working

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

Hi Dave/Ashesh, Please find patch for the dashboard issue, Please review it. I tried with both config options "threaded=True" & "threaded=False", In both cases this fix working fine. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On

[pgadmin-hackers] Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

Please ignore this patch. I will send another patch. On Thu, Jun 2, 2016 at 7:25 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Please find attached patch for RM#1293. > Add support to display GRANT privilege query in SQL Pane. > > Please review. > > Thanks, > Surinder

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

Hi, Please find attached patch for RM#1293. Add support to display GRANT privilege query in SQL Pane. Please review. Thanks, Surinder Kumar display_GRANT_queries_in_SQL_PANE.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, This patch requires backgrid password cell for I have sent patch yesterday. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 2, 2016 at 7:12 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: >

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, PFA patch for user management functionality. Major changes in this patch are: 1. In-place editing of user and saving on server. 2. Removed dependency on marshmallow python package. 3. UI improvements. 4. Search by email. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India:

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

I will look into it.. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jun 2, 2016 at 6:23 PM, Dave Page wrote: > On

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

okay. Thanks again! On Thu, Jun 2, 2016 at 6:37 PM, Dave Page wrote: > On Thu, Jun 2, 2016 at 2:05 PM, Sandeep Thakkar > wrote: > > Thanks Dave! > > > > I saw the runtime code and observed one change (prepend -> append) . Was > it > > not

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

On Thu, Jun 2, 2016 at 2:05 PM, Sandeep Thakkar wrote: > Thanks Dave! > > I saw the runtime code and observed one change (prepend -> append) . Was it > not saving the location because of this? No - I changed that because if the value is prepended, the user

Re: [pgadmin-hackers] Patch for pgAdmin 4 docs

Thanks - pushed! On Wed, Jun 1, 2016 at 1:24 PM, Susan Douglas wrote: > Hi All, > > I've attached a patch for the pgAdmin 4 docs... let me know if there are any > problems! > > Thanks! > > -- Susan > -- Dave Page VP, Chief Architect, Tools & Installers

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Thanks Dave! I saw the runtime code and observed one change (prepend -> append) . Was it not saving the location because of this? On Thu, Jun 2, 2016 at 6:27 PM, Dave Page wrote: > Thanks - applied with some tweaks to the runtime code (i.e. not saving > the location of the

[pgadmin-hackers] pgAdmin 4 commit: Table dialog and backup tool docs

Table dialog and backup tool docs Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e47671edaa3ae9e0b6db6ebb96468029b1d26095 Author: Susan Douglas Modified Files -- docs/en_US/backup_dialog.rst

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

Hi Few changes in the updated patch: - added the missing modules in the specfile. The unavailable modules are still commented. - added changelog in specfile - added dependency of pgadmin4-doc on pgadmin4-web On Wed, Jun 1, 2016 at 2:57 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com>

[pgadmin-hackers] pgAdmin 4 commit: Add Mac Appbundle generation support.

Add Mac Appbundle generation support. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3074af101bd118772b6fe98553bed7b2096c40bb Author: Sandeep Thakkar Modified Files -- .gitignore

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

Thanks - applied with some tweaks to the runtime code (i.e. not saving the location of the venv in the appbundle). On Tue, May 31, 2016 at 6:37 PM, Sandeep Thakkar wrote: > Hi Dave, > > > On Tue, May 31, 2016 at 9:29 PM, Dave Page wrote: >>

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

On Tue, May 31, 2016 at 3:43 PM, Murtuza Zabuawala wrote: > Hi, > > As advised by Ashesh, I have tried flask 'threaded' options for this issues > & it fixed the issue. > > PFA patches to fix long load delay when expanding server if server is > inaccessible. >

Re: [pgadmin-hackers] PATCH: To fix minor patches (pgAdmin4)

Hi, PFA updated patch for RM#1234. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 2, 2016 at 3:38 PM, Ashesh Vashi wrote: > > On Wed, Jun 1, 2016 at 1:23 PM, Murtuza

[pgadmin-hackers] PATCH: Fixed issue in Index node (pgAdmin4)

Hi, PFA patches to fixed the issue mentioned in RM#1283 RM#1285 RM#1287 Additionally I have fixed the issue where Columns collection was not disable in edit mode, adding new column was disabled but we were able to change the value of existing columns. -- Regards, Murtuza Zabuawala

Re: [pgadmin-hackers] PATCH: Fix the issue in JSON decoding (pgAdmin4)

Hi, I was not sure about all the internal representation of psycopg date/time format against python’s datetime for JSON decoding format, so I used logical OR. Thanks, Murtuza > On 02-Jun-2016, at 3:10 pm, Ashesh Vashi > wrote: > > On Thu, Jun 2, 2016 at 12:04

Re: [pgadmin-hackers] PATCH: To fix the issue in type node (pgAdmin4)

Hi, We had condition where we were validating some model objects only if it’s in sessAttrs, which I have removed it now. Issue: we were not getting error for required fields. Regards, Murtuza > On 02-Jun-2016, at 3:55 pm, Ashesh Vashi > wrote: > > On Thu, Jun

Re: [pgadmin-hackers] PATCH: To fix the issue in type node (pgAdmin4)

On Thu, Jun 2, 2016 at 3:53 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Ashesh, > > I have fixed the issue and also corrected some validations as well in > privileges.js where we were using object before validation it. > Can you please give some details about those

Re: [pgadmin-hackers] PATCH: To fix the issue in type node (pgAdmin4)

Hi Ashesh, I have fixed the issue and also corrected some validations as well in privileges.js where we were using object before validation it. Thanks, Murtuza. > On 02-Jun-2016, at 3:40 pm, Ashesh Vashi > wrote: > > On Wed, Jun 1, 2016 at 6:25 PM, Murtuza

Re: [pgadmin-hackers] PATCH: Fix issue in Query tool not showing correct output (pgAdmin4)

Akshay, Can you please review it? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Wed, Jun 1, 2016 at 4:07 PM, Murtuza Zabuawala <

Re: [pgadmin-hackers] PATCH: To fix the issue in type node (pgAdmin4)

On Wed, Jun 1, 2016 at 6:25 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue when throwing "Internal server error" on adding > Privileges > (RM#1273) > The patch contains multiple fixes in the Type node. Can you please explain, what these

Re: [pgadmin-hackers] PATCH: To fix minor patches (pgAdmin4)

On Wed, Jun 1, 2016 at 1:23 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patches to fix RM#1234, RM#1279. > I've committed the fix for RM#1276. But - Proposed fix for RM#1234 does not look right to me. Consider a name, value has ';' (semicolon) within

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1276 - Resolved an issue - 'TypeError: c is un

Fixes #1276 - Resolved an issue - 'TypeError: c is undefined on removing member type from Type=composite'. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f25e90fa409583b3678a26b2aab120d3614406b Author: Murtuza Zabuawala

[pgadmin-hackers] pgAdmin 4 commit: Rename the 'Auto Vacuum' tab to 'Parameter' as it rep

Rename the 'Auto Vacuum' tab to 'Parameter' as it represents 'Storage Parameters'. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e18b135f6fcd31403c1eb42287b527ca49321a0f Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][runtime]: Checkbox and radiobutton rendering issue on Mac OS

Thanks - committed! I've added the following link as reference: https://bugreports.qt.io/browse/QTBUG-43366 -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

[pgadmin-hackers] pgAdmin 4 commit: QWebView does not render checkbox, and radio button p

QWebView does not render checkbox, and radio button propoerly on MacOSX. In order to fix it, we need to set 'style' to 'funsion' on MacOSX. Reference: https://bugreports.qt.io/browse/QTBUG-43366 Branch -- master Details ---

Re: [pgadmin-hackers] PATCH: Fix the issue in JSON decoding (pgAdmin4)

On Thu, Jun 2, 2016 at 12:04 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in json decoding while dealing with date > format, causing QueryTool to fail to render data. > RM#1280 > Shouldn't the check have 'and' instead of 'or' bitwise

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1290 - unknown error displayed if add comments on Materialized view that contain special characters

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jun 2, 2016 at 12:09 PM, Surinder Kumar <

[pgadmin-hackers] pgAdmin 4 commit: Fixes# 1290 - Use qtLiteral with parameterized values

Fixes# 1290 - Use qtLiteral with parameterized values. When not using qtLiteral, it was result into an error - "unknown error displayed when modify comments which may special characters on Materialized view". Branch -- master Details ---

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

Thanks - all patches are committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Wed, Jun 1, 2016 at 11:04 AM, Murtuza Zabuawala <

[pgadmin-hackers] pgAdmin 4 commit: Check valid DOMElement existance before accessing it

Check valid DOMElement existance before accessing it while updating the menu updation. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf042d46a26d374604050a4d4a908ad7b0329ea4 Author: Murtuza Zabuawala

[pgadmin-hackers] pgAdmin 4 commit: Fixes an issue rendering the dashboard, when data obj

Fixes an issue rendering the dashboard, when data object is missing. Also, fixed an issue checking the existence of the data object before accessing it in schema javascript module. Branch -- master Details ---

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1185 - While connecting to the server, applica

Fixes #1185 - While connecting to the server, application becomes almost inaccessible. In stand (without threaded) mode, flask application is not able to process more than one request at a time. Hence - even the client (browser) send multiple request, when connecting the server (which is

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1295 - Added menu for the 'Grant Wizard' for t

Fixes #1295 - Added menu for the 'Grant Wizard' for the trigger function nodes. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e8a52fcd310f0728eec1432a92e558136e060dd0 Author: Surinder Kumar Modified Files

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1295 - Grant wizard should also added with Trigger function node through Right Click

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jun 2, 2016 at 2:43 PM, Surinder Kumar <

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1243 - Allow to resize the columns of the resu

Fixes #1243 - Allow to resize the columns of the result table in the Query editor. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=278f18bab8ce7d36a05c789a9e10d6211dfd5451 Author: Surinder Kumar Modified Files

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1295 - Grant wizard should also added with Trigger function node through Right Click

Hi, Please find attached patch for RM#1295 Support was already added for trigger function but its option was missing in menu. Thanks, Surinder Kumar add_grant_wizard_option_for_trigger_function.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1243 - Columns on the Query Tool should be sizeable

On Tue, May 31, 2016 at 1:56 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Please find updated patch with following changes: > 1. the sizeHandler is not calculating the position without resizing > 2. Apply sizeable columns to history grid in query tool. > 3. Table column

Re: [pgadmin-hackers] Regarding issue 1241

On Tue, May 31, 2016 at 8:53 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > Regarding Issue 1241 : > > We have added header section for parameter tab deliberately so that we can > force user to select parameter name (and

[pgadmin-hackers] pgAdmin 4 commit: [Runtime] Adding python libs in the LIBS build enviro

[Runtime] Adding python libs in the LIBS build environment. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fddc30c99ff2ac5c23fb345577a2cad1de4c60c8 Modified Files -- runtime/pgAdmin4.pro | 1 + 1 file changed, 1 insertion(+) --

[pgadmin-hackers] pgAdmin 4 commit: Fixed issue only coming in the runtime.

Fixed issue only coming in the runtime. * Do not need to translate an empty string. (that results into the translation header inclusion in the javacript module). * String.prototype.StartsWith is not an well received function, it has not been available in the QWebkit for linux. Branch --

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1290 - unknown error displayed if add comments on Materialized view that contain special characters

Hi, Please find attached patch for RM#1290 The text for comment in SQL query should be wrapped by qtIdent instead of single quotes. Please review. Thanks, Surinder Kumar RM#1290.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make

[pgadmin-hackers] PATCH: Fix the issue in JSON decoding (pgAdmin4)

Hi, PFA patch to fix the issue in json decoding while dealing with date format, causing QueryTool to fail to render data. RM#1280 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1280.patch Description: Binary data -- Sent via