Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

Hi Dave, Can you please share steps to re-produce RM#1316, I’m not able to re-produce it on my side. Meanwhile, PFA patch for RM#1315 :-) Regards, Murtuza On 07-Jun-2016, at 5:52 pm, Dave Page wrote: Thanks. I've pushed this with changes to reformat some of the SQL, and

[pgadmin-hackers] pgadmin4 install problems

First time install from git of pgadmin4, a few problems. Requirements seem to be installed correctly, but on make I get Babel not imported. pip shows that Flask and Babel are in. I'm getting the impression that python 3 is required, since if I try 2.7 I get many problems with importlib.util

[pgadmin-hackers] pgAdmin 4 commit: Revert "Fix appicon font styling."

Revert "Fix appicon font styling." This doesn't actually work - there seems to be something funky about the way the runtime renders mfizz icons on Windows. This reverts commit 5bbaf7841eeb005ab52356a7e7ac855910cefb16. Branch -- master Details ---

[pgadmin-hackers] pgAdmin 4 commit: Fix appicon font styling.

Fix appicon font styling. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5bbaf7841eeb005ab52356a7e7ac855910cefb16 Modified Files -- web/pgadmin/static/css/overrides.css | 1 + 1 file changed, 1 insertion(+) -- Sent via

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

Thanks. I've pushed this with changes to reformat some of the SQL, and ensure the column headers are properly cased. There is one outstanding bug though - if an object is selected for which the stats query doesn't return any rows (e.g. track_functions = false), then weird things happen - you get

[pgadmin-hackers] pgAdmin 4 commit: Statistics support remaining object types that suppor

Statistics support remaining object types that support them. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ace8bb5b6cae4428c1ce3c749e46a5c684e536d Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Fix validation of object before using it

Fix validation of object before using it Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ac2612264c6ae2ba9e4d75ed05d1532c67cd909f Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Fix incorrect condition checking for privileges.

Fix incorrect condition checking for privileges. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=20a22731e0b1045040f62807a92147c7d24a7061 Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

Hi, PFA patch to add Statistics functionality to below nodes, - Table - Function - Procedure - Trigger Function - Sequence - Index - Column - Primary Key - Unique constraint - Exclusion constraint (RM#1299) --- Additionally, attaching two separate

[pgadmin-hackers] pgAdmin 4 commit: Fix venv search path on Mac.

Fix venv search path on Mac. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4380c6714edfe8e505d7ea2ccec2d563fc331700 Modified Files -- runtime/Server.cpp | 5 + 1 file changed, 5 insertions(+) -- Sent via pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch]: TypeError: Cannot read property 'generate_url' of undefined

Hi, *Issue:* When any of the docked tab(statistics, dependents & dependencies) are clicked without selecting any tree node. it gives error in browser console panel. Because the node passed is undefined. and check is missing. This is now fixed by adding check for node passed. So, please review

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken

On Tue, Jun 7, 2016 at 1:46 PM, Ashesh Vashi wrote: > On Sat, Jun 4, 2016 at 3:44 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi, >> >> Please find attached patch for mentioned issue: >> *Issue*: Re-docking on the main tabset is broken >>

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework

Hi, Please find the patch with following changes: 1. Added help button to the bottom left of the wizard framework. *Usage: * Set *wizard_help* property with url while creating wizard object. var wizard = new (pgBrowser.Wizard.extend({ options: { title: _('Wizard Title'), *wizard_help:

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Thanks - applied with a minor tweak for the button styling so it looked consistent in webkit browsers. On Tue, Jun 7, 2016 at 8:13 AM, Harshal Dhumal wrote: > Hi, > > > PFA patch for user management issues. > > -- > Harshal Dhumal > Software Engineer > >

[pgadmin-hackers] pgAdmin 4 commit: Fix email validation and mouse pointer over the Users

Fix email validation and mouse pointer over the Users option. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f3fae9d238dc6243485812f873d78e94390ad855 Author: Harshal Dhumal Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Fix styling of Alertify buttons

Fix styling of Alertify buttons Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e4f21568add5e3e52f71453ba45e1007823bc1e3 Author: Harshal Dhumal Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken

On Sat, Jun 4, 2016 at 3:44 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Please find attached patch for mentioned issue: > *Issue*: Re-docking on the main tabset is broken > *Explanation*: > We were missing 'moveable' property. It should be set to false while > creating

[pgadmin-hackers] pgAdmin 4 commit: Fix typo per Susan.

Fix typo per Susan. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=124f49869e15eafed793de050ebd11f8e75c3496 Modified Files -- web/pgadmin/tools/maintenance/templates/maintenance/js/maintenance.js | 2 +- 1 file changed, 1

Re: [pgadmin-hackers] Patch for pgAdmin docs

Thanks, applied. On Mon, Jun 6, 2016 at 4:31 PM, Susan Douglas wrote: > Hi All, > > I've attached a patch for the pgAdmin 4 documentation. Let me know if there > are any problems! > > Thanks! > > -- Susan > > > -- Dave Page VP, Chief Architect, Tools &

[pgadmin-hackers] pgAdmin 4 commit: More doc updates.

More doc updates. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b0a901e90ed1bd60e200d7e5e863895ff6b05163 Author: Susan Douglas Modified Files -- docs/en_US/.gitignore

[pgadmin-hackers] pgAdmin 4 commit: Remove and ignore code_snippets.rst as it's auto-gene

Remove and ignore code_snippets.rst as it's auto-generated. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=14ced20db01f44b0400ddb3173aab8815b3939cf Modified Files -- docs/en_US/.gitignore| 1 +

[pgadmin-hackers] pgAdmin 4 commit: During encryption password is converted to buffer (in

During encryption password is converted to buffer (instead of bytearray), and that is causing the issue in Python 2. This was regress of commit-id: 37e2e1d24beb9d5a4474dfaacfa209d2c060991f Branch -- master Details ---

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, PFA patch for user management issues. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jun 6, 2016 at 6:06 PM, Dave Page wrote: > Hi > > Thanks - I've commit as-is (with some minor

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

Hi Dave I used few APIs from Importing Modules and Modules Objects to import the pgAdmin4 module and then get it's location but the application crashed on running. I didn't debug it and instead created a new function in Server.cpp to get the python path and the webpath which uses python command.