[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #283

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Ashesh Vashi] Using client-side 'url_for' implementation in the Grant-Wizard 
module.

--
[...truncated 272.94 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #165

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Ashesh Vashi] Using client-side 'url_for' implementation in the Grant-Wizard 
module.

--
[...truncated 270.86 KB...]
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_get.TriggerFuncGetTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_put.TriggerFuncPutTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_add.SequenceAddTestCase)
Fetch sequence Node URL
--
Traceback (most recent call last):
  File 
"
 line 39, in runTest
self.server_id, self.db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_add.SchemaAddTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 36, in runTest
db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_delete.SchemaDeleteTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 46, in runTest
server_id, db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_ge

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #159

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Ashesh Vashi] Using client-side 'url_for' implementation in the Grant-Wizard 
module.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the Gra

2017-06-12 Thread Ashesh Vashi 
Using client-side 'url_for' implementation in the Grant-Wizard module.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0243d886c3cd01d8ca4d2941edf063c39affd1e6

Modified Files
--
web/pgadmin/tools/grant_wizard/__init__.py | 38 -
.../templates/grant_wizard/js/grant_wizard.js  | 63 +++---
2 files changed, 57 insertions(+), 44 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #164

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Ashesh Vashi] Using client-side 'url_for' implementation in the module - 
bgprocess

[Ashesh Vashi] Using client-side 'url_for' implementation in the backup module.

[Ashesh Vashi] Using client-side 'url_for' implementation in the restore module.

--
[...truncated 270.86 KB...]
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_get.TriggerFuncGetTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_put.TriggerFuncPutTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_add.SequenceAddTestCase)
Fetch sequence Node URL
--
Traceback (most recent call last):
  File 
"
 line 39, in runTest
self.server_id, self.db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_add.SchemaAddTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 36, in runTest
db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_delete.SchemaDeleteTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 46, in runTest
server_id, db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

2017-06-12 Thread Khushboo Vashi 
Hi,

On Mon, Jun 12, 2017 at 5:27 PM, Dave Page  wrote:

> Hi
>
> On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi
>  wrote:
> > Hi,
> >
> > Please find the attached patch to reset the zoom level in the desktop
> > runtime.
> >
> > Added the new shortcut CTRL + 0 to reset the zoom level.
>
> The code looks good, however I don't think resetting to the startup
> value is really what we want. Shouldn't it reset it to 1.0?
>
> I have changed the code.
Also, introduced a single slot for Zoom In/Out/Reset rather than 3
different.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/runtime/BrowserWindow.cpp b/runtime/BrowserWindow.cpp
index 516b868..b04396d 100644
--- a/runtime/BrowserWindow.cpp
+++ b/runtime/BrowserWindow.cpp
@@ -197,6 +197,8 @@ void BrowserWindow::createActions()
 exitShortcut->setContext(Qt::ApplicationShortcut);
 connect(exitShortcut, SIGNAL(activated()), this, SLOT(close()));
 
+signalMapper = new QSignalMapper(this);
+
 // About box
 aboutShortcut = new QShortcut(QKeySequence(Qt::ALT + Qt::SHIFT + Qt::Key_A), this);
 aboutShortcut->setContext(Qt::ApplicationShortcut);
@@ -205,12 +207,23 @@ void BrowserWindow::createActions()
 // Zoom in
 zoomInShortcut = new QShortcut(QKeySequence(QKeySequence::ZoomIn), this);
 zoomInShortcut->setContext(Qt::ApplicationShortcut);
-connect(zoomInShortcut, SIGNAL(activated()), this, SLOT(zoomIn()));
+signalMapper->setMapping(zoomInShortcut, 1);
+connect(zoomInShortcut, SIGNAL(activated()), signalMapper, SLOT(map()));
 
 // Zoom out
 zoomOutShortcut = new QShortcut(QKeySequence(QKeySequence::ZoomOut), this);
 zoomOutShortcut->setContext(Qt::ApplicationShortcut);
-connect(zoomOutShortcut, SIGNAL(activated()), this, SLOT(zoomOut()));
+signalMapper->setMapping(zoomOutShortcut, -1);
+connect(zoomOutShortcut, SIGNAL(activated()), signalMapper,  SLOT(map()));
+
+// Reset Zoom
+zoomResetShortcut = new QShortcut(QKeySequence(Qt::CTRL + Qt::Key_0), this);
+zoomResetShortcut->setContext(Qt::ApplicationShortcut);
+signalMapper->setMapping(zoomResetShortcut,  0);
+connect(zoomResetShortcut, SIGNAL(activated()), signalMapper,  SLOT(map()));
+
+connect(signalMapper, SIGNAL(mapped(int)), this, SLOT(setZoomLevel(int)));
+
 
 #ifdef __APPLE__
   #ifdef PGADMIN4_USE_WEBENGINE
@@ -1186,8 +1199,8 @@ void BrowserWindow::about()
 }
 
 
-// Zoom in
-void BrowserWindow::zoomIn()
+// Set Zoom Level
+void BrowserWindow::setZoomLevel(int zoomFlag)
 {
 int tabCount = 0;
 WebViewWindow *webviewPtr = NULL;
@@ -1209,55 +1222,27 @@ void BrowserWindow::zoomIn()
 
 if (webviewPtr != NULL)
 {
-webviewPtr->setZoomFactor(m_mainWebView->zoomFactor() + 0.1);
+if (zoomFlag == 1) {
+ webviewPtr->setZoomFactor(m_mainWebView->zoomFactor() + 0.1);
+}
+else if (zoomFlag == -1) {
+webviewPtr->setZoomFactor(m_mainWebView->zoomFactor() - 0.1);
+}
+else if(zoomFlag == 0) {
+webviewPtr->setZoomFactor(1.0);
+}
 }
 }
 }
 }
 }
 
-// Save the zoom factor for next time
+// Set the zoom value for the next time
 QSettings settings;
 settings.setValue("Browser/Zoom", m_mainWebView->zoomFactor());
-}
-
-
-// Zoom out
-void BrowserWindow::zoomOut()
-{
-int tabCount = 0;
-WebViewWindow *webviewPtr = NULL;
-
-// Loop through all the tabs
-for (tabCount = 0; tabCount < m_tabWidget->count(); tabCount++)
-{
-QWidget *tab = m_tabWidget->widget(tabCount);
-if (tab != NULL)
-{
-// Find and loop through any child controls
-QList widgetList = tab->findChildren();
-foreach( QWidget* widgetPtr, widgetList )
-{
-if (widgetPtr != NULL)
-{
-// If it's a web view control, set the zoom level based on the main view
-webviewPtr = dynamic_cast(widgetPtr);
-
-if (webviewPtr != NULL)
-{
-webviewPtr->setZoomFactor(m_mainWebView->zoomFactor() - 0.1);
-}
-}
-}
-}
-}
 
-// Save the zoom factor for next time
-QSettings settings;
-settings.setValue("Browser/Zoom", m_mainWebView->zoomFactor());
 }
 
-
 // Open an arbitrary URL
 void BrowserWindow::openUrl()
 {
diff --git a/runtime/BrowserWindow.h b/runtime/BrowserWindow.h
index 1465a48..9d2febd 100644
--- a/runtime/BrowserWindow.h
+++ b/runtime/BrowserWindow.h
@@ -70,8 +70,7 @@ private slots:
 void openUrl();
 voi

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #158

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Ashesh Vashi] Using client-side 'url_for' implementation in the module - 
bgprocess

[Ashesh Vashi] Using client-side 'url_for' implementation in the backup module.

[Ashesh Vashi] Using client-side 'url_for' implementation in the restore module.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #282

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Ashesh Vashi] Using client-side 'url_for' implementation in the module - 
bgprocess

[Ashesh Vashi] Using client-side 'url_for' implementation in the backup module.

[Ashesh Vashi] Using client-side 'url_for' implementation in the restore module.

--
[...truncated 274.00 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the bac

2017-06-12 Thread Ashesh Vashi 
Using client-side 'url_for' implementation in the backup module.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a46f7b1eb7246f34f05b1bf2a2429c2cff7ea9e

Modified Files
--
web/pgadmin/tools/backup/__init__.py| 15 +--
.../tools/backup/templates/backup/js/backup.js  | 21 +++--
2 files changed, 24 insertions(+), 12 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the res

2017-06-12 Thread Ashesh Vashi 
Using client-side 'url_for' implementation in the restore module.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f9a387822047f862b01fb62e879b071b1e3c3c00

Modified Files
--
web/pgadmin/tools/restore/__init__.py  |  8 +++-
.../tools/restore/templates/restore/js/restore.js  | 18 ++
2 files changed, 17 insertions(+), 9 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the mod

2017-06-12 Thread Ashesh Vashi 
Using client-side 'url_for' implementation in the module - bgprocess
(background-processes).

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a7c9d5ca1e0d92c113b093aa5cf2c2a34092b59

Modified Files
--
web/pgadmin/misc/bgprocess/__init__.py| 22 --
web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 37 ++-
2 files changed, 34 insertions(+), 25 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-12 Thread Surinder Kumar 
Hi

Changes:

1) When Query tool is opened, right now - panel title is displayed as
"Query - 1 ", instead it should display Query - [db_name] on [server_name] as
in pgAdmin3.

2) When Edit grid is opened for table, the panel title should display
Edit Data - [server_name] - [db_name] - [table_name]

These names are more meaningful instead of "Query - #'. helpful while
switching to panel tabs.

3) If panel is inactive and its title is quite long, show ellipsis(...),
otherwise display full title.

4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab.

Also tested with preference settings > Open query tool in new tab. It
works!!.

Please find attached patch

Thanks
Surinder


RM_2482.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-12 Thread Khushboo Vashi 
Hi,

On Mon, Jun 12, 2017 at 8:24 PM, Dave Page  wrote:

> Hi Khushboo,
>
> Looks like this patch broke the regressions tests :-(. Can you take a look
> ASAP please?
>
> please find the attached fix. However I didn't get any error while running
regression tests.

> Thanks!
>
> 2017-06-12 10:04:11,938: INFO werkzeug: 127.0.0.1 - - [12/Jun/2017
> 10:04:11] "GET /browser/table/sql/1/1/12669/2200/81920 HTTP/1.1" 500 -
> Traceback (most recent call last):
>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/
> python2.7/site-packages/flask/app.py", line 2000, in __call__
> return self.wsgi_app(environ, start_response)
>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/
> python2.7/site-packages/flask/app.py", line 1991, in wsgi_app
> response = self.make_response(self.handle_exception(e))
>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/
> python2.7/site-packages/flask/app.py", line 1567, in handle_exception
> reraise(exc_type, exc_value, tb)
>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/
> python2.7/site-packages/flask/app.py", line 1988, in wsgi_app
> response = self.full_dispatch_request()
>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/
> python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
> rv = self.handle_user_exception(e)
>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/
> python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
> reraise(exc_type, exc_value, tb)
>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/
> python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
> rv = self.dispatch_request()
>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/
> python2.7/site-packages/flask/app.py", line 1625, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/
> python2.7/site-packages/flask/views.py", line 84, in view
> return self.dispatch_request(*args, **kwargs)
>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/utils.py",
> line 235, in dispatch_request
> return method(*args, **kwargs)
>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/serve
> r_groups/servers/databases/schemas/tables/__init__.py", line 315, in wrap
> return f(*args, **kwargs)
>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/serve
> r_groups/servers/databases/schemas/tables/__init__.py", line 2555, in sql
> data = self._formatter(did, scid, tid, data)
>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/serve
> r_groups/servers/databases/schemas/tables/__init__.py", line 1081, in
> _formatter
> data = self._columns_formatter(tid, data)
>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/serve
> r_groups/servers/databases/schemas/tables/__init__.py", line 663, in
> _columns_formatter
> column['attlen'] = matchObj.group(1)
> AttributeError: 'NoneType' object has no attribute 'group'
>
>
> On Mon, Jun 12, 2017 at 12:49 PM, Dave Page  wrote:
>
>> Thanks, applied.
>>
>> On Fri, Jun 9, 2017 at 10:18 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached updated patch.
>>>
>>> Fixed the PostGIS Datatypes in SQL tab, Create / Update dialogues for
>>> Table, Column, Foreign Table and Type node.
>>>
>>> Regarding  the review comment given by Dave (Also, I there should be a
>>> space between the , and value in the_geom geometry(MultiPolygon,3310).),
>>> won't be fixed as this format is returned by format_type() function itself.
>>>
>>> As per the conversation with Dave, I have logged RM #2473
>>>  to add support for PostGIS
>>> Datatypes.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Tue, Jun 6, 2017 at 6:49 PM, Dave Page  wrote:
>>>


 On Tue, Jun 6, 2017 at 2:15 PM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On 6 Jun 2017 18:36, "Dave Page"  wrote:
>
>
>
> On Tue, Jun 6, 2017 at 1:23 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On 6 Jun 2017 17:42, "Dave Page"  wrote:
>>
>> Hi
>>
>> The table and column dialogues seem to have related problems. For
>> example, the table dialogue shows the length of the geometry field in the
>> test case as 847,380, whilst the column dialogue shows no length at all.
>>
>> What should be there in length and precision fields in this case?
>>
>
> I have no idea :-). What did pgAdmin 3 do here? I assume there's some
> way to decode the typmod into the desired values, and map them back to
> appropriate SQL.
>
> I will try to figure out the way.
> pgAdmin 3 has the same issue, so I have asked for the suggestion.
>

 Oh, OK - thanks. Maybe we need to r

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

2017-06-12 Thread Joao Pedro De Almeida Pereira 
Hello Hackers,
We sent the wrong patch. Attached is the correct one.

Sorry

Shruti & Joao

On Mon, Jun 12, 2017 at 3:08 PM, Joao Pedro De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Hackers,
>
> We were trying to run the feature tests against GreenPlum and one of the
> tests was failing (CheckForViewDataTest). In this test, we are creating a
> table using COLLATE, and the COLLATE command is only available starting
> in version 9.1 of Postgres, per the documentation. We decided to skip this
> test for now for all PG Versions below 9.1
>
> Thanks
> Shruti & Joao
>


skip-collate-test.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

2017-06-12 Thread Joao Pedro De Almeida Pereira 
Hi Hackers,

We were trying to run the feature tests against GreenPlum and one of the
tests was failing (CheckForViewDataTest). In this test, we are creating a
table using COLLATE, and the COLLATE command is only available starting in
version 9.1 of Postgres, per the documentation. We decided to skip this
test for now for all PG Versions below 9.1

Thanks
Shruti & Joao


skip-collate-test.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-12 Thread Shruti B Iyer 
Hi Dave,

We regenerated the patch to add new tasks to package.json to compile react
code for development and to not minimize it. This should fix the error you
captured in the screenshot.

The new task to lint and bundle everything for development is:
yarn run bundle:dev

The new task only bundle everything is:
yarn run webpacker:dev

We also changed the task test:feature to bundle without optimization before
we start the tests.

When we ran these commands in our machine, they did not display any error.
Is it possible that you forgot to run yarn install before running the
webpacker task? We are asking this because the errors look like missing
node packages.

Thanks
Shruti & Joao

On Mon, Jun 12, 2017 at 12:15 PM Dave Page  wrote:

> To add to that; running the JS tests gives:
>
> ERROR in ./regression/javascript/history/query_history_entry_spec.jsx
> Module not found: Error: Can't resolve 'jasmine-enzyme' in
> '/Users/dpage/git/pgadmin4/web/regression/javascript/history'
>  @ ./regression/javascript/history/query_history_entry_spec.jsx 13:21-46
>
> ERROR in ./pgadmin/static/jsx/history/query_history_entry.jsx
> Module not found: Error: Can't resolve 'immutability-helper' in
> '/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
>  @ ./pgadmin/static/jsx/history/query_history_entry.jsx 13:26-56
>  @ ./regression/javascript/history/query_history_entry_spec.jsx
>
> ERROR in ./pgadmin/static/jsx/history/query_history_entry.jsx
> Module not found: Error: Can't resolve 'moment' in
> '/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
>  @ ./pgadmin/static/jsx/history/query_history_entry.jsx 17:14-31
>  @ ./regression/javascript/history/query_history_entry_spec.jsx
>
> ERROR in ./regression/javascript/history/query_history_spec.jsx
> Module not found: Error: Can't resolve 'jasmine-enzyme' in
> '/Users/dpage/git/pgadmin4/web/regression/javascript/history'
>  @ ./regression/javascript/history/query_history_spec.jsx 19:21-46
> webpack: Failed to compile.
> PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
>   Error: Cannot find module "immutability-helper"
>   at regression/javascript/history/query_history_entry_spec.jsx:30705
>
>
> PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
>   Error: Cannot find module "immutability-helper"
>   at regression/javascript/history/query_history_spec.jsx:30705
>
>
> error Command failed with exit code 1.
> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
> this command.
> error Command failed with exit code 1.
> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
> this command.
>
>
> Also, while I think of it, why the addition of the delay to app_starter.py?
>
>
> On Mon, Jun 12, 2017 at 5:12 PM, Dave Page  wrote:
> > Hi,
> >
> > So 01 and 02 are now committed :-).
> >
> > 03 has a couple of problems though (likely the same):
> >
> > - Running the webpacker results in:
> >
> > (pgadmin4)piranha:web dpage$ yarn run webpacker
> > yarn run v0.24.4
> > $ yarn run webpack -- --optimize-minimize --config webpack.config.js
> > yarn run v0.24.4
> > $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/webpack"
> > --optimize-minimize --config webpack.config.js
> > (node:19446) DeprecationWarning: loaderUtils.parseQuery() received a
> > non-string value which can be problematic, see
> > https://github.com/webpack/loader-utils/issues/56
> > parseQuery() will be replaced with getOptions() in the next major
> > version of loader-utils.
> > Hash: a5e75aa70eb6b09bdb78
> > Version: webpack 2.3.3
> > Time: 3983ms
> >  Asset Size  Chunks Chunk Names
> > reactComponents.js   222 kB   0  [emitted]  reactComponents
> > history.js  1.58 kB   1  [emitted]  history
> >[0] /Users/dpage/git/pgadmin4/web/~/process/browser.js 5.42 kB {0}
> [built]
> >   [18] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/ReactReconciler.js
> > 6.21 kB {0} [built]
> >   [19] /Users/dpage/git/pgadmin4/web/~/react/lib/React.js 2.69 kB {0}
> [built]
> >   [31] /Users/dpage/git/pgadmin4/web/~/react/react.js 56 bytes {0}
> [built]
> >   [80] ./js/history/history_collection.js 1.91 kB {1} [built]
> >   [81] ./jsx/history/query_history.jsx 3.65 kB {0} [built]
> >   [82] /Users/dpage/git/pgadmin4/web/~/react-dom/index.js 59 bytes {0}
> [built]
> >   [83] ./js/history/index.js 690 bytes {1} [built]
> >   [84] ./jsx/components.jsx 599 bytes {0} [built]
> >   [85] ./jsx/history/query_history_entry.jsx 5.21 kB {0} [built]
> >  [113] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/ReactDOM.js 5.14
> > kB {0} [built]
> >  [175] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactDOMFactories.js
> > 5.53 kB {0} [built]
> >  [176] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactPropTypes.js
> > 15.8 kB {0} [built]
> >  [177] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactPureComponent.js
> > 1.32 kB {0} [built]
> >  [178] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactVersion.js 350
> > bytes {0} [built]
> > + 167 hidden modules
> >
> > ERROR in ./jsx/history/query_h

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #157

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Bring React into the tree, and add linting and bundling framework 
for

[Dave Page] Add linting support, and, well, lint.

[Dave Page] Add a missing translation call.

--
[...truncated 270.41 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #153

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Bring React into the tree, and add linting and bundling framework 
for

[Dave Page] Add linting support, and, well, lint.

[Dave Page] Add a missing translation call.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Shirley Wang 
>
>
>>
>> On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar
>>  wrote:
>> > Hi
>> >
>> > The current font-family applied to slick-grid is
>> 'Verdana,Arial,sans-serif'.
>> > I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif
>> but
>> > the font size and spacing between text is reduced. so to match style I
>> used
>> > "Verdana".
>> >
>> > Also, as per my knowledge, the Helvetica font will work only for
>> Operating
>> > Systems where this font actually exists in system, otherwise it will
>> pick
>> > Arial font.
>> >
>> > The right way to use 'Helvetica' is to download its 'ttf' and 'eot'
>> files
>> > and use in CSS so that it appears same on all machines:
>> >
>> https://stackoverflow.com/questions/13013616/css-helvetica-neue-not-working
>> >
>> > But it seems it is not available for free
>> > https://www.myfonts.com/fonts/linotype/neue-helvetica/licensing.html
>>
>> Oh, that's not good. I assume we were relying on it being on a users
>> machine already. I think we need to do one of two things:
>>
>> 1) Default to a font that we know should exist everywhere.
>> 2) Have a fallback from Helvetica Neue to Arial or similar.
>
> 3) Choose something completely new and free, and ship it with the app.
>>
>> I prefer 1 if possible, then 2, finally 3.
>>
>> Shirley, any thoughts?
>>
>
Option 1 would require us choosing something new and free (there are a lot
of webfonts you can get from Google) but would take some time to pick the
appropriate one.

Option 2 would be the best option for now. We should stick with Helvetica
and Arial until we have more time to choose the right font.

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #163

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Bring React into the tree, and add linting and bundling framework 
for

[Dave Page] Add linting support, and, well, lint.

[Dave Page] Add a missing translation call.

--
[...truncated 270.86 KB...]
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_get.TriggerFuncGetTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.functions.tests.test_trigger_func_put.TriggerFuncPutTestCase)
Fetch Trigger Function Node URL
--
Traceback (most recent call last):
  File 
"
 line 43, in runTest
server_con = server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.sequences.tests.test_sequence_add.SequenceAddTestCase)
Fetch sequence Node URL
--
Traceback (most recent call last):
  File 
"
 line 39, in runTest
self.server_id, self.db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_add.SchemaAddTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 36, in runTest
db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.tests.test_schema_delete.SchemaDeleteTestCase)
Check Schema Node URL
--
Traceback (most recent call last):
  File 
"
 line 46, in runTest
server_id, db_id)
  File 
"
 line 134, in connect_database
server_utils.connect_server(self, server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #159

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Bring React into the tree, and add linting and bundling framework 
for

[Dave Page] Add linting support, and, well, lint.

[Dave Page] Add a missing translation call.

--
[...truncated 270.41 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #160

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Bring React into the tree, and add linting and bundling framework 
for

[Dave Page] Add linting support, and, well, lint.

[Dave Page] Add a missing translation call.

--
[...truncated 270.38 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #281

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Bring React into the tree, and add linting and bundling framework 
for

[Dave Page] Add linting support, and, well, lint.

[Dave Page] Add a missing translation call.

--
[...truncated 274.00 KB...]
==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 47, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node
--
Traceback (most recent call last):
  File 
"
 line 48, in setUp
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 33, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"
 line 32, in connect_server
assert response.status_code == 200
AssertionError

==
FAIL: runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL
--
Traceback (most recent call last):
  File 
"
 line 35, in runTest
server_response = server_utils.connect_server(self, self.server_id)
  File 
"

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Translatable Text in Query Results Header

2017-06-12 Thread Dave Page 
Thanks, applied.

On Mon, Jun 12, 2017 at 4:43 PM, Shruti B Iyer  wrote:
> Hi Hackers!
>
> Attached is a minor patch that wraps with gettext() the "Select/Deselect
> All" text in the top left corner of the query results grid.
>
> Thanks,
> Matt and Shruti
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Bring React into the tree, and add linting and bundli

2017-06-12 Thread Dave Page 
Bring React into the tree, and add linting and bundling framework for the JS 
etc.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=659eb1c1e821e2ea414dc00d22022b8a2d7c91f7
Author: Shruti B Iyer 

Modified Files
--
.gitignore |1 +
Make-MinGW.bat |6 +
Make.bat   |6 +
pkg/mac/build.sh   |5 +
pkg/pip/build.sh   |9 +
pkg/src/build.sh   |   11 +
web/karma.conf.js  |   55 +-
web/package.json   |   45 +-
web/pgAdmin4.py|   28 +-
web/pgadmin/static/jsx/components.jsx  |8 +
web/pgadmin/utils/javascript/__init__.py   |8 +
web/pgadmin/utils/javascript/javascript_bundler.py |   62 +
web/pgadmin/utils/javascript/tests/__init__.py |8 +
.../javascript/tests/test_javascript_bundler.py|  117 +
web/regression/README  |9 +-
web/regression/javascript/browser/menu_spec.js |8 +-
web/regression/javascript/gettext_spec.js  |   65 +-
.../jasmine_capture_warnings_beforeall.js  |   23 +
.../javascript/selection/column_selector_spec.js   |  708 +--
.../javascript/selection/copy_data_spec.js |  227 +-
.../javascript/selection/grid_selector_spec.js |  209 +-
.../selection/range_boundary_navigator_spec.js |   22 +-
.../selection/range_selection_helper_spec.js   |  132 +-
.../javascript/selection/row_selector_spec.js  |  558 +--
.../selection/xcell_selection_model_spec.js|  778 ++--
.../javascript/slickgrid/cell_selector_spec.js |  110 +-
.../handle_query_output_keyboard_event_spec.js |  208 +-
web/regression/javascript/test-main.js |  139 -
web/regression/requirements.txt|1 +
web/webpack.config.js  |   29 +
web/webpack.test.config.js |   71 +
web/yarn.lock  | 4526 
32 files changed, 6516 insertions(+), 1676 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Add a missing translation call.

2017-06-12 Thread Dave Page 
Add a missing translation call.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f1acad85db4b9bf8a201cd8b6d90c703322a0073
Author: Shruti B Iyer 

Modified Files
--
web/pgadmin/static/js/selection/grid_selector.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Add linting support, and, well, lint.

2017-06-12 Thread Dave Page 
Add linting support, and, well, lint.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f4f8b9e77204a62ecdbf99caf296b6ac39b0f5e
Author: Shruti B Iyer 

Modified Files
--
web/.eslintrc.js   |  45 +
web/karma.conf.js  |   4 +-
web/package.json   |  10 +-
.../static/js/selection/active_cell_capture.js |  10 +-
web/pgadmin/static/js/selection/clipboard.js   |   4 +-
web/pgadmin/static/js/selection/column_selector.js |  28 +++---
web/pgadmin/static/js/selection/copy_data.js   |  22 +
web/pgadmin/static/js/selection/grid_selector.js   | 105 ++---
.../js/selection/range_boundary_navigator.js   |   8 +-
.../static/js/selection/range_selection_helper.js  |  24 ++---
web/pgadmin/static/js/selection/row_selector.js|  12 +--
web/pgadmin/static/js/selection/set_staged_rows.js |  10 +-
.../static/js/selection/xcell_selection_model.js   |  53 +--
web/regression/javascript/browser/menu_spec.js |   2 +-
.../javascript/check_node_visiblity_spec.js|  16 ++--
web/regression/javascript/fake_translations.js |   2 +-
.../selection/active_cell_capture_spec.js  |  23 ++---
.../javascript/selection/column_selector_spec.js   |  32 ---
.../javascript/selection/copy_data_spec.js |  65 +++--
.../javascript/selection/grid_selector_spec.js |  10 +-
.../selection/range_boundary_navigator_spec.js |  75 ---
.../selection/range_selection_helper_spec.js   |  36 +++
.../javascript/selection/row_selector_spec.js  |  19 ++--
.../javascript/selection/set_staged_rows_spec.js   |  28 +++---
.../selection/xcell_selection_model_spec.js|  23 ++---
web/regression/javascript/size_prettify_spec.js|  56 +--
.../javascript/slickgrid/cell_selector_spec.js |  29 +++---
.../handle_query_output_keyboard_event_spec.js |  44 +
web/regression/javascript/sqleditor_utils_spec.js  |  12 +--
web/webpack.test.config.js |   1 -
web/yarn.lock  |  16 +---
31 files changed, 424 insertions(+), 400 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-12 Thread Dave Page 
To add to that; running the JS tests gives:

ERROR in ./regression/javascript/history/query_history_entry_spec.jsx
Module not found: Error: Can't resolve 'jasmine-enzyme' in
'/Users/dpage/git/pgadmin4/web/regression/javascript/history'
 @ ./regression/javascript/history/query_history_entry_spec.jsx 13:21-46

ERROR in ./pgadmin/static/jsx/history/query_history_entry.jsx
Module not found: Error: Can't resolve 'immutability-helper' in
'/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
 @ ./pgadmin/static/jsx/history/query_history_entry.jsx 13:26-56
 @ ./regression/javascript/history/query_history_entry_spec.jsx

ERROR in ./pgadmin/static/jsx/history/query_history_entry.jsx
Module not found: Error: Can't resolve 'moment' in
'/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
 @ ./pgadmin/static/jsx/history/query_history_entry.jsx 17:14-31
 @ ./regression/javascript/history/query_history_entry_spec.jsx

ERROR in ./regression/javascript/history/query_history_spec.jsx
Module not found: Error: Can't resolve 'jasmine-enzyme' in
'/Users/dpage/git/pgadmin4/web/regression/javascript/history'
 @ ./regression/javascript/history/query_history_spec.jsx 19:21-46
webpack: Failed to compile.
PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
  Error: Cannot find module "immutability-helper"
  at regression/javascript/history/query_history_entry_spec.jsx:30705


PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
  Error: Cannot find module "immutability-helper"
  at regression/javascript/history/query_history_spec.jsx:30705


error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
this command.


Also, while I think of it, why the addition of the delay to app_starter.py?


On Mon, Jun 12, 2017 at 5:12 PM, Dave Page  wrote:
> Hi,
>
> So 01 and 02 are now committed :-).
>
> 03 has a couple of problems though (likely the same):
>
> - Running the webpacker results in:
>
> (pgadmin4)piranha:web dpage$ yarn run webpacker
> yarn run v0.24.4
> $ yarn run webpack -- --optimize-minimize --config webpack.config.js
> yarn run v0.24.4
> $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/webpack"
> --optimize-minimize --config webpack.config.js
> (node:19446) DeprecationWarning: loaderUtils.parseQuery() received a
> non-string value which can be problematic, see
> https://github.com/webpack/loader-utils/issues/56
> parseQuery() will be replaced with getOptions() in the next major
> version of loader-utils.
> Hash: a5e75aa70eb6b09bdb78
> Version: webpack 2.3.3
> Time: 3983ms
>  Asset Size  Chunks Chunk Names
> reactComponents.js   222 kB   0  [emitted]  reactComponents
> history.js  1.58 kB   1  [emitted]  history
>[0] /Users/dpage/git/pgadmin4/web/~/process/browser.js 5.42 kB {0} [built]
>   [18] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/ReactReconciler.js
> 6.21 kB {0} [built]
>   [19] /Users/dpage/git/pgadmin4/web/~/react/lib/React.js 2.69 kB {0} [built]
>   [31] /Users/dpage/git/pgadmin4/web/~/react/react.js 56 bytes {0} [built]
>   [80] ./js/history/history_collection.js 1.91 kB {1} [built]
>   [81] ./jsx/history/query_history.jsx 3.65 kB {0} [built]
>   [82] /Users/dpage/git/pgadmin4/web/~/react-dom/index.js 59 bytes {0} [built]
>   [83] ./js/history/index.js 690 bytes {1} [built]
>   [84] ./jsx/components.jsx 599 bytes {0} [built]
>   [85] ./jsx/history/query_history_entry.jsx 5.21 kB {0} [built]
>  [113] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/ReactDOM.js 5.14
> kB {0} [built]
>  [175] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactDOMFactories.js
> 5.53 kB {0} [built]
>  [176] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactPropTypes.js
> 15.8 kB {0} [built]
>  [177] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactPureComponent.js
> 1.32 kB {0} [built]
>  [178] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactVersion.js 350
> bytes {0} [built]
> + 167 hidden modules
>
> ERROR in ./jsx/history/query_history_entry.jsx
> Module not found: Error: Can't resolve 'immutability-helper' in
> '/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
>  @ ./jsx/history/query_history_entry.jsx 13:26-56
>  @ ./jsx/history/query_history.jsx
>  @ ./jsx/components.jsx
>
> ERROR in ./jsx/history/query_history_entry.jsx
> Module not found: Error: Can't resolve 'moment' in
> '/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
>  @ ./jsx/history/query_history_entry.jsx 17:14-31
>  @ ./jsx/history/query_history.jsx
>  @ ./jsx/components.jsx
> error Command failed with exit code 2.
> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
> this command.
> error Command failed with exit code 1.
> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
> this command
>
>
> - If I try to run pgAdmin, I get a script error in the UI, and console
> output as attached (sorry for the screenshot, I've

[pgadmin-hackers] PACKAGERS BEWARE: Build changes required

2017-06-12 Thread Dave Page 
I've just committed a couple of patches that change the requirements
for building pgAdmin for packages:

- You will need node.js and yarn to be installed for building

- During the build process, do something like this:

cd $PGADMIN_SRC/web
yarn install
yarn run bundle

This will create web/node_modules and pgadmin/static/js/generated
directories that will need to be included in packages.

This is part of a numer of in-progress changes:

1) To remove all vendor code from the pgAdmin source tree. Eventually
is should all be installed using Yarn into a vendor/ directory. Each
developer/packager will need to do this.

2) Web-packing of all the JS and CSS code. This will minimise all the
JS/CSS to reduce file transfer sizes, and bundle it together into as
few files as possible to minimise client/server round trips.

3) A move towards React to improve UI rendering/generation etc.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4] [PATCH] Translatable Text in Query Results Header

2017-06-12 Thread Shruti B Iyer 
Hi Hackers!

Attached is a minor patch that wraps with gettext() the "Select/Deselect
All" text in the top left corner of the query results grid.

Thanks,
Matt and Shruti


query_results_gettext.diff
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page 
Thanks, applied.

On Mon, Jun 12, 2017 at 3:52 PM, Surinder Kumar
 wrote:
> Hi Dave,
>
> Please find updated patch.
>
> On Mon, Jun 12, 2017 at 7:58 PM, Dave Page  wrote:
>>
>> Hi
>>
>> On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar
>>  wrote:
>> > Hi
>> >
>> > I confirm this is updated patch.
>>
>> Thanks. Something else seems to have changed that I can't spot. Only
>>  should be ignored if a child control has focus - Escape and
>> F1 should continue to work. I tried moving the:
>>
>> if (panel && panel['_type'] !== 'node_props') return;
>>
>> into the branch for keyCode.ENTER, but that doesn't seem to help.
>
> Fixed.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Teach dialogues about Escape to cancel, Enter to Save

2017-06-12 Thread Dave Page 
Teach dialogues about Escape to cancel, Enter to Save/OK, and F1 for help. 
Fixes #1535

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af43ccfc07bd1f919015b79ce9c9e7e06d92cf6a
Author: Surinder Kumar 

Modified Files
--
.../templates/tablespaces/js/tablespaces.js|   4 +-
.../servers/templates/servers/servers.js   |   2 +-
web/pgadmin/browser/templates/browser/js/node.js   | 150 +
.../templates/file_manager/js/file_manager.js  |   6 +-
.../templates/preferences/preferences.js   |   4 +-
.../tools/backup/templates/backup/js/backup.js |  12 +-
.../debugger/templates/debugger/js/debugger_ui.js  |   2 +-
.../templates/import_export/js/import_export.js|   2 +-
.../templates/maintenance/js/maintenance.js|   6 +-
.../tools/restore/templates/restore/js/restore.js  |   6 +-
.../user_management/js/user_management.js  |   2 +-
11 files changed, 118 insertions(+), 78 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-12 Thread Dave Page 
Hi Khushboo,

Looks like this patch broke the regressions tests :-(. Can you take a look
ASAP please?

Thanks!

2017-06-12 10:04:11,938: INFO werkzeug: 127.0.0.1 - - [12/Jun/2017
10:04:11] "GET /browser/table/sql/1/1/12669/2200/81920 HTTP/1.1" 500 -
Traceback (most recent call last):
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 2000, in __call__
return self.wsgi_app(environ, start_response)
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1991, in wsgi_app
response = self.make_response(self.handle_exception(e))
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1567, in handle_exception
reraise(exc_type, exc_value, tb)
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1641, in
full_dispatch_request
rv = self.handle_user_exception(e)
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1544, in
handle_user_exception
reraise(exc_type, exc_value, tb)
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1639, in
full_dispatch_request
rv = self.dispatch_request()
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/views.py", line 84, in view
return self.dispatch_request(*args, **kwargs)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/utils.py",
line 235, in dispatch_request
return method(*args, **kwargs)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/
server_groups/servers/databases/schemas/tables/__init__.py", line 315, in
wrap
return f(*args, **kwargs)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/
server_groups/servers/databases/schemas/tables/__init__.py", line 2555, in
sql
data = self._formatter(did, scid, tid, data)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/
server_groups/servers/databases/schemas/tables/__init__.py", line 1081, in
_formatter
data = self._columns_formatter(tid, data)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/
server_groups/servers/databases/schemas/tables/__init__.py", line 663, in
_columns_formatter
column['attlen'] = matchObj.group(1)
AttributeError: 'NoneType' object has no attribute 'group'


On Mon, Jun 12, 2017 at 12:49 PM, Dave Page  wrote:

> Thanks, applied.
>
> On Fri, Jun 9, 2017 at 10:18 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached updated patch.
>>
>> Fixed the PostGIS Datatypes in SQL tab, Create / Update dialogues for
>> Table, Column, Foreign Table and Type node.
>>
>> Regarding  the review comment given by Dave (Also, I there should be a
>> space between the , and value in the_geom geometry(MultiPolygon,3310).),
>> won't be fixed as this format is returned by format_type() function itself.
>>
>> As per the conversation with Dave, I have logged RM #2473
>>  to add support for PostGIS
>> Datatypes.
>>
>> Thanks,
>> Khushboo
>>
>> On Tue, Jun 6, 2017 at 6:49 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Tue, Jun 6, 2017 at 2:15 PM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On 6 Jun 2017 18:36, "Dave Page"  wrote:



 On Tue, Jun 6, 2017 at 1:23 PM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On 6 Jun 2017 17:42, "Dave Page"  wrote:
>
> Hi
>
> The table and column dialogues seem to have related problems. For
> example, the table dialogue shows the length of the geometry field in the
> test case as 847,380, whilst the column dialogue shows no length at all.
>
> What should be there in length and precision fields in this case?
>

 I have no idea :-). What did pgAdmin 3 do here? I assume there's some
 way to decode the typmod into the desired values, and map them back to
 appropriate SQL.

 I will try to figure out the way.
 pgAdmin 3 has the same issue, so I have asked for the suggestion.

>>>
>>> Oh, OK - thanks. Maybe we need to reuse the length and precision fields
>>> for these types. That is, I believe, essentially how PostGIS passes extra
>>> info to the column definitions.
>>>
>>>


> Also, I there should be a space between the , and value in the_geom
> geometry(MultiPolygon,3310).
>
> Thanks.
>
> On Mon, Jun 5, 2

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Surinder Kumar 
Hi Dave,

Please find updated patch.

On Mon, Jun 12, 2017 at 7:58 PM, Dave Page  wrote:

> Hi
>
> On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar
>  wrote:
> > Hi
> >
> > I confirm this is updated patch.
>
> Thanks. Something else seems to have changed that I can't spot. Only
>  should be ignored if a child control has focus - Escape and
> F1 should continue to work. I tried moving the:
>
> if (panel && panel['_type'] !== 'node_props') return;
>
> into the branch for keyCode.ENTER, but that doesn't seem to help.
>
​Fixed.​

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


Feature_1535_rebased_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-12 Thread Dave Page 
Hi Shruti

On Mon, Jun 12, 2017 at 3:24 PM, Shruti B Iyer  wrote:
>
> Hello Dave,
>
> Thanks for making those fixes and sharing them with us. We tried applying
> the patch and it looks like there are some missing file changes from your
> patch that were present in ours, like the Make.bat file changes. But we will
> add them when we send you the new patches.

Hmm, I wonder if I missed them because I applied the patch in a sub directory.

> While trying to generate the new patches we realized some tests are failing
> in master branch due to an internal server error:
>
> 2017-06-12 10:04:11,938: INFO werkzeug: 127.0.0.1 - - [12/Jun/2017 10:04:11]
> "GET /browser/table/sql/1/1/12669/2200/81920 HTTP/1.1" 500 -
> Traceback (most recent call last):
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 2000, in __call__
> return self.wsgi_app(environ, start_response)
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1991, in wsgi_app
> response = self.make_response(self.handle_exception(e))
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1567, in handle_exception
> reraise(exc_type, exc_value, tb)
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1988, in wsgi_app
> response = self.full_dispatch_request()
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1641, in full_dispatch_request
> rv = self.handle_user_exception(e)
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1544, in handle_user_exception
> reraise(exc_type, exc_value, tb)
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1639, in full_dispatch_request
> rv = self.dispatch_request()
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1625, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/views.py",
> line 84, in view
> return self.dispatch_request(*args, **kwargs)
>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/utils.py",
> line 235, in dispatch_request
> return method(*args, **kwargs)
>   File
> "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
> line 315, in wrap
> return f(*args, **kwargs)
>   File
> "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
> line 2555, in sql
> data = self._formatter(did, scid, tid, data)
>   File
> "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
> line 1081, in _formatter
> data = self._columns_formatter(tid, data)
>   File
> "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
> line 663, in _columns_formatter
> column['attlen'] = matchObj.group(1)
> AttributeError: 'NoneType' object has no attribute 'group'
>
> Was this introduced in a previous patch?

Yes, it looks like it. For some reason it's not failing on the Jenkins
server though. I'll ask Khushboo to fix it.

> We will recreate the patches and send them ASAP.

Thanks!

> Thanks
> Shruti & Joao
>
> On Mon, Jun 12, 2017 at 6:59 AM Dave Page  wrote:
>>
>> Hi
>>
>> OK, so Ashesh and I spend much of the morning on this.
>>
>> Patch 01 - Applied.
>> Patch 02:
>>
>> - karma.conf.js wouldn't patch; I've manually handled that.
>> - test-main.js wouldn't patch. The diff looked like it was trying to
>> empty it; I have removed it instead.
>> - The imports in pgAdmin4.py need to be made after the app root is
>> added to the path.
>> - The JS bundler should be in pgadmin/utils, not pgadmin/tools (which
>> is intended for plugin modules)
>> - The tests were failing following some changes Ashesh pushed earlier
>> to add a client-side url_for function.
>> - pgAdmin4.py was attempting to run the bundler on every startup. I've
>> wrapped those called in "if config.DEBUG:" conditionals, as typically
>> an installation for an end-user will be in a read-only directory.
>>
>> We've fixed all of that in the attached patch. I'm not sure why it's
>> so much bigger than yours.
>>
>> The following issues are outstanding; please take a look at them:
>>
>> - There is no update to the Windows installer generation code (needed
>> in 2 places unfortunately; Make.bat and Make-MinGW.bat).
>>
>> - The updates to the other packages call "yarn run webpacker" which is
>> an undefined target.
>>
>> I haven't looked at patch 03 yet, but Ashesh did tell me i

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Robert Eckhardt 
Shirley and I are in SF this week so we will be even more async that usual.

-- Rob

On Mon, Jun 12, 2017 at 7:33 AM, Dave Page  wrote:

> Adding Shirley...
>
> Hi
>
> On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar
>  wrote:
> > Hi
> >
> > The current font-family applied to slick-grid is
> 'Verdana,Arial,sans-serif'.
> > I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif but
> > the font size and spacing between text is reduced. so to match style I
> used
> > "Verdana".
> >
> > Also, as per my knowledge, the Helvetica font will work only for
> Operating
> > Systems where this font actually exists in system, otherwise it will pick
> > Arial font.
> >
> > The right way to use 'Helvetica' is to download its 'ttf' and 'eot' files
> > and use in CSS so that it appears same on all machines:
> > https://stackoverflow.com/questions/13013616/css-
> helvetica-neue-not-working
> >
> > But it seems it is not available for free
> > https://www.myfonts.com/fonts/linotype/neue-helvetica/licensing.html
>
> Oh, that's not good. I assume we were relying on it being on a users
> machine already. I think we need to do one of two things:
>
> 1) Default to a font that we know should exist everywhere.
> 2) Have a fallback from Helvetica Neue to Arial or similar.
> 3) Choose something completely new and free, and ship it with the app.
>
> I prefer 1 if possible, then 2, finally 3.
>
> Shirley, any thoughts?
>
>
> > On Mon, Jun 12, 2017 at 6:16 PM, Dave Page  wrote:
> >>
> >> Hi
> >>
> >> Can you update this so that the CSS all follows the standards in the
> >> WIP styleguide please? I see that the current patch is using the wrong
> >> font for example.
> >>
> >> http://pgadmin4-styleguide.cfapps.io/
> >>
> >> Thanks!
> >>
> >> On Mon, Jun 12, 2017 at 11:57 AM, Surinder Kumar
> >>  wrote:
> >> > Hi
> >> >
> >> > Changes:
> >> >
> >> > 1) Calculate text editor position properly when the size of the grid
> >> > exceeds
> >> > the size of the window.
> >> >
> >> > 2) Assign NumberEditor to cell types('oid', 'xid', 'real').
> >> >
> >> > 3) Remove inline styles from rendered editors and move its styles to
> CSS
> >> > file.
> >> >
> >> > Please find attached patch and review.
> >> >
> >> > Thanks
> >> > Surinder
> >> >
> >> >
> >> > --
> >> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org
> )
> >> > To make changes to your subscription:
> >> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >> >
> >>
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Dave Page 
Adding Shirley...

Hi

On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar
 wrote:
> Hi
>
> The current font-family applied to slick-grid is 'Verdana,Arial,sans-serif'.
> I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif but
> the font size and spacing between text is reduced. so to match style I used
> "Verdana".
>
> Also, as per my knowledge, the Helvetica font will work only for Operating
> Systems where this font actually exists in system, otherwise it will pick
> Arial font.
>
> The right way to use 'Helvetica' is to download its 'ttf' and 'eot' files
> and use in CSS so that it appears same on all machines:
> https://stackoverflow.com/questions/13013616/css-helvetica-neue-not-working
>
> But it seems it is not available for free
> https://www.myfonts.com/fonts/linotype/neue-helvetica/licensing.html

Oh, that's not good. I assume we were relying on it being on a users
machine already. I think we need to do one of two things:

1) Default to a font that we know should exist everywhere.
2) Have a fallback from Helvetica Neue to Arial or similar.
3) Choose something completely new and free, and ship it with the app.

I prefer 1 if possible, then 2, finally 3.

Shirley, any thoughts?


> On Mon, Jun 12, 2017 at 6:16 PM, Dave Page  wrote:
>>
>> Hi
>>
>> Can you update this so that the CSS all follows the standards in the
>> WIP styleguide please? I see that the current patch is using the wrong
>> font for example.
>>
>> http://pgadmin4-styleguide.cfapps.io/
>>
>> Thanks!
>>
>> On Mon, Jun 12, 2017 at 11:57 AM, Surinder Kumar
>>  wrote:
>> > Hi
>> >
>> > Changes:
>> >
>> > 1) Calculate text editor position properly when the size of the grid
>> > exceeds
>> > the size of the window.
>> >
>> > 2) Assign NumberEditor to cell types('oid', 'xid', 'real').
>> >
>> > 3) Remove inline styles from rendered editors and move its styles to CSS
>> > file.
>> >
>> > Please find attached patch and review.
>> >
>> > Thanks
>> > Surinder
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page 
Hi

On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar
 wrote:
> Hi
>
> I confirm this is updated patch.

Thanks. Something else seems to have changed that I can't spot. Only
 should be ignored if a child control has focus - Escape and
F1 should continue to work. I tried moving the:

if (panel && panel['_type'] !== 'node_props') return;

into the branch for keyCode.ENTER, but that doesn't seem to help.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-12 Thread Shruti B Iyer 
Hello Dave,

Thanks for making those fixes and sharing them with us. We tried applying
the patch and it looks like there are some missing file changes from your
patch that were present in ours, like the Make.bat file changes. But we
will add them when we send you the new patches.

While trying to generate the new patches we realized some tests are failing
in master branch due to an internal server error:

2017-06-12 10:04:11,938: INFO werkzeug: 127.0.0.1 - - [12/Jun/2017
10:04:11] "GET /browser/table/sql/1/1/12669/2200/81920 HTTP/1.1" 500 -
Traceback (most recent call last):
  File
"/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
line 2000, in __call__
return self.wsgi_app(environ, start_response)
  File
"/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
line 1991, in wsgi_app
response = self.make_response(self.handle_exception(e))
  File
"/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
line 1567, in handle_exception
reraise(exc_type, exc_value, tb)
  File
"/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
line 1988, in wsgi_app
response = self.full_dispatch_request()
  File
"/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
  File
"/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
  File
"/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
line 1639, in full_dispatch_request
rv = self.dispatch_request()
  File
"/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
line 1625, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
  File
"/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/views.py",
line 84, in view
return self.dispatch_request(*args, **kwargs)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/utils.py",
line 235, in dispatch_request
return method(*args, **kwargs)
  File
"/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
line 315, in wrap
return f(*args, **kwargs)
  File
"/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
line 2555, in sql
data = self._formatter(did, scid, tid, data)
  File
"/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
line 1081, in _formatter
data = self._columns_formatter(tid, data)
  File
"/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
line 663, in _columns_formatter
column['attlen'] = matchObj.group(1)
AttributeError: 'NoneType' object has no attribute 'group'

Was this introduced in a previous patch?

We will recreate the patches and send them ASAP.

Thanks
Shruti & Joao

On Mon, Jun 12, 2017 at 6:59 AM Dave Page  wrote:

> Hi
>
> OK, so Ashesh and I spend much of the morning on this.
>
> Patch 01 - Applied.
> Patch 02:
>
> - karma.conf.js wouldn't patch; I've manually handled that.
> - test-main.js wouldn't patch. The diff looked like it was trying to
> empty it; I have removed it instead.
> - The imports in pgAdmin4.py need to be made after the app root is
> added to the path.
> - The JS bundler should be in pgadmin/utils, not pgadmin/tools (which
> is intended for plugin modules)
> - The tests were failing following some changes Ashesh pushed earlier
> to add a client-side url_for function.
> - pgAdmin4.py was attempting to run the bundler on every startup. I've
> wrapped those called in "if config.DEBUG:" conditionals, as typically
> an installation for an end-user will be in a read-only directory.
>
> We've fixed all of that in the attached patch. I'm not sure why it's
> so much bigger than yours.
>
> The following issues are outstanding; please take a look at them:
>
> - There is no update to the Windows installer generation code (needed
> in 2 places unfortunately; Make.bat and Make-MinGW.bat).
>
> - The updates to the other packages call "yarn run webpacker" which is
> an undefined target.
>
> I haven't looked at patch 03 yet, but Ashesh did tell me it won't
> apply for him. Patch 4 is also untested at this stage.
>
> If the issues above can be fixed, we can get patch 2 applied then move
> on from there.
>
> I'll hold off on Harshal's patch for the Query Tool's load on demand
> to give you a chance to get this done.
>
> Thanks.
>
> On Sat, Jun 10, 2017 at 2:52 AM, George Gelashvili
>  wrote:
> > Hi Dave,
> >
> > Our patch touches code also changed by the patches that were recently
> > committed.

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Role Membership control

2017-06-12 Thread Dave Page 
Thanks applied.

On Mon, Jun 12, 2017 at 1:46 PM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA minor patch to fix the issue in Role Membership control, In edit mode
> user was unable to toggle grant admin privileges to membership roles.
> RM#2086
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Surinder Kumar 
Hi

The current font-family applied to slick-grid is 'Verdana,Arial,sans-serif'.
I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif but
the font size and spacing between text is reduced. so to match style I used
"Verdana".

Also, as per my knowledge, the Helvetica font will work only for Operating
Systems where this font actually exists in system, otherwise it will pick
Arial font.

The right way to use 'Helvetica' is to download its 'ttf' and 'eot' files
and use in CSS so that it appears same on all machines:
https://stackoverflow.com/questions/13013616/css-helvetica-neue-not-working

But it seems it is not available for free
https://www.myfonts.com/fonts/linotype/neue-helvetica/licensing.html

On Mon, Jun 12, 2017 at 6:16 PM, Dave Page  wrote:

> Hi
>
> Can you update this so that the CSS all follows the standards in the
> WIP styleguide please? I see that the current patch is using the wrong
> font for example.
>
> http://pgadmin4-styleguide.cfapps.io/
>
> Thanks!
>
> On Mon, Jun 12, 2017 at 11:57 AM, Surinder Kumar
>  wrote:
> > Hi
> >
> > Changes:
> >
> > 1) Calculate text editor position properly when the size of the grid
> exceeds
> > the size of the window.
> >
> > 2) Assign NumberEditor to cell types('oid', 'xid', 'real').
> >
> > 3) Remove inline styles from rendered editors and move its styles to CSS
> > file.
> >
> > Please find attached patch and review.
> >
> > Thanks
> > Surinder
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python35 #155

2017-06-12 Thread pgAdmin 4 Jenkins 
See 




-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python34 #150

2017-06-12 Thread pgAdmin 4 Jenkins 
See 




-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Surinder Kumar 
Hi

I confirm this is updated patch.

PFA patch.
On Mon, Jun 12, 2017 at 6:20 PM, Dave Page  wrote:

> Hi
>
> Is that the correct patch? Hitting  in a comment text area is
> still causing the dialogue to close.​


> Thanks.
>
> On Mon, Jun 12, 2017 at 12:55 PM, Surinder Kumar
>  wrote:
> > Hi
> >
> > Please find rebased patch
> >
> > Thanks
> >
> > On Mon, Jun 12, 2017 at 5:20 PM, Dave Page  wrote:
> >>
> >> Could you rebase this please?
> >>
> >> Thanks.
> >>
> >> On Fri, Jun 9, 2017 at 10:40 AM, Surinder Kumar
> >>  wrote:
> >> > Ignore previous patch as it doesn't contains new changes.
> >> > Please find attached patch.
> >> >
> >> >
> >> > On Fri, Jun 9, 2017 at 3:06 PM, Surinder Kumar
> >> >  wrote:
> >> >>
> >> >> Hi
> >> >>
> >> >> PFA patch and review.
> >> >>
> >> >>
> >> >> On Fri, Jun 9, 2017 at 1:47 PM, Dave Page  wrote:
> >> >>>
> >> >>> Hi
> >> >>>
> >> >>> Ahh, now we have a bug. In the properties dialogues, if you edit a
> >> >>> comment, as soon as the Save button gets enabled, hitting Return
> will
> >> >>> Save the changes instead of adding a newline to the comment. That's
> >> >>> clearly not right :-(
> >> >>
> >> >> Now if event.target is its child elements(for example input, textarea
> >> >> etc), the function "handleKeyDown(event)" won't call.
> >> >>>
> >> >>>
> >> >>> On Fri, Jun 9, 2017 at 7:48 AM, Surinder Kumar
> >> >>>  wrote:
> >> >>> > Hi
> >> >>> >
> >> >>> > Please find updated patch.
> >> >>> >
> >> >>> > Thanks,
> >> >>> > Surinder
> >> >>> >
> >> >>> > On Thu, Jun 8, 2017 at 7:16 PM, Dave Page 
> wrote:
> >> >>> >>
> >> >>> >> Hi
> >> >>> >>
> >> >>> >> On Thu, Jun 8, 2017 at 5:38 AM, Surinder Kumar
> >> >>> >>  wrote:
> >> >>> >> > Hi
> >> >>> >> >
> >> >>> >> > The attribute key for Ok, Save buttons should be mapped to
> >> >>> >> > 13(Enter),
> >> >>> >> > for Help - 112(F1) and
> >> >>> >> > for Cancel - 27(Esc)
> >> >>> >> > The above changes are made into all dialog related template
> >> >>> >> > files.
> >> >>> >> >
> >> >>> >> > PFA patch and review.
> >> >>> >>
> >> >>> >> Looks good. Just a couple of thoughts:
> >> >>> >>
> >> >>> >> - You've missed the object property dialogues. This really needs
> to
> >> >>> >> be
> >> >>> >> consistent across all dialogues :-)
> >> >>> >>
> >> >>> >> - The behaviour with Enter is a bit odd, because priority will be
> >> >>> >> given the the focussed control to handle it. That's what we want
> if
> >> >>> >> it's a text area for example, but on the other hand, if you open
> >> >>> >> the
> >> >>> >> Preference dialogue, then the Help button gets focus first, so
> >> >>> >> Enter
> >> >>> >> there will end up opening the docs. I suspect in most cases the
> >> >>> >> behaviour you've got is fine, so I'm not inclined to change it.
> >> >>> >>  >> >>> >> a little> Hmm, I see similar behaviour in some other apps. Let's
> >> >>> >> leave
> >> >>> >> it as you've done it :-)
> >> >>> >>
> >> >>> >> Please add support for the properties dialogues, then I think
> we're
> >> >>> >> good
> >> >>> >> to go.
> >> >>> >
> >> >>> > Done.
> >> >>> >>
> >> >>> >>
> >> >>> >> Thanks!
> >> >>> >>
> >> >>> >> --
> >> >>> >> Dave Page
> >> >>> >> Blog: http://pgsnake.blogspot.com
> >> >>> >> Twitter: @pgsnake
> >> >>> >>
> >> >>> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> >>> >> The Enterprise PostgreSQL Company
> >> >>> >
> >> >>> >
> >> >>>
> >> >>>
> >> >>>
> >> >>> --
> >> >>> Dave Page
> >> >>> Blog: http://pgsnake.blogspot.com
> >> >>> Twitter: @pgsnake
> >> >>>
> >> >>> EnterpriseDB UK: http://www.enterprisedb.com
> >> >>> The Enterprise PostgreSQL Company
> >> >>
> >> >>
> >> >
> >>
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


Feature_1535_rebased.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Allow editing of the WITH ADMIN option of role member

2017-06-12 Thread Dave Page 
Allow editing of the WITH ADMIN option of role membership. Fixes #2086

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ec5bc23dfdb41da1b5ccd4ab2ab2e6244d8b5ebd
Author: Murtuza Zabuawala 

Modified Files
--
.../browser/server_groups/servers/roles/templates/role/js/role.js| 1 +
1 file changed, 1 insertion(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python36 #156

2017-06-12 Thread pgAdmin 4 Jenkins 
See 




-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page 
Hi

Is that the correct patch? Hitting  in a comment text area is
still causing the dialogue to close.

Thanks.

On Mon, Jun 12, 2017 at 12:55 PM, Surinder Kumar
 wrote:
> Hi
>
> Please find rebased patch
>
> Thanks
>
> On Mon, Jun 12, 2017 at 5:20 PM, Dave Page  wrote:
>>
>> Could you rebase this please?
>>
>> Thanks.
>>
>> On Fri, Jun 9, 2017 at 10:40 AM, Surinder Kumar
>>  wrote:
>> > Ignore previous patch as it doesn't contains new changes.
>> > Please find attached patch.
>> >
>> >
>> > On Fri, Jun 9, 2017 at 3:06 PM, Surinder Kumar
>> >  wrote:
>> >>
>> >> Hi
>> >>
>> >> PFA patch and review.
>> >>
>> >>
>> >> On Fri, Jun 9, 2017 at 1:47 PM, Dave Page  wrote:
>> >>>
>> >>> Hi
>> >>>
>> >>> Ahh, now we have a bug. In the properties dialogues, if you edit a
>> >>> comment, as soon as the Save button gets enabled, hitting Return will
>> >>> Save the changes instead of adding a newline to the comment. That's
>> >>> clearly not right :-(
>> >>
>> >> Now if event.target is its child elements(for example input, textarea
>> >> etc), the function "handleKeyDown(event)" won't call.
>> >>>
>> >>>
>> >>> On Fri, Jun 9, 2017 at 7:48 AM, Surinder Kumar
>> >>>  wrote:
>> >>> > Hi
>> >>> >
>> >>> > Please find updated patch.
>> >>> >
>> >>> > Thanks,
>> >>> > Surinder
>> >>> >
>> >>> > On Thu, Jun 8, 2017 at 7:16 PM, Dave Page  wrote:
>> >>> >>
>> >>> >> Hi
>> >>> >>
>> >>> >> On Thu, Jun 8, 2017 at 5:38 AM, Surinder Kumar
>> >>> >>  wrote:
>> >>> >> > Hi
>> >>> >> >
>> >>> >> > The attribute key for Ok, Save buttons should be mapped to
>> >>> >> > 13(Enter),
>> >>> >> > for Help - 112(F1) and
>> >>> >> > for Cancel - 27(Esc)
>> >>> >> > The above changes are made into all dialog related template
>> >>> >> > files.
>> >>> >> >
>> >>> >> > PFA patch and review.
>> >>> >>
>> >>> >> Looks good. Just a couple of thoughts:
>> >>> >>
>> >>> >> - You've missed the object property dialogues. This really needs to
>> >>> >> be
>> >>> >> consistent across all dialogues :-)
>> >>> >>
>> >>> >> - The behaviour with Enter is a bit odd, because priority will be
>> >>> >> given the the focussed control to handle it. That's what we want if
>> >>> >> it's a text area for example, but on the other hand, if you open
>> >>> >> the
>> >>> >> Preference dialogue, then the Help button gets focus first, so
>> >>> >> Enter
>> >>> >> there will end up opening the docs. I suspect in most cases the
>> >>> >> behaviour you've got is fine, so I'm not inclined to change it.
>> >>> >> > >>> >> a little> Hmm, I see similar behaviour in some other apps. Let's
>> >>> >> leave
>> >>> >> it as you've done it :-)
>> >>> >>
>> >>> >> Please add support for the properties dialogues, then I think we're
>> >>> >> good
>> >>> >> to go.
>> >>> >
>> >>> > Done.
>> >>> >>
>> >>> >>
>> >>> >> Thanks!
>> >>> >>
>> >>> >> --
>> >>> >> Dave Page
>> >>> >> Blog: http://pgsnake.blogspot.com
>> >>> >> Twitter: @pgsnake
>> >>> >>
>> >>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >>> >> The Enterprise PostgreSQL Company
>> >>> >
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Dave Page
>> >>> Blog: http://pgsnake.blogspot.com
>> >>> Twitter: @pgsnake
>> >>>
>> >>> EnterpriseDB UK: http://www.enterprisedb.com
>> >>> The Enterprise PostgreSQL Company
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Role Membership control

2017-06-12 Thread Murtuza Zabuawala 
Hi,

PFA minor patch to fix the issue in Role Membership control, In edit mode
user was unable to toggle grant admin privileges to membership roles.
RM#2086

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git 
a/web/pgadmin/browser/server_groups/servers/roles/templates/role/js/role.js 
b/web/pgadmin/browser/server_groups/servers/roles/templates/role/js/role.js
index a9b54b8..8d8cca7 100644
--- a/web/pgadmin/browser/server_groups/servers/roles/templates/role/js/role.js
+++ b/web/pgadmin/browser/server_groups/servers/roles/templates/role/js/role.js
@@ -483,6 +483,7 @@ define('pgadmin.node.role', [
   mode: ['properties', 'edit', 'create'],
   control: RoleMembersControl, model: pgBrowser.Node.Model.extend({
 keys: ['role'],
+idAttribute: 'role',
 defaults: {
   role: undefined,
   admin: false

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Dave Page 
Hi

Can you update this so that the CSS all follows the standards in the
WIP styleguide please? I see that the current patch is using the wrong
font for example.

http://pgadmin4-styleguide.cfapps.io/

Thanks!

On Mon, Jun 12, 2017 at 11:57 AM, Surinder Kumar
 wrote:
> Hi
>
> Changes:
>
> 1) Calculate text editor position properly when the size of the grid exceeds
> the size of the window.
>
> 2) Assign NumberEditor to cell types('oid', 'xid', 'real').
>
> 3) Remove inline styles from rendered editors and move its styles to CSS
> file.
>
> Please find attached patch and review.
>
> Thanks
> Surinder
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #154

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Fix error on the stats tab with PG10. Also, rename the 10.0_plus

[Dave Page] Properly handle trigger functions with parameters. Fixes #2043

[Dave Page] Refresh the SQL editor view on resize to ensure the contents are

--
[...truncated 260.64 KB...]
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.types.tests.test_types_get.TypesGetTestCase)
Get type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.types.tests.test_types_put.TypesUpdateTestCase)
Update type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_add.ViewsAddTestCase)
Add view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_add.ViewsAddTestCase)
Add materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_delete.ViewsDeleteTestCase)
Delete view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_delete.ViewsDeleteTestCase)
Delete materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase)
Check Databases Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_add.ResourceGroupsAddTestCase)
Add resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_delete.ResourceGroupsDeleteTestCase)
Delete resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_put.ResourceGroupsPutTestCase)
Put resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.tests_resource_groups_get.ResourceGroupsGetTestCase)
Get resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_add.LoginRoleAddTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_delete.LoginRoleDeleteTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_get.LoginRoleGetTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_put.LoginRolePutTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_add.TableSpaceAddTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_delete.TableSpaceDeleteTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.TablespaceGetTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_check_recovery.TestCheckRecovery)
Test for check recovery ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_dependencies_sql.TestDependenciesSql)
Test dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_dependents_sql.TestDependentsSql)
Test dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_role_dependencies_sql.TestRoleDependenciesSql)
Test Role Dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_add.ServersAddTestCase)
Default Server Node url ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_delete.ServerDeleteTestCase)
Default Server Node url ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_get.ServersGetTestCase)
Default Server Node url ... ok
ru

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #149

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for

[Dave Page] Fix error on the stats tab with PG10. Also, rename the 10.0_plus

[Dave Page] Properly handle trigger functions with parameters. Fixes #2043

--
[...truncated 260.62 KB...]
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.types.tests.test_types_get.TypesGetTestCase)
Get type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.types.tests.test_types_put.TypesUpdateTestCase)
Update type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_add.ViewsAddTestCase)
Add view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_add.ViewsAddTestCase)
Add materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_delete.ViewsDeleteTestCase)
Delete view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_delete.ViewsDeleteTestCase)
Delete materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase)
Check Databases Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_add.ResourceGroupsAddTestCase)
Add resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_delete.ResourceGroupsDeleteTestCase)
Delete resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_put.ResourceGroupsPutTestCase)
Put resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.tests_resource_groups_get.ResourceGroupsGetTestCase)
Get resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_add.LoginRoleAddTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_delete.LoginRoleDeleteTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_get.LoginRoleGetTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_put.LoginRolePutTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_add.TableSpaceAddTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_delete.TableSpaceDeleteTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.TablespaceGetTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_check_recovery.TestCheckRecovery)
Test for check recovery ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_dependencies_sql.TestDependenciesSql)
Test dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_dependents_sql.TestDependentsSql)
Test dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_role_dependencies_sql.TestRoleDependenciesSql)
Test Role Dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_add.ServersAddTestCase)
Default Server Node url ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_delete.ServerDeleteTestCase)
Default Server Node url ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_get.ServersGetTestCase)
Default Server Node url ... ok

[pgadmin-hackers] pgAdmin 4 commit: Refresh the SQL editor view on resize to ensure the c

2017-06-12 Thread Dave Page 
Refresh the SQL editor view on resize to ensure the contents are re-rendered 
for the new viewport. Fixes #2078

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3743c6e86ed74b8ae6f4776f27e1555c4ee64e89
Author: Murtuza Zabuawala 

Modified Files
--
.../tools/sqleditor/templates/sqleditor/js/sqleditor.js| 10 ++
1 file changed, 10 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][PATCH] CREATE Script do not display properly on panel resize

2017-06-12 Thread Dave Page 
Thanks, patch applied!

On Mon, Jun 12, 2017 at 11:48 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to fix the issue where SQL Panel in query tool displays truncated
> sql on resize.
> RM#2078
>
> Steps to re-produce the issue:
> 1) Create table provided by user from RM.
> 2) Right click on newly created table
> 3) Select 'Script' -> 'CREATE Script'
> 4) Drag the splitter down side to maximise SQL Panel area.
> *** Do not click on SQL area ***
> 5) You will see truncated sql.
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in displaying Trigger SQL

2017-06-12 Thread Dave Page 
Thanks, patch applied.

On Mon, Jun 12, 2017 at 10:54 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to fix the issue in Table node where it was not displaying
> reversed engineered sql for Trigger(s) properly, if trigger function
> associated with that trigger has parameters.
> RM#2043
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Properly handle trigger functions with parameters. Fi

2017-06-12 Thread Dave Page 
Properly handle trigger functions with parameters. Fixes #2043

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c435d488853b7b52f33b8d01fe98b5938e6fd835
Author: Murtuza Zabuawala 

Modified Files
--
.../servers/databases/schemas/tables/__init__.py   | 50 --
.../databases/schemas/tables/triggers/__init__.py  |  2 +-
2 files changed, 48 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #155

2017-06-12 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for

[Dave Page] Fix error on the stats tab with PG10. Also, rename the 10.0_plus

--
[...truncated 261.86 KB...]
Get type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.types.tests.test_types_put.TypesUpdateTestCase)
Update type under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_add.ViewsAddTestCase)
Add view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_add.ViewsAddTestCase)
Add materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_delete.ViewsDeleteTestCase)
Delete view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_delete.ViewsDeleteTestCase)
Delete materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_get.ViewsGetTestCase)
Get materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.schemas.views.tests.test_views_put.ViewsUpdateTestCase)
Update materialized view under schema node ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase)
Check Databases Node URL ... ok
runTest 
(pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase)
Check Databases Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_add.ResourceGroupsAddTestCase)
Add resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_delete.ResourceGroupsDeleteTestCase)
Delete resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_put.ResourceGroupsPutTestCase)
Put resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.tests_resource_groups_get.ResourceGroupsGetTestCase)
Get resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_add.LoginRoleAddTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_delete.LoginRoleDeleteTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_get.LoginRoleGetTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_put.LoginRolePutTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_add.TableSpaceAddTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_delete.TableSpaceDeleteTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.TablespaceGetTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_check_recovery.TestCheckRecovery)
Test for check recovery ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_dependencies_sql.TestDependenciesSql)
Test dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_dependents_sql.TestDependentsSql)
Test dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_role_dependencies_sql.TestRoleDependenciesSql)
Test Role Dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_add.ServersAddTestCase)
Default Server Node url ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_delete.ServerDeleteTestCase)
Default Server Node url ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_get.ServersGetTestCase)
Default Server Node url ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_put.ServerUpdateTestCase)
Default Server Node url ... ok
runTest (pgadmin.browser.server_groups.tests.test_sg_get.SgNode

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

2017-06-12 Thread Dave Page 
Hi

On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi
 wrote:
> Hi,
>
> Please find the attached patch to reset the zoom level in the desktop
> runtime.
>
> Added the new shortcut CTRL + 0 to reset the zoom level.

The code looks good, however I don't think resetting to the startup
value is really what we want. Shouldn't it reset it to 1.0?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Surinder Kumar 
Hi

Please find rebased patch

Thanks

On Mon, Jun 12, 2017 at 5:20 PM, Dave Page  wrote:

> Could you rebase this please?
>
> Thanks.
>
> On Fri, Jun 9, 2017 at 10:40 AM, Surinder Kumar
>  wrote:
> > Ignore previous patch as it doesn't contains new changes.
> > Please find attached patch.
> >
> >
> > On Fri, Jun 9, 2017 at 3:06 PM, Surinder Kumar
> >  wrote:
> >>
> >> Hi
> >>
> >> PFA patch and review.
> >>
> >>
> >> On Fri, Jun 9, 2017 at 1:47 PM, Dave Page  wrote:
> >>>
> >>> Hi
> >>>
> >>> Ahh, now we have a bug. In the properties dialogues, if you edit a
> >>> comment, as soon as the Save button gets enabled, hitting Return will
> >>> Save the changes instead of adding a newline to the comment. That's
> >>> clearly not right :-(
> >>
> >> Now if event.target is its child elements(for example input, textarea
> >> etc), the function "handleKeyDown(event)" won't call.
> >>>
> >>>
> >>> On Fri, Jun 9, 2017 at 7:48 AM, Surinder Kumar
> >>>  wrote:
> >>> > Hi
> >>> >
> >>> > Please find updated patch.
> >>> >
> >>> > Thanks,
> >>> > Surinder
> >>> >
> >>> > On Thu, Jun 8, 2017 at 7:16 PM, Dave Page  wrote:
> >>> >>
> >>> >> Hi
> >>> >>
> >>> >> On Thu, Jun 8, 2017 at 5:38 AM, Surinder Kumar
> >>> >>  wrote:
> >>> >> > Hi
> >>> >> >
> >>> >> > The attribute key for Ok, Save buttons should be mapped to
> >>> >> > 13(Enter),
> >>> >> > for Help - 112(F1) and
> >>> >> > for Cancel - 27(Esc)
> >>> >> > The above changes are made into all dialog related template files.
> >>> >> >
> >>> >> > PFA patch and review.
> >>> >>
> >>> >> Looks good. Just a couple of thoughts:
> >>> >>
> >>> >> - You've missed the object property dialogues. This really needs to
> be
> >>> >> consistent across all dialogues :-)
> >>> >>
> >>> >> - The behaviour with Enter is a bit odd, because priority will be
> >>> >> given the the focussed control to handle it. That's what we want if
> >>> >> it's a text area for example, but on the other hand, if you open the
> >>> >> Preference dialogue, then the Help button gets focus first, so Enter
> >>> >> there will end up opening the docs. I suspect in most cases the
> >>> >> behaviour you've got is fine, so I'm not inclined to change it.
>  >>> >> a little> Hmm, I see similar behaviour in some other apps. Let's
> leave
> >>> >> it as you've done it :-)
> >>> >>
> >>> >> Please add support for the properties dialogues, then I think we're
> >>> >> good
> >>> >> to go.
> >>> >
> >>> > Done.
> >>> >>
> >>> >>
> >>> >> Thanks!
> >>> >>
> >>> >> --
> >>> >> Dave Page
> >>> >> Blog: http://pgsnake.blogspot.com
> >>> >> Twitter: @pgsnake
> >>> >>
> >>> >> EnterpriseDB UK: http://www.enterprisedb.com
> >>> >> The Enterprise PostgreSQL Company
> >>> >
> >>> >
> >>>
> >>>
> >>>
> >>> --
> >>> Dave Page
> >>> Blog: http://pgsnake.blogspot.com
> >>> Twitter: @pgsnake
> >>>
> >>> EnterpriseDB UK: http://www.enterprisedb.com
> >>> The Enterprise PostgreSQL Company
> >>
> >>
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


Feature_1535_v2.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server

2017-06-12 Thread Dave Page 
Thanks Atul, patch applied.

On Fri, Jun 9, 2017 at 1:34 PM, Atul Sharma
 wrote:
> Hi Dave,
>
> I have made the template search code to work for 10_plus directory name.
> Please review the attached patch
>
> Regards,
> Atul.
>
>
>
> On Thu, Jun 8, 2017 at 7:55 PM, Dave Page  wrote:
>>
>> Hi Atul,
>>
>> On Thu, Jun 8, 2017 at 3:03 PM, Atul Sharma
>>  wrote:
>> > Hi,
>> >
>> > The issue is fixed now. Added a new "stats.sql" file with updated
>> > columns
>> > for the version 10.0_plus
>> >
>> > PFA RM patch.
>>
>> As PostgreSQL has moved to a 2 digit version number system instead of
>> 3, I think the directory name should be 10_plus shouldn't it? Will
>> that work with the template search code? If not, can you please fix
>> that as well?
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix error on the stats tab with PG10. Also, rename th

2017-06-12 Thread Dave Page 
Fix error on the stats tab with PG10. Also, rename the 10.0_plus template 
directory to 10_plus to match the new versioning. Fixes #2450

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=49cd578816ab45166556fcd46096671130939cc3
Author: Atul Sharma 

Modified Files
--
.../templates/sequence/sql/10.0_plus/get_def.sql   | 11 -
.../templates/sequence/sql/10_plus/get_def.sql | 11 +
.../connect/sql/10.0_plus/check_recovery.sql   |  9 
.../connect/sql/10_plus/check_recovery.sql |  9 
.../templates/servers/sql/10_plus/stats.sql| 51 ++
web/pgadmin/utils/versioned_template_loader.py |  2 +-
6 files changed, 72 insertions(+), 21 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page 
Could you rebase this please?

Thanks.

On Fri, Jun 9, 2017 at 10:40 AM, Surinder Kumar
 wrote:
> Ignore previous patch as it doesn't contains new changes.
> Please find attached patch.
>
>
> On Fri, Jun 9, 2017 at 3:06 PM, Surinder Kumar
>  wrote:
>>
>> Hi
>>
>> PFA patch and review.
>>
>>
>> On Fri, Jun 9, 2017 at 1:47 PM, Dave Page  wrote:
>>>
>>> Hi
>>>
>>> Ahh, now we have a bug. In the properties dialogues, if you edit a
>>> comment, as soon as the Save button gets enabled, hitting Return will
>>> Save the changes instead of adding a newline to the comment. That's
>>> clearly not right :-(
>>
>> Now if event.target is its child elements(for example input, textarea
>> etc), the function "handleKeyDown(event)" won't call.
>>>
>>>
>>> On Fri, Jun 9, 2017 at 7:48 AM, Surinder Kumar
>>>  wrote:
>>> > Hi
>>> >
>>> > Please find updated patch.
>>> >
>>> > Thanks,
>>> > Surinder
>>> >
>>> > On Thu, Jun 8, 2017 at 7:16 PM, Dave Page  wrote:
>>> >>
>>> >> Hi
>>> >>
>>> >> On Thu, Jun 8, 2017 at 5:38 AM, Surinder Kumar
>>> >>  wrote:
>>> >> > Hi
>>> >> >
>>> >> > The attribute key for Ok, Save buttons should be mapped to
>>> >> > 13(Enter),
>>> >> > for Help - 112(F1) and
>>> >> > for Cancel - 27(Esc)
>>> >> > The above changes are made into all dialog related template files.
>>> >> >
>>> >> > PFA patch and review.
>>> >>
>>> >> Looks good. Just a couple of thoughts:
>>> >>
>>> >> - You've missed the object property dialogues. This really needs to be
>>> >> consistent across all dialogues :-)
>>> >>
>>> >> - The behaviour with Enter is a bit odd, because priority will be
>>> >> given the the focussed control to handle it. That's what we want if
>>> >> it's a text area for example, but on the other hand, if you open the
>>> >> Preference dialogue, then the Help button gets focus first, so Enter
>>> >> there will end up opening the docs. I suspect in most cases the
>>> >> behaviour you've got is fine, so I'm not inclined to change it. >> >> a little> Hmm, I see similar behaviour in some other apps. Let's leave
>>> >> it as you've done it :-)
>>> >>
>>> >> Please add support for the properties dialogues, then I think we're
>>> >> good
>>> >> to go.
>>> >
>>> > Done.
>>> >>
>>> >>
>>> >> Thanks!
>>> >>
>>> >> --
>>> >> Dave Page
>>> >> Blog: http://pgsnake.blogspot.com
>>> >> Twitter: @pgsnake
>>> >>
>>> >> EnterpriseDB UK: http://www.enterprisedb.com
>>> >> The Enterprise PostgreSQL Company
>>> >
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix the PostGIS Datatypes in SQL tab, Create / Update

2017-06-12 Thread Dave Page 
Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for Table, 
Column, Foreign Table and Type node. Fixes #2324

Note that this doesn't add full support for PostGIS types to the table/column 
dialogues, which still can't handle the typmod usage. It does bring support to 
parity with pgAdmin 3 though.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8bd8ae001bd7c3141d8b5a22b00907b9fbe046f5
Author: Khushboo Vashi 

Modified Files
--
.../databases/schemas/foreign_tables/__init__.py   |  8 ++--
.../foreign_tables/sql/9.2_plus/create.sql |  2 +-
.../foreign_tables/sql/9.5_plus/create.sql |  2 +-
.../foreign_tables/sql/default/create.sql  |  2 +-
.../servers/databases/schemas/tables/__init__.py   | 24 ++-
.../databases/schemas/tables/column/__init__.py| 29 +++--
.../templates/column/sql/9.1_plus/properties.sql   |  1 +
.../tables/templates/column/sql/default/create.sql |  2 +-
.../templates/column/sql/default/properties.sql|  1 +
.../tables/templates/table/sql/default/create.sql  |  2 +-
.../servers/databases/schemas/types/__init__.py| 42 +--
.../type/sql/default/additional_properties.sql |  4 +-
.../types/templates/type/sql/default/create.sql|  2 +-
.../servers/databases/schemas/utils.py | 48 ++
14 files changed, 97 insertions(+), 72 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-12 Thread Dave Page 
Thanks, applied.

On Fri, Jun 9, 2017 at 10:18 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached updated patch.
>
> Fixed the PostGIS Datatypes in SQL tab, Create / Update dialogues for
> Table, Column, Foreign Table and Type node.
>
> Regarding  the review comment given by Dave (Also, I there should be a
> space between the , and value in the_geom geometry(MultiPolygon,3310).),
> won't be fixed as this format is returned by format_type() function itself.
>
> As per the conversation with Dave, I have logged RM #2473
>  to add support for PostGIS
> Datatypes.
>
> Thanks,
> Khushboo
>
> On Tue, Jun 6, 2017 at 6:49 PM, Dave Page  wrote:
>
>>
>>
>> On Tue, Jun 6, 2017 at 2:15 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On 6 Jun 2017 18:36, "Dave Page"  wrote:
>>>
>>>
>>>
>>> On Tue, Jun 6, 2017 at 1:23 PM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On 6 Jun 2017 17:42, "Dave Page"  wrote:

 Hi

 The table and column dialogues seem to have related problems. For
 example, the table dialogue shows the length of the geometry field in the
 test case as 847,380, whilst the column dialogue shows no length at all.

 What should be there in length and precision fields in this case?

>>>
>>> I have no idea :-). What did pgAdmin 3 do here? I assume there's some
>>> way to decode the typmod into the desired values, and map them back to
>>> appropriate SQL.
>>>
>>> I will try to figure out the way.
>>> pgAdmin 3 has the same issue, so I have asked for the suggestion.
>>>
>>
>> Oh, OK - thanks. Maybe we need to reuse the length and precision fields
>> for these types. That is, I believe, essentially how PostGIS passes extra
>> info to the column definitions.
>>
>>
>>>
>>>
 Also, I there should be a space between the , and value in the_geom
 geometry(MultiPolygon,3310).

 Thanks.

 On Mon, Jun 5, 2017 at 8:32 AM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Fixed PostGIS datatype on SQL tab for Table, column, Foreign Table and
> Type node.
>
> Please find the attached updated patch.
>
>
> Thanks,
> Khushboo
>
> On Thu, Jun 1, 2017 at 6:36 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>>
>> On Thu, Jun 1, 2017 at 5:27 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>>
>>> On Thu, Jun 1, 2017 at 4:57 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Khushboo,

 Please include Type node and Foreign Table node in your fix :-)

 I don't think Type node requires this change.
>>>
>>> Yes, It do require because user can create composite type from
>> existing types.
>> [image: Inline image 1]
>>
>>> Foreign table changes added in the attached updated patch.
>>>
 --

>>> Thanks Murtuza for pointing this out.
>
>
>> Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Thu, Jun 1, 2017 at 3:23 PM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix RM #2324 : PostGIS datatypes
> not showing up properly on SQL tab.
>
> Thanks,
> Khushboo
>
>
>
> --
> Sent via pgadmin-hackers mailing list (
> pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

>>>
>>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company



>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Surinder Kumar 
Hi

Changes:

1) Calculate text editor position properly when the size of the grid
exceeds the size of the window.

2) Assign NumberEditor to cell types('oid', 'xid', 'real').

3) Remove inline styles from rendered editors and move its styles to CSS
file.

Please find attached patch and review.

Thanks
Surinder


RM_2477.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][PATCH] CREATE Script do not display properly on panel resize

2017-06-12 Thread Murtuza Zabuawala 
Hi,

PFA patch to fix the issue where SQL Panel in query tool displays truncated
sql on resize.
RM#2078

Steps to re-produce the issue:
1) Create table provided by user from RM.
2) Right click on newly created table
3) Select 'Script' -> 'CREATE Script'
4) Drag the splitter down side to maximise SQL Panel area.
*** Do not click on SQL area ***
5) You will see truncated sql.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js 
b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index da24f77..ea8fedb 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -176,6 +176,16 @@ define([
 scrollbarStyle: 'simple'
 });
 
+// Refresh Code mirror on SQL panel resize to
+// display its value properly
+sql_panel_obj.on(wcDocker.EVENT.RESIZE_ENDED, function() {
+  setTimeout(function() {
+if(self && self.query_tool_obj) {
+  self.query_tool_obj.refresh();
+}
+  }, 200);
+});
+
 // Create panels for 'Data Output', 'Explain', 'Messages' and 'History'
 var data_output = new pgAdmin.Browser.Panel({
   name: 'data_output',

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in displaying Trigger SQL

2017-06-12 Thread Murtuza Zabuawala 
Hi,

PFA patch to fix the issue in Table node where it was not displaying
reversed engineered sql for Trigger(s) properly, if trigger function
associated with that trigger has parameters.
RM#2043

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
index 99f0ddc..b80bfd4 100644
--- 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
+++ 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
@@ -2132,6 +2132,48 @@ class TableView(PGChildNodeView, DataTypeReader, 
VacuumSettings):
 else:
 return None
 
+def get_trigger_function_schema(self, data):
+"""
+This function will return trigger function with schema name
+"""
+# If language is 'edbspl' then trigger function should be
+# 'Inline EDB-SPL' else we will find the trigger function
+# with schema name.
+if data['lanname'] == 'edbspl':
+data['tfunction'] = 'Inline EDB-SPL'
+else:
+SQL = render_template(
+"/".join(
+[self.trigger_template_path,'get_triggerfunctions.sql']
+),
+tgfoid=data['tgfoid'],
+show_system_objects=self.blueprint.show_system_objects
+)
+
+status, result = self.conn.execute_dict(SQL)
+if not status:
+return internal_server_error(errormsg=res)
+
+# Update the trigger function which we have fetched with
+# schema name
+if 'rows' in result and len(result['rows']) > 0 and \
+'tfunctions' in result['rows'][0]:
+data['tfunction'] = result['rows'][0]['tfunctions']
+return data
+
+def _format_args(self, args):
+"""
+This function will format arguments.
+
+Args:
+args: Arguments
+
+Returns:
+Formated arguments for function
+"""
+formatted_args = ["'{0}'".format(arg) for arg in args]
+return ', '.join(formatted_args)
+
 def get_sql(self, did, scid, tid, data):
 """
 This function will generate create/update sql from model data
@@ -2658,9 +2700,11 @@ class TableView(PGChildNodeView, DataTypeReader, 
VacuumSettings):
 data['schema'] = schema
 data['table'] = table
 
-if data['tgnargs'] > 1:
-# We know that trigger has more than 1 arguments, let's join 
them
-data['tgargs'] = ', '.join(data['tgargs'])
+data = self.get_trigger_function_schema(data)
+
+if len(data['custom_tgargs']) > 1:
+# We know that trigger has more than 1 argument, let's join 
them
+data['tgargs'] = self._format_args(data['custom_tgargs'])
 
 if len(data['tgattr']) > 1:
 columns = ', '.join(data['tgattr'].split(' '))
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/__init__.py
 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/__init__.py
index a3a26d7..5cbcc4d 100644
--- 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/__init__.py
+++ 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/__init__.py
@@ -528,7 +528,7 @@ class TriggerView(PGChildNodeView):
 Returns:
 Formated arguments for function
 """
-formatted_args = ["{0}".format(arg) for arg in args]
+formatted_args = ["'{0}'".format(arg) for arg in args]
 return ', '.join(formatted_args)
 
 

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Stop ignoring yarn.lock, per discussion with Pivotal

2017-06-12 Thread Dave Page 
Stop ignoring yarn.lock, per discussion with Pivotal team.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=59da69087cd32ea9e4996f87bae62c8c31dc632b
Author: George Gelashvili 

Modified Files
--
.gitignore| 1 -
web/yarn.lock | 0
2 files changed, 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Implementation of the client side 'url_for(...)' func

2017-06-12 Thread Ashesh Vashi 
Implementation of the client side 'url_for(...)' function.

Created a url_for function module to be used by different javascript
modules to use the same functionality of flask at client side.

A python module can expose the list of endpoints, used by its
javascripts, by overriding the 'get_exposed_url_endpoints(self)'
function.

In this patch, we have modified all the browser modules to use this
function. It will allow us to move the majority of the javascript
modules of browser nodes from templates directory to the static
directory.

TODO::
- Move these javascripts modules to the static directory.
- Use this function in all the applicable javascript modules.
  e.g. tools, miscellaneous modules

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fd3ddbeafbd30614043330696b8c9996dac2f08c

Modified Files
--
web/karma.conf.js  |  3 +-
web/pgadmin/__init__.py| 10 ++
web/pgadmin/browser/__init__.py| 21 +--
web/pgadmin/browser/server_groups/__init__.py  |  2 +-
.../databases/casts/templates/cast/js/casts.js |  8 ++---
.../templates/event_triggers/js/event_trigger.js   | 11 +++---
.../templates/extensions/js/extensions.js  | 11 +++---
.../foreign_servers/js/foreign_servers.js  |  2 +-
.../templates/user_mappings/js/user_mappings.js|  8 ++---
.../js/foreign_data_wrappers.js| 12 +++
.../languages/templates/languages/js/languages.js  | 12 +++
.../js/catalog_object_column.js|  2 +-
.../templates/catalog_object/js/catalog_object.js  |  2 +-
.../collations/templates/collation/js/collation.js | 11 +++---
.../domain_constraints/js/domain_constraints.js| 11 +++---
.../domains/templates/domains/js/domains.js|  8 ++---
.../templates/foreign_tables/js/foreign_tables.js  | 11 +++---
.../fts_configuration/js/fts_configuration.js  | 11 +++---
.../templates/fts_dictionary/js/fts_dictionary.js  | 11 +++---
.../templates/fts_parser/js/fts_parser.js  | 11 +++---
.../templates/fts_template/js/fts_templates.js | 11 +++---
.../functions/templates/function/js/functions.js   | 12 +++
.../functions/templates/procedure/js/procedures.js | 13 +++
.../trigger_function/js/trigger_functions.js   | 12 +++
.../edbfuncs/templates/edbfunc/js/edbfunc.js   | 12 +++
.../edbfuncs/templates/edbproc/js/edbproc.js   | 15 
.../packages/edbvars/templates/edbvar/js/edbvar.js | 12 +++
.../packages/templates/package/js/package.js   | 11 +++---
.../sequences/templates/sequence/js/sequence.js| 11 +++---
.../synonyms/templates/synonym/js/synonym.js   | 11 +++---
.../tables/column/templates/column/js/column.js| 11 +++---
.../check_constraint/js/check_constraint.js| 11 +++---
.../js/exclusion_constraint.js | 11 +++---
.../templates/foreign_key/js/foreign_key.js| 11 +++---
.../index_constraint/js/index_constraint.js|  2 +-
.../templates/constraints/js/constraints.js|  2 +-
.../tables/indexes/templates/index/js/index.js | 11 +++---
.../tables/rules/templates/rules/js/rules.js   | 10 +++---
.../schemas/tables/templates/table/js/table.js | 13 +++
.../triggers/templates/trigger/js/trigger.js   | 11 +++---
.../schemas/templates/catalog/js/catalog.js|  2 +-
.../schemas/templates/schema/js/schema.js  | 12 +++
.../schemas/types/templates/type/js/type.js| 12 +++
.../schemas/views/templates/mview/js/mview.js  | 10 +++---
.../schemas/views/templates/view/js/view.js| 11 +++---
.../databases/templates/databases/js/databases.js  | 13 +++
.../templates/pga_schedule/js/pga_schedule.js  | 11 +++---
.../steps/templates/pga_jobstep/js/pga_jobstep.js  | 11 +++---
.../pgagent/templates/pga_job/js/pga_job.js| 12 +++
.../resource_groups/js/resource_groups.js  |  8 ++---
.../servers/roles/templates/role/js/role.js| 14 
.../templates/tablespaces/js/tablespaces.js| 15 
.../servers/templates/servers/servers.js   | 10 +++---
.../templates/server_groups/server_groups.js   | 10 +++---
web/pgadmin/browser/templates/browser/index.html   |  2 +-
.../browser/templates/browser/js/browser.js| 18 ++
.../browser/templates/browser/js/endpoints.js  | 11 ++
web/pgadmin/help/__init__.py   |  6 
web/pgadmin/misc/__init__.py   |  9 -
web/pgadmin/preferences/__init__.py| 25 ++---
.../templates/preferences/preferences.js   | 33 +
web/pgadmin/settings/__init__.py   | 11 --
web/pgadmin/static/js/selection/grid_selector.js   |  8 +++--
web/pgadmin/static/js/url_for.js   | 41 ++
web/pgadmin/utils/__init__.py  | 16 +
web/r