Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-16 Thread Harshal Dhumal
not allow to add another primary key if one already exist. And another minor enhancements. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Sat, May 14, 2016 at 2:03 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > Hi,

[pgadmin-hackers] psycopg2 issue when returning password from sqlite db to python [pgadmin4]

2016-05-13 Thread Harshal Dhumal
Hi, PFA minor patch for psycopg2 Issue fixed: cast password to string before returning serverManager as_dict() -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/utils/driver/psycopg2/__init__.py b/web/pgadmin/utils/driver/ps

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-18 Thread Harshal Dhumal
Hi, PFA patch for table node (version 8.1). apply this patch on version 7 patch. Not all issue are fixed in this patch. Murtuza will be sending version 8.2 witch will have resolution for remaining issues. Apply version 8.2 patch on version 8.1 -- *Harshal Dhumal* *Software Engineer

[pgadmin-hackers] Change server password [pgadmin4]

2016-05-11 Thread Harshal Dhumal
Hi, PFA patch for changing server password. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin/browser/server_groups/servers/__init__.py index b2fd313..fe1f1b6 100644 ---

[pgadmin-hackers] Destroy select2 controls before re-rendering [pgadmin4]

2016-05-12 Thread Harshal Dhumal
Hi, PFA patch for select2 controls. Change: Destroy existing any select2 controls before re-rendering them. Otherwise this was causing wired dialogue UI hang issue. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/

[pgadmin-hackers] Object cell editor remove/destroy issue [pgadmin4]

2016-05-12 Thread Harshal Dhumal
destroy all controls within it. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/static/js/backgrid/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid/backgrid.pgadmin.js index e42c4cf..5197f15 100644 --- a/web/pgadmin/sta

[pgadmin-hackers] variable scope issue in server js [pgadmin4]

2016-05-12 Thread Harshal Dhumal
h same name at different place in same file. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js b/web/pgadmin/browser/server_groups/servers/templates/servers/servers.js ind

[pgadmin-hackers] Backgrid Select2cell multiselect support [pgadmin4]

2016-05-05 Thread Harshal Dhumal
Hi, PFA patch for backgrid Select2cell in which I have added multiselect support which was missing. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/static/js/backgrid/backgrid.pgadmin.js b/web/pgadmin/static/js/ba

Re: [pgadmin-hackers] PATCH: FTS configuration node

2016-05-05 Thread Harshal Dhumal
+ patch link http://www.postgresql.org/message-id/CAFiP3vwkka+=1foj7kr2zbc4azecoca9eo9dz34-oyy_9ge...@mail.gmail.com -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Thu, May 5, 2016 at 8:18 PM, Sanket Mehta <sanket.me...@enterprisedb.com>

[pgadmin-hackers] Improved password error message ui on password change page [pgadmin4]

2016-05-09 Thread Harshal Dhumal
Hi, PFA minor patch for password change page. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css index 2531863..00a9829 100755 --- a/web/pgadmin/stat

[pgadmin-hackers] Initial Check constraint node patch [Pgadmin4]

2016-04-15 Thread Harshal Dhumal
Hi, PFA initial patch for check constraint. Note: This patch has dependency on Table, Column node and Index constraint. As of now all (5) constraint nodes are completed (initial patches). -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> diff --git

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-07 Thread Harshal Dhumal
traints should be start > with Schema.Table.Constraint. Please follow same path for all the nodes. > I cross checked with pgadmin3. Reverse Engineering SQL looks good to me. Please let me know what is missing? > 23. Indexes : Comments can not be updated. Please check the attached > scre

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-07 Thread Harshal Dhumal
Hi, i have fixed all of below mentioned issues. > A couple more: > > > If I go to create a new table, give it a name, select a table to > inherit from, and then do nothing else, I get an error: > > ERROR: syntax error at or near "INHERITS" > LINE 2: INHERITS (test) > ^ > > This is because no

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-07 Thread Harshal Dhumal
Hi, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Wed, Apr 27, 2016 at 6:13 PM, Thom Brown <t...@linux.com> wrote: > On 27 April 2016 at 10:22, Harshal Dhumal > <harshal.dhu...@enterprisedb.com> wrote: > > > &

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

2016-07-27 Thread Harshal Dhumal
Hi, PFA updated patch for RM1260. In addition to RM1260 issue I have added following changes in this patch. 1] datamodel.js: Added option check against undefined. 2] foreign key: fixed first empty option issue. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

2016-07-27 Thread Harshal Dhumal
and patch file -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 27, 2016 at 3:49 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for RM1260. > >

[pgadmin-hackers] patch for RM1497

2016-07-25 Thread Harshal Dhumal
Hi, PFA attached for rm1497 Issue: fixed js error while re-rendering shubnode grid -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

2016-07-27 Thread Harshal Dhumal
Hi, PFA updated patch for RM1260 (V4). Fixed create and delete operations for foreign table. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 27, 2016 at 6:53 PM, Ashesh Vashi <ashesh.va...@enterprisedb.

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

2016-07-22 Thread Harshal Dhumal
Hi, PFA rebased patch for RM1293 and RM1294. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jun 6, 2016 at 7:17 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > Please fin

[pgadmin-hackers] Fix for RM1154: Show proper error message for already delete object [pgadmin4]

2016-07-26 Thread Harshal Dhumal
Hi, PFA patch for rm1154. Issue fixed: Show proper error message if try to delete already deleted object. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers

Re: [pgadmin-hackers] patch for RM1460 [pgAdmin4]

2016-07-25 Thread Harshal Dhumal
Hi Dave, Can you please try again with clean cache. Above mentioned scenario is working fine for me. Thanks. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 22, 2016 at 9:13 PM, Dave Page <dp...@pgadmin.

[pgadmin-hackers] Patch for RM1500 other issues [pgAdmin4]

2016-08-03 Thread Harshal Dhumal
(and vice versa) 8] Renaming constraint (RM1500). -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py b/web/pgadmin/browser/ser

Re: [pgadmin-hackers] Patch for RM1500 other issues [pgAdmin4]

2016-08-03 Thread Harshal Dhumal
Hi Dave, This because on python 2.X simplejson throws KeyError instead of TypeError if any error occurs while loading json data from given object. Now I have handled that exception as well in attached patch. I'm sending this as separate patch instead part of RM1500. -- *Harshal Dhumal

[pgadmin-hackers] RM1492 [pgadmin4]

2016-08-04 Thread Harshal Dhumal
Hi, PFA patch for RM1492 Issue fixed: Generate proper queries for "View all/first 100/last 100 rows" with table containing columns with capital letters. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff -

[pgadmin-hackers] patch for RM1450 [pgAdmin4]

2016-08-03 Thread Harshal Dhumal
Hi, PFA patch for RM1450. Changes: Added save password option in sever create mode. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin

Re: [pgadmin-hackers] Patch for RM1500 other issues [pgAdmin4]

2016-08-03 Thread Harshal Dhumal
Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Aug 3, 2016 at 6:30 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Wed, Aug 3, 2016 at 12:43 PM, Harshal Dhumal > <harshal.dhu...@enterprisedb.co

[pgadmin-hackers] patch for RM1460 [pgAdmin4]

2016-07-20 Thread Harshal Dhumal
. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/datagrid/templates/datagrid/index.html b/web/pgadmin/tools/datagrid/templates/datagrid/index.html index 67cf107..1611887 100644 --- a/web/pgadmin/tools

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

2016-07-13 Thread Harshal Dhumal
Yes sure -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 13, 2016 at 5:10 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > Can you rebase this please? > > Thanks. > > On M

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

2016-07-13 Thread Harshal Dhumal
Hi, PFA rebased patch for RM1405 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Yes sure > > -- &g

Re: [pgadmin-hackers] Regarding issue 1241

2016-07-18 Thread Harshal Dhumal
Hi, PFA patch for issue RM1241 Changes: 1. Altered variable control to make its UI consistence with privileges and Security labels. 2. Changed datamodel.js to handle duplicate rows at datamodel level and not UI/Control level. (See variable control for example) -- *Harshal Dhumal* *Software

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

2016-07-18 Thread Harshal Dhumal
Hi, PFA rebased patch RM1405 (version 4) Neel will be sending patch for QT issue for same functionality. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 18, 2016 at 4:02 PM, Dave Page <dp...@pgadmin.

[pgadmin-hackers] Patch for RM1399 [pGADMIN4]

2016-06-28 Thread Harshal Dhumal
Hi, PFA patch for issue rm1399 Issue: Sometimes codemirror does not render properly in SQL tab -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web

Re: [pgadmin-hackers] Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers

2016-07-05 Thread Harshal Dhumal
: 4267545e08cb28b8c4574bb7a5da0322ef7728d2 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 24, 2016 at 4:54 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue RM#12

[pgadmin-hackers] patch for issue RM1418 and RM1434 [pgadmin4]

2016-07-05 Thread Harshal Dhumal
Hi, PFA patch for Issue RM1418 and RM1434 Issues fixed: 1. Select2 control fixed for multi-select mode. 2. Index constrains (primary and unique key) fixed column listing issue. 3. Table node "inherited from" (Select2 control) was not showing table name with public schema -- *Hars

[pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

2016-07-06 Thread Harshal Dhumal
Hi, PFA patch for issue RM1260. Changes: Issue wasn't related to foreign table but was due the Select2 control. Now I have improved select2 control to handle null value in multi-select mode. Initial it was returning "null" instead it should return [] (empty array). -- *Hars

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

2016-07-07 Thread Harshal Dhumal
Hi, PFA updated patch for issue RM1260 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > Please ignor

Re: [pgadmin-hackers] patch for issue RM1260 [pgAdmin4]

2016-07-07 Thread Harshal Dhumal
Hi, By mistake I deleted a line which was not supposed to be deleted, and that line of code was initialization of select2. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 7, 2016 at 12:13 PM, Ashesh Vashi

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

2016-07-11 Thread Harshal Dhumal
to use download attr. of anchor tag () as it's not support by all of major browsers (e.g. Safari). Also it's not feasible to load data in html to download if result set of query is very huge (in GBs). -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Ente

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

2016-07-04 Thread Harshal Dhumal
Hi, PFA updated patch for RM1336 and keyboard shortcuts file separately. This patch is same as last patch except I have removed keyboard shortcut list from this patch. Also please see my inline response below. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http

[pgadmin-hackers] [pgadmin4] fix for RM1417

2016-08-08 Thread Harshal Dhumal
Hi, PFA patch for issue RM1417. Changes: Fixed privileges parsing issue while editing privileges of exiting object. Additional Note: This was general issue and was not related to runtime or pg 9.6. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com

Re: [pgadmin-hackers] patch for RM1460 [pgAdmin4]

2016-07-22 Thread Harshal Dhumal
Hi, PFA attached patch to show save as option always and to show menu save option only when file is changed. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 21, 2016 at 6:18 PM, Dave Page <dp...@pgadmin.

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

2016-06-30 Thread Harshal Dhumal
Hi Dave, Somehow control key is mapped to Command key in Mac. So on Mac shortcuts are Shift+Command+E, Shift+Command+X, Shift+Command+A -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 30, 2016 at 1:05 AM

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

2016-07-01 Thread Harshal Dhumal
Hi, PFA patch This contains: 1] All shortcuts' list which we are using in pgAdmin4. 2] Fixed shortcut display tooltips. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 30, 2016 at 2:34 PM, Dave Page <

[pgadmin-hackers] fix for issue rm1425 [pgAdmin4]

2016-07-01 Thread Harshal Dhumal
Hi, PFA patch for issue RM1425. Issue fixed: Loading panel does not hide in Mac runtime due error in js. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/templates/browser/index.html b

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

2016-06-29 Thread Harshal Dhumal
Hi, PFA upadated patch for RM1336 Issue fixed: Query tool shortcuts weren't working on mac runtime. Also changed shortcut key for "Explain analyze" from Ctrl+Shift+A ---> Alt+Shift+N as Ctrl+Shift+A was conflicting with shortcut to show "about" dialog in runtime.

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

2016-06-29 Thread Harshal Dhumal
Hi, Here is updated patch for RM1336 Fixed query tool shortcuts issue in Mac runtime and changed shortcut to show "About" dialog in runtime from Ctrl+Shift+A > Alt+Shift+A -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterpri

[pgadmin-hackers] Patch from RM1983 [pgAdmin4]

2017-02-06 Thread Harshal Dhumal
was not decoded properly. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/__init__.py index

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

2017-02-06 Thread Harshal Dhumal
Hi Dave, -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Feb 6, 2017 at 6:48 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Mon, Feb 6, 2017 at 12:57 PM, Harshal Dhumal > <harshal.dh

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

2017-02-23 Thread Harshal Dhumal
Note: Apply patches which I have just sent (with subject pgAdmin4 minor issues [pgAdmin4]) before applying this patch. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Feb 17, 2017 at 4:22 PM, Murtuza Zabuawala

[pgadmin-hackers] pgAdmin4 mirror issues [pgAdmin4]

2017-02-23 Thread Harshal Dhumal
-- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/event_triggers/templates/event_triggers/sql/9.3_plus/properties.sql b/web/pgadmin/browser/server_groups

[pgadmin-hackers] Minor patch for subnode control clean up code [pgAdmin4]

2017-01-18 Thread Harshal Dhumal
Hi, This patch includes following change: Properly remove any event listeners added by subnode control. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company subnode_cleanup.patch Description: Binary data -- Sent via

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

2017-01-19 Thread Harshal Dhumal
Hi, Pls find updated patch (V7) for direct file navigation with below bug fixes. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 16, 2017 at 8:42 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi &

[pgadmin-hackers] patch for RM1538: show db default acls [pgadmin4]

2016-08-16 Thread Harshal Dhumal
Hi, PFA patch for rm 1538 to show default database privileges in properties mode. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/js

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

2016-08-22 Thread Harshal Dhumal
Hi, PFA patch for wrong header and body were generated. Fixed the header and body sql parsing issue. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Aug 22, 2016 at 5:10 PM, Khushboo Vashi < khushboo

Re: [pgadmin-hackers] [pgadmin4] Edb package support.

2016-08-22 Thread Harshal Dhumal
Hi Dave, -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Aug 22, 2016 at 5:45 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Mon, Aug 22, 2016 at 1:04 PM, Harshal Dhumal > <harshal.dh

[pgadmin-hackers] patch for RM1177 [pgadmin4]

2016-08-05 Thread Harshal Dhumal
Hi, PFA patch for RM1177. Issue fixed: Added a check to warn the user if the binary path is not set before running external commands. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

2017-02-27 Thread Harshal Dhumal
Hi, Please find updated patch for encoding issue. Apart from encoding issue I have also fixed issue of wrong data was show in query editor for string types and array string types for databases with encoding other than utf-8. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http

Re: [pgadmin-hackers] Package node test cases [pgadmin4]

2016-09-01 Thread Harshal Dhumal
Ok, I'll do that once that work is completed. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Sep 1, 2016 at 3:57 PM, Dave Page <dp...@pgadmin.org> wrote: > Per my earlier email to Priyanka, I'm

[pgadmin-hackers] Package node test cases [pgadmin4]

2016-08-30 Thread Harshal Dhumal
Hi, PFA patch for package node test cases. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/packages/tests/__init__.py b/web/pgadmin/browser

[pgadmin-hackers] Patch for RM1531 and other improvements related to same issue [pgAdmin4]

2016-10-08 Thread Harshal Dhumal
Hi, PFA patch for RM 1531. Changes: 1. Fixed update privileges for views and materialized views. 2. Apart from this fixed wrong sql for privilege update. 3. Fixed: Error message was not got cleared even after removing entry with error on privilege tab. -- *Harshal Dhumal* *Software Engineer

[pgadmin-hackers] Patch for RM1720 [pgadmin4]

2016-09-21 Thread Harshal Dhumal
to another in some cases. To avoid this issue we now deleting server connection details (server manger) when user drops server. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups

Re: [pgadmin-hackers] Patch for RM1720 [pgadmin4]

2016-09-22 Thread Harshal Dhumal
Hi, Please find attached updated patch for RM1720. Also test this patch with updated test suite patch which Navnath would be sending. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Sep 21, 2016 at 8:39 PM

Re: [pgadmin-hackers] PGAdmin 4 Bug report

2016-11-08 Thread Harshal Dhumal
Hi, This is known issue and already reported here https://redmine.postgresql.org/issues/1797 This will be taken care in future release. Until this issue gets fixed you can use normal english characters in directory name/path. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http

[pgadmin-hackers] patch for RM1861 [pgAdmin4]

2016-10-20 Thread Harshal Dhumal
Hi, PFA minor patch for RM1861. Issue fixed: SQL not generated for exclusion constraint on table -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas

Re: [pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

2016-10-24 Thread Harshal Dhumal
Hi Dave, I mean reverse engineered sql tab. Currently it's not implemented for both pgagent schedule and jobs. I have created Rm for that RM1891 <https://redmine.postgresql.org/issues/1891> -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Ente

Re: [pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

2016-10-24 Thread Harshal Dhumal
Hi Dave, -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Oct 24, 2016 at 1:34 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Mon, Oct 24, 2016 at 7:27 AM, Harshal Dhumal > <harshal.dh

[pgadmin-hackers] patch for RM1863 [pgadmin4]

2016-10-20 Thread Harshal Dhumal
Hi, PFA patch for RM1863. Issue fixed: Correctly interpret composite data type for columns while generating sql. also minor UI improvement in foreign key column tab -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff

Re: [pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

2016-10-21 Thread Harshal Dhumal
. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Oct 21, 2016 at 4:11 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please ignore this patch as I haven't fixed same issue for

[pgadmin-hackers] patch for RM1875 exclusion constraint support for pg-9.6 [pgAdmin4]

2016-10-21 Thread Harshal Dhumal
Hi, PFA patch for RM1875. Issue fixed: 1. Exclusion constraint added support for pg-9.6 2. Fixed index out of list (python error) when Exclusion constraint is created without name. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

2016-11-24 Thread Harshal Dhumal
Hi Dave, Please find updated attached patch for RM1911 (V2) -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Nov 21, 2016 at 7:48 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Sat, Nov 19,

[pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

2016-11-19 Thread Harshal Dhumal
Hi, PFA for RM1911 Feature added: Allow user add file/folder path directly in input field. Other improvements like clean up after file manager is closed. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web

[pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

2016-10-21 Thread Harshal Dhumal
Hi, PFA attached patch for pgagent issue RM1878 issue fixed: ProgrammingError: can't adapt type 'Undefined' -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/pgagent

Re: [pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

2016-10-21 Thread Harshal Dhumal
Hi, Please ignore this patch as I haven't fixed same issue for schedule. Also there is issue "malformed array literal" when we try to save schedule. I'll be sending updated patch. Thanks Harshal, -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterp

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

2016-12-16 Thread Harshal Dhumal
Hi Dave, Please find updated patch below for direct file navigation. I have covered all of above mentioned case. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Nov 25, 2016 at 4:09 PM, Dave Page <

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

2017-01-14 Thread Harshal Dhumal
Hi, Pls updated patch for RM1911. 1. This includes fix for issue index out of range when user enters path of folder without trailing slash (showed by Dave). 2. To make this functionality compatible with save last used directory feature. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB

Fwd: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

2017-01-08 Thread Harshal Dhumal
Hi Dave, Please find attached rebased patch. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Sun, Jan 8, 2017 at 4:07 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > Can you rebase this pleas

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

2016-12-27 Thread Harshal Dhumal
Hi Dave, Here is updated (V4) patch. Changes: 1] Now can enter both type of slashes ( / and \ ) and all will get replaced with the platform standard. 2] Added unicode support. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL

[pgadmin-hackers] [RM2283] [pgAdmin4] minor patch for select2 cell

2017-03-23 Thread Harshal Dhumal
Hi, PFA minor patch for RM2283. Issue: When setting default selection of multiple values we need to check if select2 cell is in multiselect mode. We need to check this as javascript assumes string as array of chars and tries to set individual char as selected option in cell. RM2283.patch

[pgadmin-hackers] Re: [pgAdmin 4 - Bug #2274] Row Deletion Against Tables With PKs Not at Ordinal 0 Position Fail

2017-03-24 Thread Harshal Dhumal
cols as primary key. 4. Table with 4 columns with 2nd and 4th cols as primary key. 5. Table with 4 columns with 4th col as primary key. 6. Table with 4 columns with 1st col as primary key. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise

Re: [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

2017-03-18 Thread Harshal Dhumal
Hi, -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Mar 17, 2017 at 4:04 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Fri, Mar 17, 2017 at 7:02 AM, Harshal Dhumal > <harshal.dh

Re: [pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

2017-03-21 Thread Harshal Dhumal
Hi, Please find updated patch for RM2244. Changes: View Data was broken in last patch when table contains more that 1 column. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Mar 20, 2017 at 4:10 PM, Dave Page

[pgadmin-hackers] patch for RM2243 and RM2244 [pgAdmin4]

2017-03-17 Thread Harshal Dhumal
Hi, Here is patch for RM2243 and RM2244 Changes: 1. Pickup correct encoding in qtLiteral to decode. 2. While releasing database connection only decode database name if it's not unicode. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise

[pgadmin-hackers] Numeric controls validation issue in nested schema [pgAdmin4]

2017-03-09 Thread Harshal Dhumal
Hi, PFA minor patch for numeric control . This Fixes #2241 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js index

[pgadmin-hackers] Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-04-25 Thread Harshal Dhumal
w your opinion on this. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] pgAdmin 4 commit: Improve handling of nulls and default values in the d

2017-05-12 Thread Harshal Dhumal
ser adds new row (do not save) and then copy past few exiting rows (at this point newly added row no longer remains at last position). And after saving it disable last row which is not the newly added row. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.ente

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-05-15 Thread Harshal Dhumal
Hi Murtuza, Currently nodes are sorted in case sensitive manner it should be case insensitive. See current Server group order is A, Servers, a1, a​2. It should be A, a1, a2, Servers. Similarly check sorting order for server and database nodes -- *Harshal Dhumal* *Sr. Software Engineer

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-05-15 Thread Harshal Dhumal
Hi Dave, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 15, 2017 at 1:43 PM, Dave Page <dp...@pgadmin.org> wrote: > So is the last patch considered good? > Except one thing, when user re

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-05-09 Thread Harshal Dhumal
Hi, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 9, 2017 at 1:08 AM, Sarah McAlear <smcal...@pivotal.io> wrote: > Hi Harshal! > > We applied your patch and ran the Javascript tes

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background color disappeared on save in View data

2017-05-15 Thread Harshal Dhumal
Hi, Issue caused because variable temp_new_rows was access before it was initialised. Attached patch fixes this issue. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 15, 2017 at 9:28 PM, Dave Page <

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-05-15 Thread Harshal Dhumal
ld be tested. > At this point we don't have any python unit tests that can test sqleditor backend (python code). @Dave should I include python unit test cases in this patch? > > --Joao and George > > > On Fri, May 12, 2017 at 8:32 AM, Harshal Dhumal < > harshal.dhu...@enterp

[pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-05-18 Thread Harshal Dhumal
Hi, Please find attached patch for RM2421 Issue fixed: 1. Integer/numeric Validation is not working properly. 2. Wrong CPU rate unit -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser

Re: [pgadmin-hackers] pgAdmin 4 commit: Cleanup handling of default/null values when data edi

2017-05-28 Thread Harshal Dhumal
] , grid:grid} ) causes grid to re-render (as we listener on onAddNewRow event where we re-render the grid) -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Sun, May 28, 2017 at 12:21 AM, Dave Page

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-05-19 Thread Harshal Dhumal
miliar. Is > there any reason to have this code duplicated? If not this could be a good > time to refactor it. > As said earlier in response of point 2 code duplication is because the way controls are derived. > +++ b/web/pgadmin/static/js/backform.pgadmin.js > @@ -1528,7 +152

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-05-29 Thread Harshal Dhumal
group. Also I have updated all other nodes which uses Numeric controls -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, May 19, 2017 at 12:22 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote:

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-05-30 Thread Harshal Dhumal
Hi, Please ignore this patch as I forgot to include few changes. I'll send updated one. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 29, 2017 at 3:18 PM, Harshal Dhumal < harshal.

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-05-30 Thread Harshal Dhumal
Hi, Please find updated patch. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 30, 2017 at 12:30 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please ignore

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-06-08 Thread Harshal Dhumal
Please find attached rebased patch. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 7, 2017 at 6:59 PM, Dave Page <dp...@pgadmin.org> wrote: > Can you rebase this please? I think Ashesh bro

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-08 Thread Harshal Dhumal
Ignore this patch. Rebase and migration of feature tests and jasmine tests required. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 8, 2017 at 3:56 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-06-06 Thread Harshal Dhumal
B)' must be numeric. > Fixed. Please find attached updated patch. > > Thanks. > > On Tue, May 30, 2017 at 8:28 AM, Harshal Dhumal > <harshal.dhu...@enterprisedb.com> wrote: > > Hi, > > > > Please find updated patch. > > > > -- > >

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-14 Thread Harshal Dhumal
se PostgreSQL Company > <http://www.enterprisedb.com/> > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshvashi> > >> >> Thanks. >> >> On Fri, Jun 9, 2017 at 10:08 AM, Harshal Dhumal >> <harshal.dhu...@enterpris

<    1   2   3   >