Re: [pgadmin-hackers] Patch: Auto-generate search_path statement for selected schema in query editor

2013-03-18 Thread Neel Patel
); *if (outputPaneInfo.IsOk() == true scratchPad.IsOk() == true)* manager.Update(); Please find the patch along with this email and let me know. Thanks, Neel Patel On Wed, Mar 6, 2013 at 11:54 AM, Ashesh Vashi ashesh.va...@enterprisedb.com wrote: On Tue, Feb 19, 2013 at 6:53 PM, Dave Page dp

Re: [pgadmin-hackers] Patch: Auto-generate search_path statement for selected schema in query editor

2013-03-25 Thread Neel Patel
at your end. Thanks, Neel Patel On Tue, Mar 19, 2013 at 11:05 PM, Dave Page dp...@pgadmin.org wrote: Hi On Mon, Mar 18, 2013 at 1:09 PM, Neel Patel neel.pa...@enterprisedb.comwrote: Hi, We have checked the bug and below is our finding. As we are getting the pane information from

Re: [pgadmin-hackers] Patch: Auto-generate search_path statement for selected schema in query editor

2013-03-26 Thread Neel Patel
Hi Dave, I will check and let you know. Thanks, Neel Patel On Tue, Mar 26, 2013 at 12:22 AM, Dave Page dp...@pgadmin.org wrote: Hi On Mon, Mar 25, 2013 at 9:02 AM, Neel Patel neel.pa...@enterprisedb.com wrote: Hi Dave, Please find the attached new patch file for fix. I have tested

Re: [pgadmin-hackers] Patch: Auto-generate search_path statement for selected schema in query editor

2013-03-28 Thread Neel Patel
, Neel Patel On Tue, Mar 26, 2013 at 2:12 PM, Neel Patel neel.pa...@enterprisedb.comwrote: Hi Dave, I will check and let you know. Thanks, Neel Patel On Tue, Mar 26, 2013 at 12:22 AM, Dave Page dp...@pgadmin.org wrote: Hi On Mon, Mar 25, 2013 at 9:02 AM, Neel Patel neel.pa

Re: [pgadmin-hackers] Patch: Auto-generate search_path statement for selected schema in query editor

2013-04-16 Thread Neel Patel
the output. Thanks, Neel Patel On Mon, Apr 8, 2013 at 8:09 PM, Dave Page dp...@pgadmin.org wrote: On Thu, Mar 28, 2013 at 12:04 PM, Neel Patel neel.pa...@enterprisedb.com wrote: Hi Dave, I looked in the code and attached is the updated patch. I have tested with my environment

Re: [pgadmin-hackers]

2013-05-22 Thread Neel Patel
Hi Dave, Sorry forgot to add the flag wxFLP_USE_TEXTCTRL at two places in dlgServer.xrc file . so attached updated patch file. Thanks, Neel Patel On Wed, May 22, 2013 at 4:35 PM, Neel Patel neel.pa...@enterprisedb.comwrote: Hi Dave, Rohit found one crash while we add the servers

Re: [pgadmin-hackers]

2013-05-22 Thread Neel Patel
Hi Dave, Please find the patch for 1.16 branch. Thanks, Neel Patel On Wed, May 22, 2013 at 5:27 PM, Ashesh Vashi ashesh.va...@enterprisedb.com wrote: Probably because of the sshtunnel changes in the master. You should have done it in reverse. :P On Wed, May 22, 2013 at 5:25 PM, Dave

Re: [pgadmin-hackers] Materialized View Patch File

2013-06-03 Thread Neel Patel
On Mon, Jun 3, 2013 at 5:20 PM, Dave Page dave.p...@enterprisedb.comwrote: Hi On Mon, Jun 3, 2013 at 7:56 AM, Neel Patel neel.pa...@enterprisedb.com wrote: Hi Dave, Thanks for update. Yes it is a bug, I have not put the version check. Below are the changes. --- Put the PG

Re: [pgadmin-hackers] Materialized View Patch File

2013-06-10 Thread Neel Patel
view 2. Table 3. Toast Table Please suggest. Thanks, Neel Patel On Wed, Jun 5, 2013 at 1:20 PM, Neel Patel neel.pa...@enterprisedb.comwrote: Hi Dave, Please find the patch in attachement with below changes. --- Changed the UI design and make it consistence with dlgTable. When user creates

Re: [pgadmin-hackers] Materialized View Patch File

2013-06-19 Thread Neel Patel
under database. Step 2:- Create new table under newly created schema Step 3:- Create new materialized view and give in definition new_schema.new_table Step 4:- Click on the materialized view and check properties and SQL Pane. Please find attached patch for fix. Thanks, Neel Patel On Tue, Jun 18

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-01 Thread Neel Patel
Hi Dave, Find the attached patch file ( it is on top of master branch ) for change in icon of materialized view in pgAdmin and also put the icon images attached in pgadmin/include/images folder. Please let me know in case of any issue. Thanks, Neel Patel On Wed, Jun 19, 2013 at 8:46 PM, Dave

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-02 Thread Neel Patel
. Thanks, Neel Patel On Mon, Jul 1, 2013 at 5:30 PM, Neel Patel neel.pa...@enterprisedb.comwrote: Hi Dave, Find the attached patch file ( it is on top of master branch ) for change in icon of materialized view in pgAdmin and also put the icon images attached in pgadmin/include/images folder

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-03 Thread Neel Patel
-GetConnection()-BackendMinimumVersion(9, 3)) Please let me know for further comments. Thanks, Neel Patel On Tue, Jul 2, 2013 at 8:06 PM, Dave Page dave.p...@enterprisedb.comwrote: Hi On Tue, Jul 2, 2013 at 3:25 PM, Thom Brown t...@linux.com wrote: On 29 May 2013 10:40, Neel Patel neel.pa

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-16 Thread Neel Patel
Hi Dave, I think we missed to commit the below bug fix for materialized view. Thanks, Neel Patel On Tue, Jul 2, 2013 at 12:42 PM, Neel Patel neel.pa...@enterprisedb.comwrote: Hi Dave, Attached patch contains the fix for the below bug for materialized view in pgAdmin. If create any

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-16 Thread Neel Patel
MATERIALIZED VIEW Steps: 1. Install PostgreSQL 9.3 beta 2 2. Launch pgAdmin III 3. and create this view from SQL editor CREATE MATERIALIZED VIEW public.z a AS select * from emp WITH DATA; 4. created successfully. 5. Click on SQL pane Thanks, Neel Patel On Tue, Jul 16, 2013 at 7:23 PM, Neel Patel

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-17 Thread Neel Patel
Hi Dave, Yes, you are right. I also found one bug because of this fix where information is not correct in the SQL Pane. I will check and will send you the updated patch. Thanks, Neel Patel On Wed, Jul 17, 2013 at 1:45 PM, Dave Page dave.p...@enterprisedb.comwrote: Hi On Tue, Jul 16, 2013

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-17 Thread Neel Patel
( AND schemaname = ) + qtDbString(this-GetSchema()-GetName()); Is it correct ? Thanks, Neel Patel On Wed, Jul 17, 2013 at 1:57 PM, Neel Patel neel.pa...@enterprisedb.comwrote: Hi Dave, Yes, you are right. I also found one bug because of this fix where information is not correct in the SQL

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-17 Thread Neel Patel
Hi Dave, Please find the updated patch with modification in query. Thanks, Neel Patel On Wed, Jul 17, 2013 at 5:15 PM, Dave Page dave.p...@enterprisedb.comwrote: On Wed, Jul 17, 2013 at 12:23 PM, Neel Patel neel.pa...@enterprisedb.com wrote: Hi Dave, Just want to know. Now we

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-19 Thread Neel Patel
Hi Dave, Thanks for the comment. We made the changes as you suggested. Please find the updated patch in attachment and let me know if you have any query. Thanks, Neel Patel On Thu, Jul 18, 2013 at 5:54 PM, Dave Page dave.p...@enterprisedb.comwrote: Hi I realised this code is all wonky

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-19 Thread Neel Patel
Thanks Dave. On Fri, Jul 19, 2013 at 2:43 PM, Dave Page dave.p...@enterprisedb.comwrote: Thanks, patch applied. On Fri, Jul 19, 2013 at 7:21 AM, Neel Patel neel.pa...@enterprisedb.com wrote: Hi Dave, Thanks for the comment. We made the changes as you suggested. Please find

[pgadmin-hackers] Possible crash fix for xmlCleanupParser

2013-08-12 Thread Neel Patel
or plugin still using the libxml2. http://xmlsoft.org/html/libxml-parser.html#xmlCleanupParser Kindly review it and let me know for any modification. Thanks, Neel Patel xmlParser.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes

[pgadmin-hackers] Fixed pgAdmin crash issue

2013-09-10 Thread Neel Patel
the process is once we get the callback of EndProcess not in Abort() method so changed it accordingly. Kindly let me know for any modification. Thanks, Neel Patel pgAdminCrashIssue.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make

[pgadmin-hackers] Fix for Slony replication issue in pgAdmin

2013-09-17 Thread Neel Patel
p, pg_namespace n WHERE t.tgfoid = p.oid AND p.pronamespace = n.oid AND n.nspname = '_slonycluster2'; Please let me know for any modification. Thanks, Neel Patel SlonyFix.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes

[pgadmin-hackers] Slony Issue Fix in pgAdmin

2013-09-24 Thread Neel Patel
. Please review it and let me know for any modifications. Thanks, Neel Patel Slony_Fix.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Slony Issue Fix in pgAdmin

2013-09-26 Thread Neel Patel
Patel On Wed, Sep 25, 2013 at 7:50 PM, Dave Page dave.p...@enterprisedb.comwrote: Hi On Tue, Sep 24, 2013 at 12:24 PM, Neel Patel neel.pa...@enterprisedb.com wrote: Hi Dave, Please find the attached patch file for fix of below slony issue in pgAdmin. Steps to reproduce:- - Install

Re: [pgadmin-hackers] Slony Issue Fix in pgAdmin

2013-09-26 Thread Neel Patel
Thanks Dave. Thanks, Neel Patel On Thu, Sep 26, 2013 at 2:42 PM, Dave Page dave.p...@enterprisedb.comwrote: Thanks, applied for 1.18.1+. On Thu, Sep 26, 2013 at 9:01 AM, Neel Patel neel.pa...@enterprisedb.com wrote: Hi Dave, Thanks for the comment. We changed the logic as below

Re: [pgadmin-hackers] Regarding storenode in Slony

2013-10-14 Thread Neel Patel
Hi Ashesh, On Mon, Oct 14, 2013 at 6:28 PM, Ashesh Vashi ashesh.va...@enterprisedb.com wrote: On 14 Oct 2013 18:21, Neel Patel neel.pa...@enterprisedb.com wrote: Hi, As per the slony documentation and code storenode API requires below two arguments. storenode(p_no_comment

Re: [pgadmin-hackers] [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3

2013-10-22 Thread Neel Patel
argument in slony version 1.1 and 1.2 but in slony version 2.0 onwards it contains only two arguments so that issue also fixed. As per our knowledge we have tested this patch in slony 2.2.0 with PG 9.3. Can anyone please test this patch and let us know if any bugs. Thanks, Neel Patel

Re: [pgadmin-hackers] [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3

2013-10-22 Thread Neel Patel
Hi Sven, Download pgadmin source code, apply this new patch and compile the source code. To test this you have to build the development environment required by pgadmin. Thanks, Neel Patel On Tue, Oct 22, 2013 at 5:37 PM, Sven Meirsman sven.meirs...@gmail.comwrote: Neel, Thanks

Re: [pgadmin-hackers] [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3

2013-10-23 Thread Neel Patel
Hi, Once we complete the testing and code review, we will commit the code and it will be available in next pgAdmin release but don't know about the next release of pgAdmin. Thanks, Neel Patel On Tue, Oct 22, 2013 at 11:42 PM, Sven Meirsman sven.meirs...@gmail.comwrote: Neel, I do not have

Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-10-23 Thread Neel Patel
be modified according to new changes. 5) In Execute() method in Job.cpp file, we should have to delete steps from wherever we are returning otherwise it will create the memory leak. Thanks, Neel Patel On Fri, Oct 18, 2013 at 5:35 PM, Dave Page dp...@pgadmin.org wrote: Neel, can you review this patch

Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-10-24 Thread Neel Patel
Hi, On Thu, Oct 24, 2013 at 3:03 PM, Dave Page dp...@pgadmin.org wrote: On Thu, Oct 24, 2013 at 10:29 AM, Linreg lin...@gmx.net wrote: Am Donnerstag, 24. Oktober 2013, 11:11:21 schrieb Neel Patel: Hi, Below are the review comments. Compile and tested in Linux. 1) During

Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-10-25 Thread Neel Patel
Hi, On Thu, Oct 24, 2013 at 2:59 PM, Linreg lin...@gmx.net wrote: ** Am Donnerstag, 24. Oktober 2013, 11:11:21 schrieb Neel Patel: Hi, Below are the review comments. Compile and tested in Linux. 1) During compilation we got the following error in connection.h error

Re: [pgadmin-hackers] pgAgent: C++ Port - Patch Review

2013-10-25 Thread Neel Patel
Hi, One more thing we forgot to add. Windows part is not working. @Thomas: Are you going to fix windows part along with this review comments and send the updated patch ? Thanks, Neel Patel On Fri, Oct 25, 2013 at 12:04 PM, Neel Patel neel.pa...@enterprisedb.comwrote: Hi, On Thu, Oct 24

Re: [pgadmin-hackers] [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3

2013-10-30 Thread Neel Patel
Hi, Thanks Ashesh. I will check and let you know. Thanks, Neel Patel On Wed, Oct 30, 2013 at 5:19 PM, Ashesh Vashi ashesh.va...@enterprisedb.com wrote: Hi Neel, I test the patch with following slony-I versions: 1.2.27 (not working with PG 9.0) 2.0.x(not picking correct

[pgadmin-hackers] wxWidgets 3.0 support in pgAdmin

2014-01-20 Thread Neel Patel
us know for any error during the run time while playing with GUI ? Thanks, Neel Patel pgAdmin_wxWidgets_3_0.tgz Description: GNU Zip compressed data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [pgadmin-hackers] wxWidgets 3.0 support in pgAdmin

2014-01-20 Thread Neel Patel
Hi Dave, I have attached the .tgz file that contains two patch files separately. Please let me know if something is missing. Thanks, Neel Patel On Mon, Jan 20, 2014 at 9:59 PM, Dave Page dp...@pgadmin.org wrote: Hi On Mon, Jan 20, 2014 at 1:09 PM, Neel Patel neel.pa...@enterprisedb.com

Re: [pgadmin-hackers] wxWidgets 3.0 support in pgAdmin

2014-01-27 Thread Neel Patel
Thanks Dave. On Mon, Jan 27, 2014 at 5:04 PM, Dave Page dp...@pgadmin.org wrote: Thanks, both patches applied. On Tue, Jan 21, 2014 at 5:15 AM, Neel Patel neel.pa...@enterprisedb.com wrote: Hi Dave, I have attached the .tgz file that contains two patch files separately. Please let

Re: [pgadmin-hackers] Compiling on El Capitan with Home Brew?

2016-01-05 Thread Neel Patel
r with Qt 4 environment then send us the patch file with fix. It will be good start to contribute to the community. Thanks, Neel Patel On Wed, Jan 6, 2016 at 1:06 AM, Lorin Rivers <lriv...@mosasaur.com> wrote: > qmake gives me an error: > /Users/lrivers/Documents/CurrentProjects/Progra

Re: [pgadmin-hackers] pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390

2016-01-05 Thread Neel Patel
Hi Dave, Sure, I will look into this issue. Thanks, Neel Patel On Tue, Jan 5, 2016 at 4:47 PM, Dave Page <dp...@pgadmin.org> wrote: > Neel, can you look at this please? > > Thanks. > > On Tue, Jan 5, 2016 at 11:01 AM, Nikolai Zhubr <n-a-zh...@yandex.ru> > wrot

Re: [pgadmin-hackers] pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390

2016-01-05 Thread Neel Patel
Hi, Please find attached patch file with below fix. - Return value of the function will be displayed as "SETOF record" instead of "SETOF SETOF record" under SQL tab within properties window. Let me know for any comments. Thanks, Neel Patel On Tue, Jan 5, 2016 at 5:08 PM,

Re: [pgadmin-hackers] pgAdmin3: check_option translated in View editing dialog

2015-12-23 Thread Neel Patel
Hi Dave, Sure. I will look into this issue. Thanks, Neel Patel On Wed, Dec 23, 2015 at 7:04 PM, Dave Page <dp...@pgadmin.org> wrote: > Neel, can you look into this please? > > Thanks. > > On Wed, Dec 23, 2015 at 1:25 PM, Sebastian Albert > <alb...@math.uni-goettinge

Re: [pgadmin-hackers] pgAdmin3: check_option translated in View editing dialog

2015-12-28 Thread Neel Patel
Hi Dave, I have fixed the issue. Can you please review the attached patch file ? Let me know for any comments. @Sebastian - Can you please apply and test the attached patch file ? Let us know for any issue. Thanks, Neel Patel On Thu, Dec 24, 2015 at 5:44 PM, Neel Patel <neel

Re: [pgadmin-hackers] pgAdmin3: check_option translated in View editing dialog

2015-12-24 Thread Neel Patel
to change in option, we are able to see and edit the query. Let me know if anything missing in above steps or Can you please give steps to understand the issue ? Thanks, Neel Patel On Wed, Dec 23, 2015 at 7:09 PM, Neel Patel <neel.pa...@enterprisedb.com> wrote: > Hi Dave, &g

Re: [pgadmin-hackers] pgAdmin3: check_option translated in View editing dialog

2015-12-24 Thread Neel Patel
Hi Sebastian, Thank you for the information. Issue is reproduced with the given steps. I will submit the patch after the fix. Thanks, Neel Patel On Thu, Dec 24, 2015 at 5:28 PM, Sebastian Albert < alb...@math.uni-goettingen.de> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: S

Re: [pgadmin-hackers] [pgadmin-support] Unable to change variable of role on OS X 10.11

2016-01-13 Thread Neel Patel
Hi, Please find the patch file for fix of above mentioned issue. Do let us know for any comments. Thanks, Neel Patel On Tue, Jan 12, 2016 at 11:22 PM, Axel Rau <axel@chaos1.de> wrote: > Hi, > > thanks for maintaining pgAdmin3. > > I tried to change a variable of a logi

Re: [pgadmin-hackers] [pgadmin-support] Unable to change variable of role on OS X 10.11

2016-01-13 Thread Neel Patel
Patel On Wed, Jan 13, 2016 at 6:31 PM, Neel Patel <neel.pa...@enterprisedb.com> wrote: > Hi, > > Please find the patch file for fix of above mentioned issue. > Do let us know for any comments. > > Thanks, > Neel Patel > > On Tue, Jan 12, 2016 at 11:22 PM, Axel Rau &l

[pgadmin-hackers] [pgAdmin4][runtime]: Fix #1310 - Application icon missing from runtime

2016-06-08 Thread Neel Patel
file. Qt 4 :- We need to create pgAdmin4.rc file which contains pgAdmin4.ico file path to RC_FILE flag and we have to add this flag to Qt project file. Do let us know for comments. Thanks, Neel Patel window_application_icon.patch Description: Binary data -- Sent via pgadmin-hackers mailing

[pgadmin-hackers] [pgAdmin4][Debugger][Patch]: RM-1225 - Debugger start error if function contains special characters

2016-06-04 Thread Neel Patel
s. Thanks, Neel Patel RM_1225.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][runtime]: Checkbox and radiobutton rendering issue on Mac OS

2016-06-01 Thread Neel Patel
Hi, We have observed that Checkbox and RadioButtons are not painted properly on QWebView widget when we run pgAdmin4 in desktop mode in Mac OS. Please find attached patch file for the fix. Do review it and let us know for comments. Thanks, Neel Patel runtime_issue_checkbox.patch Description

[pgadmin-hackers] [pgAdmin4][runtime]: RM 1186 - Query tool and debugger rendering issue in Linux

2016-06-21 Thread Neel Patel
set '-webkit-transform' property to 'none' for .ajs-notifier, .ajs-message, .ajs-modal classes. Do review it and let us know for comments. Thanks, Neel Patel RM_1186_v2.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes

Re: [pgadmin-hackers] [pgAdmin4][debugger]: RM #1354 & RM #1323

2016-06-19 Thread Neel Patel
Hi Dave, make sense. We should ensure that operations happen sequentially. Please find attached patch file for the fix. Thanks, Neel Patel On Sat, Jun 18, 2016 at 8:40 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > Isn't any solution that relies on artificial delays likely

[pgadmin-hackers] [pgAdmin4][debugger]: RM #1354 & RM #1323

2016-06-18 Thread Neel Patel
t and let us know for comments. Thanks, Neel Patel RM_1354_1323.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4] - Desktop runtime patch

2016-01-15 Thread Neel Patel
the version of python 2 and python 3. Qt5 is recommended to test pgAdmin4 in dektop mode. Attached patch is applied and tested on Linux, do let us know for any comments/issues. Thanks, Neel Patel pgAdmin4_runtime_new.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin

Re: [pgadmin-hackers] Unable to update Domain properly

2016-01-13 Thread Neel Patel
long with domain name. Thanks Khushboo for point out the issue. Thanks, Neel Patel On Wed, Jan 13, 2016 at 10:57 PM, Neel Patel <neel.pa...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch file for fix of above issue. > > *Issue:- * > Below generated SQL w

Re: [pgadmin-hackers] Unable to update Domain properly

2016-01-13 Thread Neel Patel
DROP NOT NULL; Please review it and do let us know for any comment. Thanks, Neel Patel On Wed, Jan 13, 2016 at 6:43 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > While updating Domain from pgAdmin-III , I observed an error. > > When I update only Doma

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

2016-01-18 Thread Neel Patel
with caching mechanism. 7. When we remove the schema_name during the "Edit" operation then wrong SQL is getting generated. 8. Remove "Use Slony" option. As discussed with Ashesh, we will implement it as separate module. Please fix the above issues. Let us know if you wan

Re: [pgadmin-hackers] PATCH: added "Collation" & "Catalog Objects" nodes in pgAdmin4

2016-01-18 Thread Neel Patel
sign in one variable and use that variable in all the places. Do let us know for any comments/issues. Thanks, Neel Patel On Wed, Jan 6, 2016 at 6:10 PM, Dave Page <dp...@pgadmin.org> wrote: > On Wed, Jan 6, 2016 at 12:18 PM, Murtuza Zabuawala > <murtuza.zabuaw...@en

Re: [pgadmin-hackers] [pgadmin-support] [pgAdmin4] - Desktop runtime patch

2016-01-18 Thread Neel Patel
Thanks Dave. I will test on Windows and Linux and keep you updated. Thanks, Neel Patel On Mon, Jan 18, 2016 at 8:07 PM, Dave Page <dp...@pgadmin.org> wrote: > Thanks Neel. I've committed this with various minor tweaks, mostly > around the tab button text and sizing. > > Plea

Re: [pgadmin-hackers] Updated patches

2016-02-04 Thread Neel Patel
Hi, New database patch is working fine. Ashesh - Can you please review it ? If it looks good then can you please commit ? Thanks, Neel Patel On Thu, Feb 4, 2016 at 6:35 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for database node.

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

2016-02-04 Thread Neel Patel
Hi Team, New Tablespace patch is working fine. If it looks good then we can commit the code. Thanks, Neel Patel On Thu, Feb 4, 2016 at 7:44 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch, Corrected a typo in sql panel. > &g

Re: [pgadmin-hackers] PATCH: Schema/Catalog Node [pgAdmin4]

2016-02-10 Thread Neel Patel
catalog node. ERROR pgadmin: Failed to execute query (execute_2darray) for the server #3 - DB:postgres (Query-id: 1019298): Error Message:relation "pg_shseclabel" does not exist LINE 11: ... (SELECT array_agg(provider || '=' || label) FROM pg_shsecla... Thanks, Neel Patel

[pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

2016-02-05 Thread Neel Patel
Hi All, Please find attached patch file that include the below three nodes under the database node. - Foreign Data Wrappers - Foreign Servers - User Mappings Do review it and let me know for any comments. Thanks, Neel Patel foreign_data_wrapper_v1.patch Description: Binary data

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Resource Group Module

2016-02-07 Thread Neel Patel
uired positional argument: 'label'*". - Valid range for CPU Rate Limit and Dirty Rate Limit is from 0 to 1.67772e+07. We are not able to enter the maximum limit value while creating the resource group. Thanks, Neel Patel On Fri, Feb 5, 2016 at 6:15 PM, Akshay Joshi <akshay.jo...@enterprisedb

[pgadmin-hackers] [pgAdmin4] - Runtime compilation error

2016-01-25 Thread Neel Patel
d in Linux and Mac. Please review it and let us know for any comments. Thanks, Neel Patel Autohide_tab_fix.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin 4 commit: Update the runtime to properly support Windows.

2016-02-02 Thread Neel Patel
and let us know for any comments. Thanks, Neel Patel On Tue, Feb 2, 2016 at 6:46 PM, Dave Page <dp...@pgadmin.org> wrote: > Update the runtime to properly support Windows. > > Branch > -- > master > > Details > --- > > http://git.postg

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

2016-02-03 Thread Neel Patel
Hi, New patch looks good to me. All the features are working fine. Ashesh - If possible, can you please review it ?. if it looks good then you can commit it. Thanks, Neel Patel On Wed, Feb 3, 2016 at 3:41 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Neel, &

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

2016-02-03 Thread Neel Patel
e Query :- * ALTER TABLESPACE "1 tb" RESET (random_page_cost); ALTER TABLESPACE "1 tb" RESET (seq_page_cost); * Single Query :- * ALTER TABLESPACE "1 tb" RESET (random_page_cost, seq_page_cost); Other functionalities are working fine. Let us

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-02-03 Thread Neel Patel
hema name along with domain name. *Wrong Query :- * SECURITY LABEL FOR pv_label ON DOMAIN test_123 IS 'label_val'; Correct Query :- SECURITY LABEL FOR pv_label ON DOMAIN .test_123 IS 'label_val'; Let us know in case of any issues. Thanks, Neel Patel On Tue, Feb 2, 2016 a

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

2016-02-03 Thread Neel Patel
Hi, New patch is working fine. Ashesh - Can you please review it? If it looks good then we can commit the extension module. Thanks, Neel Patel On Thu, Feb 4, 2016 at 11:40 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Neel, > > Please find the patch with fo

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

2016-02-03 Thread Neel Patel
. Can you please resend the patch file, after fixing above warnings ? Thanks, Neel Patel On Fri, Jan 22, 2016 at 12:25 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Please find the updated patch with following fixes: > 1. Missing `owner` colum

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

2016-02-03 Thread Neel Patel
Thank you Murtuza. New patch is working fine with all supported PG version. We should use this latest tablespace patch. Ashesh - Can you please review it ? If It looks good then we should commit this patch. Thanks, Neel Patel On Thu, Feb 4, 2016 at 12:36 PM, Murtuza Zabuawala < murtuza.zab

Re: [pgadmin-hackers] Updated patches

2016-02-01 Thread Neel Patel
ange the database properties from "Properties" panel. - In "Security" tab, After adding new privilege, we are not able to add the second privilege due to scroll bar issue. - After clicking on "Add" button in security tab, "Save" button is getting disabled so we a

Re: [pgadmin-hackers] Updated patches

2016-02-02 Thread Neel Patel
rivileges are not getting displayed when we select any database node in Properties panel. - When the database is already disconnected and when user again perform "Disconnect database" then it gives python error in backend saying " *NameError: **name 'unauthorized' is not defined*". -

[pgadmin-hackers] Fixed runtime compilation error for Qt4

2016-02-22 Thread Neel Patel
ted in both the versions Qt4 and Qt5 and now it is compiling without any errors. Do review it and let us know in case of any comments/queries. Thanks, Neel Patel runtime_compilation_error_fix.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hacker

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-01-20 Thread Neel Patel
he related SQL files. e.g. - In update.sql file "data.owner" should be "conn|qtIdent(data.owner)" {% if data.owner %} ALTER DOMAIN {{ conn|qtIdent(o_data.basensp, name) }} OWNER TO {{ data.owner }}; {% endif %} Let us know for any issues. Thanks, Neel Patel On We

Re: [pgadmin-hackers] patch for cast module

2016-01-19 Thread Neel Patel
f it is not required. - Remove commented code from the source file. Please check all the generated SQL statements . Test the basic functionality of "create", "Edit" and "Delete" node before sending patch file. Do let us know for any comments/issues. Thanks, Neel Pa

Re: [pgadmin-hackers] Observed bug in pgAdmin3

2016-01-24 Thread Neel Patel
. Review it and let us know for any comments. Thanks, Neel Patel On Mon, Jan 4, 2016 at 12:28 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi All, > > I observed an issue while creating new collation (in schemas). > > Steps to reproduce, > 1) Connect

Re: [pgadmin-hackers] [pgAdmin3][Extension]: Wrong SQL generated

2016-01-24 Thread Neel Patel
file. Do review it and let us know for any comments. Thanks, Neel Patel On Mon, Jan 18, 2016 at 4:33 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi all, > > > While implementing Extension module in pgAdmin4, I came to know that there > is an bug in pgadmi

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Resource Group Module

2016-02-14 Thread Neel Patel
tly it allows to enter invalid character so we are getting below SQL error saying "*LINE 2: SET cpu_rate_limit = 4545, dirty_rate_limit = gfgf;*" Both above errors are due to not validated "CPU Rate Limit" and "Dirty Rate Limit" fields. Thanks, Neel Pa

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

2016-02-18 Thread Neel Patel
Hi Dave, I re-tested and reviewed the attached patch and it is working perfectly. Thank you Sergey for the patch. Thanks, Neel Patel On Thu, Feb 18, 2016 at 9:08 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi Sergey > > That works perfectly for me! I've made a minor change

[pgadmin-hackers] [pgAdmin4][psycopg2] - poll function local variable reference error

2016-03-15 Thread Neel Patel
" Attached is the patch that resolves the above error. Do review it and let us know for comments. Thanks, Neel Patel poll_local_var_error.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.p

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

2016-03-11 Thread Neel Patel
Page <dp...@pgadmin.org> wrote: > Hi > > On Thu, Mar 10, 2016 at 4:58 PM, Neel Patel <neel.pa...@enterprisedb.com> > wrote: > > Hi Dave, > > > > Please find attached patch file with all the fixes. > > Let us know for any comments. > > I just spent

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

2016-03-11 Thread Neel Patel
Hi Dave, New patch file gives another kind of error. Attached is the error log file for the reference. Anyway, I will use first patch file by giving command "patch -p1 " which is working and manually copy the image files. Thanks, Neel Patel On Fri, Mar 11, 2016 at 6:51 PM, Dav

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-06 Thread Neel Patel
blank panel ? - Can you please share request/response of last request URL sent to server in browser ? Thanks, Neel Patel On Tue, Apr 5, 2016 at 9:59 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Tue, Apr 5, 2016 at 12:40 PM, Neel Patel <neel.pa...@e

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-06 Thread Neel Patel
folder. - Start the server. - Now click on the "Debug" context menu and add requirement input. After clicking on the debug button on the input dialog send us the pgAdmin4.log file. Thanks, Neel Patel On Wed, Apr 6, 2016 at 11:38 AM, Neel Patel <neel.pa...@enterpris

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-06 Thread Neel Patel
r. pgBrowser.Events.trigger('pgadmin-browser:frame:urlloaded:' + that.name, frame, that.url, self); Do let us know if you still face the same issue. Thanks, Neel Patel On Wed, Apr 6, 2016 at 12:07 PM, Neel Patel <neel.pa...@enterprisedb.com> wrote: > Hi Dave, > > Updated above informa

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-06 Thread Neel Patel
Hi Dave, Updated above information. We want this pgadmin4 log information to debug the debugger blank tab open issue. Thanks, Neel Patel On Wed, Apr 6, 2016 at 11:50 AM, Neel Patel <neel.pa...@enterprisedb.com> wrote: > One more additional information. > > Follow the below st

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

2016-03-19 Thread Neel Patel
Thank you dave for the change. In Version 6 patch file, I made the same change but don't know why were you not be able to see the object type with space ( may be depends.js was not updated ). After your comment i thought you want with underscore so i again change the logic. :) Thanks, Neel Patel

[pgadmin-hackers] [pgAdmin4][psycopg2] - Modified status message implementation

2016-04-04 Thread Neel Patel
s messages then they have to call "status_message()" which will return the status message text. Do review it and let us know for any comments. Thanks, Neel Patel psycopg2_status_message.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.

Re: [pgadmin-hackers] Server side session management using the SQLite (per session) database

2016-03-23 Thread Neel Patel
Hi, I just tested the latest code under windows environment with python 2.7 which is working fine without any errors. Thanks, Neel Patel On Wed, Mar 23, 2016 at 1:02 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com > wrote: > On Tue, Mar 22, 2016 at 8:41 PM, Dave Page <dp...@pgadmi

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-25 Thread Neel Patel
eMirror.pgadminLoopRangeFinder, CodeMirror.pgadminCaseRangeFinder) }, *gutters*: ["CodeMirror-foldgutter"] Do review it and let us know for comments. Thanks, Neel Patel On Wed, Apr 20, 2016 at 6:32 PM, Dave Page <dp...@pgadmin.org> wrote: > Thanks - appl

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

2016-04-29 Thread Neel Patel
ABLE TRIGGER [ trigger_name | ALL | USER ] 4. ENABLE REPLICA TRIGGER trigger_name 5. ENABLE ALWAYS TRIGGER trigger_name 6. SET WITH OIDS 7. SET WITHOUT OIDS Do let us know in case of any queries. Thanks, Neel Pate

Re: [pgadmin-hackers][pgAdmin4][Patch]: File Manager & Backform FileControl

2016-04-28 Thread Neel Patel
. "Delete" button is enabled even though we have not selected the files/folder to delete and when we click on the "Delete" button it gives below error. TypeError: path is undefined Do let us know if you have queries. Thanks, Neel Patel On Wed, Apr 27, 2016 at 9:15 PM, Neel Pa

Re: [pgadmin-hackers][pgAdmin4][Patch]: File Manager & Backform FileControl

2016-04-27 Thread Neel Patel
mport" dialog and observed that new control is getting added in new tab called "General". I think it should not create the new "General" tab. - "Select" and "Cancel" buttons font is different then other dialogs. Thanks, Neel Patel On Wed, Apr

[pgadmin-hackers] [pgAdmin4][runtime]: Web Inspect feature in desktop application in debug mode

2016-05-19 Thread Neel Patel
oper tools in browser. Do review it and let us know for comments. Thanks, Neel Patel runtime_inspect_option_feature.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin][runtime]: Panel content is not displayed in debugger and query tool

2016-05-19 Thread Neel Patel
the debugger, then panel will able to display the content of the function to debug but once the execution completed then again panel content set to blank. So i will send the patch specific to this issue later. Thanks, Neel Patel runtime_querytool_debugger_fix.patch Description: Binary data -- Sent

[pgadmin-hackers] [pgAdmin4]: Query tool and debugger height issue

2016-05-23 Thread Neel Patel
;a=commitdiff;h=9a832086c5c4c0dda51c43edd7fc4f40dda63a0c Please find attached fix. Now query tool and debugger will open in both browser windows and runtime environment. Do review it and let us know for comments. Thanks, Neel Patel debugger_query_tool_height_issue.patch Description: Binary data

Re: [pgadmin-hackers] [pgAdmin4]: Initial patch for Import table

2016-05-17 Thread Neel Patel
Hi, I have fixed some of the issues observed during testing and as per your feedback added "Export" functionality as well. I have tested it on both linux and windows and it is working. Please find attached updated patch. Do review it and let me know for any modifications. Thanks,

[pgadmin-hackers] [pgAdmin4][patch] : cStringIO and StringIO module compatibility in python

2016-05-12 Thread Neel Patel
Hi, Please find attached minor patch file to fix the import error regarding the StringIO module in python2 and python3. As StringIO and cStringIO module is no more exist in python3. Do review it and let us know for comments. Thanks, Neel Patel stringIO.patch Description: Binary data

  1   2   >