Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

2016-03-19 Thread Neel Patel
Thank you dave for the change. In Version 6 patch file, I made the same change but don't know why were you not be able to see the object type with space ( may be depends.js was not updated ). After your comment i thought you want with underscore so i again change the logic. :) Thanks, Neel

Re: [pgadmin-hackers] Server side session management using the SQLite (per session) database

2016-03-23 Thread Neel Patel
Hi, I just tested the latest code under windows environment with python 2.7 which is working fine without any errors. Thanks, Neel Patel On Wed, Mar 23, 2016 at 1:02 PM, Ashesh Vashi wrote: > On Tue, Mar 22, 2016 at 8:41 PM, Dave Page wrote: > >> Hi >> >> On Thu,

[pgadmin-hackers] [pgAdmin4][psycopg2] - Modified status message implementation

2016-04-04 Thread Neel Patel
sages then they have to call "status_message()" which will return the status message text. Do review it and let us know for any comments. Thanks, Neel Patel psycopg2_status_message.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-05 Thread Neel Patel
en ? Only blank panel ? - Can you please share request/response of last request URL sent to server in browser ? Thanks, Neel Patel On Tue, Apr 5, 2016 at 9:59 PM, Dave Page wrote: > Hi > > On Tue, Apr 5, 2016 at 12:40 PM, Neel Patel > wrote: > > Hi, > > > >

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-05 Thread Neel Patel
folder. - Start the server. - Now click on the "Debug" context menu and add requirement input. After clicking on the debug button on the input dialog send us the pgAdmin4.log file. Thanks, Neel Patel On Wed, Apr 6, 2016 at 11:38 AM, Neel Patel wrote: > Hi Dave, >

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-05 Thread Neel Patel
Hi Dave, Updated above information. We want this pgadmin4 log information to debug the debugger blank tab open issue. Thanks, Neel Patel On Wed, Apr 6, 2016 at 11:50 AM, Neel Patel wrote: > One more additional information. > > Follow the below steps and send us pgAdmin4

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-06 Thread Neel Patel
by debugger. pgBrowser.Events.trigger('pgadmin-browser:frame:urlloaded:' + that.name, frame, that.url, self); Do let us know if you still face the same issue. Thanks, Neel Patel On Wed, Apr 6, 2016 at 12:07 PM, Neel Patel wrote: > Hi Dave, > > Updated above information. > We

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-18 Thread Neel Patel
Hi Dave, Please find inline comments with all the fixes. Attached is the updated patch file. Do review it and let me know for any comments. If you find any issues, let me know .Now, Working on the remaining TODOs as mentioned in below email. Thanks, Neel Patel On Fri, Apr 15, 2016 at 2:09 AM

[pgadmin-hackers] [pgAdmin4][patch]: String evaluation issue

2016-04-18 Thread Neel Patel
because Jinja will evaluate the string " + err.errormsg + " before it gets evaluated as JS by the browser. *alertify.error("{{ _('" + err.errormsg + "') }}");* Do review it and let us know for any comments. Thanks, Neel Patel string_evaluate.patc

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-18 Thread Neel Patel
this patch file, we have used only 1 wcDocker instance. Do review it and let us know for comments. Thanks, Neel Patel On Mon, Apr 18, 2016 at 6:07 PM, Dave Page wrote: > Hi > > On Monday, April 18, 2016, Neel Patel wrote: > >> Hi Dave, >> >> Please find

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-25 Thread Neel Patel
or.pgadminIfRangeFinder, CodeMirror.pgadminLoopRangeFinder, CodeMirror.pgadminCaseRangeFinder) }, *gutters*: ["CodeMirror-foldgutter"] Do review it and let us know for comments. Thanks, Neel Patel On Wed, Apr 20, 2016 at 6:32 PM, Dave Page wrote: > Thanks

Re: [pgadmin-hackers][pgAdmin4][Patch]: File Manager & Backform FileControl

2016-04-27 Thread Neel Patel
in "Import" dialog and observed that new control is getting added in new tab called "General". I think it should not create the new "General" tab. - "Select" and "Cancel" buttons font is different then other dialogs. Thanks, Neel Patel O

Re: [pgadmin-hackers][pgAdmin4][Patch]: File Manager & Backform FileControl

2016-04-28 Thread Neel Patel
alue is undefined 12. "Delete" button is enabled even though we have not selected the files/folder to delete and when we click on the "Delete" button it gives below error. TypeError: path is undefined Do let us know if you have queries. Thanks, Neel Patel On Wed, Apr 27, 2016

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Foreign Table Module

2016-04-28 Thread Neel Patel
me | ALL | USER ] 3. ENABLE TRIGGER [ trigger_name | ALL | USER ] 4. ENABLE REPLICA TRIGGER trigger_name 5. ENABLE ALWAYS TRIGGER trigger_name 6. SET WITH OIDS 7. SET WITHOUT OIDS Do let us kn

[pgadmin-hackers] [pgAdmin4]: Initial patch for Import table

2016-05-05 Thread Neel Patel
Hi, Please find attached patch file which contains the table Import functionality. Attached patch file is depend on the following patch which is not committed yet. - File Manager patch - Table node patch Do review it and let us know for comments. Thanks, Neel Patel import_v1.patch

[pgadmin-hackers] [pgAdmin4]: Reload Server Configuration

2016-05-05 Thread Neel Patel
Hi, Please find attached patch file to reload the server configuration. Do review it and let me know for any comments. Thanks, Neel Patel reload_config_v1.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your

Re: [pgadmin-hackers] New committer: Akshay Joshi

2016-05-06 Thread Neel Patel
Congratulations Akshay... Well deserved... !! Thanks, Neel Patel On Fri, May 6, 2016 at 1:58 PM, Guillaume Lelarge wrote: > Le 6 mai 2016 10:25 AM, "Dave Page" a écrit : > > > > All, > > > > I'm pleased to announce that Akshay Joshi has been added

[pgadmin-hackers] [pgAdmin4]: Reload configuration Fix

2016-05-10 Thread Neel Patel
Akshay for reporting this issue. Thanks, Neel Patel reload_fix.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4]: Maintenance tool for vaccum operation

2016-05-10 Thread Neel Patel
ll complete, we will integrate this patch file. Do review it and let us know for any comments. Thanks, Neel Patel maintenance_v1.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][patch] : cStringIO and StringIO module compatibility in python

2016-05-12 Thread Neel Patel
Hi, Please find attached minor patch file to fix the import error regarding the StringIO module in python2 and python3. As StringIO and cStringIO module is no more exist in python3. Do review it and let us know for comments. Thanks, Neel Patel stringIO.patch Description: Binary data

[pgadmin-hackers] [pgAdmin4][Patch]: Pause/Resume replay of WAL functionality

2016-05-13 Thread Neel Patel
Hi, Please find the attached patch file which contains the functionality of "Pause/Resume replay of WAL". Do review it and let us know for any comments. Thanks, Neel Patel WAL_pause_resume_replay.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadm

Re: [pgadmin-hackers] [pgAdmin4]: Initial patch for Import table

2016-05-17 Thread Neel Patel
Hi, I have fixed some of the issues observed during testing and as per your feedback added "Export" functionality as well. I have tested it on both linux and windows and it is working. Please find attached updated patch. Do review it and let me know for any modifications. Thanks, Neel

[pgadmin-hackers] [pgAdmin][runtime]: Panel content is not displayed in debugger and query tool

2016-05-19 Thread Neel Patel
debugger, then panel will able to display the content of the function to debug but once the execution completed then again panel content set to blank. So i will send the patch specific to this issue later. Thanks, Neel Patel runtime_querytool_debugger_fix.patch Description: Binary data -- Sent

[pgadmin-hackers] [pgAdmin4][runtime]: Web Inspect feature in desktop application in debug mode

2016-05-19 Thread Neel Patel
r tools in browser. Do review it and let us know for comments. Thanks, Neel Patel runtime_inspect_option_feature.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4]: Query tool and debugger height issue

2016-05-22 Thread Neel Patel
=commitdiff;h=9a832086c5c4c0dda51c43edd7fc4f40dda63a0c Please find attached fix. Now query tool and debugger will open in both browser windows and runtime environment. Do review it and let us know for comments. Thanks, Neel Patel debugger_query_tool_height_issue.patch Description: Binary data

[pgadmin-hackers] [pgAdmin4][datagrid] : Fix URL generation issue in datagrid

2016-05-25 Thread Neel Patel
be in the URL not the selected table node OID. Thanks Murtuza for reporting this issue. Thanks, Neel Patel datagrid_fix.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.or

[pgadmin-hackers] [pgAdmin4][runtime]: Checkbox and radiobutton rendering issue on Mac OS

2016-06-01 Thread Neel Patel
Hi, We have observed that Checkbox and RadioButtons are not painted properly on QWebView widget when we run pgAdmin4 in desktop mode in Mac OS. Please find attached patch file for the fix. Do review it and let us know for comments. Thanks, Neel Patel runtime_issue_checkbox.patch Description

[pgadmin-hackers] [pgAdmin4][Debugger][Patch]: RM-1225 - Debugger start error if function contains special characters

2016-06-04 Thread Neel Patel
s. Thanks, Neel Patel RM_1225.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][runtime]: Fix #1310 - Application icon missing from runtime

2016-06-08 Thread Neel Patel
file. Qt 4 :- We need to create pgAdmin4.rc file which contains pgAdmin4.ico file path to RC_FILE flag and we have to add this flag to Qt project file. Do let us know for comments. Thanks, Neel Patel window_application_icon.patch Description: Binary data -- Sent via pgadmin-hackers mailing

[pgadmin-hackers] [pgAdmin4][debugger]: RM #1354 & RM #1323

2016-06-18 Thread Neel Patel
t and let us know for comments. Thanks, Neel Patel RM_1354_1323.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][debugger]: RM #1354 & RM #1323

2016-06-19 Thread Neel Patel
Hi Dave, make sense. We should ensure that operations happen sequentially. Please find attached patch file for the fix. Thanks, Neel Patel On Sat, Jun 18, 2016 at 8:40 PM, Dave Page wrote: > Hi > > Isn't any solution that relies on artificial delays likely to fail sooner > o

Re: [pgadmin-hackers] [pgAdmin4][debugger]: RM #1354 & RM #1323

2016-06-20 Thread Neel Patel
Hi Dave, Please find attached modified patch file. Do review it and let us know for comments. Thanks, Neel Patel On Mon, Jun 20, 2016 at 2:08 PM, Dave Page wrote: > Hi > > On Sun, Jun 19, 2016 at 5:50 PM, Neel Patel > wrote: > > Hi Dave, > > > > make sense. We

[pgadmin-hackers] [pgAdmin4][runtime]: RM 1186 - Query tool and debugger rendering issue in Linux

2016-06-21 Thread Neel Patel
rk, we need to explicitly set '-webkit-transform' property to 'none' for .ajs-notifier, .ajs-message, .ajs-modal classes. Do review it and let us know for comments. Thanks, Neel Patel RM_1186_v2.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadm

[pgadmin-hackers] [pgAdmin4][runtime]: Download feature in runtime

2016-06-30 Thread Neel Patel
header ? Let us know your thoughts on this feature. Please review it and let us know comments. Thanks, Neel Patel download_runtime.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][runtime]: Download feature in runtime

2016-06-30 Thread Neel Patel
Hi Dave, On Thu, Jun 30, 2016 at 7:31 PM, Dave Page wrote: > Hi > > On Thu, Jun 30, 2016 at 10:42 AM, Neel Patel > wrote: > > Hi, > > > > Please find attached patch file for initial version of download file in > > runtime application. > > I've

Re: [pgadmin-hackers] [pgAdmin4][runtime]: Download feature in runtime

2016-07-06 Thread Neel Patel
Hi Dave, I have tried to fix most of the review comments. I have modified the patch on top of your changes. Please find attached updated patch file. Find my comments inline. Can you please review and let us know your feedback ? Thanks, Neel Patel On Fri, Jul 1, 2016 at 2:39 PM, Dave Page

Re: [pgadmin-hackers] [pgAdmin4][runtime]: Download feature in runtime

2016-07-07 Thread Neel Patel
Hi Dave, Please find attached patch file for the fix of crash and comment text. Downloading cancel request was not handled properly and due to that application was getting crashed. Do review it and let us know for comments. Thanks, Neel Patel On Thu, Jul 7, 2016 at 2:13 PM, Dave Page wrote

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

2016-07-18 Thread Neel Patel
Hi Dave, Yes, it will break in runtime. If we need to support downloading at server side then we need to change the runtime code. I will send the patch for runtime to support server side download CSV file. Thanks, Neel Patel On Fri, Jul 15, 2016 at 3:05 PM, Dave Page wrote: > Hi >

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

2016-07-18 Thread Neel Patel
Yes. I am just testing with different OS. I will send it next 1-2 hour. Is it fine ? Thanks, Neel Patel On Mon, Jul 18, 2016 at 3:53 PM, Dave Page wrote: > Any chance of getting that in the next couple of hours so I can get it > into beta 3? > > On Mon, Jul 18, 2016 at 11:18 A

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

2016-07-18 Thread Neel Patel
Hi, Please find attached patch file to support server side download in runtime application. NOTE: Before applying this patch, use above harshal's patch. Thanks, Neel Patel On Mon, Jul 18, 2016 at 5:31 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > &g

[pgadmin-hackers] [pgAdmin4][runtime][patch]: Compilation error with Qt4

2016-07-23 Thread Neel Patel
ete sender object inside slot. If we do so it may crash the application. To avoid this, we used Qt's "deleteLater" which will delete the objects once the processing of all the events have been done. Do review it and let us know for comments. Thanks, Neel Patel runtim

[pgadmin-hackers] [pgAdmin4][patch]: Fix for RM 1320

2016-07-24 Thread Neel Patel
Hi, Please find attached patch file for the fix of RM- 1320. RM-1320 - Unable to create foreign data wrapper when user change the schema of extension 'postgres_fdw_handler'. Thanks, Neel Patel RM_1320.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadm

Re: [pgadmin-hackers] [pgAdmin4][patch]: Fix for RM 1320

2016-07-24 Thread Neel Patel
fdw handler 'postgres_fdw_handler' under schema 'test' then we should display the handler name under fdw as "test. postgres_fdw_handler". *Solution:-* With this patch, we have added . so while creating or updating the fdw, proper sql will be generated. Thanks, Nee

[pgadmin-hackers] [pgAdmin4][runtime][patch]: Runtime not working in all platform

2016-08-08 Thread Neel Patel
f78024808e80fef67de1aef5c97d1756c6771c0e It is working in browser but Qt's web engine is not able to handle the error and goes into infinite loop of paint event which may crash the pgAdmin4 application. Can you please review and commit this patch ? Thanks, Neel Patel runtime_issue.

Re: [pgadmin-hackers] pgAdmin 4 as Web application

2016-08-08 Thread Neel Patel
kit). Thanks, Neel Patel On Mon, Aug 8, 2016 at 8:37 PM, Albe Laurenz wrote: > I'm trying to follow > https://www.pgadmin.org/docs4/dev/server_deployment.html > to install pgAdmin 4 as web application on RHEL 6, but I didn't get very > far: > > There is no fil

Re: [pgadmin-hackers] pgAdmin 4 as Web application

2016-08-09 Thread Neel Patel
- Qt version is detected as 5 but you are compiling against Qt 4 so application is not able to find the QUrlQuery class. Can you please share console log and Makefile when you run the qmake command with project file ? Thanks, Neel Patel On Tue, Aug 9, 2016 at 6:09 PM, Albe Laurenz wrote: > N

[pgadmin-hackers] [pgAdmin4][Debugger]: Fix RM-1224

2016-08-16 Thread Neel Patel
Hi, Please find attached patch file for fix of RM-1224. *Issue:-* Previously, error message was generic for any error. *Solution:-* Instead of showing generic message, now we will display error specific message to user. Do review it and let us know for any comments. Thanks, Neel Patel

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1238

2016-08-25 Thread Neel Patel
Hi, Please find attached minor patch for the fix of RM-1238. *Issue :- * Proper quoted SQL string was not generated. To resolve this issue, we formed proper SQL and now user can debug the function mentioned in RM case. Please review it and let us know for any comments. Thanks, Neel Patel

[pgadmin-hackers] [pgAdmin4][patch]: RM #1226

2016-08-26 Thread Neel Patel
s. Thanks, Neel Patel RM_1226.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: SlickGrid integration in query tool (pgAdmin4)

2016-08-29 Thread Neel Patel
e click on new blank row and select "By Selection" then it throws 'javascript' exception. Uncaught TypeError: Cannot read property 'id' of undefined Thanks, Neel patel On Mon, Aug 29, 2016 at 10:43 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprise

[pgadmin-hackers] [pgAdmin4][patch]: RM#1621

2016-08-30 Thread Neel Patel
. Thanks, Neel Patel RM_1621.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue displaying composite result types in debugger (pgAdmin4)

2016-09-20 Thread Neel Patel
Hi Murtuza, Sure. I will review it. Thanks, Neel Patel On Tue, Sep 20, 2016 at 3:16 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in debugger where we were not displaying result > properly in result tab for composit

[pgadmin-hackers] [Patch][pgAdmin4]: RM#1577 - Debug option for function/procedure under package node

2016-10-07 Thread Neel Patel
Hi, Please find attached patch file which contains function/procedure debug support under package node. (RM #1577) Do review it and let me know for any comments. Thanks, Neel Patel RM_1577.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers

Re: [pgadmin-hackers] [Patch][pgAdmin4]: RM#1577 - Debug option for function/procedure under package node

2016-10-12 Thread Neel Patel
ption for "Debug package initialiser". I will submit updated patch for both above points. > > On Fri, Oct 7, 2016 at 11:55 AM, Neel Patel > wrote: > > Hi, > > > > Please find attached patch file which contains function/procedure debug > > support unde

Re: [pgadmin-hackers] RM1849: Auto-generating security keys

2016-10-19 Thread Neel Patel
7; % (self.sid, self.randval), secret) File "/home/neel/Projects/pgAdmin4/pgadmin4_patch/pgadmin4/web/pgadmin/utils/session.py", line 44, in _calc_hmac secret.encode(), body.encode(), hashlib.sha1 AttributeError: 'bytes' object has no attribute 'encode' ### Th

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-10-21 Thread Neel Patel
Hi, On Fri, Oct 21, 2016 at 4:48 PM, Dave Page wrote: > Hi > > There are still issues I'm afraid: > > - When execution stops, we seem to keep polling for more results > indefinitely. > Do you mean after completion of first successful debugging ? If yes, we are polling because user can start sam

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

2016-10-21 Thread Neel Patel
Hi, On Fri, Oct 21, 2016 at 5:03 PM, Dave Page wrote: > Hi > > On Fri, Oct 21, 2016 at 12:32 PM, Neel Patel > wrote: > > Hi, > > > > > > On Fri, Oct 21, 2016 at 4:48 PM, Dave Page wrote: > >> > >> Hi > >> > >> There a

[pgadmin-hackers] [Patch][pgAdmin4][runtime]: RM#1375 - Migrate the runtime to QtWebEngine from QtWebKit

2016-11-04 Thread Neel Patel
re getting "acceptNavigationRequested" call which contains URL so before we save the URL, tab was already opened so we are not able to compare with existing opened tab. I have tested this patch on Linux & Mac and it is working as expected. Do review it and let us know for any comme

Re: [pgadmin-hackers] QtWebEngine issue

2016-11-10 Thread Neel Patel
Hi, That means it is an issue with OpenGL drivers and Qt Webengine ? Do we need to compile Qt with Desktop OpenGL which do not call OpenGL ES 2.0 API OR may be ANGLE ? Thanks, Neel Patel On Wed, Nov 9, 2016 at 10:05 PM, Dave Page wrote: > Incidentally, turning off accelerated graphics

Re: [pgadmin-hackers] QtWebEngine issue

2016-11-10 Thread Neel Patel
usg=AFQjCNFQXqXbnnLZO2AorxjQyrZjw1LBHg> https://bugreports.qt.io/browse/QTBUG-54326 <https://www.google.com/url?q=https%3A%2F%2Fbugreports.qt.io%2Fbrowse%2FQTBUG-54326&sa=D&sntz=1&usg=AFQjCNGJ0-kHL4TYI1w6G2W0FOzUWlHmcg> Let me know if anything needed for more investigations. Thanks, Nee

Re: [pgadmin-hackers] QtWebEngine issue

2016-11-10 Thread Neel Patel
); Below is the link for reference. http://doc.qt.io/qt-5/windows-requirements.html Thanks, Neel Patel On Thu, Nov 10, 2016 at 7:24 PM, Dave Page wrote: > Hi > > On Thu, Nov 10, 2016 at 1:28 PM, Neel Patel > wrote: > > Hi Dave, > > > > I have tried to reprod

[pgadmin-hackers] [Patch]: RM#1979 - Editing Function Issues

2016-11-24 Thread Neel Patel
NOTE: All the above issues will appear when editing function/procedure. Do review it and let us know for comments. Thanks, Neel Patel RM_1979.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscrip

[pgadmin-hackers] [pgAdmin4]: RM-1910 - Remember last used directory in the file manager

2016-12-09 Thread Neel Patel
Hi, Please find attached patch file which contains the fix of last used directory in file manager. Now file manager will remember last used directory per user basis and will be store in SQLite database. Do review it and let us know for comments. Thanks, Neel Patel RM_1910.patch Description

Re: [pgadmin-hackers] [pgAdmin4]: RM-1910 - Remember last used directory in the file manager

2016-12-16 Thread Neel Patel
Hi Dave, Please find attached patch file with the fix of below suggestion. - If the directory that has been remembered no longer exists, then find closest parent directory to set last remembered directory. Do review it and let us know for comments. Thanks, Neel Patel On Fri, Dec 9, 2016

Re: [pgadmin-hackers] [pgAdmin4]: RM-1910 - Remember last used directory in the file manager

2016-12-22 Thread Neel Patel
e know the steps to reproduce so that i can fix this issue ? Thanks, Neel Patel On Fri, Dec 16, 2016 at 7:06 PM, Dave Page wrote: > Hi > > On Fri, Dec 16, 2016 at 12:08 PM, Neel Patel > wrote: > > Hi Dave, > > > > Please find attached patch file with the fix of below s

[pgadmin-hackers] [pgAdmin4][patch]: RM #1745 - Fixed Clear breakpoint issue

2016-12-23 Thread Neel Patel
Hi, Please find attached patch file for the fix of RM #1745. *Issue:-* Line number was set properly when user set the breakpoint so clear breakpoint was not working properly. Do review it and let us know for comments. Thanks, Neel Patel RM_1745.patch Description: Binary data -- Sent via

[pgadmin-hackers] [pgAdmin4][patch]: RM#2026 - Debugger enabled when pldbgapi extension not loaded

2016-12-23 Thread Neel Patel
riate message to user before staring debugger. Do review it and let us know for comments. Thanks, Neel Patel RM_2026.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pg

[pgadmin-hackers] [pgAdmin4][patch]: RM 2009 - Create Index Issue

2016-12-29 Thread Neel Patel
review it and let us know for comments. Thanks, Neel Patel RM_2009.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4]: RM-1910 - Remember last used directory in the file manager

2017-01-06 Thread Neel Patel
Hi Dave, I am able to reproduce the issue with the steps mentioned. Please find attached patch file for the fix. I have tested on web and desktop mode. Do review it and let us know for comments. Thanks, Neel Patel On Tue, Jan 3, 2017 at 3:18 PM, Dave Page wrote: > Hi > > On Fri, Dec

[pgadmin-hackers] [pgAdmin4][patch]: RM 1967 - Layout is not remembered

2017-01-13 Thread Neel Patel
d not listen "unload" event for saving layout. *Solution:-* Save the Layout on docker's "*ATTACHED, DETACHED, MOVE_ENDED*" event so that layout will be saved once user move the panel. Do review it and let us know for comments. Thanks, Neel Patel RM_1967.patch Descripti

[pgadmin-hackers] [pgAdmin4][patch][FileManager]: RM-2110 - Invalid path error displayed

2017-01-27 Thread Neel Patel
S. I have tested with windows, Mac - web and desktop mode. Do review it and let us know for comments. Thanks, Neel Patel RM_2110.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.or

[pgadmin-hackers] [pgAdmin4][Patch]: RM#2015 - Trigger issues

2017-01-27 Thread Neel Patel
Do review it and let us know for comments. Thanks, Neel Patel RM_2015_v1.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][patch][FileManager]: RM-2110 - Invalid path error displayed

2017-02-03 Thread Neel Patel
Hi Dave, Please find attached updated patch with the fix of mentioned issue. Do review it and let us know for comments. Thanks, Neel Patel On Mon, Jan 30, 2017 at 5:44 PM, Dave Page wrote: > Hi > > On Fri, Jan 27, 2017 at 10:30 AM, Neel Patel > wrote: > > Hi, > >

[pgadmin-hackers] [pgAdmin4][Patch]: Fix #2198 - Cannot create function/procedure with arguments

2017-02-24 Thread Neel Patel
Hi, Please find attached patch file for the fix of RM #2198 - Can not create function/procedure with arguments. Do review it and let me know for any comments. Thanks, Neel Patel RM_2198.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org

[pgadmin-hackers] [pgAdmin4][patch]: RM #1796 - Added 'Run now' option to run pgAgent Job

2017-03-03 Thread Neel Patel
Hi, Please find attached patch file to fix for RM #1796 - Added "Run now" option to run the pgAgent job. Do review it and let me know for comments. Thanks, Neel Patel RM_1796.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.or

Re: [pgadmin-hackers] [pgadmin-support] How to clean off all python stuff

2017-03-06 Thread Neel Patel
Hi, Always loop pgadmin-hackers while replying email thread. Can you please share the errors while running application ? Thanks, Neel Patel On Mon, Mar 6, 2017 at 2:06 PM, marcelo wrote: > Hi > > Of course I read the README, and followed it until these indications > (pint 6) &

Re: [pgadmin-hackers] [pgadmin-support] How to clean off all python stuff

2017-03-06 Thread Neel Patel
looping pgadmin-hackers... As you are running desktop application but it's not finding python path and required modules. You need to export PYTHONPATH to where it installed all the required packages needed by application. Thanks, Neel Patel On Mon, Mar 6, 2017 at 5:30 PM, marcelo wrote:

[pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

2017-05-05 Thread Neel Patel
it release for Mac in below URL but for other platform we need to apply the patch and compile the webkit until they provide webkit-releases for all platforms. https://github.com/annulen/webkit/issues/519 Do review it and let me know in case of any issue. Thanks, Neel Patel RM_2328.patch D

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

2017-05-09 Thread Neel Patel
Hi Dave, Yes, It looks like compilation fails on Qt4. We will fix this issue but which version of Qt4 we are using in Jenkins ? Thanks, Neel Patel On Tue, May 9, 2017 at 1:56 PM, Dave Page wrote: > > > On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi < > akshay.jo...@enterpri

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

2017-05-09 Thread Neel Patel
ut on above issue. Thanks, Neel Patel On Tue, May 9, 2017 at 2:02 PM, Dave Page wrote: > It's running CentOS 7.3, with packages from EPEL: > > [dpage@jenkins ~]$ rpm -qa |grep qt > qt5-qtbase-common-5.6.1-10.el7.noarch > qt5-qtbase-devel-5.6.1-10.el7.x86_64 > qt-4.8.5-13.

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

2017-05-09 Thread Neel Patel
Hi Dave, On Tue, May 9, 2017 at 3:08 PM, Dave Page wrote: > Hi > > On Tue, May 9, 2017 at 10:28 AM, Neel Patel > wrote: > >> Hi Dave, >> >> Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar' >> related compilation error in

Re: [pgadmin-hackers] Patch: Auto-generate search_path statement for selected schema in query editor

2013-03-18 Thread Neel Patel
U_SCRATCHPAD, false); *if (outputPaneInfo.IsOk() == true && scratchPad.IsOk() == true)* manager.Update(); Please find the patch along with this email and let me know. Thanks, Neel Patel On Wed, Mar 6, 2013 at 11:54 AM, Ashesh Vashi wrote: > On Tue, Feb 19, 2013 at 6:53 PM,

Re: [pgadmin-hackers] Patch: Auto-generate search_path statement for selected schema in query editor

2013-03-25 Thread Neel Patel
your end. Thanks, Neel Patel On Tue, Mar 19, 2013 at 11:05 PM, Dave Page wrote: > Hi > > > On Mon, Mar 18, 2013 at 1:09 PM, Neel Patel > wrote: > >> Hi, >> >> We have checked the bug and below is our finding. >> >> As we are getting the pane in

Re: [pgadmin-hackers] Patch: Auto-generate search_path statement for selected schema in query editor

2013-03-26 Thread Neel Patel
Hi Dave, I will check and let you know. Thanks, Neel Patel On Tue, Mar 26, 2013 at 12:22 AM, Dave Page wrote: > Hi > > On Mon, Mar 25, 2013 at 9:02 AM, Neel Patel > wrote: > > Hi Dave, > > > > Please find the attached new patch file for fix. I have tested in

Re: [pgadmin-hackers] Patch: Auto-generate search_path statement for selected schema in query editor

2013-03-28 Thread Neel Patel
fication is required. Thanks, Neel Patel On Tue, Mar 26, 2013 at 2:12 PM, Neel Patel wrote: > Hi Dave, > > I will check and let you know. > > Thanks, > Neel Patel > > > On Tue, Mar 26, 2013 at 12:22 AM, Dave Page wrote: > >> Hi >> >> On Mon, Mar 25, 2

Re: [pgadmin-hackers] Patch: Auto-generate search_path statement for selected schema in query editor

2013-04-16 Thread Neel Patel
the output. Thanks, Neel Patel On Mon, Apr 8, 2013 at 8:09 PM, Dave Page wrote: > On Thu, Mar 28, 2013 at 12:04 PM, Neel Patel > wrote: > > Hi Dave, > > > > I looked in the code and attached is the updated patch. > > > > I have tested with my environment

Re: [pgadmin-hackers]

2013-05-22 Thread Neel Patel
Hi Dave, Sorry forgot to add the flag wxFLP_USE_TEXTCTRL at two places in dlgServer.xrc file . so attached updated patch file. Thanks, Neel Patel On Wed, May 22, 2013 at 4:35 PM, Neel Patel wrote: > Hi Dave, > > Rohit found one crash while we add the servers in the PEM. > > W

Re: [pgadmin-hackers]

2013-05-22 Thread Neel Patel
Hi Dave, Please find the patch for 1.16 branch. Thanks, Neel Patel On Wed, May 22, 2013 at 5:27 PM, Ashesh Vashi wrote: > Probably because of the sshtunnel changes in the master. > You should have done it in reverse. :P > > > On Wed, May 22, 2013 at 5:25 PM, Dave Page wro

Re: [pgadmin-hackers] Materialized View Patch File

2013-06-03 Thread Neel Patel
On Mon, Jun 3, 2013 at 5:20 PM, Dave Page wrote: > Hi > > On Mon, Jun 3, 2013 at 7:56 AM, Neel Patel > wrote: > > Hi Dave, > > > > Thanks for update. > > > > Yes it is a bug, I have not put the version check. > > > > Below are the ch

Re: [pgadmin-hackers] Materialized View Patch File

2013-06-09 Thread Neel Patel
terialized view 2. Table 3. Toast Table Please suggest. Thanks, Neel Patel On Wed, Jun 5, 2013 at 1:20 PM, Neel Patel wrote: > Hi Dave, > > Please find the patch in attachement with below changes. > > --- Changed the UI design and make it consistence with dlgTable. > >

Re: [pgadmin-hackers] Materialized View Patch File

2013-06-10 Thread Neel Patel
patch along with all the fixes. Thanks, Neel Patel On Mon, Jun 10, 2013 at 12:27 PM, Dave Page wrote: > Hi > > On Mon, Jun 10, 2013 at 7:23 AM, Neel Patel > wrote: > > Hi Dave, > > > > We can combine the Materialization Tab and auto-vacuum tab. > > >

Re: [pgadmin-hackers] Materialized View Patch File

2013-06-19 Thread Neel Patel
:- Create new table under newly created schema Step 3:- Create new materialized view and give in definition . Step 4:- Click on the materialized view and check properties and SQL Pane. Please find attached patch for fix. Thanks, Neel Patel On Tue, Jun 18, 2013 at 8:13 PM, Dave Page wrote

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-01 Thread Neel Patel
Hi Dave, Find the attached patch file ( it is on top of master branch ) for change in icon of materialized view in pgAdmin and also put the icon images attached in pgadmin/include/images folder. Please let me know in case of any issue. Thanks, Neel Patel On Wed, Jun 19, 2013 at 8:46 PM, Dave

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-02 Thread Neel Patel
know in case of any issue. Thanks, Neel Patel On Mon, Jul 1, 2013 at 5:30 PM, Neel Patel wrote: > Hi Dave, > > Find the attached patch file ( it is on top of master branch ) for change > in icon of materialized view in pgAdmin and also put the icon images > attached in pgadmin/inclu

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-03 Thread Neel Patel
uot;(collection->GetConnection()->BackendMinimumVersion(9, 3))" Please let me know for further comments. Thanks, Neel Patel On Tue, Jul 2, 2013 at 8:06 PM, Dave Page wrote: > Hi > > On Tue, Jul 2, 2013 at 3:25 PM, Thom Brown wrote: > > On 29 May 2013 10:40, Neel Patel wrote

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-08 Thread Neel Patel
Thanks Dave. Thanks, Neel Patel On Mon, Jul 8, 2013 at 6:04 PM, Dave Page wrote: > Thanks, patch applied. > > On Wed, Jul 3, 2013 at 8:44 AM, Neel Patel > wrote: > > Hi Dave, > > > > Thanks for the comments. > > > > Find the attached patch with

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-16 Thread Neel Patel
Hi Dave, I think we missed to commit the below bug fix for materialized view. Thanks, Neel Patel On Tue, Jul 2, 2013 at 12:42 PM, Neel Patel wrote: > Hi Dave, > > Attached patch contains the fix for the below bug for materialized view in > pgAdmin. > > > "If create

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-16 Thread Neel Patel
played use MATERIALIZED VIEW" Steps: 1. Install PostgreSQL 9.3 beta 2 2. Launch pgAdmin III 3. and create this view from SQL editor CREATE MATERIALIZED VIEW public."z a" AS select * from emp WITH DATA; 4. created successfully. 5. Click on SQL pane Thanks, Neel Patel On Tue, Jul 16, 20

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-17 Thread Neel Patel
Hi Dave, Yes, you are right. I also found one bug because of this fix where information is not correct in the SQL Pane. I will check and will send you the updated patch. Thanks, Neel Patel On Wed, Jul 17, 2013 at 1:45 PM, Dave Page wrote: > Hi > > On Tue, Jul 16, 2013 at 2:58 PM, N

Re: [pgadmin-hackers] Materialized View Patch File

2013-07-17 Thread Neel Patel
Name()) + wxT(" AND schemaname = ") + qtDbString(this->GetSchema()->GetName()); Is it correct ? Thanks, Neel Patel On Wed, Jul 17, 2013 at 1:57 PM, Neel Patel wrote: > Hi Dave, > > Yes, you are right. > I also found one bug because of this fix where information is no

  1   2   >