---
pgadmin4-fixpath-mac.patch - This is for runtime/Server.cpp to fix the path
where the runtime looks for web application path in app bundle.
Kindly review and suggest the changes required. Thanks.
--
Sandeep Thakkar
pgadmin4-fixpath-mac.patch
Description: Binary data
pgadmin4-mac
) and not for the already absolute path (ex.
ApplicationPath like /usr/lib/python2.7/site-packages/pgadmin4-web).
Well, I'm not a developer and the patch is just an attempt to resolve the
issue related to packaging. Please feel free to change it as required for
better.
Thanks.
--
Sandeep
ork/Versions/5/QtWebKitWidgets
> to QtWebKitWidgets
> error:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool:
> can't open file:
> Contents/Frameworks/QtWebKitWidgets.framework/Versions/5/QtWebKitWidgets
> (No such file or d
re the patch.
On Fri, May 13, 2016 at 6:41 PM, Dave Page wrote:
> On Fri, May 13, 2016 at 2:01 PM, Sandeep Thakkar
> wrote:
> > Thanks Dave.
> >
> > Please see inline.
> >
> > On Fri, May 6, 2016 at 9:03 PM, Dave Page wrote:
> >>
> >> Hi
>
On Tue, May 17, 2016 at 4:52 PM, Dave Page wrote:
>
>
> On Tuesday, May 17, 2016, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> Hi Dave
>>
>> I have fixed the issues. Attached is the updated patch.
>>
>> The docs are built
Okay, so the patch needs a little change because of the change in the
versioning for pgAdmin. Will update it.
Paresh, please take a note of it.
On Tue, May 17, 2016 at 4:24 PM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.com> wrote:
> Hi Dave
>
> I have fixed the issues.
:20 PM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.com> wrote:
> Okay, so the patch needs a little change because of the change in the
> versioning for pgAdmin. Will update it.
>
> Paresh, please take a note of it.
>
> On Tue, May 17, 2016 at 4:24 PM, Sandeep
age wrote:
>
>
> On Tuesday, May 17, 2016, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> Hi Dave
>>
>> I have fixed the issues. Attached is the updated patch.
>>
>> The docs are built as part of 'appbundle' target,
ory)
> complete-bundle.sh failed
> make: *** [appbundle] Error 1
>
> On Thu, May 19, 2016 at 6:34 AM, Sandeep Thakkar
> wrote:
> > Hi Dave
> >
> > I have added the 'docs' target in the /Makefile. This target is also
> called
> > by appbundle. pgAd
Hi Dave
I have fixed this issue. Instead of getting path from otool, script now
uses QTDIR variable to copy the framework directory. Please find the
updated patch attached.
Thanks.
On Thu, May 19, 2016 at 7:39 PM, Dave Page wrote:
> On Thu, May 19, 2016 at 10:05 AM, Sandeep Thakkar
>
On Mon, May 9, 2016 at 6:35 PM, Dave Page wrote:
> Hi
>
> Initial eyeball review comments below...
>
> On Fri, Apr 22, 2016 at 11:57 AM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> Hi Team, Dave,
>>
>> Attached herewith are two
> >
> >
> > On Fri, May 27, 2016 at 1:11 PM, Sandeep Thakkar
> > wrote:
> >>
> >> Sure. Thanks.
> >>
> >> There is a typo in pkg/mac/build.sh. i.e
> >>
> >> s/HTML_HELP/HELP_PATH/
> >>
> >>
> >>
Somehow the patch skipped the Makefile changes. Attached is the updated
patch.
On Mon, May 30, 2016 at 6:00 PM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.com> wrote:
> Thanks. I have fixed all the issues.
>
> Regarding the app not running from within the DMG for the firs
t;s/'//g"` ?
>
> yes, I have used the couple of more variables that gives proper
understanding.
Thanks! I have attached the updated patch. (runtime changes remains same).
>
> On Tue, May 31, 2016 at 1:19 PM, Sandeep Thakkar
> wrote:
> > Somehow the patch skipped
pm' like we did for
appbundle?
2. Should web rpm require doc rpm? I guess so, otherwise online help won't
work. Right?
On Fri, May 27, 2016 at 6:35 PM, Dave Page wrote:
> [Adding Devrim]
>
> On Fri, May 27, 2016 at 1:55 PM, Sandeep Thakkar
> wrote:
> >
&g
Hi
Few changes in the updated patch:
- added the missing modules in the specfile. The unavailable modules are
still commented.
- added changelog in specfile
- added dependency of pgadmin4-doc on pgadmin4-web
On Wed, Jun 1, 2016 at 2:57 PM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.
nv in the appbundle).
>
> On Tue, May 31, 2016 at 6:37 PM, Sandeep Thakkar
> wrote:
> > Hi Dave,
> >
> >
> > On Tue, May 31, 2016 at 9:29 PM, Dave Page wrote:
> >>
> >> Hi,
> >>
> >> On the first run, I get:
> >>
> >> Ap
okay. Thanks again!
On Thu, Jun 2, 2016 at 6:37 PM, Dave Page wrote:
> On Thu, Jun 2, 2016 at 2:05 PM, Sandeep Thakkar
> wrote:
> > Thanks Dave!
> >
> > I saw the runtime code and observed one change (prepend -> append) . Was
> it
> > not saving the location
dmin4-web-1.0_dev-1.rhel7.noarch*
--
Thanks!
On Thu, Jun 2, 2016 at 6:29 PM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.com> wrote:
> Hi
>
> Few changes in the updated patch:
> - added the missing modules in the specfile. The unavailable modules are
> still commented.
>
Thanks Dave.
On Fri, Jun 3, 2016 at 2:08 PM, Dave Page wrote:
> Hi
>
> On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar
> wrote:
> > Hi Devrim, Hi Dave,
> >
> > I have updated the patch. The earlier patch may fail because of app
> bundle
> > commit in g
Hi Dave,
how about changes in the pgadmin4 source code for conf.py and Server.cpp?
Looks okay?
On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.com> wrote:
> Thanks Dave.
>
> On Fri, Jun 3, 2016 at 2:08 PM, Dave Page wrote:
>
>> Hi
>&g
system - doesn't it know where it's site-packages are already? I could see
> us needing this is we were using a distro-independent build of Python and
> wanted to find the OS site-packages location, but we're not.
>
>
> On Fri, Jun 3, 2016 at 10:15 AM, Sandeep Thakkar <
sted code - I just want to make
> sure we need it.
>
>
> On Fri, Jun 3, 2016 at 3:39 PM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> Do you mean to say when a python app is launched, it imports some modules
>> automatically and in that s
e.g. /etc/httpd/conf.d/pgadmin4-v1.conf. The online docs for pgAdmin have a
> section on configuring that.
>
>
>
> On Mon, Jun 6, 2016 at 9:15 AM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> Yeah, I got the point. To distinguish between v1 an
7;t support back-branches long term anyway.
>
> Does anyone think we need to support side-by-side RPM/DEB installation of
> multiple major versions of pgAdmin? Devrim? Hamid?
>
> The config file would be part of the web package.
>
> On Mon, Jun 6, 2016 at 10:09 AM, Sandeep
gt;
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
>>
>> The confi
rectory of python in venv (as python libs may refer the actual directory)
and instead create a sym link. There might be other way to fix this, but I
found this to be easy. :)
Thanks!
--
Sandeep Thakkar
pgadmin-macbuild.patch
Description: Binary data
pgadminpro.patch
Description: Binary da
On Thu, Jun 16, 2016 at 3:19 PM, Dave Page wrote:
> On Thu, Jun 16, 2016 at 8:51 AM, Sandeep Thakkar
> wrote:
> > Hi,
> >
> > I created virtual environment and tried building pgadmin on my Mac with
> > Python 3.3 and QT 5.5. I observed that in venv, the python3-co
On Thu, Jun 16, 2016 at 7:04 PM, Dave Page wrote:
> On Thu, Jun 16, 2016 at 11:40 AM, Sandeep Thakkar
> wrote:
> >
> >
> >> > I have attached the patch (pgadminpro.patch) to fix this.
> >>
> >> Configuration and build fails for me with this:
>
s you suggest and migrate existing values for
>>> SECURITY_PASSWORD_SALT, given that there's clearly some other per user and
>>> per installation/database salting going on anyway. New installations can
>>> have the random value for SECURITY_PASSWORD_SALT.
>>>
>> We do not need to generate the random SECURITY_PASSWORD_SALT during
>> upgrade mode, which was wrong added in my addon patch.
>>
>> Please find the updated patch.
>>
>> Otherwise - looks good to me.
>> Please commit the new patch (if you're ok with the change).
>>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com/>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>>>
>>> I don't believe SECURITY_KEY and CSRF_SESSION_KEY are issues either, as
>>> they're used for purposes that are essentially ephemeral, and thus can be
>>> changed during an upgrade.
>>>
>>> Adding Magnus as I'd appreciate any thoughts he may have.
>>>
>>> Patch attached - please review (Ashesh, but others too would be
>>> appreciated)!
>>>
>>> Thanks.
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Sandeep Thakkar
Admin in PG server and EPAS Meta.
On Wed, Oct 19, 2016 at 4:35 PM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.com> wrote:
> Hi Dave,
>
> On Wed, Oct 19, 2016 at 1:57 PM, Dave Page wrote:
>
>> Patch applied.
>>
>> Fahar, can you please test this thoroughly
u build the PostgreSQL 9.2
> installers tomorrow (don't update the older branches though).
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreS
ake: *** [doc] Error 2
--
I set the following two variables in the environment to get through the
build.
export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8
On Tue, Dec 4, 2012 at 9:07 AM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.com> wrote:
> Sure. I'll update the pgAdmin for Postgr
executable i386
So, the grep fails there. Attached herewith is the patch that should work
for "Mach-O i386 executable" and as well as "Mach-O executable i386"
outputs.
--
Sandeep Thakkar
pgadmin.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgad
Hi
We dynamically build wxWidgets and hence the hhp2cached.exe is present
in %WXWIN%\utils\hhp2cached\*vc_mswudll* instead
of %WXWIN%\utils\hhp2cached\*vc_mswu*
Attached is the patch for builddocs.bat that will work with both static and
dynamic builds.
--
Sandeep Thakkar
Lead Software
Sorry, the patch contained the unnecessary newline in the condition. This
is fixed and the patch is attached.
On Wed, Feb 25, 2015 at 6:44 PM, Dave Page wrote:
> Thanks - patch applied.
>
> On Wed, Feb 25, 2015 at 6:09 AM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com&
36 matches
Mail list logo