Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

gadmin4/web/pgadmin/static/jsx/history' > > @ ./jsx/history/query_history_entry.jsx 17:14-31 > > @ ./jsx/history/query_history.jsx > > @ ./jsx/components.jsx > > error Command failed with exit code 2. > > info Visit https://yarnpkg.com/en/docs/cli/run for documentation about > &

[pgadmin-hackers] [pgAdmin4] [PATCH] Translatable Text in Query Results Header

Hi Hackers! Attached is a minor patch that wraps with gettext() the "Select/Deselect All" text in the top left corner of the query results grid. Thanks, Matt and Shruti query_results_gettext.diff Description: Binary data -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hello Dave, Thanks for making those fixes and sharing them with us. We tried applying the patch and it looks like there are some missing file changes from your patch that were present in ours, like the Make.bat file changes. But we will add them when we send you the new patches. While trying to

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

Hi Surinder! We reviewed this patch. The changes look good and we especially like that you have extracted out the new utility functions and the epicRandomString function too. This patch will likely affect the Query Results patch that is currently under review

[pgadmin-hackers] Process for Creating Translations

Hi Hackers, In the patches we sent recently, we added text to the User Interface. We know that calling getText translates it but currently we don't have translations for any of the new text. Is there a process for getting these text translated to other languages? Thanks, Shruti & Joao

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

authorship > information and patches, and applies them to the current branch. > > That doesn't seem like it'll help me as a gmail user. Can you fix the > patches to apply with git apply please? > > On Tuesday, May 23, 2017, Shruti B Iyer <si...@pivotal.io> wrote: > >> H

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

Hi Dave, We see the same errors when doing *git apply* for each patch. However, if you do *git am* for each patch, it should proceed. Thanks, Shruti & Matt On Tue, May 23, 2017 at 4:55 PM, Dave Page wrote: > Hi! > > Looks great! I found a few issues which I think should be