Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Thanks patch applied. On Mon, May 15, 2017 at 6:19 AM, Matthew Kleiman wrote: > Hi Akshay > > I really appreciate you taking a look at this on a Sunday! > I am not able to get access to my work computer to run your changes > directly. From what you are saying, though, it

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Joao On Fri, May 12, 2017 at 11:23 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Akshay, > > You can find attached a new version of the patch that changes the test in > question. > This new version instead of requiring a creation of a new Role now does > the

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hello Akshay, You can find attached a new version of the patch that changes the test in question. This new version instead of requiring a creation of a new Role now does the following: 1 - Creates a new Role 2 - Creates a table with that Role 3 - Checks for dependencies Thanks Joao & George On

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

On Thu, May 11, 2017 at 12:03 PM, Dave Page wrote: > > > On 11 May 2017, at 07:11, Akshay Joshi > wrote: > > Hi Sarah > > On Thu, May 11, 2017 at 2:30 AM, Sarah McAlear > wrote: > >> Hi Ashkay! >> >> TestTablesNodeSql

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

> On 11 May 2017, at 07:11, Akshay Joshi wrote: > > Hi Sarah > >> On Thu, May 11, 2017 at 2:30 AM, Sarah McAlear wrote: >> Hi Ashkay! >> >>> TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed with >>> below error: >>>

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Sarah On Thu, May 11, 2017 at 2:30 AM, Sarah McAlear wrote: > Hi Ashkay! > > TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed with >> below error: >> .\test_role_dependencies_sql.py\", line 41, in assertions\n >> self.assertEqual(1,

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Ashkay! TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed with > below error: > .\test_role_dependencies_sql.py\", line 41, in assertions\n > self.assertEqual(1, > len(fetch_result))\nAssertionError: 1 != 0 We experienced a similar problem when we started developing

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

On May 10, 2017 19:07, "Sarah McAlear" wrote: Hi Akshay! Does this error occur on 9.6 or 10.0? We tested it in 9.6 and all our tests pass. On both 9.6 and 10.0. Query returned 0 rows which is compared against 1 in assert statement. Thanks! João & Sarah On Wed, May

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Akshay! Does this error occur on 9.6 or 10.0? We tested it in 9.6 and all our tests pass. Thanks! João & Sarah On Wed, May 10, 2017 at 2:29 AM, Akshay Joshi wrote: > Hi Sarah > > On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear wrote: > >>

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Sarah On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear wrote: > Hi Akshay! > > >> Some test file names ended with "*_sql_template.py*" do we need to add >> that string ? > > we added this suffix after moving the tests up a level to tables/tests to > clarify what subject

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Akshay! > Some test file names ended with "*_sql_template.py*" do we need to add > that string ? we added this suffix after moving the tests up a level to tables/tests to clarify what subject they applied to. we changed the suffix to "_sql.py" - Files "test_column_acl_sql_template.py" and

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Sarah Below are my review comments on the latest patch: - Some test file names ended with "*_sql_template.py*" do we need to add that string ? - Files "test_column_acl_sql_template.py" and "test_column_properties_sql _template.py" should be moved from tables->tests to

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi! This patch has the tests moved to the test directories of the parent. Thanks, Joao & Sarah On Mon, May 8, 2017 at 7:28 AM, Dave Page wrote: > Hi > > On Mon, May 8, 2017 at 12:24 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> I have reviewed

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi On Mon, May 8, 2017 at 12:24 PM, Akshay Joshi wrote: > Hi All > > I have reviewed the code and have following questions: > >- Why do we have empty __init__.py file in sql and templates/ >folder. In this patch we have couple of occurrences one of them

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi All I have reviewed the code and have following questions: - Why do we have empty __init__.py file in sql and templates/ folder. In this patch we have couple of occurrences one of them is web/ pgadmin/browser/server_groups/servers/databases/schemas/table/templates/trigger and

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

On Mon, May 8, 2017 at 1:46 PM, Dave Page wrote: > Akshay, as Ashesh is unavailable today, can you please review/commit this > ASAP? > Sure. > > Thanks. > > On Fri, May 5, 2017 at 1:18 PM, Dave Page wrote: > >> Can you get this polished off on Monday

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Akshay, as Ashesh is unavailable today, can you please review/commit this ASAP? Thanks. On Fri, May 5, 2017 at 1:18 PM, Dave Page wrote: > Can you get this polished off on Monday please Ashesh? > > On Thu, May 4, 2017 at 12:51 PM, Robert Eckhardt >

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Can you get this polished off on Monday please Ashesh? On Thu, May 4, 2017 at 12:51 PM, Robert Eckhardt wrote: > All, > > This change in the xss testing is preventing our CI from going green and > is also preventing the Dependents and Dependencies tabs in Greenplum from >

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Hackers & Ashesh! Is there anything else we can do for this? Thanks! Matt & Sarah On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Thanks for reviewing, Ashesh. > > We have updated the patch. The headers are all consistent and we

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Thanks for reviewing, Ashesh. We have updated the patch. The headers are all consistent and we removed the __init__.py files in directories containing only .sql. Thanks! Joao & Matt On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hello Ashesh, Thanks for reviewing the patch. We added the __init__.py files into templates to convert them into packages so that the tests inside of them can be found by the test runner. Thanks! Joao & Sarah On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi wrote:

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

On Mon, Apr 24, 2017 at 4:43 PM, Dave Page wrote: > Ashesh, can you review/commit this please? > > On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Hackers, >> >> We found out that when you are connected to a

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Ashesh, can you review/commit this please? On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > We found out that when you are connected to a GreenPlum database and try > to get Dependents and Dependencies of an object the

[pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Hackers, We found out that when you are connected to a GreenPlum database and try to get Dependents and Dependencies of an object the application was returning a SQL error. This patch splits the SQL query used to retrieve the Dependents, Dependencies, and Roles SQL file into multiple