Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Thanks, patch applied. On Fri, Jun 2, 2017 at 8:55 PM, Surinder Kumar wrote: > Hi Dave, > > Please find updated patch with following changes: > > 1) Locate grid row by div's style attribute 'top'(i.e. 'top:0px' for first > row), instead of by div class-name

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Dave, Please find updated patch with following changes: 1) Locate grid row by div's style attribute 'top'(i.e. 'top:0px' for first row), instead of by div class-name because the order of rendered rows is not always same. 2) Increase the wait timeout of WebDriverWait to 5 seconds in

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi On Sat, May 27, 2017 at 4:03 PM, Surinder Kumar wrote: > Hi Dave > > Please find update Feature test cases patch. > > On Sun, May 28, 2017 at 12:40 AM, Dave Page wrote: >> >> Thanks - I committed the code changes, as they seem to work very

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Dave Please find update Feature test cases patch. On Sun, May 28, 2017 at 12:40 AM, Dave Page wrote: > Thanks - I committed the code changes, as they seem to work very well. > The regression tests are failing for me though :-(. Can you take > another look please? Note

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Thanks - I committed the code changes, as they seem to work very well. The regression tests are failing for me though :-(. Can you take another look please? Note that I'm running under Python 2.7 on Mal == ERROR: runTest

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Dave Please find updated Feature test case and review. This patch is dependent on RM_2400v2.patch On Fri, May 26, 2017 at 8:45 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Joao, > > On May 26, 2017 8:33 PM, "Joao Pedro De Almeida Pereira" < >

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Joao, On May 26, 2017 8:33 PM, "Joao Pedro De Almeida Pereira" < jdealmeidapere...@pivotal.io> wrote: > > Hi Surinder, > You are right, nevertheless that was not the only error we had on the flaky tests. Okay, please send stack trace where test case fails.. Thanks Surinder > > Thanks > Joao &

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Joao, Please apply patch RM_2400v2.patch first then apply Feature test cases patch. On May 26, 2017 7:42 PM, "Joao Pedro De Almeida Pereira" < jdealmeidapere...@pivotal.io> wrote: Hello Surinder, Thanks for updating the patch. After looking into the updated version, we found the following

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hello Surinder, Thanks for updating the patch. After looking into the updated version, we found the following issues. The tests looked flaky. We ran the tests three times and each time we had timeout issues. It failed twice in the location mentioned below. It also failed because the row1 cell2

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Please find updated patch. On Fri, May 26, 2017 at 3:15 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Surinder, > > We are having issues running the tests, this is the error that we are > getting: > > File >

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hello Surinder, We are having issues running the tests, this is the error that we are getting: File "/Users/pivotal/workspace/pgadmin4/web/regression/python_test_utils/test_utils.py", line 196, in create_table_with_query pg_cursor.execute(query) ProgrammingError: role "postgres" does not

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi The tests failed on both PG 9.4 and 9.6 for me :-( == ERROR: runTest (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest) Validate Insert, Update operations in View data with given test data

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Please find updated patch and review. On Thu, May 18, 2017 at 7:36 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > We reviewed the PR, and there are a lot of new lines of code in this > patch, are we sure that we can have a good coverage of the

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hello Hackers, We reviewed the PR, and there are a lot of new lines of code in this patch, are we sure that we can have a good coverage of the functionality just by doing feature tests? Adding more code to a 3.5k+ lines file doesn't look like a good option, do you think it is possible to extract

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi On Wed, May 17, 2017 at 3:08 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > *Implementation:* > > 1) Took a flag 'is_row_copied' for each copied row: > > - to distinguish it from add/update row. > - to write code specific to copied row only as it requires

[pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Hi Dave, *Implementation:* 1) Took a flag 'is_row_copied' for each copied row: - to distinguish it from add/update row. - to write code specific to copied row only as it requires different logic than add row. 2) After pasting an existing row: - If a user clear the cell value, it must set