Re: [pgadmin-hackers] Change server password [pgadmin4]

2016-05-13 Thread Akshay Joshi
On Thu, May 12, 2016 at 11:45 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > > -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB > > On Thu, May 12, 2016 at 4:16 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >>

Re: [pgadmin-hackers] Change server password [pgadmin4]

2016-05-12 Thread Harshal Dhumal
Hi, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, May 12, 2016 at 4:16 PM, Ashesh Vashi wrote: > On Thu, May 12, 2016 at 4:14 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Harshal >> >>

Re: [pgadmin-hackers] Change server password [pgadmin4]

2016-05-12 Thread Harshal Dhumal
Hi, PFA updated patch. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, May 12, 2016 at 4:14 PM, Akshay Joshi wrote: > Hi Harshal > > Below are my review comments : > >- Facing error unexpected identifier

Re: [pgadmin-hackers] Change server password [pgadmin4]

2016-05-12 Thread Ashesh Vashi
On Thu, May 12, 2016 at 4:14 PM, Akshay Joshi wrote: > Hi Harshal > > Below are my review comments : > >- Facing error unexpected identifier 'change_password: function(args)' >in js file. >- Please correct the spelling of password in the menu item. >

Re: [pgadmin-hackers] Change server password [pgadmin4]

2016-05-12 Thread Akshay Joshi
Hi Harshal Below are my review comments : - Facing error unexpected identifier 'change_password: function(args)' in js file. - Please correct the spelling of password in the menu item. - Title for alertify dialog showing "Change password for servers" it should be only "Change

Re: [pgadmin-hackers] Change server password [pgadmin4]

2016-05-12 Thread Harshal Dhumal
Hi, PFA updated patch. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, May 12, 2016 at 1:27 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > This patch needs a rebase. (as "Named restore point" patch is committed.) > > -- >

Re: [pgadmin-hackers] Change server password [pgadmin4]

2016-05-12 Thread Harshal Dhumal
Hi, This patch needs a rebase. (as "Named restore point" patch is committed.) -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Wed, May 11, 2016 at 12:35 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA patch for changing

[pgadmin-hackers] Change server password [pgadmin4]

2016-05-11 Thread Harshal Dhumal
Hi, PFA patch for changing server password. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin/browser/server_groups/servers/__init__.py index b2fd313..fe1f1b6 100644 ---