Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Thanks - patch applied! On Thu, Apr 14, 2016 at 2:31 PM, Murtuza Zabuawala wrote: > Hi Dave, > > Sorry my bad I misinterpreted, I thought you meant rename/changing schema > only. > > PFA updated patch. > > And For Dialog not closing issue is generic and I have

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi Dave, Sorry my bad I misinterpreted, I thought you meant rename/changing schema only. PFA updated patch. And For Dialog not closing issue is generic and I have already created internal ticket for it. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi, The first issue is only partially fixed - it'll still let me try to rename a shell type. Also, I notice when hitting Save on my changes, they're applied (if they're valid), but the dialogue doesn't close. I see the following in the browser console: Uncaught TypeError: Cannot read property

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi Dave, PFA patch to fixed given issues. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 14, 2016 at 5:11 PM, Dave Page wrote: > Thanks - patch applied. Unfortunately there are 3 more minor issues > for

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Thanks - patch applied. Unfortunately there are 3 more minor issues for you to fix: - Renaming or changing the schema for a shell type should not be allowed. - I'm allowed to try to add ACL entries or security labels to an existing shell type. This should be disallowed. - Changing the schema on

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi Dave, PFA updated patch which will fix mentioned issues. Hopefully the last one :-) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Apr 13, 2016 at 6:18 PM, Dave Page wrote: > Hi > > I'm seeing some more

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi I'm seeing some more issues now, some related to new functionality: - Please don't include the descriptive header for shell types in create.sql. - Shell types can (and should) have owner/comments set if specified. - The Type dropdown should just say "Shell" for shell types (no additional

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi Dave, Please find updated patches to fix all the mentioned issues. There are three patches, 1) One for fixing rendering issue when selecting type 2) Added utility function to fetch full type name with length & precision 3) Added new Shell type for External types. Regards, Murtuza --

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi Murtuza On Tue, Mar 22, 2016 at 9:22 AM, Dave Page wrote: > Hi > > On Tue, Mar 22, 2016 at 8:14 AM, Murtuza Zabuawala > wrote: >> Hi Dave, >> >> We can create new external type using below method, By running all of below >> queries at

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi On Tue, Mar 22, 2016 at 8:14 AM, Murtuza Zabuawala wrote: > Hi Dave, > > We can create new external type using below method, By running all of below > queries at the same time , we can not create separate external type by only > using create type statement.

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi Dave, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, Mar 17, 2016 at 4:13 PM, Dave Page wrote: > Hi > > On Thu, Mar 17, 2016 at 10:08 AM, Murtuza Zabuawala > wrote: > > > - If I click

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

On Wed, Mar 16, 2016 at 1:18 PM, Ashesh Vashi wrote: > On Wed, Mar 16, 2016 at 6:32 PM, Dave Page wrote: > >> Hi >> >> On Mon, Mar 14, 2016 at 12:21 PM, Murtuza Zabuawala >> wrote: >> > Hi Dave, >> > >> >

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi On Mon, Mar 14, 2016 at 12:21 PM, Murtuza Zabuawala wrote: > Hi Dave, > > Thank you for reviewing my patch. > > I have made changes according to your feedback. > > Please review updated patch. OK, I think it's in pretty good shape now. Here's what I hope

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

On Wed, Mar 16, 2016 at 6:32 PM, Dave Page wrote: > Hi > > On Mon, Mar 14, 2016 at 12:21 PM, Murtuza Zabuawala > wrote: > > Hi Dave, > > > > Thank you for reviewing my patch. > > > > I have made changes according to your feedback. > > > >

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Hi On Thu, Mar 17, 2016 at 10:08 AM, Murtuza Zabuawala wrote: > > - When editing a type, I cannot select a Grantee on the Privileges tab. > > This is general issue with privilege control. > [We will add it in TODO list] OK. > - When adding a composite type,

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

On Tue, Mar 8, 2016 at 1:38 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to add new nodes in pgAdmin4. > 1) Type node > 2) Catalog objects > > Note: Both above nodes depended on schema/catalog node, Please apply them > after latest patch of schema/catalog

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Committed the catalog_objects with few changes: - Renamed to catalog_objects - columns under it were renamed to catalog_object_column - Some of the query were specific to PPAS moved them to specific SQL templates. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL