Re: [pgadmin-hackers] PATCH: FTS configuration node

Thanks - Committed with some modification and fixes. On Wed, May 18, 2016 at 12:57 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > > On Wed, May 18, 2016 at 12:52 PM, Sanket Mehta < > sanket.me...@enterprisedb.com> wrote: > >> >> On Wed, May 18, 2016 at 12:42 PM, Ashesh Vashi < >>

Re: [pgadmin-hackers] PATCH: FTS configuration node

On Wed, May 18, 2016 at 12:52 PM, Sanket Mehta < sanket.me...@enterprisedb.com> wrote: > > On Wed, May 18, 2016 at 12:42 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Wed, May 18, 2016 at 12:41 PM, Sanket Mehta < >> sanket.me...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA

Re: [pgadmin-hackers] PATCH: FTS configuration node

On Wed, May 18, 2016 at 12:42 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Wed, May 18, 2016 at 12:41 PM, Sanket Mehta < > sanket.me...@enterprisedb.com> wrote: > >> Hi, >> >> PFA the revised patch. >> Response is lnline. >> >> Regards, >> Sanket Mehta >> Sr Software engineer >>

Re: [pgadmin-hackers] PATCH: FTS configuration node

On Wed, May 18, 2016 at 12:41 PM, Sanket Mehta < sanket.me...@enterprisedb.com> wrote: > Hi, > > PFA the revised patch. > Response is lnline. > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Tue, May 17, 2016 at 12:54 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com>

Re: [pgadmin-hackers] PATCH: FTS configuration node

Hi, PFA the revised patch. Response is lnline. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Tue, May 17, 2016 at 12:54 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Sanket, > > Please find my review comments below: > > 1. In create mode it generates wrong sql.

Re: [pgadmin-hackers] PATCH: FTS configuration node

Hi Sanket, Please find my review comments below: 1. In create mode it generates wrong sql. CREATE TEXT SEARCH CONFIGURATION test.asdf ( COPY= ); steps to reproduce: a] Fill up any necessary fields in general tab. b] On definition tab set Copy config filed and navigate to SQL tab.

Re: [pgadmin-hackers] PATCH: FTS configuration node

Hi, Revised patch is attached with this mail. My response is inline. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Fri, May 13, 2016 at 6:20 PM, Akshay Joshi wrote: > Hi Sanket > > Below are my review comments: > > >- Add button should be

Re: [pgadmin-hackers] PATCH: FTS configuration node

Hi Sanket Below are my review comments: - Add button should be disabled in Tokens tab while creating. - Unable to click on down arrow for token select control. - Title should be change from "Create FTS-dictionaries" to "Create FTS -Configuration". - Tree node is not getting

Re: [pgadmin-hackers] PATCH: FTS configuration node

Hi All, Last patch for FTS configuration does not contain node.ui.js file Kindly ignore it. Here is the new revised patch attached with this mail. Please do review it and let me know if any changes required Regards, Sanket Mehta Sr Software engineer Enterprisedb On Thu, May 12, 2016 at 4:38

Re: [pgadmin-hackers] PATCH: FTS configuration node

Hi, PFA the revised patch. Please do review it and let me know if anything is not proper. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Thu, May 5, 2016 at 8:19 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > + patch link > > >

Re: [pgadmin-hackers] PATCH: FTS configuration node

+ patch link http://www.postgresql.org/message-id/CAFiP3vwkka+=1foj7kr2zbc4azecoca9eo9dz34-oyy_9ge...@mail.gmail.com -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, May 5, 2016 at 8:18 PM, Sanket Mehta wrote: >