Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Thanks - applied with a minor tweak for the button styling so it looked consistent in webkit browsers. On Tue, Jun 7, 2016 at 8:13 AM, Harshal Dhumal wrote: > Hi, > > > PFA patch for user management issues. > > -- > Harshal Dhumal > Software Engineer > >

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, PFA patch for user management issues. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jun 6, 2016 at 6:06 PM, Dave Page wrote: > Hi > > Thanks - I've commit as-is (with some minor

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi Thanks - I've commit as-is (with some minor tweaks), however the following issues are present: 1) I get an error: "Invalid Email id: dpage...@pgadmin.org". That is a perfectly valid email address, but I guess we're not recognising the +. 2) When I mouse-over the Users menu option, the cursor

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi On Fri, Jun 3, 2016 at 10:52 PM, Harshal Dhumal wrote: > Hi, > > > PFA attached patch (V5) for user management functionality. > > Note: If you've applied any of the previous patch of this functionality then > set ConfigDB value to 10 in version table of and

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, PFA attached patch (V5) for user management functionality. Note: If you've applied any of the previous patch of this functionality then set ConfigDB value to 10 in version table of and also delete role 'Standard' from role table before applying this patch. On Fri, Jun 3, 2016 at 4:39 PM,

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

On Fri, Jun 3, 2016 at 11:37 AM, Ashesh Vashi wrote: > Hi Harshal, > > Dave asked to put the User Management menu under the 'Change Password' > (right top side). > Correct - that way it won't be displayed in desktop mode. Other comments: - If I type an email

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi Harshal, Dave asked to put the User Management menu under the 'Change Password' (right top side). -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, This patch requires backgrid password cell for I have sent patch yesterday. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 2, 2016 at 7:12 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: >

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, PFA patch for user management functionality. Major changes in this patch are: 1. In-place editing of user and saving on server. 2. Removed dependency on marshmallow python package. 3. UI improvements. 4. Search by email. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India:

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

On Tue, May 31, 2016 at 2:45 PM, Dave Page wrote: > > > On Tue, May 31, 2016 at 9:52 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> >> >> On Tue, May 31, 2016 at 1:26 PM, Dave Page wrote: >> >>> Yeah, I was about to reply on this too;

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

On Tue, May 31, 2016 at 9:52 AM, Ashesh Vashi wrote: > > > > On Tue, May 31, 2016 at 1:26 PM, Dave Page wrote: > >> Yeah, I was about to reply on this too; >> >> - Why do we need Marshmallow? >> >> - Why do we need a role system? Perhaps in the

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

On Tue, May 31, 2016 at 1:26 PM, Dave Page wrote: > Yeah, I was about to reply on this too; > > - Why do we need Marshmallow? > > - Why do we need a role system? Perhaps in the future we might have shared > servers, and roles that cannot modify them, but not now. > Hmm.. He

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Yeah, I was about to reply on this too; - Why do we need Marshmallow? - Why do we need a role system? Perhaps in the future we might have shared servers, and roles that cannot modify them, but not now. - Why is the editing not done in-grid? It's only a single line per record. Seems like an

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Mon, May 30, 2016 at 4:09 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Harshal, > > PFA comments as below, > > 1) While running setup.py for the first time, We did not

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, PFA updated patch for user management. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Mon, May 30, 2016 at 5:51 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Harshal, > > > Please find the review comments so far: > >

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

On Mon, May 30, 2016 at 4:09 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Harshal, > > PFA comments as below, > > 1) While running setup.py for the first time, We did not handle the case > to create Standard user. > 2) Save button gets enable only clicking on input text

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi Harshal, PFA comments as below, 1) While running setup.py for the first time, We did not handle the case to create Standard user. 2) Save button gets enable only clicking on input text box 3) Remove delete button from sub-node 4) If current user changes its own name/email, main page should

[pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, PFA initial patch for User management functionality. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/requirements_py2.txt b/requirements_py2.txt index a442e36..f3d8622 100644 --- a/requirements_py2.txt +++ b/requirements_py2.txt @@ -44,3