Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-06 Thread Sarah McAlear
Hi hackers, Could you please review this patch? Thanks Wenlin and Sarah On Wed, Aug 2, 2017 at 2:15 PM, Wenlin Zhang wrote: > Hi Hackers, > > This patch changes the alert style in the sub-navigation to match style > guide. > > Thanks, > Wenlin, Shirley & Sarah > > >

Re: [pgAdmin4][RM2586] Cleanup feature test

2017-08-06 Thread Sarah McAlear
Hi Harshal! There are a few files in which there are leftover imports that are not needed anymore: - PGDataypeFeatureTest - PgadminPage - CheckForXssFeatureTest - CheckDebuggerForXssFeatureTest We also noticed that there were quite a few time.sleep functions that were removed. This

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-06 Thread Ashesh Vashi
Surinder, Please take a look at this patch. If I recalls correctly, this patch is related to styling of the 'tabs' shown on the main window. Wenlin - please correct me if my understanding is wrong. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-06 Thread Wenlin Zhang
Hi Ashesh, That's correct. This patch just changed alert style in the 'tabs', such as Dependency and Dependents. Thanks Wenlin On Mon, Aug 7, 2017 at 12:51 PM, Ashesh Vashi wrote: > Surinder, > > Please take a look at this patch. > > If I recalls correctly, this patch is related to stylin