Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

Hi Atul, The given patch breaks RM#1801 . After applying the patch, Now I'm not able to see the properties of a database of which "datallowconn" is set to False. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise Post

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

ok, Lemme check and I will get back to you. Thanks, Atul On Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Atul, > > The given patch breaks RM#1801 > . > After applying the patch, Now I'm not able to s

Re: Unified server/desktop config

On Tue, Aug 8, 2017 at 7:18 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > On Ubuntu-14.04, I got error Application Server couldn't be contacted: > > *Steps performed:* > >- I have already installed pgAdmin4-1.4 which come with PostgreSQL-9.6 >installer. >then I

Re: [pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard

Hi, PFA updated patch for the same. Thanks Surinder for pointing that out, I assumed that we had a typo in that file. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/]

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

Hi Atul, Better solution to solve this issue is to use self.conn instead of creating new conn using did, we already checking for "datallowconn" flag in check_precondition decorator. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image:

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi Surinder, Thanks for your review. We have changed the indentation for _dashboard.scss file and also removed the style about icon-postgres:before, like margin-top,etc, but we are not sure if it is perfectly aligned now, you can add further change to it. As the second comment, I'm sor

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

makes sense. Thanks for the solution. Please find attached revised patch. Thanks, Atul On Tue, Aug 8, 2017 at 2:12 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Atul, > > Better solution to solve this issue is to use self.conn instead of > creating new conn using did,

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

Hi Wenlin, Patch looks good to me. I'm also attaching minor patch to update document for new keyboard shortcuts. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/]

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

Patch looks good to me. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] On Tue, Aug 8, 2017 at 3:25 PM, Atul Sharma wrote: > makes sense. Thanks for th

Re: Unified server/desktop config

On Tue, Aug 8, 2017 at 1:47 PM, Dave Page wrote: > > On Tue, Aug 8, 2017 at 7:18 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> On Ubuntu-14.04, I got error Application Server couldn't be contacted: >> >> *Steps performed:* >> >>- I have already installed pgAdmi

Re: [gpAdmin4][patch] query history updates

Hi Wenlin & Violet, On Tue, Aug 8, 2017 at 12:05 PM, Wenlin Zhang wrote: > Hi Khushboo, > > Thanks for your review. > > About the copy/paste function bug, we just found that this is an > existing bug in master. Except for the query History tab, this bug also > exist in the query data

Re: Unified server/desktop config

On Tue, Aug 8, 2017 at 11:27 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Tue, Aug 8, 2017 at 1:47 PM, Dave Page wrote: > > >> >> On Tue, Aug 8, 2017 at 7:18 AM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi >>> >>> On Ubuntu-14.04, I got error Applica

Re: Can someone tell me what this code does ?

Hi, I guess my question was a bit vague. I get that it loads drivers. But note it does not actually put them anywhere. First it creates a dict sets the attribute in the app loads the drivers dynamically and returns an empty dict. >From what I can tell this: DriverRegistry.load_drivers() is all

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

Nice! Would a DBA need to click on the drop down to expand? I think that drop down icon might be too small. Perhaps the whole row could be a clickable area to show further details. This is a good thing to test with some people > On Aug 8, 2017, at 12:52, Ashesh Vashi wrote: > >> On Mon, Aug

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

Oh, great! Thanks Murtuza! On Tue, Aug 8, 2017 at 6:16 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Wenlin, > > Patch looks good to me. > > I'm also attaching minor patch to update document for new keyboard > shortcuts. > > -- > Regards, > Murtuza Zabuawala > Enterprise

Re: [pgAdmin4[Patch][Webpacking]: Enable source maps in pgAdmin4 for development environment

Hi Surinder, This is great and useful. Looks good to me. Hope this can be committed ASAP. Thanks, Wenlin & Violet On Wed, Aug 2, 2017 at 9:41 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi All, > > This patch enables source maps in pgAdmin4 for development environment.

Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module

On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to use fetch dict based data instead of 2d-array based in > Type module as we are adding keys on the fly. > There is no RM just a minor enhancement. > Harshal, Please review th

Re: [gpAdmin4][patch] query history updates

Hi Khushboo! These are 2 separate patches. The failure of the feature test you're describing happens on Master even without this patch. The other patch fixes this, but is unrelated to this patch. Right now it applies cleanly on Master. If we rebase it here, we won't be able to apply it on master.

Re: [pgAdmin4][patch] Fix feature tests failure

Hi Hackers! Could someone review this patch, please? Thanks so much! Sarah On Mon, Aug 7, 2017 at 4:42 PM, Wenlin Zhang wrote: > Hi Hackers, > > This patch is about fixing the feature tests failure. > > Thanks, > Wenlin, Violet & Hao >

Re: [pgAdmin4][patch] Fix feature tests failure

Hi Sarah, I am doing this and didn't reply on this thread as we are discussing this on the another thread (the History Update patch). Thanks, Khushboo On Wed, Aug 9, 2017 at 9:10 AM, Sarah McAlear wrote: > Hi Hackers! > > Could someone review this patch, please? > > Thanks so much! > Sarah > >

[pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Hi Hackers! This patch enables Greenplum users to see the same charts on the dashboard as postgres users. It also adds some additional information to the DDL that is Greenplum specific and necessary to create a new table. Thanks! Sarah diff --git a/web/pgadmin/browser/server_groups/servers/datab

Re: Unified server/desktop config

Hi, I noticed that test cases don’t run and I got an error: (pgAdmin_27)Laptop195:regression surinder$ python runtests.py --pkg feature_tests Traceback (most recent call last): File "runtests.py", line 45, in import config File "/Users/surinder/Documents/Projects/pgadmin4/web/config.py"

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi Wenlin, On Tue, Aug 8, 2017 at 3:15 PM, Wenlin Zhang wrote: > Hi Surinder, > >Thanks for your review. > >We have changed the indentation for _dashboard.scss file and also > removed the style about icon-postgres:before, like margin-top,etc, but we > are not sure if it is perfectly alig

Re: Build failed in Jenkins: pgadmin4-master-python33 #207

Hi Dave, On Fri, Jun 30, 2017 at 3:57 PM, pgAdmin 4 Jenkins wrote: > See 7/display/redirect?page=changes> > > Changes: > > [Dave Page] Fix a couple of gripes from the JS linter on Windows. > >

Re: Unified server/desktop config

Please update the patch :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 9 Aug 2017, at 05:53, Surinder Kumar > wrote: > > Hi, > > I noticed that test cases don’t run and I got an error: >

Re: Unified server/desktop config

Sure, I will update. On Wed, Aug 9, 2017 at 11:17 AM, Dave Page wrote: > Please update the patch :-) > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK:http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On 9 Aug 2017, at 05:53, Surinde