Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions

2018-10-25 Thread Khushboo Vashi
Hi Team, On Mon, Oct 22, 2018 at 6:15 PM Akshay Joshi wrote: > Hi Khushboo > > Following are the review comments: > >1. There is difference in the colour of the two icons for Drop and >Drop Cascade when both the button are disabled. Please refer > Disabled_Icons. >png. > > The

pgAdmin 4 commit: Ensure that utility existence check should work for s

2018-10-25 Thread Akshay Joshi
Ensure that utility existence check should work for schema and other child objects while taking Backup/Restore. Fixes #3722 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0d5a6eeeffa1c7aac6274ee798b7e74e603c5804 Modified Files --

Re: [pgAdmin4][Patch]: Fixed process watcher status message.

2018-10-25 Thread Aditya Toshniwal
Hi Akshay, The patch looks good to me. But, I would suggest using some dictionary or const variables for process states instead of hard code numbers 0,1,2,3. It would be more readable and easier to change. On Wed, Oct 24, 2018 at 5:48 PM Akshay Joshi wrote: > Hi All > > Please ignore my

[pgAdmin4][Patch]: RM #3029 Cannot sort columns when importing data

2018-10-25 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix the RM #3029 Cannot sort columns when importing data. Select2 orders the selections based on the order of the `` behind the scenes. This means that the order will typically match the order of the options as they appear in the dropdown. For *import/export*

pgAdmin 4 commit: 1) Fixed process watcher status message when user has

2018-10-25 Thread Akshay Joshi
1) Fixed process watcher status message when user has stopped the process. 2) Saved the process state in sqlite database. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6ddab0276906deab1332109a9b7b917a8b5ef91c Modified Files --

Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions

2018-10-25 Thread Dave Page
On Thu, Oct 25, 2018 at 7:20 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Team, > > On Mon, Oct 22, 2018 at 6:15 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Following are the review comments: >> >>1. There is difference in the colour of