[pgAdmin4][PATCH] Fix handling of real type

2017-06-19 Thread Murtuza Zabuawala
Hi, PFA patch to fix the handling of real type. RM#2502 Steps to re-produce: Below given query fails to render result in Query tool, SELECT 'Infinity'::real, '{Infinity}'::real[] Also updated PG Data type feature test for the same. -- Regards, Murtuza Zabuawal

[pgAdmin4][PATCH] Fix clicking on the "pgAdmin 4" header logo shows a empty dialog

2017-06-19 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue, where user will get empty dialog in desktop mode if user clicks on pgadmin4 header logo. pgAdmin4 is already a SPA so in my opinion we don't require route to to home page. RM#2479 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.co

Re: [pgAdmin4][PATCH] Fix handling of real type

2017-06-20 Thread Murtuza Zabuawala
Hi, Please ignore previous patch, Attach is the updated patch which will cover RM#2498 - Handling of bytea[] type. RM#2502 - Handling of real & real[] type. including their feature tests. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgr

[pgAdmin4][PATCH] To increase the size of Grant Wizard dialog

2017-06-20 Thread Murtuza Zabuawala
Hi, PFA minor patch to make Grant Wizard dialog size larger so that it displays all the privileges properly when opened in smaller resolution screen. RM#2013 Tested on 1024 x 768 screen resolution. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

[pgAdmin4][PATCH] To fix the issue in Synonym node

2017-06-20 Thread Murtuza Zabuawala
Hi, PFA patch to handle the deleted Synonym node gracefully when user clicks SQL or Properties Panel. RM#2503 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas

[pgAdmin4][PATCH] To fix the issue in Materialized View

2017-06-21 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where create dialog opens blank due to JS error. RM#2504 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/views/templates/mview

Re: [pgAdmin4][PATCH] To fix the issue in Materialized View

2017-06-21 Thread Murtuza Zabuawala
Hi, Please ignore previous patch. Attached is the updated patch which includes fixes for Materialized View & pgAgent modules are also included. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 21, 2017 at 1:54 PM, Mur

Re: [pgAdmin4][PATCH] To fix the issue in Materialized View

2017-06-21 Thread Murtuza Zabuawala
Apologies disregard my previous patch also, I missed changes in "pga_job.js". Thanks to Harshal pointing that out. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 21, 2017 at 3:44 PM, Murtuza Zabuawala < m

[pgAdmin4][PATCH] To fix the issue in column module

2017-06-22 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where in column node we were not displaying column's default value properly, for example if the default value is zero. RM#1860 I have also fixed similar issue in foreign table module. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB:

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

2017-06-22 Thread Murtuza Zabuawala
Hi Khusboo, Looks like given change have broken Backup, Restore, Import/Export & Maintenance, even if I have binary path set it is throwing an error. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 21, 2017 at 9:40 PM,

[pgAdmin4][Patch] To fix the in Import/Export module

2017-06-22 Thread Murtuza Zabuawala
lect delimiter. RM#1934 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/import_export/templates/import_export/js/import_export.js b/web/pgadmin/tools/import_export/templates/import_export/js/import_export.js i

[pgAdmin4][Patch] To fix the issue in Column module

2017-06-22 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in Column module where clearing the length of a character(or any other type as well) generates empty SQL. RM#2155 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser

[pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-22 Thread Murtuza Zabuawala
against current code. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/debugger/__init__.py b/web/pgadmin/tools/debugger/__init__.py index 79e5eae..22df207 100644 --- a/web/pgadmin/tools/debugger/__init__.py +

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-22 Thread Murtuza Zabuawala
On Fri, Jun 23, 2017 at 11:24 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Review comments: > > ​1. ​ > Can we set "message"(in message detail) style property scroll to > ​'​ > auto > ​'​ > instead of > ​'​ > scroll > ​'​ > ? > > ​2. ​ > CSS property flex is supported for

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-23 Thread Murtuza Zabuawala
Yes Dave, You are right, I tested and found that indirect debugging is not working. But otherwise for direct debugging it works properly. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 23, 2017 at 1:20 PM, Dave Page wrote

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-23 Thread Murtuza Zabuawala
Yes, I'm looking into it, I will send updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 23, 2017 at 2:32 PM, Dave Page wrote: > On Fri, Jun 23, 2017 at 9:56 AM, Murtuza Zabuawala > wrote: &

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-23 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 23, 2017 at 2:38 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Yes, I'm looking into it, I will send

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

2017-06-27 Thread Murtuza Zabuawala
potential), so shouldn't the superuser check be changed to "if > !superuser then throw error"? As it is, if you're not superuser then > it just skips the check for the plugin, which seems like it'll never > end well. > > Fixed. > > On Fri, Jun 23,

[pgAdmin4][Patch] To add preferences for brace matching and auto brace closing

2017-06-27 Thread Murtuza Zabuawala
Hi, Please find patch to add preferences for brace matching and auto brace closing in SQL editor. RM#2513 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/__init__.py b/web/pgadmin/browser/__init__.py index

Re: [pgAdmin4][Patch] To add preferences for brace matching and auto brace closing

2017-06-27 Thread Murtuza Zabuawala
Sure Dave, I'll do the needful. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 27, 2017 at 7:29 PM, Dave Page wrote: > Thanks - patch applied with some minor tweaks to enable both options by > default and adju

Re: [RM2522] Improve grid/column select all operation

2017-06-30 Thread Murtuza Zabuawala
user can select different columns as well, so we have scan for each selected columns. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 30, 2017 at 12:07 PM, Dave Page wrote: > Hi > > On Thursday, June 29, 2017, Ha

Re: [RM2522] Improve grid/column select all operation

2017-06-30 Thread Murtuza Zabuawala
++ Corrected sentence On Fri, Jun 30, 2017 at 1:27 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > I guess so, number of columns do have overhead on selection & copy/paste > operation because of arbitrary copy paste feature, now we have to scan > start c

[pgAdmin4][Patch] To fix the issues in Debugger module

2017-06-30 Thread Murtuza Zabuawala
we find the solution for this issue. Misc changes are for PEP-8. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/debugger/__init__.py b/web/pgadmin/tools/debugger/__init__.py index 8cebffc

[pgAdmin4][Patch] To fix the duplicate entry in History panel

2017-06-30 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where duplicate entry is made of successful executed query one with status message and one without status message. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools

Re: [pgAdmin4][Patch]: Refactor of the History Tab

2017-06-30 Thread Murtuza Zabuawala
Hi, On Fri, Jun 30, 2017 at 10:30 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > ​Hi, > > Review comments: > > 1) I see the font used for class .query-history .entry​ is monospace, > shouldn't it be Helvetica as per style guide ? the font for Messages > text > is also monospace. >

[pgAdmin4][Patch] To fix the issue in Debugger & Procedure module for EPAS server

2017-07-03 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where 'Debug' option was not displaying on Package -> Function if the user if non-super user. RM#1948 Another minor issue where there was a whitespace on SQL panel while displaying reversed engineering sql for Procedure. RM#2146 -- Regards, Murt

[pgAdmin4][Patch]: Allow user to delete Tab via Shift-Tab in query editor

2017-07-05 Thread Murtuza Zabuawala
Hi, PFA minor patch which will add functionality to allow user to delete Tab(s) using Shift-Tab keys. RM#1988 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin

[pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in Function, Procedure & Trigger Function modules where user was not able to update object if user changes the code definition. RM#2537 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a

[pgAdmin4][Patch] Fix the issue in save password checkbox in "Create - Server" dialog.

2017-07-06 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue, where user is not able to save the password even if config.py has option "ALLOW_SAVE_PASSWORD = True". RM#2540 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadm

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Murtuza Zabuawala
Hi Dave, This behaviour is from beginning I think and it is inherited from pgAdmin3. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 6, 2017 at 5:58 PM, Dave Page wrote: > Hi > > On Thu, Jul 6, 2017 at 12:04 PM

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-06 Thread Murtuza Zabuawala
Sorry, I think my last statement was misleading. No, It's not broken, I meant the behaviour is taken from pgAdmin3, It is disabled by default but once you change the value of "Returns a set?" (under Options tab) to Yes while creating new function it gets enabled. -- Regards, Mu

[pgAdmin4][Patch] To fix the issue in privileges control

2017-07-11 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue in privileges control, where privileges were not displaying in IE10/11 when user click on it to grant privileges for given role. RM#1166 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web

Re: [pgAdmin4][Patch] To fix the issue in privileges control

2017-07-11 Thread Murtuza Zabuawala
Please disregard previous patch, I'll send updated patch as I found one issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 11, 2017 at 4:49 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: &g

Re: [pgAdmin4][Patch] To fix the issue in privileges control

2017-07-11 Thread Murtuza Zabuawala
Hi, Please find updated patch. On Tue, Jul 11, 2017 at 4:52 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Please disregard previous patch, I'll send updated patch as I found one > issue. > > -- > Regards, > Murtuza Zabuawala > Enterpris

[pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-12 Thread Murtuza Zabuawala
Hi, PFA patch which will add functionality to allow user to comment/uncomment code in query editor. RM#2456 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/docs/en_US/keyboard_shortcuts.rst b/docs/en_US

Re: pgAdmin 4 commit: Fix IE11 alert layout again.

2017-07-13 Thread Murtuza Zabuawala
n top of alert message and layout becomes kind of square shape. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 10, 2017 at 6:19 PM, Dave Page wrote: > Fix IE11 alert layout again. > > Branch > -- > master

[pgAdmin4][Patch] Not to display PID comma separated in statistics panel

2017-07-13 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where PID column was displaying comma separated in statistics panel. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/misc/statistics/static/js/statistics.js b/web/pgadmin/misc

[pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-13 Thread Murtuza Zabuawala
to respective server 5) Click on Dashboard 6) Check "Sessions" tab under "Server activity" section then look for active sessions for test database. 7) Click on cancel button and cancel the active session 8) Check psql session now, you will see "ERROR: canceling statemen

Re: Testing out font changes in query editor tool

2017-07-13 Thread Murtuza Zabuawala
Hi Shirley, It's easy on the eyes :) ~M On Thu, Jul 13, 2017 at 10:00 PM, Shirley Wang wrote: > Hello! > > We're trying out a new font in the query editor tool. Attached is a patch > that changes the font. > > We'd like to know how this change affects your experience working in the > query too

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-17 Thread Murtuza Zabuawala
Hi Dave, On Mon, Jul 17, 2017 at 2:33 PM, Dave Page wrote: > Hi > > On Wed, Jul 12, 2017 at 1:16 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch which will add functionality to allow user to comment/uncomment >> code in query edit

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-17 Thread Murtuza Zabuawala
On Mon, Jul 17, 2017 at 3:01 PM, Dave Page wrote: > Hi > > On Thu, Jul 13, 2017 at 2:53 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> hiHi, >> >> PFA patch to add functionality which will allow super user to cancel long >> running queries from das

[RM2544][pgAdmin4] Add SSL database connection support in Regression tests

2017-07-17 Thread Murtuza Zabuawala
Hi, PFA patch to add SSL support for database connection. RM#2170 Included test to check if current connection is using SSL or not. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers

Re: [RM2544][pgAdmin4] Add SSL database connection support in Regression tests

2017-07-17 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch for the same. On Mon, Jul 17, 2017 at 8:59 PM, Dave Page wrote: > Hi > > On Mon, Jul 17, 2017 at 2:59 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to add SSL support for database connection. >&g

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-18 Thread Murtuza Zabuawala
we can do is, it will throw an error when user is not eligible to cancel the active running query. > - Perhaps this is a good feature to review with Chethana! :) > > On Mon, Jul 17, 2017 at 5:37 AM Murtuza Zabuawala enterprisedb.com> wrote: > >> On Mon, Jul 17, 201

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-18 Thread Murtuza Zabuawala
Great job Surinder, Load time ~2 sec on browser :) [image: Inline image 1] -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 18, 2017 at 9:01 PM, Dave Page wrote: > Thanks, applied. > > On Tue, Jul 18, 2017 a

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-19 Thread Murtuza Zabuawala
Jul 17, 2017 at 3:05 PM, Dave Page wrote: > Hi > > On Mon, Jul 17, 2017 at 10:31 AM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Mon, Jul 17, 2017 at 2:33 PM, Dave Page wrote: >> >>> Hi

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-19 Thread Murtuza Zabuawala
Just a FYI, You need to run yarn bundle for this to be working as Surinder has moved all the CodeMirror code into bundle package. On Wed, Jul 19, 2017 at 2:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch, > 1) Added Keyboard sh

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-19 Thread Murtuza Zabuawala
ttons though, so if anyone > has a better idea how they should be styled, please yelp (CCing Chethana > for his input as well)... > > > > On Wed, Jul 19, 2017 at 9:56 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Just a FYI, >> You need to run yarn bund

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-19 Thread Murtuza Zabuawala
Sure, Will take a look. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 19, 2017 at 8:00 PM, Dave Page wrote: > Except I managed to break a couple of tests :-(. Can you take a look > please? I've had some other w

[pgAdmin4][Patch]: To make session more secure in web mode

2017-07-20 Thread Murtuza Zabuawala
Hi, PFA minor patch to make session more secure in web mode. RM#2584 Ref: https://flask-paranoid.readthedocs.io/en/latest/ Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/requirements.txt b/requirements.txt

Re: [pgAdmin4][Patch]: To make session more secure in web mode

2017-07-20 Thread Murtuza Zabuawala
2 PM, Dave Page wrote: > Hi > > On Thu, Jul 20, 2017 at 12:59 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> Tested it with PEM7 RestApi testsuite and it is working fine :) >> > > The docs for this module say it's based on Fla

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-20 Thread Murtuza Zabuawala
Hi Dave, I am working on this, will send you patch soon. On Thu, Jul 20, 2017 at 5:53 PM, Dave Page wrote: > Did you get a chance to look at this yet Murtuza? > > On Wed, Jul 19, 2017 at 3:37 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Sure, Will take a look

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-20 Thread Murtuza Zabuawala
ot;Explain Options" sub menu to go out of browser visibility in feature test, so it was failing. I have put Edit button near Clear button for now, until we come up with new design for our editor for displaying these options. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterpri

Re: [pgAdmin4][Patch]: To make session more secure in web mode

2017-07-20 Thread Murtuza Zabuawala
On Thu, Jul 20, 2017 at 6:17 PM, Dave Page wrote: > > > On Thu, Jul 20, 2017 at 1:34 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> It is based on Flask-Login module but >> 1) Flask-Login will mark a user as logged out when it detects that an >> existing

Re: Unified server/desktop config

2017-07-20 Thread Murtuza Zabuawala
Hi Dave, Partial patch for feature test got included in you patch :) On Thu, Jul 20, 2017 at 9:33 PM, Dave Page wrote: > All, > > Attached is a patch that aims to allow us to have a standardised config > that will work out of the box for both web and desktop modes. It does this > by doing two

Re: Unified server/desktop config

2017-07-20 Thread Murtuza Zabuawala
Oops sorry my bad, I did not removed it. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 20, 2017 at 10:22 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Partial patch for f

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-20 Thread Murtuza Zabuawala
On Thu, Jul 20, 2017 at 10:29 PM, Dave Page wrote: > Hi > > On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find patch attached, There were two issues, >> 1) We removed the default button

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-21 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch. On Thu, Jul 20, 2017 at 10:35 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > On Thu, Jul 20, 2017 at 10:29 PM, Dave Page wrote: > >> Hi >> >> On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala < &

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-21 Thread Murtuza Zabuawala
T+Q Toggle block comment > TextWrangler Ctrl+/ > > -- Rob > > > On Thu, Jul 20, 2017 at 1:05 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> >> On Thu, Jul 20, 2017 at 10:29 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu,

[pgAdmin4][Patch]: To fix database disconnect option

2017-07-21 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where database disconnect option is not working. *Steps to re-produce:* 1) Create a "test" database 2) Connect to "test" database 3) Right click on "test" database and try to disconnect it, you will get an error on console.

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-21 Thread Murtuza Zabuawala
shortcut keys, I'll change them accordingly and send new patch. On Fri, Jul 21, 2017 at 4:25 PM, Robert Eckhardt wrote: > I'm not sure what you mean by across platforms. Do you mean that those > are the keyboard shortcuts in pgAdmin 3? > > Rob > > On Jul 21, 2017 4:42

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch. On Tue, Jul 18, 2017 at 8:05 PM, Murtuza Zabuawala wrote: > Hi Shirley, > > On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang wrote: > >> Hi! >> >> I can't seem to get the patch to completely work on my computer, only the >

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Murtuza Zabuawala
2-3 days would be needed. > > On Mon, Jul 24, 2017 at 11:45 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find updated patch. >> >> On Tue, Jul 18, 2017 at 8:05 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.c

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-24 Thread Murtuza Zabuawala
Sure. RM created: https://redmine.postgresql.org/issues/2597. On Mon, Jul 24, 2017 at 6:04 PM, Dave Page wrote: > > > On Mon, Jul 24, 2017 at 1:12 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> On Mon, Jul 24, 2017 at 4:44 PM, Dave Pa

[pgAdmin4][Patch]: Handle WSGI Alias while generating URL for endpoints.js

2017-07-25 Thread Murtuza Zabuawala
l the endpoints and their respective url's. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/__init__.py b/web/pgadmin/__init__.py index 49c4fdd..0ca1c58 100644 --- a/web/pgadmin/__init__.py +++ b/w

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-26 Thread Murtuza Zabuawala
Hi Dave, Please find updated patch for new shortcut keys, I have tested it on all three major platforms (macOS, Linux & Windows with Chrome, FF & IE11 Browsers). -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 21, 2

Re: Build failed in Jenkins: pgadmin4-master-python26 #386

2017-07-26 Thread Murtuza Zabuawala
Looking into it. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 26, 2017 at 5:28 PM, pgAdmin 4 Jenkins wrote: > See <https://jenkins.pgadmin.org/job/pgadmin4-master-python26/ > 386/display/redirect?page=changes>

Re: Build failed in Jenkins: pgadmin4-master-python26 #386

2017-07-26 Thread Murtuza Zabuawala
Hi Dave, Please find a patch to fix the JS tests. FYI, I have removed the labels like 'Shift+CTRL+/' from test instead used ' inlineComment' because key shortcuts are different based on platform. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Murtuza Zabuawala
Hi Dave, PFA patch to display additional information from pg_stat_activity table using subnode control. RM#2597 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang wrote

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Murtuza Zabuawala
++ Attaching the patch -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA patch to display additional i

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Murtuza Zabuawala
hers welcome of course - screenshot attached. > > Thanks. > > On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> ++ Attaching the patch >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: ht

Re: Error using pgadmin4 HEAD

2017-07-28 Thread Murtuza Zabuawala
sitory, Another way is to download and use the source which is already bundled from here <https://www.pgadmin.org/download/pgadmin-4-source-code/> -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Sat, Jul 29, 2017 at 2:27 AM, Dave C

[pgAdmin4][Patch]: Fix the Domain Create dialog issue

2017-07-31 Thread Murtuza Zabuawala
sing font size class collision with Bootstrap's label class. RM#2616 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/domains/static/js/domain.js b/web/pgadmin/brow

Re: pgAdmin 4 commit: Fix test assertion.

2017-07-31 Thread Murtuza Zabuawala
passed 1 test failed: QueryToolJourneyTest (Tests the path through the query tool) 1 test skipped: CheckDebuggerForXssFeatureTest (Tests to check if Debugger is vulnerable to XSS) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On

Re: Discussion on improving alertify notifications logic

2017-07-31 Thread Murtuza Zabuawala
Hi, Looks good to me. Regards, Murtuza On Mon, Jul 31, 2017 at 2:59 PM, Ashesh Vashi wrote: > On Mon, Jul 31, 2017 at 2:54 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> > >> On Fri, Jul 28, 2017 at 1:51 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Jul 27, 2017 at 2:4

Re: pgAdmin 4 commit: Fix test assertion.

2017-07-31 Thread Murtuza Zabuawala
a few weeks ago. > > Rob > > On Jul 31, 2017 6:51 PM, "Murtuza Zabuawala" enterprisedb.com> wrote: > > Hi All, > > When I run the feature tests, the gives test always fails ( > 'query_tool_journey_test.py'), > > Python: 3.6 (64-bit) > P

Re: [pgAdmin4][Patch]: Dashboard requests don't stop even after closing the panel

2017-07-31 Thread Murtuza Zabuawala
Hi Ashesh, On Mon, Jul 31, 2017 at 4:50 PM, Ashesh Vashi wrote: > > > On Fri, Jul 28, 2017 at 4:00 PM, Dave Page wrote: > >> Ashesh, can you deal with this please? Thanks. >> > Hi Khushboo, > > I've committed the code. > But - I am not able to reopen the dashboard panel once it is closed, even >

[pgAdmin4][Patch]: To fix Collation tests

2017-08-01 Thread Murtuza Zabuawala
mmunity regarding "POSIX" collation issue on Windows. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/collations/tests/test_collation_add.py b/web/pgadmin/brows

[pgAdmin4][Patch]: To fix Function/Procedures messages issue in query tool

2017-08-02 Thread Murtuza Zabuawala
, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.py index 2ffc74a..15ec8c4 100644 --- a/web/pgadmin/tools/sqleditor/__init__.py +++ b/web/pgadmin/tools/sqleditor

[pgAdmin4][Patch]: Use the correct resultset type for Type module

2017-08-03 Thread Murtuza Zabuawala
Hi, PFA minor patch to use fetch dict based data instead of 2d-array based in Type module as we are adding keys on the fly. There is no RM just a minor enhancement. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

2017-08-04 Thread Murtuza Zabuawala
/keyboard_shortcuts.js: patch does not apply error: patch failed: web/regression/javascript/sqleditor/keyboard_shortcuts_spec.js:181 error: web/regression/javascript/sqleditor/keyboard_shortcuts_spec.js: patch does not apply -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The

[pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard

2017-08-07 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where add new server functionality through Quick link on Dashboard is broken. RM#2634 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <ht

Re: Can someone tell me what this code does ?

2017-08-07 Thread Murtuza Zabuawala
Hi, This piece of code allow us to dynamically import all the available driver modules from '../utils/driver/' directory into our application. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgre

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

2017-08-08 Thread Murtuza Zabuawala
Hi Atul, The given patch breaks RM#1801 <https://redmine.postgresql.org/issues/1801>. After applying the patch, Now I'm not able to see the properties of a database of which "datallowconn" is set to False. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprise

Re: [pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard

2017-08-08 Thread Murtuza Zabuawala
Hi, PFA updated patch for the same. Thanks Surinder for pointing that out, I assumed that we had a typo in that file. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <ht

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

2017-08-08 Thread Murtuza Zabuawala
Hi Atul, Better solution to solve this issue is to use self.conn instead of creating new conn using did, we already checking for "datallowconn" flag in check_precondition decorator. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Compa

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

2017-08-08 Thread Murtuza Zabuawala
Hi Wenlin, Patch looks good to me. I'm also attaching minor patch to update document for new keyboard shortcuts. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] &

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

2017-08-08 Thread Murtuza Zabuawala
Patch looks good to me. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <https://community.postgresrocks.net/> On Tue, Aug 8, 2017 at 3:25 PM, Atul Sharma wrote: > makes sense. T

Re: Can someone tell me what this code does ?

2017-08-09 Thread Murtuza Zabuawala
s the attribute in the app > loads the drivers dynamically > and returns an empty dict. > > From what I can tell this: > > DriverRegistry.load_drivers() > > is all it does? > > > > > > > Dave Cramer > > On 7 August 2017 at 23:35, Murtuza Zabu

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-09 Thread Murtuza Zabuawala
grid because it will break the subnode control consistency, If user sees that grid expands on clicking the row they will expect the same behaviour in other grids as well. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image:

Re: Can someone tell me what this code does ?

2017-08-09 Thread Murtuza Zabuawala
Hi, On Wed, Aug 9, 2017 at 8:19 PM, Dave Cramer wrote: > So what is the policy of the project? Ideally the cruft should be removed. > > Would a patch doing so be committed? > ​Yes, I guess.​ Dave Cramer > > On 9 August 2017 at 00:28, Murtuza Zabuawala enterprisedb.com>

[pgAdmin4][PATCH] To fix pgAgent job step issues

2017-08-16 Thread Murtuza Zabuawala
Hi, Please find attached patch to fix below given issues from pgAgent Jobs Steps module. 1) 'Connection Type' cell was not honouring to 'Kind' option in Subnode control. 2) Kind option was not saved properly 3) User was not be able to update Kind option in edit mode. RM#2633

[pgAdmin4][PATCH] Fix trigger's reversed engineered SQL for View

2017-08-18 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where view is not fully qualified in Trigger definition. RM#2560 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <https://community.postgresrocks.

[pgAdmin4][Patch]: To fix validation issue in connection string for pgAgent Job Step

2017-08-21 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where it was throwing error for valid connection string if user passed host value as ip address. RM#2655 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups

[pgAdmin4][Patch]: Update codemirror to latest version

2017-08-21 Thread Murtuza Zabuawala
Hi, PFA patch to update CodeMirror to latest version(5.28.0 <https://codemirror.net/doc/releases.html>) which will fixes below listed issues, *Fixes:* RM#1697 RM#2168 RM#2447 RM#2562 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL C

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-21 Thread Murtuza Zabuawala
e very different from each other despite both are triggers. I know this is out of context but in my own opinion these icons have resemblance with Flat design where as rest of our application is in 2d design, for example buttons, dialogs etc. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www

Re: [pgAdmin4][Patch]: RM_ 2658 - Improve help message for "binary paths" entered in Preferences

2017-08-22 Thread Murtuza Zabuawala
​​ https://redmine.postgresql.org/issues/2008 ​ On Tue, Aug 22, 2017 at 7:14 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Tue, Aug 22, 2017 at 6:07 PM, Dave Page wrote: > >> >> >> On Tue, Aug 22, 2017 at 1:30 PM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >>

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-23 Thread Murtuza Zabuawala
Hi Chethana, On Wed, Aug 23, 2017 at 12:51 PM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hi Murtuza, > > Please see my reply inline along with the updated .svg file for tree view > icons. > > > On Tue, Aug 22, 2017 at 11:17 AM, Murtuza Z

[pgAdmin4][Patch]: Allow user to provide custom SSL certificates and provide .pgpass file

2017-08-24 Thread Murtuza Zabuawala
/static/ssl-tcp.html *.pgpass file reference:* https://www.postgresql.org/docs/10/static/libpq-pgpass.html -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <https://community.postgresrocks.

Re: Next release

2017-08-24 Thread Murtuza Zabuawala
+1 to 2.0 -- Thanks, Murtuza On Thu, Aug 24, 2017 at 3:06 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Aug 24, 2017 at 2:28 PM, Dave Page wrote: > >> Anyone object to doing a release on 14th September, wrapping the code on >> Monday 11th? This seems like t

  1   2   3   4   5   >