[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #149

See Changes: [Dave Page] Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for [Dave Page] Fix error on the stats tab with PG10. Also, rename the 10.0_plus [Dave Page] Properly handle

Re: [pgadmin-hackers] [pgAdmin4][PATCH] CREATE Script do not display properly on panel resize

Thanks, patch applied! On Mon, Jun 12, 2017 at 11:48 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where SQL Panel in query tool displays truncated > sql on resize. > RM#2078 > > Steps to re-produce the issue: > 1) Create table provided by

[pgadmin-hackers] pgAdmin 4 commit: Refresh the SQL editor view on resize to ensure the c

Refresh the SQL editor view on resize to ensure the contents are re-rendered for the new viewport. Fixes #2078 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3743c6e86ed74b8ae6f4776f27e1555c4ee64e89 Author: Murtuza Zabuawala

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python34 #150

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar wrote: > Hi > > I confirm this is updated patch. Thanks. Something else seems to have changed that I can't spot. Only should be ignored if a child control has focus - Escape and F1 should continue to work. I

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi Shruti On Mon, Jun 12, 2017 at 3:24 PM, Shruti B Iyer wrote: > > Hello Dave, > > Thanks for making those fixes and sharing them with us. We tried applying > the patch and it looks like there are some missing file changes from your > patch that were present in ours, like the

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

Adding Shirley... Hi On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar wrote: > Hi > > The current font-family applied to slick-grid is 'Verdana,Arial,sans-serif'. > I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif but > the font size and

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi I confirm this is updated patch. PFA patch. On Mon, Jun 12, 2017 at 6:20 PM, Dave Page wrote: > Hi > > Is that the correct patch? Hitting in a comment text area is > still causing the dialogue to close.​ > Thanks. > > On Mon, Jun 12, 2017 at 12:55 PM, Surinder Kumar >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

Hi Khushboo, Looks like this patch broke the regressions tests :-(. Can you take a look ASAP please? Thanks! 2017-06-12 10:04:11,938: INFO werkzeug: 127.0.0.1 - - [12/Jun/2017 10:04:11] "GET /browser/table/sql/1/1/12669/2200/81920 HTTP/1.1" 500 - Traceback (most recent call last): File

[pgadmin-hackers] pgAdmin 4 commit: Properly handle trigger functions with parameters. Fi

Properly handle trigger functions with parameters. Fixes #2043 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c435d488853b7b52f33b8d01fe98b5938e6fd835 Author: Murtuza Zabuawala Modified Files

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python35 #155

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi Is that the correct patch? Hitting in a comment text area is still causing the dialogue to close. Thanks. On Mon, Jun 12, 2017 at 12:55 PM, Surinder Kumar wrote: > Hi > > Please find rebased patch > > Thanks > > On Mon, Jun 12, 2017 at 5:20 PM, Dave Page

[pgadmin-hackers] pgAdmin 4 commit: Allow editing of the WITH ADMIN option of role member

Allow editing of the WITH ADMIN option of role membership. Fixes #2086 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ec5bc23dfdb41da1b5ccd4ab2ab2e6244d8b5ebd Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

Hi The current font-family applied to slick-grid is 'Verdana,Arial,sans-serif'. I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif but the font size and spacing between text is reduced. so to match style I used "Verdana". Also, as per my knowledge, the Helvetica font will work

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hello Dave, Thanks for making those fixes and sharing them with us. We tried applying the patch and it looks like there are some missing file changes from your patch that were present in ours, like the Make.bat file changes. But we will add them when we send you the new patches. While trying to

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Role Membership control

Thanks applied. On Mon, Jun 12, 2017 at 1:46 PM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue in Role Membership control, In edit mode > user was unable to toggle grant admin privileges to membership roles. > RM#2086 > > -- > Regards, >

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

Shirley and I are in SF this week so we will be even more async that usual. -- Rob On Mon, Jun 12, 2017 at 7:33 AM, Dave Page wrote: > Adding Shirley... > > Hi > > On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar > wrote: > > Hi > > > > The

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python36 #156

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #154

See Changes: [Dave Page] Fix error on the stats tab with PG10. Also, rename the 10.0_plus [Dave Page] Properly handle trigger functions with parameters. Fixes #2043 [Dave Page] Refresh the SQL editor

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi Dave, Please find updated patch. On Mon, Jun 12, 2017 at 7:58 PM, Dave Page wrote: > Hi > > On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar > wrote: > > Hi > > > > I confirm this is updated patch. > > Thanks. Something else seems to have

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in displaying Trigger SQL

Thanks, patch applied. On Mon, Jun 12, 2017 at 10:54 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in Table node where it was not displaying > reversed engineered sql for Trigger(s) properly, if trigger function > associated with that

[pgadmin-hackers] pgAdmin 4 commit: Add linting support, and, well, lint.

Add linting support, and, well, lint. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f4f8b9e77204a62ecdbf99caf296b6ac39b0f5e Author: Shruti B Iyer Modified Files -- web/.eslintrc.js

[pgadmin-hackers] pgAdmin 4 commit: Bring React into the tree, and add linting and bundli

Bring React into the tree, and add linting and bundling framework for the JS etc. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=659eb1c1e821e2ea414dc00d22022b8a2d7c91f7 Author: Shruti B Iyer Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Add a missing translation call.

Add a missing translation call. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f1acad85db4b9bf8a201cd8b6d90c703322a0073 Author: Shruti B Iyer Modified Files -- web/pgadmin/static/js/selection/grid_selector.js |

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Translatable Text in Query Results Header

Thanks, applied. On Mon, Jun 12, 2017 at 4:43 PM, Shruti B Iyer wrote: > Hi Hackers! > > Attached is a minor patch that wraps with gettext() the "Select/Deselect > All" text in the top left corner of the query results grid. > > Thanks, > Matt and Shruti > > > -- > Sent via

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #153

See Changes: [Dave Page] Bring React into the tree, and add linting and bundling framework for [Dave Page] Add linting support, and, well, lint. [Dave Page] Add a missing translation call.

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

To add to that; running the JS tests gives: ERROR in ./regression/javascript/history/query_history_entry_spec.jsx Module not found: Error: Can't resolve 'jasmine-enzyme' in '/Users/dpage/git/pgadmin4/web/regression/javascript/history' @

[pgadmin-hackers] PACKAGERS BEWARE: Build changes required

I've just committed a couple of patches that change the requirements for building pgAdmin for packages: - You will need node.js and yarn to be installed for building - During the build process, do something like this: cd $PGADMIN_SRC/web yarn install yarn run bundle This will create

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #157

See Changes: [Dave Page] Bring React into the tree, and add linting and bundling framework for [Dave Page] Add linting support, and, well, lint. [Dave Page] Add a missing translation call.

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #281

See Changes: [Dave Page] Bring React into the tree, and add linting and bundling framework for [Dave Page] Add linting support, and, well, lint. [Dave Page] Add a missing translation call.

[pgadmin-hackers] pgAdmin 4 commit: Teach dialogues about Escape to cancel, Enter to Save

Teach dialogues about Escape to cancel, Enter to Save/OK, and F1 for help. Fixes #1535 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af43ccfc07bd1f919015b79ce9c9e7e06d92cf6a Author: Surinder Kumar Modified

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Thanks, applied. On Mon, Jun 12, 2017 at 3:52 PM, Surinder Kumar wrote: > Hi Dave, > > Please find updated patch. > > On Mon, Jun 12, 2017 at 7:58 PM, Dave Page wrote: >> >> Hi >> >> On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar >>

[pgadmin-hackers] [pgAdmin4] [PATCH] Translatable Text in Query Results Header

Hi Hackers! Attached is a minor patch that wraps with gettext() the "Select/Deselect All" text in the top left corner of the query results grid. Thanks, Matt and Shruti query_results_gettext.diff Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #160

See Changes: [Dave Page] Bring React into the tree, and add linting and bundling framework for [Dave Page] Add linting support, and, well, lint. [Dave Page] Add a missing translation call.

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

Hello Hackers, We sent the wrong patch. Attached is the correct one. Sorry Shruti & Joao On Mon, Jun 12, 2017 at 3:08 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > We were trying to run the feature tests against GreenPlum and one of the > tests was

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

Hi Dave, We regenerated the patch to add new tasks to package.json to compile react code for development and to not minimize it. This should fix the error you captured in the screenshot. The new task to lint and bundle everything for development is: yarn run bundle:dev The new task only bundle

[pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

Hi Hackers, We were trying to run the feature tests against GreenPlum and one of the tests was failing (CheckForViewDataTest). In this test, we are creating a table using COLLATE, and the COLLATE command is only available starting in version 9.1 of Postgres, per the documentation. We decided to

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

Hi, On Mon, Jun 12, 2017 at 8:24 PM, Dave Page wrote: > Hi Khushboo, > > Looks like this patch broke the regressions tests :-(. Can you take a look > ASAP please? > > please find the attached fix. However I didn't get any error while running regression tests. > Thanks! > >

[pgadmin-hackers] pgAdmin 4 commit: Stop ignoring yarn.lock, per discussion with Pivotal

Stop ignoring yarn.lock, per discussion with Pivotal team. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=59da69087cd32ea9e4996f87bae62c8c31dc632b Author: George Gelashvili Modified Files -- .gitignore

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in displaying Trigger SQL

Hi, PFA patch to fix the issue in Table node where it was not displaying reversed engineered sql for Trigger(s) properly, if trigger function associated with that trigger has parameters. RM#2043 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

[pgadmin-hackers] pgAdmin 4 commit: Fix the PostGIS Datatypes in SQL tab, Create / Update

Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for Table, Column, Foreign Table and Type node. Fixes #2324 Note that this doesn't add full support for PostGIS types to the table/column dialogues, which still can't handle the typmod usage. It does bring support to parity with

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

Thanks, applied. On Fri, Jun 9, 2017 at 10:18 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Fixed the PostGIS Datatypes in SQL tab, Create / Update dialogues for > Table, Column, Foreign Table and Type node. > > Regarding the

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

Hi Please find rebased patch Thanks On Mon, Jun 12, 2017 at 5:20 PM, Dave Page wrote: > Could you rebase this please? > > Thanks. > > On Fri, Jun 9, 2017 at 10:40 AM, Surinder Kumar > wrote: > > Ignore previous patch as it doesn't contains

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

Hi On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to reset the zoom level in the desktop > runtime. > > Added the new shortcut CTRL + 0 to reset the zoom level. The code looks good, however I don't think resetting

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #155

See Changes: [Dave Page] Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for [Dave Page] Fix error on the stats tab with PG10. Also, rename the 10.0_plus

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the bac

Using client-side 'url_for' implementation in the backup module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a46f7b1eb7246f34f05b1bf2a2429c2cff7ea9e Modified Files -- web/pgadmin/tools/backup/__init__.py| 15

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the res

Using client-side 'url_for' implementation in the restore module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f9a387822047f862b01fb62e879b071b1e3c3c00 Modified Files -- web/pgadmin/tools/restore/__init__.py |

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #282

See Changes: [Ashesh Vashi] Using client-side 'url_for' implementation in the module - bgprocess [Ashesh Vashi] Using client-side 'url_for' implementation in the backup module. [Ashesh Vashi] Using

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #158

See Changes: [Ashesh Vashi] Using client-side 'url_for' implementation in the module - bgprocess [Ashesh Vashi] Using client-side 'url_for' implementation in the backup module. [Ashesh Vashi] Using

[pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Hi Changes: 1) When Query tool is opened, right now - panel title is displayed as "Query - 1 ", instead it should display Query - [db_name] on [server_name] as in pgAdmin3. 2) When Edit grid is opened for table, the panel title should display Edit Data - [server_name] - [db_name] - [table_name]

[pgadmin-hackers] pgAdmin 4 commit: Using client-side 'url_for' implementation in the mod

Using client-side 'url_for' implementation in the module - bgprocess (background-processes). Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a7c9d5ca1e0d92c113b093aa5cf2c2a34092b59 Modified Files --

[pgadmin-hackers] [pgAdmin4][PATCH] CREATE Script do not display properly on panel resize

Hi, PFA patch to fix the issue where SQL Panel in query tool displays truncated sql on resize. RM#2078 Steps to re-produce the issue: 1) Create table provided by user from RM. 2) Right click on newly created table 3) Select 'Script' -> 'CREATE Script' 4) Drag the splitter down side to maximise