[pgadmin-hackers] depends.js and sql.js

2016-03-15 Thread Dave Page
Hi Ashesh, Any reason the above files are in static directories? Both have strings in them that should be translated. FYI, I'm not overly sure what needs to be done to move them these days - I haven't looked into the require code at all. Thanks. -- Dave Page Blog: http://pgsnake.bl

Re: [pgadmin-hackers] depends.js and sql.js

2016-03-15 Thread Dave Page
On Tue, Mar 15, 2016 at 4:01 PM, Ashesh Vashi wrote: > On Tue, Mar 15, 2016 at 9:22 PM, Dave Page wrote: > >> Hi Ashesh, >> >> Any reason the above files are in static directories? Both have >> strings in them that should be translated. >> > When it was i

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-15 Thread Dave Page
> Note: When using this control model should have *column* attribute. And >> node property should be *column*. >> >> >> >> >> -- >> *Harshal Dhumal* >> *Software Engineer * >> >> >> >> EenterpriseDB <http://www.enterprisedb.com> >> > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-03-16 Thread Dave Page
given > input will be without space in the grid then it will expand. For this, we > can make table layout fixed. So, please suggest, should I do that or not? Yes, I think it should be fixed. If the grid row is expanded, presumably it'll show in a multi-line field anyway? Plus th

[pgadmin-hackers] pgAdmin 4 commit: Add a data type reader utility.

2016-03-16 Thread Dave Page
Add a data type reader utility. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a18553bd8c26010a89e50c6057eaf826ebe9b7a3 Author: Khushboo Vashi Modified Files -- .../templates/datatype/sql/9.1_plus/get_types.sql | 18 + .../ser

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Data-type Reader

2016-03-16 Thread Dave Page
> > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.en

[pgadmin-hackers] pgAdmin 4 commit: Re-shuffle server properties.

2016-03-16 Thread Dave Page
Re-shuffle server properties. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2fb6ccf5b2e9dedc9fd9134b43cfc89857ba86fd Modified Files -- .../server_groups/servers/templates/servers/servers.js | 16 1 file changed,

[pgadmin-hackers] pgAdmin 4 commit: Sort all nodes when loading.

2016-03-16 Thread Dave Page
Sort all nodes when loading. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=41805d40b5f4872ad4aa24f625391927fd09f1c7 Modified Files -- web/pgadmin/browser/server_groups/__init__.py | 2 +- web/pgadmin/browser

[pgadmin-hackers] pgAdmin 4 commit: Add support for inline fieldsets.

2016-03-18 Thread Dave Page
Add support for inline fieldsets. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=530f58e66bc0b04ec80be891767e26513b850ea0 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/overrides.css | 9 + web/pga

Re: [pgadmin-hackers] Control for displaying "auto vacuum" fields into grid

2016-03-18 Thread Dave Page
; }, > { > name: 'setting', label: '{{ _("Default value") }}', > cellFunction: cellFunction, editable: false > } > ] > }), > > > When using this control, provide following parameters in schema: > 1. mo

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-03-18 Thread Dave Page
eld from pg_type for the > base_type selected for the Domain. > If the typcategory is String type (i.e. S), then only I have used qtLiteral > function to quote the default value. > > Is this right approach or not? Yes, I think that's a good approach (at least, I don't see an

[pgadmin-hackers] pgAdmin 4 commit: Add support for domain dependencies/dependents.

2016-03-18 Thread Dave Page
Add support for domain dependencies/dependents. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a99282e07c8ffed855307cd2a268fa465bd9fe0 Author: Khushboo Vashi Modified Files -- .../servers/templates/depends/sql/9.1_plus/dependents

Re: [pgadmin-hackers] Subnode grid row close issue [pgAdmin4]

2016-03-18 Thread Dave Page
> This doesn't appear to make any difference to me. I've confirmed the patch is applied, restarted the app, emptied my cache and reloaded, and tested with composite types on the Create Type dialogue. I still see multiple row forms when I hit the ADD button if one is already open. --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added Support for the Domain Dependencies

2016-03-19 Thread Dave Page
ia pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise Postg

[pgadmin-hackers] pgAdmin 4 commit: Support "show system objects" in casts.

2016-03-19 Thread Dave Page
Support "show system objects" in casts. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=71badac203f3199e58eac1f45654d41a1bf52812 Author: Sanket Mehta Modified Files -- .../servers/databases/casts/__init__.py| 47 +++

[pgadmin-hackers] pgAdmin 4 commit: First pass at improving the dialogue borders.

2016-03-19 Thread Dave Page
First pass at improving the dialogue borders. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=05e527505da507758ff407e6ccb5c45c679f63a3 Author: Arun Kollan Modified Files -- web/pgadmin/static/css/wcDocker/Themes/pgadmin.css | 30 ++

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

2016-03-19 Thread Dave Page
hole instead having separate code for each control/element. > That frame is because we used ‘FieldsetControl’ of backform to group all the > elements of Range type. Can you make it a plain div with no border/title? That would fit in better with the existing styling, assuming the columns line up pr

[pgadmin-hackers] pgAdmin 4 commit: Add support for Foreign data wrappers, servers and us

2016-03-19 Thread Dave Page
Add support for Foreign data wrappers, servers and user mappings. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3969e915630d2e566575be5dac99d2b79b5093b3 Author: Neel Patel Modified Files -- .../databases/foreign_data_wrappers/__i

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-03-19 Thread Dave Page
of doing "ALTER DOMAIN ... VALIDATE CONSTRAINT" - If I switch the "Don't Validate" switch on a constraint, there are leading blank lines in the generated SQL. The same occurs when adding a comment to a constraint. - I think we need to reverse the meaning of "Don

Re: [pgadmin-hackers] PATCH: Updated catalog names [pgAdmin4]

2016-03-19 Thread Dave Page
> -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprised

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

2016-03-19 Thread Dave Page
d, did, scid), ensure error messages are properly pluralised, e.g. 'Composite types require at least two members' or 'External types require both Input & Output conversion functions.' - additional_features.sql is poorly formatted (lack of proper indentation) Thanks! -- Dave Page

[pgadmin-hackers] pgAdmin 4 commit: Support textareas in backgrid.

2016-03-19 Thread Dave Page
Support textareas in backgrid. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3df180831f161f96cf0a2d251606c720114b4733 Author: Khushboo Vashi Modified Files -- web/pgadmin/static/css/overrides.css | 9 +++ web/pg

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-19 Thread Dave Page
exception that it expands to multiple rows if needed, as it does). Thanks. [image: Inline image 2][image: Inline image 1] -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added Support for the Domain Dependencies

2016-03-19 Thread Dave Page
Thanks, applied. On Fri, Mar 18, 2016 at 10:41 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch for the same. > > Thanks, > Khushboo > > On Fri, Mar 18, 2016 at 4:02 PM, Dave Page wrote: >> >> Can you rebase please? >>

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

2016-03-19 Thread Dave Page
On Wed, Mar 16, 2016 at 1:18 PM, Ashesh Vashi wrote: > On Wed, Mar 16, 2016 at 6:32 PM, Dave Page wrote: > >> Hi >> >> On Mon, Mar 14, 2016 at 12:21 PM, Murtuza Zabuawala >> wrote: >> > Hi Dave, >> > >> > Thank you for reviewing

Re: [pgadmin-hackers] patch for cast module

2016-03-19 Thread Dave Page
it looks good, please commit. >> >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Fri, Mar 4, 2016 at 4:33 PM, Dave Page wrote: >>> >>> Thanks, patch applied. >>> >>> On Tue, M

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

2016-03-19 Thread Dave Page
; > On Wed, Mar 16, 2016 at 8:44 PM, Dave Page wrote: > >> Hi >> >> Almost there :-) >> >> - The text felds on the Options grid resize when they're in Edit mode. >> See the recent patch by Arun to prevent this in other nodes. >> >> - If

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-19 Thread Dave Page
; -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB <http://www.enterprisedb.com> > > On Tue, Mar 15, 2016 at 10:13 PM, Dave Page wrote: > >> It seems to be missing the test dialogue? >> >> On Tue, Mar 15, 2016 at 8:47

Re: [pgadmin-hackers] [PATCH] Enhancement in sql-field control [pgAdmin4]

2016-03-20 Thread Dave Page
g', > type: 'text', mode: ['create', 'edit'], group: 'Definition', > control: Backform.SqlFieldControl, > extraClasses:['custom_height_css_class'] > } > > > Please review the attached patch and commit if it looks good. Thanks. Wh

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

2016-03-20 Thread Dave Page
reproduce the issue, if you found with latest > attached patch file ? > > Thanks, > Neel Patel > > On Fri, Mar 11, 2016 at 7:41 PM, Dave Page wrote: > >> OK, I'll add --binary next time. Not sure why I didn't think of that... >> >> Thanks. >> &g

[pgadmin-hackers] pgAdmin 4 commit: Properly name the dbo and sys catalogs in PPAS.

2016-03-20 Thread Dave Page
Properly name the dbo and sys catalogs in PPAS. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3432481f9aaf55a13e4a7e15283c1674a61dd208 Author: Murtuza Zabuawala Modified Files -- .../databases/schemas/templates/catalog/ppas/macro

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Backgrid Textarea Cell

2016-03-20 Thread Dave Page
resql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing

Re: [pgadmin-hackers] Fix PSQL Console plugin for OS X

2016-03-21 Thread Dave Page
Remove `with command` (not wrong, but redundant). > 3) Add `in window 1`. This is essential, otherwise the command fails. Similarly, that's never been an issue for me. > 4) Move `activate` at the end. This change is not strictly necessary, it is > just a matter personal preferenc

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

2016-03-22 Thread Dave Page
ction, OUTPUT = my_box_out_function ); CREATE TABLE myboxes ( id integer, description box ); -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-

[pgadmin-hackers] pgAdmin III commit: Fix the psql plugin command on OSX to work more rel

2016-03-22 Thread Dave Page
Fix the psql plugin command on OSX to work more reliably. Branch -- REL-1_22_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9f40cab816727d55490ca8354df6543c4bf74cd9 Author: Nicola Vitacolonna Modified Files -- CHANGELOG | 2 +

[pgadmin-hackers] pgAdmin III commit: Fix the psql plugin command on OSX to work more rel

2016-03-22 Thread Dave Page
Fix the psql plugin command on OSX to work more reliably. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=1ea137ff08fee6de57b89be8f61c6946d88bebe8 Author: Nicola Vitacolonna Modified Files -- CHANGELOG | 2 ++ plugins.d/

Re: [pgadmin-hackers] Fix PSQL Console plugin for OS X

2016-03-22 Thread Dave Page
Hi On Tue, Mar 22, 2016 at 9:39 AM, Nicola wrote: > On 2016-03-21 14:33:27 +0000, Dave Page said: > >> Hi >> >> On Fri, Mar 18, 2016 at 9:44 PM, Nicola Vitacolonna >> wrote: >>> >>> The PSQL Console command has been broken for a long time on OS

Re: [pgadmin-hackers] Suggestion on "External types" sql query in pgAdmin3

2016-03-22 Thread Dave Page
ion must be declared to take a single argument of type internal, and return a boolean result. Unless it's trivial, please don't spend time trying to fix this in pgAdmin 3. Clearly noone has run into it in years, so I'd rather concentrate on getting it right for pgAdmin 4. --

[pgadmin-hackers] pgAdmin 4 commit: Update the Browser Tree Node Icon after editing.

2016-03-22 Thread Dave Page
Update the Browser Tree Node Icon after editing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8ca134871ff1b2e40ef6d052cdb258d750d18ec0 Author: Khushboo Vashi Modified Files -- web/pgadmin/browser/templates/browser/js/node.js | 4

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Update the Browser Tree Node Icon after editing

2016-03-22 Thread Dave Page
hushboo > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.en

Re: [pgadmin-hackers] Speed up node animation in pgAdmin4

2016-03-22 Thread Dave Page
ower numbers. > Also - decreased the initial load time to make sure, we load the browser > tree node asap (50 microseconds after tree initialised). Hmm, not sure I like the feel now. I think it needs to be either instant, or slower than it is. The behaviour feels odd as it

[pgadmin-hackers] pgAdmin 4 commit: Make tabsets look consistent, and square off the prop

2016-03-22 Thread Dave Page
Make tabsets look consistent, and square off the properties sections a little. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06c0cf607d2799b9a40679064b837c251ba4caf2 Author: Arun Kollan Modified Files -- web/pgadmin/static/css/ov

Re: [pgadmin-hackers] Switch control options issue [pgadmin4]

2016-03-22 Thread Dave Page
den. > > > -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB <http://www.enterprisedb.com> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http:/

[pgadmin-hackers] pgAdmin 4 commit: Configuration options for switch control from differe

2016-03-22 Thread Dave Page
Configuration options for switch control from different places should be merged together and not overridden. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8189b39b1e6b63677ee7ede8f6704127eb2be9c3 Author: Harshal Dhumal Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Server side session management support.

2016-03-22 Thread Dave Page
Server side session management support. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3c366fafe7752cb514e04935ca9771afd735b6ff Author: Ashesh Vashi Modified Files -- web/config.py| 36 ++- web/pgadmin/__init__

Re: [pgadmin-hackers] Server side session management using the SQLite (per session) database

2016-03-22 Thread Dave Page
ceful reconnections)? > Murtuza, > > I have tested it on Python 2.7. > Can you please take a look at it, and do the needful to make it work on > Python 3.x? > Please double-check Windows as well. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] On restarting/reloading the server establish the connections with database server smoothly

2016-03-22 Thread Dave Page
n-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Graceful server reconnections.

2016-03-22 Thread Dave Page
Graceful server reconnections. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b3c625f135c80f48b3df05bf72e7c1b51ca8de5f Author: Ashesh Vashi Modified Files -- web/pgadmin/utils/driver/psycopg2/__init__.py | 152

[pgadmin-hackers] pgAdmin 4 commit: Update the backform control to support sql-fields.

2016-03-22 Thread Dave Page
Update the backform control to support sql-fields. Following are the enhancements: 1. Added border to control which was missing earlier. 2. Allows user to provide height to sql-field control by specifying extraClasses field in model schema. 3. Defined new classes for sql-field control height in o

Re: [pgadmin-hackers] [PATCH] Enhancement in sql-field control [pgAdmin4]

2016-03-22 Thread Dave Page
On Mon, Mar 21, 2016 at 5:01 AM, Surinder Kumar wrote: > Hi, > > Please find updated patch. > > On Fri, Mar 18, 2016 at 9:18 PM, Dave Page wrote: >> >> On Fri, Mar 18, 2016 at 2:36 PM, Surinder Kumar >> wrote: >> > Hi, >> > >

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-22 Thread Dave Page
*Software Engineer * >> >> >> >> EenterpriseDB <http://www.enterprisedb.com> >> >> On Fri, Mar 18, 2016 at 9:37 PM, Dave Page wrote: >> >>> >>> >>> On Fri, Mar 18, 2016 at 11:41 AM, Harshal Dhumal < >>> harshal.

[pgadmin-hackers] pgAdmin 4 commit: Backform control for selecting multiple columns.

2016-03-22 Thread Dave Page
Backform control for selecting multiple columns. Usage: { id: 'columns', label: '{{ _('Columns') }}', type: 'collection', group: '{{ _('Definition') }}', editable:true, canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl, deps: ['index'], node: 'column', model: pgB

[pgadmin-hackers] pgAdmin 4 commit: Ignore pycharms project directory.

2016-03-22 Thread Dave Page
Ignore pycharms project directory. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5b8c965fb713e1a6e82215ad6aa654c0646b7cc2 Modified Files -- .gitignore | 1 + 1 file changed, 1 insertion(+) -- Sent via pgadmin-hackers mailing lis

[pgadmin-hackers] pgAdmin 4 commit: Fix issues with multiple subnode forms being open at

2016-03-22 Thread Dave Page
Fix issues with multiple subnode forms being open at once when adding rows to a grid. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=709311b77c668fe4572c200873af9ff306430a44 Author: Harshal Dhumal Modified Files -- web/pgadmin/st

Re: [pgadmin-hackers] Subnode grid row close issue [pgAdmin4]

2016-03-22 Thread Dave Page
special case of subnode > control). Now I have fixed in both control. > > > > -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB <http://www.enterprisedb.com> > > On Thu, Mar 17, 2016 at 6:41 PM, Dave Page wrote: > >> Hi >> >

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-03-22 Thread Dave Page
On Mon, Mar 21, 2016 at 7:41 AM, Khushboo Vashi wrote: > Hi Dave, > > > On Fri, Mar 18, 2016 at 8:31 PM, Dave Page wrote: >> >> On Thu, Mar 17, 2016 at 5:39 PM, Khushboo Vashi >> wrote: >> > Hi Dave, >> > >> > I have a query regarding y

Re: [pgadmin-hackers] Server side session management using the SQLite (per session) database

2016-03-23 Thread Dave Page
On Wed, Mar 23, 2016 at 7:32 AM, Ashesh Vashi wrote: > On Tue, Mar 22, 2016 at 8:41 PM, Dave Page wrote: > >> Hi >> >> On Thu, Mar 17, 2016 at 5:46 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi Dave/team, >>>

Re: [pgadmin-hackers] Server side session management using the SQLite (per session) database

2016-03-23 Thread Dave Page
On Wed, Mar 23, 2016 at 9:04 AM, Magnus Hagander wrote: > > > On Tue, Mar 22, 2016 at 4:11 PM, Dave Page wrote: >> >> Hi >> >> On Thu, Mar 17, 2016 at 5:46 PM, Ashesh Vashi >> wrote: >>> >>> Hi Dave/team, >>> >>> As dis

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-03-23 Thread Dave Page
gt;> >> On Wed, Mar 16, 2016 at 9:40 PM, Dave Page wrote: >>> >>> Hi >>> >>> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi >>> wrote: >>> > Hi, >>> > >>> > Please find the updated Domain Module Patch

[pgadmin-hackers] pgAdmin 4 commit: Set appropriate default values for the boolean switch

2016-03-23 Thread Dave Page
Set appropriate default values for the boolean switch control. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a6e96c55767a870f4114d4eee92113dbca9648d6 Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 6 +++--- 1 file ch

[pgadmin-hackers] pgAdmin 4 commit: Don't display packages as schemas.

2016-03-23 Thread Dave Page
Don't display packages as schemas. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=258c7f3589f3a62a81552ab492af9a9dae40d6f4 Modified Files -- .../databases/schemas/templates/schema/ppas/9.1_plus/sql/nodes.sql | 1 + .../databas

[pgadmin-hackers] pgAdmin 4 commit: We have defaults for switch display now, so no need t

2016-03-23 Thread Dave Page
We have defaults for switch display now, so no need to set the options explicitly. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ac16cbc0ff66d2387b139779a71189d98959eea Modified Files -- .../servers/databases/schemas/templates/s

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

2016-03-23 Thread Dave Page
ound: procedure/pg/sql/9.5_plus/node.sql 2016-03-23 11:28:57,953: INFO werkzeug: 127.0.0.1 - - [23/Mar/2016 11:28:57] "POST /ping HTTP/1.1" 200 - - Procedures do not include the schema name in the headers of reverse engineered SQL, e.g. - What's the trailing - in the parame

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-03-23 Thread Dave Page
e that's done, it can be committed I think. Thanks. On Wed, Mar 23, 2016 at 7:27 AM, Khushboo Vashi wrote: > Updated one comment. > > On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi > wrote: >> >> Hi, >> >> Please find attached updated patch for the Domai

[pgadmin-hackers] pgAdmin 4 commit: String improvements.

2016-03-23 Thread Dave Page
String improvements. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=72f635356175ac94cdcc0e4c122a16629df06f5f Modified Files -- web/pgadmin/browser/templates/browser/js/browser.js | 10 +- 1 file changed, 5 insertions(+), 5 d

[pgadmin-hackers] pgAdmin 4 commit: String improvements.

2016-03-23 Thread Dave Page
String improvements. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a2374329efb07a9a4532f4c719c0704e8c3037c Modified Files -- web/pgadmin/browser/templates/browser/js/node.js | 8 1 file changed, 4 insertions(+), 4 deletio

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-03-24 Thread Dave Page
n" (with a constraint icon) and "Domain..." with a domain icon. See attached screenshot. Thanks. On Thu, Mar 24, 2016 at 9:54 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch for the Domain module. > > Thanks, > Khushboo > >

[pgadmin-hackers] pgAdmin 4 commit: Add support for functions and procedures.

2016-04-05 Thread Dave Page
Add support for functions and procedures. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ed7015ebc92c161a15e0b959846286967142f3c Author: Khushboo Vashi Modified Files -- .../databases/schemas/functions/__init__.py| 1314 +

[pgadmin-hackers] pgAdmin 4 commit: Utility functions for trigger and rule nodes, central

2016-04-05 Thread Dave Page
Utility functions for trigger and rule nodes, centralised because they're also utilised by the view node. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1eb3fd9d59eaa6d2324d93511eb27c325820f94 Author: Surinder Kumar Modified Files -

Re: [pgadmin-hackers] [pgAdmin4] PATCH: Added Utility functions for triggers node and rules node

2016-04-05 Thread Dave Page
to schema/utils.py > > > Please review the patch. > > > Thanks, > Surinder Kumar > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

2016-04-05 Thread Dave Page
Thanks - committed. On Mon, Mar 28, 2016 at 8:26 AM, Khushboo Vashi wrote: > Hi, > > Please find updated patch for the functions/procedures module. > > Thanks, > Khushboo > > On Wed, Mar 23, 2016 at 5:33 PM, Dave Page wrote: >> >> On Tue, Mar 22, 2016 a

[pgadmin-hackers] pgAdmin 4 commit: Add support for domains.

2016-04-05 Thread Dave Page
Add support for domains. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2add0155a3ff1de68bebfa78eed5b4d2248d34e9 Author: Khushboo Vashi Modified Files -- .../servers/databases/schemas/domains/__init__.py | 824 +++

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-04-05 Thread Dave Page
Thanks - committed. On Thu, Mar 24, 2016 at 3:25 PM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch for the Domains Module. > > Thanks, > Khushboo > > On Thu, Mar 24, 2016 at 5:29 PM, Dave Page wrote: >> >> Hi >> >> You

[pgadmin-hackers] pgAdmin 4 commit: Revert style change introduced in commit f7e4e8bea010

2016-04-05 Thread Dave Page
Revert style change introduced in commit f7e4e8bea01074fffd0f6f8fc8570a7518ff9137 as it's removing padding from all grids. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=34ef5790ba2476e9594a6997ab0b5c7232e3d902 Modified Files --

Re: [pgadmin-hackers] Patch: Added select2cell editor for backgrid [pgAdmin4]

2016-04-05 Thread Dave Page
gards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> <http://www.enterprisedb.com/> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> <http://www.linkedin.com/in/asheshvashi> >>> >>>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Minor adjustment to the menu font sizing.

2016-04-05 Thread Dave Page
Minor adjustment to the menu font sizing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=01d6b46838a2befc6cf8e1c0a28188c058d9f94c Modified Files -- web/pgadmin/static/css/wcDocker/Themes/pgadmin.css | 8 1 file changed, 4 i

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

2016-04-05 Thread Dave Page
lears that issue up for me. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://ww

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-05 Thread Dave Page
virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request rv = self.dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request return self.view_functions[rule

Re: [pgadmin-hackers] [pgAdmin4][Debugger]: Initial Patch

2016-04-06 Thread Dave Page
uot;frame.js" file and add the below line in "setTimeout" function which > is required by debugger. > > pgBrowser.Events.trigger('pgadmin-browser:frame:urlloaded:' > + that.name, frame, that.url, self); > > Do let us know if you still fac

Re: [pgadmin-hackers] [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool

2016-04-06 Thread Dave Page
rver, the query will execute correctly, however I should see appropriate messages when it's not running. - The layout of the result tabs should be maintained if new Query Tool or Edit Grid tabs are opened. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

2016-04-07 Thread Dave Page
. > > Please do review it and let me know in case of any issues. Did you send the right patch? I'm still getting the error (specifically, when rendering update.sql, render_template throws an exception "can't adapt type 'Undefined'") -- Dave Page Blog: http:/

Re: [pgadmin-hackers] [pgAdmin4][Patch] - Disable PrivilegeControl for nodes visible under catalog

2016-04-07 Thread Dave Page
h @ jquery-1.11.2.js:4665elemData.handle @ jquery-1.11.2.js:4333 -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresq

Re: [pgadmin-hackers] [pgAdmin4][Patch] - Disable PrivilegeControl for nodes visible under catalog

2016-04-07 Thread Dave Page
This time, with the screenshot... On Thu, Apr 7, 2016 at 11:14 AM, Dave Page wrote: > Hi > > On Thu, Apr 7, 2016 at 8:45 AM, Surinder Kumar > wrote: >> Hi, >> >> PFA minor patch for PrivilegeRoleModel >> >> Change: Add check to disable PrivilegeR

[pgadmin-hackers] pgAdmin 4 commit: Type support

2016-04-07 Thread Dave Page
Type support Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ca277bc8b67d6fe7ad3d0c56bc5cec510835226e Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/types/__init__.py| 1210 .../sc

[pgadmin-hackers] pgAdmin 4 commit: Fix sub-node error display.

2016-04-07 Thread Dave Page
Fix sub-node error display. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3914f5095a837c9005c1de2ff33fc7b0859b7d9b Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/overrides.css | 4 web/pgadmin/static

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

2016-04-07 Thread Dave Page
Hi Murtuza On Tue, Mar 22, 2016 at 9:22 AM, Dave Page wrote: > Hi > > On Tue, Mar 22, 2016 at 8:14 AM, Murtuza Zabuawala > wrote: >> Hi Dave, >> >> We can create new external type using below method, By running all of below >> queries at the same time , we c

Re: [pgadmin-hackers] [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool

2016-04-07 Thread Dave Page
ot;Add Row" button only works if you're on the last page of the >> resultset. >> > >OK. > >> >> - Can the "Copy Row" button also populate the clipboard with CSV data for >> the row? >> > >This required some research, not sure at the moment. > >> >> - In Edit mode, we need to be able to represent/set values to NULL. >> > >This will be taken care as part of multi-type rendering task. > OK. > >> - If I shutdown my pgAdmin server, then execute a query, I get no error, >> 0 rows displayed, and a message in the messages panel saying: >> >> Total query runtime: 46 msec >> 3 rows retrieved. >> >> If I restart the server, the query will execute correctly, however I >> should see appropriate messages when it's not running. >> >> - The layout of the result tabs should be maintained if new Query Tool or >> Edit Grid tabs are opened. >> > >OK. > Cool - thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Cleanup styling of wcDocker tab control buttons.

2016-04-07 Thread Dave Page
Cleanup styling of wcDocker tab control buttons. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=22841f86648d943da482bc343dec0972e9b27c36 Author: Arun Kollan Modified Files -- web/pgadmin/static/css/overrides.css | 13

Re: [pgadmin-hackers] Styling tab navigation and close buttons

2016-04-07 Thread Dave Page
from disclosure under applicable law. If you are not >> the intended recipient or authorized to receive this for the intended >> recipient, any use, dissemination, distribution, retention, archiving, or >> copying of this communication is strictly prohibited. If you have received

Re: [pgadmin-hackers] [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool

2016-04-07 Thread Dave Page
On Thu, Apr 7, 2016 at 2:03 PM, Akshay Joshi wrote: > Hi > > On Thu, Apr 7, 2016 at 6:01 PM, Dave Page wrote: > >> Hi >> >> On Thu, Apr 7, 2016 at 10:07 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >

[pgadmin-hackers] pgAdmin 4 commit: FTS Template support.

2016-04-07 Thread Dave Page
FTS Template support. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=95566ed5e13b66b47c672b8c60fb425d7bff06a7 Author: Sanket Mehta Modified Files -- .../databases/schemas/fts_templates/__init__.py| 719 + ..

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

2016-04-07 Thread Dave Page
Thanks - committed. On Thu, Apr 7, 2016 at 2:47 PM, Sanket Mehta wrote: > Hi, > > Sorry about that issue, > > Its resolved now. > > PFA the right patch with this mail. > > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On

Re: [pgadmin-hackers] Styling SQL box layout on dialogue

2016-04-07 Thread Dave Page
he browser's SQL tab. Arun to re-work. -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql

[pgadmin-hackers] pgAdmin 4 commit: String tweaks.

2016-04-07 Thread Dave Page
String tweaks. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=441a29f59c23bdbf1b905f4605dfb122a385eeaa Modified Files -- .../server_groups/servers/databases/schemas/fts_templates/__init__.py | 4 ++-- 1 file changed, 2 insertions(+)

[pgadmin-hackers] pgAdmin 4 commit: Fix node type label

2016-04-07 Thread Dave Page
Fix node type label Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=680339ff205dede6467ef81798caa6b3f8ca50d1 Modified Files -- .../schemas/fts_templates/templates/fts_template/js/fts_templates.js| 2 +- 1 file changed, 1 insertio

[pgadmin-hackers] pgAdmin 4 commit: FTS Parser support

2016-04-07 Thread Dave Page
FTS Parser support Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6d6361de54149a4cefd473c9a07deea3b7298f6 Author: Sanket Mehta Modified Files -- .../databases/schemas/fts_parser/__init__.py | 858 + 1 fil

[pgadmin-hackers] pgAdmin 4 commit: FTS Parser support

2016-04-07 Thread Dave Page
FTS Parser support Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=34a803fc687ed1880d13698a9457917700f41d26 Modified Files -- .../fts_parser/static/img/coll-fts_parser.png | Bin 0 -> 620 bytes .../schemas/fts_parser/static/img/

Re: [pgadmin-hackers] PATCH: pgadmin 4: FTS Parser

2016-04-07 Thread Dave Page
script module before sending for >> review again. >> (i.e. code should be wrapped after the line #79.) >> > Fixed > >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> <http://www.enterprisedb.com/> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> <http://www.linkedin.com/in/asheshvashi> >> >> >>> Regards, >>> Sanket Mehta >>> Sr Software engineer >>> Enterprisedb >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

2016-04-07 Thread Dave Page
Please also suggest whether we should go with 2.5.2(psycopg2) or with the > latest version. > > -- > > Thanks & Regards > > *Paresh More* > > [image: NEW-EDB-logo-4c] > > Pune, India. > Cell : +919922000564 | www.enterprisedb.com > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Improve dialog title bar colouring.

2016-04-07 Thread Dave Page
Improve dialog title bar colouring. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ec4b4f43ef4c1bc740bfa4167e3b80ec3731e8c Modified Files -- web/pgadmin/static/css/wcDocker/Themes/pgadmin.css | 13 - 1 file changed, 4 i

  1   2   3   4   5   6   7   8   9   10   >