[pgadmin-hackers] Fwd: pgAdmin IV : Unittest modular patch

Hi Dave, PFA patch for modular API test cases. Kindly, review the same and let me know for any modification. -- *Thanks,* *Navnath Gadakh* *Software Engineer* *Phone : + 91 9975389878* *The Postgres Database Company* diff --git a/web/config.py b/web/config.py index ff7c1db..6fb01ca 100644

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Hi Dave, PFA updated patch for modular API test cases. On Mon, Jul 11, 2016 at 5:11 PM, Dave Page wrote: > > > On Fri, Jul 8, 2016 at 2:30 PM, Navnath Gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> >> Hi Dave, >> >> PFA patch for modular

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

aised this bug in RM(#1464)), But still you can run the testsuite. It will run on Python 2.7 without error. On Fri, Jul 15, 2016 at 6:23 PM, Dave Page wrote: > Hi > > On Mon, Jul 11, 2016 at 2:16 PM, Navnath Gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hi D

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Hi Dave, Please find the attached patch for pgAdmin4 unittest(Support of API testing with different servers i.e. PG and PPAS). *This patch includes-* 1. Test framework support API testing with multiple server for this we need to modify test_config.json(for user it’s test_config.json

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Hi Dave, I tried to reproduce this issue at my end, but didn't work. Also tried with clean GIT tree. Will look more into this tomorrow. Thanks! On Fri, Jul 22, 2016 at 9:48 PM, Dave Page wrote: > Hi > > On Fri, Jul 22, 2016 at 2:22 PM, Navnath Gadakh > w

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

; > On Fri, Jul 22, 2016 at 2:22 PM, Navnath Gadakh > wrote: >> Hi Dave, >> >>Please find the attached patch for pgAdmin4 unittest(Support of API >> testing with different servers i.e. PG and PPAS). >> >> This patch includes- >> >> Test fr

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

ases that are created are also dropped > again. I'm getting tired of deleting them manually! I already added delete databases in tearDown () function, But yeah, I found two test cases where this code missed. I will add this in the next patch. > > Thanks, Dave. > > On Wed, Jul 2

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Hi Dave, On Mon, Aug 1, 2016 at 3:17 PM, Dave Page wrote: > On Thu, Jul 28, 2016 at 8:12 AM, Navnath Gadakh > wrote: >> Thanks Dave! >> >> On Wed, Jul 27, 2016 at 8:12 PM, Dave Page >> wrote: >>> Ahh, that explains it. Nice catch! It's work

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

n the previous email). I will look into this, need to decide approach what are the code changes required in the current code. Thanks! On Mon, Aug 1, 2016 at 3:56 PM, Dave Page wrote: > Hi > > On Mon, Aug 1, 2016 at 10:54 AM, Navnath Gadakh > wrote: > > Hi Dave, > > > &g

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Hi Dave, Thanks for clarification. On Wed, Aug 3, 2016 at 2:45 PM, Dave Page wrote: > Hi Navnath > > On Tue, Aug 2, 2016 at 3:58 PM, Navnath Gadakh > wrote: > > Hi Dave, > > Please find the attached patch. > > This patch includes: > > 1. API tes

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Hi Dave, On Wed, Aug 3, 2016 at 8:32 PM, Dave Page wrote: > On Wed, Aug 3, 2016 at 2:01 PM, Navnath Gadakh > wrote: > > Hi Dave, > > Thanks for clarification. > > > > On Wed, Aug 3, 2016 at 2:45 PM, Dave Page > > wrote: > >> > >&g

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Hi Dave, On Thu, Aug 4, 2016 at 4:04 PM, Dave Page wrote: > Hi > > On Thu, Aug 4, 2016 at 10:27 AM, Navnath Gadakh > wrote: > > >> Oh - does the per-server config override the main config? That's > >> useful. So anything that's in test_advanced_confi

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch(Schemas,Collations,Trigger Functions)

Tue, Aug 9, 2016 at 8:36 PM, Dave Page wrote: > Thanks - applied with some minor wording and README tweaks. > > On Tue, Aug 9, 2016 at 10:19 AM, Navnath Gadakh > wrote: > > Hi Dave, > > > > On Mon, Aug 8, 2016 at 9:15 PM, Dave Page > > wrote: > >>

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch(Schemas,Collations,Trigger Functions)

Summary display as discussed. > > Thanks again. > > On Fri, Aug 12, 2016 at 10:40 AM, Navnath Gadakh > wrote: > > Hi Dave, > > Please find the patch for API unit test cases for Schema and its > > sub-nodes (Collations and Trigger functions). > > You can run

[pgadmin-hackers] pgAdmin IV : Unittest modular patch (Domains and Tables nodes)

Code under 'tests' directory as its partially completed): python regression/runtests.py -- Thanks, Navnath Gadakh Software Engineer EnterpriseDB Corporation Mobile: +91 9975389878 domain_tables_apis.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmi

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch (Domains and Tables nodes)

test > cases until the existing issues are resolved and the enhanced summary and > object cleanup work is complete, otherwise it's just taking too much time > unnecessarily. > > Please re-test and resubmit this patch once that work is complete. > > Thanks. > > On

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch (Domains and Tables nodes)

Sure. On Thu, Sep 1, 2016 at 4:44 PM, Dave Page wrote: > Hi > > Please separate the cleanup from the new tests. Each patch should have > just one feature/focus/fix. > > Thanks. > > On Thu, Sep 1, 2016 at 12:12 PM, Navnath Gadakh < > navnath.gad...@enterprise

[pgadmin-hackers] Server specific advanced config file for testsuite

ed 'owner' to identify the server, but that fails if two servers have the same owner. -- Thanks, Navnath Gadakh Software Engineer EnterpriseDB Corporation Mobile: +91 9975389878

Re: [pgadmin-hackers] Server specific advanced config file for testsuite

ue, Sep 13, 2016 at 9:48 AM, Dave Page > wrote: > > Hi > > > > On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh > > wrote: > >> Hi Dave, > >> As we know that, we are using two JSON files one is for basic > >> configuration of

[pgadmin-hackers] pgAdmin IV: Unittests-drop objects functionality

browser.server_groups.servers 2. python regression/runtests.yp --pkg browser.server_groups.servers. databases *Note: *Please do not run test suite for all nodes (python regression/runtests.py) as code modifications have not been done yet. Thanks. -- Thanks, Navnath Gadakh Software Engineer EnterpriseDB

Re: [pgadmin-hackers] pgAdmin IV: Unittests-drop objects functionality

Hi Dave, Please find the revised patch with suggested modifications. On Wed, Sep 14, 2016 at 5:25 PM, Dave Page wrote: > Hi > > On Tue, Sep 13, 2016 at 3:39 PM, Navnath Gadakh > wrote: > > Hi Dave, > > Please find the patch for drop objects functionality for tes

[pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary

le, we go ahead with enhanced test summary. *To run the test suite follow the commands* 1. python regression/runtests.py --pkg browser.server_groups.servers 2. python regression/runtests.py --pkg browser.server_groups.servers.databases -- Thanks, Navnath Gadakh Software Engineer EnterpriseDB Co

Re: [pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary

Hi Dave, Error resolved. Please find the revised patch. On Fri, Sep 16, 2016 at 9:23 PM, Dave Page wrote: > Hi > > On Fri, Sep 16, 2016 at 2:37 PM, Navnath Gadakh > wrote: > > Hi Dave, > > Please find the patch for the enhanced test result summary for > test

Re: [pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary

Hi Dave, In the drop objects function scenario for 'NoneType' was not handled. Code is added in the revised patch. Thanks. On Mon, Sep 19, 2016 at 2:03 PM, Dave Page wrote: > Hi > > On Mon, Sep 19, 2016 at 8:14 AM, Navnath Gadakh > wrote: > > Hi Dave, > &g

Re: [pgadmin-hackers] Regression errors - database node

Hi Dave, After a long debugging of these errors with Harshal, we found the issue is in the handling pyscopg connection. Need to add some code in the pyscopg connection manager as per Harshal. For more details, Please refer RM #1720. @Harshal, than

Re: [pgadmin-hackers] Patch for RM1720 [pgadmin4]

Hi Dave, Can you please run testsuite for server or database node only, as there are some code modifications are remaining on the rest of the nodes. Currently i don't have a machine to look into issue, will check it tomorrow. Thanks. On 21-Sep-2016 6:50 PM, "Dave Page" wrote: > Hi > > O

Re: [pgadmin-hackers] Regression errors - database node

database node. Thanks. On Wed, Sep 21, 2016 at 4:46 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > After a long debugging of these errors with Harshal, we found the > issue is in the handling pyscopg connection. Need to add some code in the >

[pgadmin-hackers] pgAdmin IV: Code changes in roles and tablespaces test cases

Hi Dave, Please find the attached patch for the role and table spaces(Changes required due to drop objects functionality). Also, I have added the code in test result summary to show skipped test cases for tablespace if path not mentioned. To run testsuite: python regression/runtests.py --pkg br

[pgadmin-hackers] pgAdmin IV: schemas API test cases

Hi Dave, Please find the attached patch for Schema node. (Changes required due to drop object's functionality). To run test cases: python regression/runtests.py --pkg browser.server_groups.servers. databases.schemas Thanks. -- Regards, Navnath Gadakh EnterpriseDB Corporation The Enter

Re: [pgadmin-hackers] pgAdmin IV: schemas API test cases

Hi Dave, Please ignore previous patch. There are some conflicts in the code. I will send a revised patch later once 'casts' patch committed. Thanks. On Wed, Sep 28, 2016 at 2:42 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > Please fi

Re: [pgadmin-hackers] pgAdminIV : Regression tests code cleanup

ssociated tests failed, and I pretty quickly spotted (and fixed) the > bug as a result :-D > > Patch applied! > > On Fri, Oct 7, 2016 at 1:43 PM, Navnath Gadakh > wrote: > > Hi Dave, > > Please find the patch of test framework, which contains > > 1. Code chang

[pgadmin-hackers] pgAdmin IV: Resource group API test cases

Hi Dave, Please find the patch for Resource groups To run the test suite, use: python runtests.py -- Regards, Navnath Gadakh EnterpriseDB Corporation The Enterprise PostgreSQL Company resource_grps.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin

Re: [pgadmin-hackers] Language node patch

ia pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Regards, Navnath Gadakh EnterpriseDB Corporation The Enterprise PostgreSQL Company languages_modified.patch Description: Bi

Re: [pgadmin-hackers] PATCH: arguments of Trigger function was not displaying properly (pgAdmin4)

http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Regards, Navnath Gadakh

Re: [pgadmin-hackers] PATCH: arguments of Trigger function was not displaying properly (pgAdmin4)

Thanks Dave. On Thu, Nov 10, 2016 at 6:19 PM, Dave Page wrote: > Thanks Navnath. Excellent to see you fixing the bugs you find during > QA - that's very helpful. Patch applied. > > On Thu, Nov 10, 2016 at 10:13 AM, Navnath Gadakh > wrote: > > Hi Dave, > > > &

[pgadmin-hackers] pgAdmin IV: Minor code changes in API test cases

7 we will use the same type of data. - In drop object functionality we used some OS signals. There are some signals not supported by Windows. Code change add for it. -- Regards, Navnath Gadakh EnterpriseDB Corporation The Enterprise PostgreSQL Company apis_test_cases_code_changes.p

[pgadmin-hackers] pgAdmin4: Minor code change in test-suite (RM #2127)

gards, Navnath Gadakh EnterpriseDB Corporation The Enterprise PostgreSQL Company minor_code_change_in_testsuite_v1.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pg

Re: [pgadmin-hackers] pgAdmin4 regression setup

79 > > www.enterprisedb.co <http://www.enterprisedb.com/>m > <http://www.enterprisedb.com/> > > *Follow us on Twitter* > @EnterpriseDB > > Visit EnterpriseDB for tutorials, webinars, whitepapers > <http://www.enterprisedb.com/resources-community> and more > <http:

[pgadmin-hackers] pgAdmin4: Test result enhancement patch

Hi Dave, Please find the patch for test result enhancement. *What's in the patch:* 1. The test result summary will store in JSON file. 2. Removed some redundant code from *regression/test_utils.py* 3. To print test scenario names in failed and skipped test cases, I override *apply_scen

Re: [pgadmin-hackers] pgAdmin 4 commit: Re-organised the regression directory now we have mul

ests/utils.py | 2 +- > web/pgadmin/browser/tests/test_change_password.py | 4 +- > web/pgadmin/browser/tests/test_login.py| 3 +- > web/pgadmin/browser/tests/test_logout.py | 2 +- > web/pgadmin/browser/tests/test_reset_password.py | 4 +- > .../connect_to_server_feature_test.py | 2 +- > .../feature_tests/table_ddl_feature_test.py| 2 +- > .../python_test_utils/template_helper.py | 9 + > web/regression/runtests.py | 2 +- > web/regression/test_utils.py | 455 > - > 188 files changed, 871 insertions(+), 1254 deletions(-) > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Regards, Navnath Gadakh EnterpriseDB Corporation The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] pgAdmin 4 commit: Re-organised the regression directory now we have mul

ntaxError: invalid syntax * Will look into it. On Thu, Mar 23, 2017 at 6:00 PM, Dave Page wrote: > Update again please. I fixed it a couple of minutes later (I missed a > file). > > On Thu, Mar 23, 2017 at 12:23 PM, Navnath Gadakh > wrote: > > Hi Dave, > > > >

Re: [pgadmin-hackers] pgAdmin 4 commit: Re-organised the regression directory now we have mul

Yeah, just checked ...Running all now :) Thanks! On Thu, Mar 23, 2017 at 7:31 PM, Dave Page wrote: > That should also be fixed now. > > On Thu, Mar 23, 2017 at 12:45 PM, Navnath Gadakh > wrote: > > Thanks, It's running now for python2 but failing for python3. Its

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

Hi Dave, Please find the revised patch. On Wed, Mar 22, 2017 at 5:09 PM, Dave Page wrote: > Hi > > On Wed, Mar 22, 2017 at 6:03 AM, Navnath Gadakh > wrote: > > Hi Dave, > > > >Please find the patch for test result enhancement. > > What&#x

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

Hello Dave, On Fri, Mar 24, 2017 at 9:10 PM, Dave Page wrote: > Hi > > On Fri, Mar 24, 2017 at 3:13 PM, Navnath Gadakh > wrote: > > > >> When running with the patch: > >> > >> 1) The browser isn't closed, and the scri

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

Hi, On Mon, Mar 27, 2017 at 5:37 PM, Dave Page wrote: > Hi > > On Mon, Mar 27, 2017 at 12:15 AM, Navnath Gadakh > wrote: > > Hello Dave, > > > > On Fri, Mar 24, 2017 at 9:10 PM, Dave Page wrote: > >> > >> Hi > >> > &g

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

Navnath Gadakh > wrote: > > Hi, > > > > On Mon, Mar 27, 2017 at 5:37 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Mon, Mar 27, 2017 at 12:15 AM, Navnath Gadakh > >> wrote: > >> > Hello Dave, > >> > > >

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

element not to throw an exception > > > > -- > > Ran 153 tests in 45.493s > > > FAILED (errors=2, skipped=16) > > > ========== > >

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

ailed and skipped test cases, I override apply_scenario() function in regression/test_utils.py On Mon, Apr 3, 2017 at 12:32 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the revised patch for test result enhancement. > > *What

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

Hi Dave, Please find the revised patch for test result enhancement, which include code to write passed test cases into the JSON file along with skipped and failed. On Tue, Apr 4, 2017 at 11:30 AM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: >

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

essary code changes. I have also added missing scenario names to some test cases. Thanks. > > Thanks > Joao & Sarah > > On Fri, Apr 7, 2017 at 10:15 AM, Navnath Gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hi Dave, >> >> >>

Re: [pgadmin-hackers] pgAdmin4: Test result enhancement patch

Hi Dave, Please find the revised patch. On Mon, Apr 10, 2017 at 1:43 PM, Dave Page wrote: > Hi > > On Fri, Apr 7, 2017 at 8:01 PM, Navnath Gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hello Joao, >> >> Thanks for review and sugg

[pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

egards, Navnath Gadakh EnterpriseDB Corporation The Enterprise PostgreSQL Company testsuite_os_compatability_issue.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

> When testing on Mac, the testsuite never exits with this patch applied. It > just hangs after printing the result summary. > > On Fri, Apr 28, 2017 at 2:51 PM, Navnath Gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please f

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

python-mimeparse==1.6.0 > pytz==2014.10 > requests==2.13.0 > requests-toolbelt==0.7.1 > selenium==3.3.1 > simplejson==3.6.5 > six==1.10.0 > snowballstemmer==1.2.1 > speaklater==1.3 > Sphinx==1.5.3 > SQLAlchemy==1.0.14 > sqlparse==0.1.19 > testscenarios==0.5.0 > t

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

*regression.log* file Thanks! On Thu, May 4, 2017 at 2:18 PM, Dave Page wrote: > I still see the issue. See the attached screenshot. Killing process 32287 > caused the test suite to exit.[image: Inline image 1] > > On Wed, May 3, 2017 at 1:32 PM, Navnath Gadakh < > navnath.gad..

Re: [pgadmin-hackers] pgAdmin4: Test-suite OS compatability issue

ng servers. > Deleting servers. > Deleting servers. > Deleting servers. > Deleting servers. > Deleting servers. > Deleting servers. > Deleting servers. > Deleting servers. > Deleting servers. > Deleting servers. > Deleting servers. > Deleting servers. > Stopping app. &g