pgsql: Support all SQL:2011 options for window frame clauses.

2018-02-06 Thread Tom Lane
Support all SQL:2011 options for window frame clauses. This patch adds the ability to use "RANGE offset PRECEDING/FOLLOWING" frame boundaries in window functions. We'd punted on that back in the original patch to add window functions, because it was not clear how to do it in a reasonably data-typ

Re: [COMMITTERS] pgsql: Remove secondary checkpoint

2018-02-06 Thread Thomas Munro
On Wed, Nov 8, 2017 at 6:57 AM, Simon Riggs wrote: > Remove secondary checkpoint I think this comment in xlog.c was missed: - /* -* Get the last valid checkpoint record. If the latest one according -* to pg_control is broken, try the next-to-last on

pgsql: Fix incorrect grammar.

2018-02-06 Thread Robert Haas
Fix incorrect grammar. Etsuro Fujita Discussion: http://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/23209457314f6fd89fcd251a8173b0129aaa95a2 Modified Files -- src/backend/executor/execPartition.c | 2 +- 1

pgsql: Avoid valgrind complaint about write() of uninitalized bytes.

2018-02-06 Thread Robert Haas
Avoid valgrind complaint about write() of uninitalized bytes. LogicalTapeFreeze() may write out its first block when it is dirty but not full, and then immediately read the first block back in from its BufFile as a BLCKSZ-width block. This can only occur in rare cases where very few tuples were w

pgsql: Doc: move info for btree opclass implementors into main document

2018-02-06 Thread Tom Lane
Doc: move info for btree opclass implementors into main documentation. Up to now, useful info for writing a new btree opclass has been buried in the backend's nbtree/README file. Let's move it into the SGML docs, in preparation for extending it with info about "in_range" functions in the upcoming

Re: pgsql: Support parallel btree index builds.

2018-02-06 Thread Peter Geoghegan
On Tue, Feb 6, 2018 at 8:05 AM, Tom Lane wrote: > I like the option of doing VALGRIND_MAKE_MEM_DEFINED on the tail > portion of the buffer before writing it. That seems pretty tightly > tied to the behavior we're decreeing valid, whereas the suppression > is not. I think that the suppression is

Re: pgsql: Support parallel btree index builds.

2018-02-06 Thread Tom Lane
Robert Haas writes: > On Tue, Feb 6, 2018 at 10:46 AM, Tom Lane wrote: >> ... I, at least, don't have that understanding from looking >> at the thread. For one thing, Peter has not explained why this issue >> appears now with parallel index build when it did not before; it's >> not like logtape.

Re: pgsql: Support parallel btree index builds.

2018-02-06 Thread Robert Haas
On Tue, Feb 6, 2018 at 10:46 AM, Tom Lane wrote: > Robert Haas writes: >> On Sun, Feb 4, 2018 at 1:11 PM, Tom Lane wrote: >>> I'll be happier about it when the valgrind buildfarm animals are >>> happy. > >> Me too, but it's not clear what the right fix is. One thing that >> would help is if you

Re: pgsql: Support parallel btree index builds.

2018-02-06 Thread Tom Lane
Robert Haas writes: > On Sun, Feb 4, 2018 at 1:11 PM, Tom Lane wrote: >> I'll be happier about it when the valgrind buildfarm animals are >> happy. > Me too, but it's not clear what the right fix is. One thing that > would help is if you put in an appearance on the thread where this is > being

Re: pgsql: Support parallel btree index builds.

2018-02-06 Thread Robert Haas
On Sun, Feb 4, 2018 at 1:11 PM, Tom Lane wrote: > I'll be happier about it when the valgrind buildfarm animals are > happy. Me too, but it's not clear what the right fix is. One thing that would help is if you put in an appearance on the thread where this is being discussed and cast a vote. (Di