pgsql: Remove repeated test in contrib/amcheck

Remove repeated test in contrib/amcheck Repeating these tests adds unnecessary cycles, since no improvement in test coverage is expected. Cleanup from commit 8224de4f42ccf98e08db07b43d52fed72f962ebb. Peter Geoghegan Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/

Re: pgsql: Support partition pruning at execution time

On 9 April 2018 at 13:03, David Rowley wrote: > On 9 April 2018 at 09:54, Tom Lane wrote: >> BTW, pademelon just exhibited a different instability in this test: >> >> *** >> /home/bfarm/bf-data/HEAD/pgsql.build/src/test/regress/expected/partition_prune.out >> Sun Apr 8 01:56:04 2018 >> --- >

Re: pgsql: Fix EXEC BACKEND + Windows builds for group privs

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > Fix EXEC BACKEND + Windows builds for group privs > > jacana seems to think there's still an issue here: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2018-04-09%2000%3A00%3A41 > > It's pretty

pgsql: Skip permissions test under MINGW/Windows

Skip permissions test under MINGW/Windows We don't support the same kind of permissions tests on Windows/MINGW, so these tests really shouldn't be getting run on that platform. Per buildfarm. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9d0383c015aabd7565f3df010

Re: pgsql: Fix EXEC BACKEND + Windows builds for group privs

Stephen Frost writes: > Fix EXEC BACKEND + Windows builds for group privs jacana seems to think there's still an issue here: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2018-04-09%2000%3A00%3A41 It's pretty much the same symptom: Apr 08 20:58:22 Running this script will d

Re: pgsql: Support partition pruning at execution time

On 9 April 2018 at 09:54, Tom Lane wrote: > BTW, pademelon just exhibited a different instability in this test: > > *** > /home/bfarm/bf-data/HEAD/pgsql.build/src/test/regress/expected/partition_prune.out > Sun Apr 8 01:56:04 2018 > --- > /home/bfarm/bf-data/HEAD/pgsql.build/src/test/regress/

Re: pgsql: Support partition pruning at execution time

Andrew Gierth writes: > "Alvaro" == Alvaro Herrera writes: > Alvaro> Thanks for cleaning that up. I'll look into why the test > Alvaro> (without this commit) fails with force_parallel_mode=regress > Alvaro> next week. > Seems clear enough to me - the "Heap Fetches" statistic is kept in the >

Re: pgsql: Indexes with INCLUDE columns and their support in B-tree

On Mon, Apr 9, 2018 at 12:27 AM, Tom Lane wrote: > Alexander Korotkov writes: > > There is also patch for valgrind error in CheckIndexCompatible(). > > It appears that this function didn't initialize ii_NumIndexAttrs and > > ii_NumIndexKeyAttrs before calling ComputeIndexAttrs(). This > > varia

Re: pgsql: Indexes with INCLUDE columns and their support in B-tree

Alexander Korotkov writes: > There is also patch for valgrind error in CheckIndexCompatible(). > It appears that this function didn't initialize ii_NumIndexAttrs and > ii_NumIndexKeyAttrs before calling ComputeIndexAttrs(). This > variables weren't used before, but now they're used to determine >

pgsql: Fix additional breakage in covering-index patch.

Fix additional breakage in covering-index patch. CheckIndexCompatible() misused ComputeIndexAttrs() by not bothering to fill ii_NumIndexAttrs and ii_NumIndexKeyAttrs in the passed IndexInfo. Omission of ii_NumIndexAttrs was previously unimportant, but now this matters because ComputeIndexAttrs de

pgsql: Doc: clarify explanation of pg_dump usage.

Doc: clarify explanation of pg_dump usage. This section confusingly used both "infile" and "outfile" to refer to the same file, i.e. the textual output of pg_dump. Use "dumpfile" for both cases, per suggestion from Jonathan Katz. Discussion: https://postgr.es/m/152311295239.31235.64872360919069

pgsql: Doc: clarify explanation of pg_dump usage.

Doc: clarify explanation of pg_dump usage. This section confusingly used both "infile" and "outfile" to refer to the same file, i.e. the textual output of pg_dump. Use "dumpfile" for both cases, per suggestion from Jonathan Katz. Discussion: https://postgr.es/m/152311295239.31235.64872360919069

pgsql: Doc: clarify explanation of pg_dump usage.

Doc: clarify explanation of pg_dump usage. This section confusingly used both "infile" and "outfile" to refer to the same file, i.e. the textual output of pg_dump. Use "dumpfile" for both cases, per suggestion from Jonathan Katz. Discussion: https://postgr.es/m/152311295239.31235.64872360919069

pgsql: Doc: clarify explanation of pg_dump usage.

Doc: clarify explanation of pg_dump usage. This section confusingly used both "infile" and "outfile" to refer to the same file, i.e. the textual output of pg_dump. Use "dumpfile" for both cases, per suggestion from Jonathan Katz. Discussion: https://postgr.es/m/152311295239.31235.64872360919069

pgsql: Doc: clarify explanation of pg_dump usage.

Doc: clarify explanation of pg_dump usage. This section confusingly used both "infile" and "outfile" to refer to the same file, i.e. the textual output of pg_dump. Use "dumpfile" for both cases, per suggestion from Jonathan Katz. Discussion: https://postgr.es/m/152311295239.31235.64872360919069

pgsql: Doc: clarify explanation of pg_dump usage.

Doc: clarify explanation of pg_dump usage. This section confusingly used both "infile" and "outfile" to refer to the same file, i.e. the textual output of pg_dump. Use "dumpfile" for both cases, per suggestion from Jonathan Katz. Discussion: https://postgr.es/m/152311295239.31235.64872360919069

Re: pgsql: Indexes with INCLUDE columns and their support in B-tree

On Sun, Apr 8, 2018 at 7:58 PM, Teodor Sigaev wrote: > Thank you, pushed > Thank you! There is also patch for valgrind error in CheckIndexCompatible(). It appears that this function didn't initialize ii_NumIndexAttrs and ii_NumIndexKeyAttrs before calling ComputeIndexAttrs(). This variables we

pgsql: Cosmetic cleanups in initial catalog data.

Cosmetic cleanups in initial catalog data. Write ',' and ';' for typdelim values instead of the obscurantist ASCII octal equivalents. Not sure why anybody ever thought the latter were better; maybe it had something to do with lack of a better quoting convention, twenty-plus years ago? Reassign a

pgsql: Reduce worst-case shell command line length during "make install

Reduce worst-case shell command line length during "make install". Addition of the catalog/pg_foo_d.h headers seems to have pushed us over the brink of the maximum command line length for some older platforms during "make install" for our header files. The main culprit here is repetition of the t

Re: pgsql: Replace our traditional initial-catalog-data format with a bette

Teodor Sigaev writes: > Seems, gaur animal doesn't too long shell command. Could "find | xargs" > help here? Hm. I think better to cd into the target directory so we can eliminate all the repetitions of the path. Will fix ... regards, tom lane

pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.

Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers. Traditionally, include/catalog/pg_foo.h contains extern declarations for functions in backend/catalog/pg_foo.c, in addition to its function as the authoritative definition of the pg_foo catalog's rowtype. In some cases, we'd been forced

Re: pgsql: Replace our traditional initial-catalog-data format with a bette

Seems, gaur animal doesn't too long shell command. Could "find | xargs" help here? cp ./*.h '/home/bfarm/bf-data/HEAD/pgsql.build/tmp_install/home/bfarm/bf-data/HEAD/inst/include/postgresql/server'/ || exit; \ chmod 644 '/home/bfarm/bf-data/HEAD/pgsql.build/tmp_install/home/bfarm/bf-data/HEA

pgsql: Switch client-side code to include catalog/pg_foo_d.h not pg_foo

Switch client-side code to include catalog/pg_foo_d.h not pg_foo.h. Everything of use to frontend code should now appear in the _d.h files, and making this change frees us from needing to worry about whether the catalog header files proper are frontend-safe. Remove src/interfaces/ecpg/ecpglib/pg_

pgsql: Replace our traditional initial-catalog-data format with a bette

Replace our traditional initial-catalog-data format with a better design. Historically, the initial catalog data to be installed during bootstrap has been written in DATA() lines in the catalog header files. This had lots of disadvantages: the format was badly underdocumented, it was very difficu

pgsql: match_clause_to_index should check only key columns

match_clause_to_index should check only key columns Alexander Korotkov per gripe from Tom Lane noticed on valgrind-enabled buildfarm members Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/02f3e558f21c0fbec9f94d5de9ad34f321eb0e57 Modified Files -- src/b

Re: pgsql: Indexes with INCLUDE columns and their support in B-tree

Thank you, pushed Alexander Korotkov wrote: On Sun, Apr 8, 2018 at 5:41 PM, Tom Lane > wrote: Teodor Sigaev mailto:teo...@sigaev.ru>> writes: > Indexes with INCLUDE columns and their support in B-tree The valgrind-using animals seem to think this broke st

pgsql: Remove unused variable in non-assert-enabled build

Remove unused variable in non-assert-enabled build Use field of structure in Assert directly Jeff Janes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/34602b0a1dfd41400d376e73e41ad868ad2d3ce8 Modified Files -- src/backend/access/common/indextuple.c |

Re: pgsql: Indexes with INCLUDE columns and their support in B-tree

On Sun, Apr 8, 2018 at 5:41 PM, Tom Lane wrote: > Teodor Sigaev writes: > > Indexes with INCLUDE columns and their support in B-tree > > The valgrind-using animals seem to think this broke stuff. > There are at least two different problems here: > > https://buildfarm.postgresql.org/cgi-bin/show_

pgsql: Add missing "static" markers.

Add missing "static" markers. Evidently forgotten in commit 11523e860. Per buildfarm member pademelon. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2fa55f26a0c56f40b71f96859280dc5d11751514 Modified Files -- contrib/adminpack/adminpack.c | 6 +++--- 1

Re: pgsql: Indexes with INCLUDE columns and their support in B-tree

Teodor Sigaev writes: > Indexes with INCLUDE columns and their support in B-tree The valgrind-using animals seem to think this broke stuff. There are at least two different problems here: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-04-07%2020%3A03%3A02

Re: pgsql: Support index INCLUDE in the AM properties interface.

Thank you! Andrew Gierth wrote: Support index INCLUDE in the AM properties interface. This rectifies an oversight in commit 8224de4f4, by adding a new property 'can_include' for pg_indexam_has_property, and adjusting the results of pg_index_column_has_property to give more appropriate results f

Re: pgsql: Support partition pruning at execution time

> "Alvaro" == Alvaro Herrera writes: Alvaro> Thanks for cleaning that up. I'll look into why the test Alvaro> (without this commit) fails with force_parallel_mode=regress Alvaro> next week. Seems clear enough to me - the "Heap Fetches" statistic is kept in the IndexOnlyScanState node in i