Re: pgsql: Support partition pruning at execution time

On 10 April 2018 at 09:58, Alvaro Herrera wrote: > I then noticed that support for nfiltered3 was incomplete; hence 0001. > (I then noticed that nfiltered3 was added for MERGE. It looks wrong to > me.) > > Frankly, I don't like this. I would rather have an

Re: pgsql: Support partition pruning at execution time

Andrew Gierth wrote: > > "Alvaro" == Alvaro Herrera writes: > > Alvaro> Thanks for cleaning that up. I'll look into why the test > Alvaro> (without this commit) fails with force_parallel_mode=regress > Alvaro> next week. > > Seems clear enough to me - the "Heap

Re: pgsql: Support partition pruning at execution time

Alvaro Herrera writes: > David Rowley wrote: >> Okay, I've written and attached a fix for this. I'm not 100% certain >> that this is the cause of the problem on pademelon, but the code does >> look wrong, so needs to be fixed. Hopefully, it'll make pademelon >> happy, if

pgsql: Fix partial-build problems introduced by having more generated h

Fix partial-build problems introduced by having more generated headers. Commit 372728b0d created some problems for usages like building a subdirectory without having first done "make all" at the top level, or for proceeding directly to "make install" without "make all". The only reasonably clean

Re: pgsql: Support partition pruning at execution time

David Rowley wrote: > Okay, I've written and attached a fix for this. I'm not 100% certain > that this is the cause of the problem on pademelon, but the code does > look wrong, so needs to be fixed. Hopefully, it'll make pademelon > happy, if not I'll think a bit harder about what might be

pgsql: Fix incorrect logic for choosing the next Parallel Append subpla

Fix incorrect logic for choosing the next Parallel Append subplan In 499be013de support for pruning unneeded Append subnodes was added. The logic in that commit was not correctly checking if the next subplan was in fact a valid subplan. This could cause parallel workers processes to be given a

pgsql: Silence some warnings in TAP tests

Silence some warnings in TAP tests Author: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d7754822c52ccb6dfb1c29607ae352c2028979d2 Modified Files -- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 2 +- src/test/perl/PostgresNode.pm

Re: pgsql: Optimize btree insertions for common case of increasing values

On Thu, Apr 5, 2018 at 10:16 AM, Peter Geoghegan wrote: > I think you can take that wording almost verbatim. Obviously it should > refer to the optimization by name, and blend into the surrounding text > in the README. I suggest putting a small section before "On-the-Fly > Deletion

pgsql: Make sure pg_rewind can't run as root

Make sure pg_rewind can't run as root Previously a warning was printed, but the tool actually kept running even when running as root. This is something we definitely want to prevent, but since this means a behavior change, not backpatching. Author: Michael Paquier Branch -- master Details

pgsql: Make reformat_dat_file.pl preserve all blank lines.

Make reformat_dat_file.pl preserve all blank lines. In its original form, reformat_dat_file.pl smashed consecutive blank lines to a single blank line, which was helpful for mopping up excess whitespace during the bootstrap data format conversion. But going forward, there seems little reason to

pgsql: Reduce chattiness of genbki.pl and Gen_fmgrtab.pl.

Reduce chattiness of genbki.pl and Gen_fmgrtab.pl. Make these scripts emit just one log message when they run, not one per output file. The latter is way too verbose in the wake of commit 372728b0d. The specific wording used is what already existed in the MSVC scripts. John Naylor Discussion:

pgsql: Further cleanup of client dependencies on src/include/catalog he

Further cleanup of client dependencies on src/include/catalog headers. In commit 9c0a0de4c, I'd failed to notice that catalog/catalog.h should also be considered a frontend-unsafe header, because it includes (and needs) the full form of pg_class.h, not to mention relcache.h. However, various

pgsql: catversion bump for online-checksums revert

catversion bump for online-checksums revert Lack thereof pointed out by Tom Lane. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f5543d47bcb2fee2ab69220f51e2078c11e19843 Modified Files -- src/include/catalog/catversion.h | 2 +- 1 file changed, 1

Re: pgsql: Revert "Allow on-line enabling and disabling of data checksums"

On Mon, Apr 9, 2018 at 7:26 PM, Tom Lane wrote: > Magnus Hagander writes: > > Revert "Allow on-line enabling and disabling of data checksums" > > Since this changed pg_proc.dat, there should have been a catversion > bump, no? > Oh meh, yes of course. I

Re: pgsql: Revert "Allow on-line enabling and disabling of data checksums"

Magnus Hagander writes: > Revert "Allow on-line enabling and disabling of data checksums" Since this changed pg_proc.dat, there should have been a catversion bump, no? regards, tom lane

pgsql: Revert "Allow on-line enabling and disabling of data checksums"

Revert "Allow on-line enabling and disabling of data checksums" This reverts the backend sides of commit 1fde38beaa0c3e66c340efc7cc0dc272d6254bb0. I have, at least for now, left the pg_verify_checksums tool in place, as this tool can be very valuable without the rest of the patch as well, and

pgsql: Improve covering index documentation

Improve covering index documentation Add missed description of pg_constraint.conincluding Shinoda, Noriyoshi and Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/03c11796a95cc20a4559a103019d4d22a116a13c Modified Files --

pgsql: Minor comment updates

Minor comment updates Fix a couple of typos, and update a comment about why we set a BMS to NULL. Author: David Rowley Discussion: http://postgr.es/m/CAKJS1f-tux=kduz6enj9ghm_v2qgxysadyioyqs9ko9ptte...@mail.gmail.com Branch -- master Details ---

Re: pgsql: Support partition pruning at execution time

On 9 April 2018 at 15:03, David Rowley wrote: > On 9 April 2018 at 13:03, David Rowley wrote: > Okay, I've written and attached a fix for this. I'm not 100% certain > that this is the cause of the problem on pademelon, but the code

pgsql: Add missed bms_copy() in perform_pruning_combine_step

Add missed bms_copy() in perform_pruning_combine_step We were initializing a BMS to merely reference an existing one, which would cause a double-free (and a crash) when the recursive algorithm tried to intersect it with an empty one. Fix it by creating a copy at initialization time.

pgsql: Fix typo in comment.

Fix typo in comment. Author: Kyotaro Horiguchi Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2c19ea863a27303f462485c4046a850864e638b8 Modified Files -- src/backend/rewrite/rewriteManip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: pgsql: Doc: fix broken markup.

(2018/04/07 9:55), Tom Lane wrote: Doc: fix broken markup. Commit 3d956d956 was apparently not checked against HEAD's doc toolchain. Per buildfarm. That's my fault. Thanks for fixing that. Best regards, Etsuro Fujita

pgsql: Remove repeated test in contrib/amcheck

Remove repeated test in contrib/amcheck Repeating these tests adds unnecessary cycles, since no improvement in test coverage is expected. Cleanup from commit 8224de4f42ccf98e08db07b43d52fed72f962ebb. Peter Geoghegan Branch -- master Details ---