On 24 April 2018 at 13:50, Alvaro Herrera wrote:
> David Rowley wrote:
>> On 24 April 2018 at 03:12, Alvaro Herrera wrote:
>> > Remove useless default clause in switch
>> >
>> > The switch covers all values of the enum driver variable, so having a
>> > default: clause is useless, even if it's onl
David Rowley wrote:
> On 24 April 2018 at 03:12, Alvaro Herrera wrote:
> > Remove useless default clause in switch
> >
> > The switch covers all values of the enum driver variable, so having a
> > default: clause is useless, even if it's only to do Assert(false).
>
> Just for my own understanding
On 2018/04/24 10:20, Michael Paquier wrote:
> On Tue, Apr 24, 2018 at 12:27:27PM +1200, David Rowley wrote:
>> I always thought that when all options were covered that we generally
>> kept a default just in case someone added another enum and forgot to
>> update the code.
>>
>> I know generally tho
On Tue, Apr 24, 2018 at 12:27:27PM +1200, David Rowley wrote:
> I always thought that when all options were covered that we generally
> kept a default just in case someone added another enum and forgot to
> update the code.
>
> I know generally those are with elog ERRORs but both would be designed
> "David" == David Rowley writes:
David> I always thought that when all options were covered that we
David> generally kept a default just in case someone added another enum
David> and forgot to update the code.
That's what compiler warnings (-Wswitch, included in -Wall) are for;
it's actu
David Rowley writes:
> On 24 April 2018 at 03:12, Alvaro Herrera wrote:
>> Remove useless default clause in switch
> I always thought that when all options were covered that we generally
> kept a default just in case someone added another enum and forgot to
> update the code.
Actually, there's
On 24 April 2018 at 03:12, Alvaro Herrera wrote:
> Remove useless default clause in switch
>
> The switch covers all values of the enum driver variable, so having a
> default: clause is useless, even if it's only to do Assert(false).
Just for my own understanding:
I always thought that when all
Add GUC enable_partition_pruning
This controls both plan-time and execution-time new-style partition
pruning. While finer-grain control is possible (maybe using an enum GUC
instead of boolean), there doesn't seem to be much need for that.
This new parameter controls partition pruning for all que
Fix handling of partition bounds for boolean partitioning columns.
Previously, you could partition by a boolean column as long as you
spelled the bound values as string literals, for instance FOR VALUES
IN ('t'). The trouble with this is that ruleutils.c printed that as
FOR VALUES IN (TRUE), whic
Fix handling of partition bounds for boolean partitioning columns.
Previously, you could partition by a boolean column as long as you
spelled the bound values as string literals, for instance FOR VALUES
IN ('t'). The trouble with this is that ruleutils.c printed that as
FOR VALUES IN (TRUE), whic
Fix typo in logical truncate replication
This could result in some misbehavior in a cascading replication setup.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/df044026fcaf60b22291c31f4290a3b09ecf5833
Modified Files
--
src/backend/replication/logical/w
Make Emacs settings match perltidy configuration
Set Emacs's perl-continued-statement-offset to match perltidy's
--continuation-indentation, which is 2 (not overridden in PostgreSQL's
profile) rather than the 4 that Emacs uses by default.
Branch
--
master
Details
---
https://git.postgres
Add missing pstrdup
Lifetime of the input string is not right, so create a separate copy.
Author: Amit Langote
Discussion:
https://postgr.es/m/a2773420-50d1-0a42-3396-fe42b0921...@lab.ntt.co.jp
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/bc972072a3bb77e51a7937
Remove useless default clause in switch
The switch covers all values of the enum driver variable, so having a
default: clause is useless, even if it's only to do Assert(false).
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/dfce1f9e4eef3adcccbb23670fa1c432eebb0b90
Make bms_prev_member work correctly with a 64 bit bitmapword
5c067521 erroneously had coded bms_prev_member assuming that a bitmapword
would always hold 32 bits and started it's search on what it thought was the
highest 8-bits of the word. This was not the case if bitmapwords were 64
bits.
In pa
Update trigram example in docs to correct state
Author: Liudmila Mantrova
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/9975c128a1d1bd7e7366adf133b21540a2bc2450
Modified Files
--
doc/src/sgml/pgtrgm.sgml | 6 +++---
1 file changed, 3 insertions(+), 3 d
Fix wrong validation of top-parent pointer during page deletion in Btree.
After introducing usage of t_tid of inner or page high key for storing
number of attributes of tuple, validation of tuple's ItemPointer with
ItemPointerIsValid becomes incorrect, it's need to validate only blocknumber of
Ite
Make PGJIT_* macros safer.
Author: David Rowley
Discussion:
https://www.postgresql.org/message-id/cakjs1f8ge2y0sds6rqejfh-vjb-bwhs86rcx4fp4fz+tmxt...@mail.gmail.com
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/6a7b2ce2bdb9ab5fd23c98ace4bb2d811231706a
Modified F
Add comment explaining BGWORKER_BYPASS_ALLOWCONN
Suggested by Michael Paquier
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/43cc4ee6340779f2a17fb5bab27355c2cb2e23a6
Modified Files
--
src/include/postmaster/bgworker.h | 8 +++-
1 file changed, 7 ins
19 matches
Mail list logo
