pgsql: doc: add markup for PG 12 release note text

2019-05-09 Thread Bruce Momjian
doc: add markup for PG 12 release note text I will add links to other parts of the docs later. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c65bcfe9aeecae1c6204ad60612fae43669a88b0 Modified Files -- doc/src/sgml/release-12.sgml | 410 +++

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-09 Thread Peter Geoghegan
On Thu, May 9, 2019 at 8:21 PM Alexander Korotkov wrote: > If we group these very heterogeneous together, then Peter's name > probably should go first. Because he authored two quite complex > optimization, while my one is rather simple. I posted a patch over on the "pg12 release notes" thread. I

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-09 Thread Alexander Korotkov
+ + + + +Improve speed of btree index insertions (Alexander Korotkov, Peter Geoghegan) + If we group these very heterogeneous together, then Peter's name probably should go first. Because he authored two quite complex optimization, while my one is rather simple. + + LOOKUP, INDEX CLEANUP IMPROVE

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-09 Thread Amit Langote
On 2019/05/10 5:57, Bruce Momjian wrote: > So, in this case, there were so many partitioning improvements, I just > lumped them into one item. I think everyone can consider partitions to > perform much better in PG 12. Is there something more specific we > should communicate here? So the current

pgsql: doc: PG 12 wording improvments

2019-05-09 Thread Bruce Momjian
doc: PG 12 wording improvments Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20190510001335.gj3...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d0bbf871ca243eafcac7a84138741521c1aea3d2 Modified Files -- doc/src/sgml/releas

pgsql: Fix and improve description of locktag types in lock.h

2019-05-09 Thread Michael Paquier
Fix and improve description of locktag types in lock.h The description of the lock type for speculative insertions was incorrect, being copy-pasted from another one. As discussed, also move the description for all the fields of lock tag types from the structure listing lock tag types to the set o

pgsql: doc: more PG 12 wording adjustments

2019-05-09 Thread Bruce Momjian
doc: more PG 12 wording adjustments Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20190510001959.gk3...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/97b1654da7dd38fa50c9b6139f4213a1c47f0c39 Modified Files -- doc/src/sgml/

pgsql: doc: fix capitalization in PG 12 release notes

2019-05-09 Thread Bruce Momjian
doc: fix capitalization in PG 12 release notes Reported-by: Thomas Munro Discussion: https://postgr.es/m/ca+hukgjpep8usxodtvf6irocrkce-39hehdpuayfymn0u5e...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/32fe7ee2dd2b2aa8620e69451f60b2b35989677c M

pgsql: doc: more PG 12 release note adjustments

2019-05-09 Thread Bruce Momjian
doc: more PG 12 release note adjustments This adds two more items that should have been included in the beginning. Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20190508203204.ga25...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7969

pgsql: docs: update release notes with fixes

2019-05-09 Thread Bruce Momjian
docs: update release notes with fixes Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20190508203204.ga25...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/81ddfa2e4d9350eb68f28cde8ae6a7e0b39ef2ac Modified Files -- doc/src/sg

pgsql: Improve and fix some error handling for REINDEX INDEX/TABLE CONC

2019-05-09 Thread Michael Paquier
Improve and fix some error handling for REINDEX INDEX/TABLE CONCURRENTLY This improves the user experience when it comes to restrict several flavors of REINDEX CONCURRENTLY. First, for INDEX, remove a restriction on shared relations as we already check after catalog relations. Then, for TABLE, a

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-09 Thread Tatsuo Ishii
> On Thu, May 9, 2019 at 07:58:00AM +0900, Tatsuo Ishii wrote: >> -- >> >> Move recovery.conf settings into postgresql.conf (Fujii Masao, Simon Riggs, >> Abhijit Menon-Sen, Sergei Kornilov) >> >> >> >> recovery.conf is no longer used, and recovery.signal and standb

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-09 Thread Bruce Momjian
On Wed, May 8, 2019 at 03:45:34PM +0300, Oleg Bartunov wrote: > On Tue, May 7, 2019 at 2:02 AM Bruce Momjian wrote: > > > > docs: fist draft version of the PG 12 release notes > > > > Still needs text markup, links, word wrap, and indenting. > > "This allows JSON values to be selected using an

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-09 Thread Bruce Momjian
On Wed, May 8, 2019 at 04:20:40PM -0400, Alvaro Herrera wrote: > On 2019-May-06, Bruce Momjian wrote: > > > docs: fist draft version of the PG 12 release notes > > Hello, thanks for doing this work once again. > > Typo in surname: "Golgov" is Dolgov. Yes, it was "Golgov" in one commint and "D

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-09 Thread Bruce Momjian
On Wed, May 8, 2019 at 10:09:19PM +0900, Michael Paquier wrote: > On Mon, May 06, 2019 at 11:02:37PM +, Bruce Momjian wrote: > > docs: fist draft version of the PG 12 release notes > > > > Still needs text markup, links, word wrap, and indenting. > > I have noticed a duplicated word: > $ gi

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-09 Thread Bruce Momjian
On Tue, May 7, 2019 at 09:44:54AM +0530, Amit Kapila wrote: > On Tue, May 7, 2019 at 5:00 AM Bruce Momjian wrote: > > > > On Mon, May 6, 2019 at 07:03:39PM -0400, Bruce Momjian wrote: > > > On Mon, May 6, 2019 at 11:02:37PM +, Bruce Momjian wrote: > > > > docs: fist draft version of the PG

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-09 Thread Bruce Momjian
On Tue, May 7, 2019 at 02:38:39PM +0100, Andrew Gierth wrote: > > "Bruce" == Bruce Momjian writes: > > Bruce> docs: fist draft version of the PG 12 release notes > Bruce> Still needs text markup, links, word wrap, and indenting. > > The floating-point output change probably needs to be c

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-09 Thread Bruce Momjian
On Thu, May 9, 2019 at 07:58:00AM +0900, Tatsuo Ishii wrote: > -- > > Move recovery.conf settings into postgresql.conf (Fujii Masao, Simon Riggs, > Abhijit Menon-Sen, Sergei Kornilov) > > > > recovery.conf is no longer used, and recovery.signal and standby.signal a

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-09 Thread Bruce Momjian
On Wed, May 8, 2019 at 10:43:00AM +0900, Amit Langote wrote: > I think there may be two (or more) distinct improvements here. > > * Performance of "pruning" itself which was bottle-necked in the planner > is improved mostly due to: > > +Author: Tom Lane > +2019-03-30 [428b260f8] Speed up planni

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-09 Thread Bruce Momjian
On Tue, May 7, 2019 at 09:08:06PM +1200, Thomas Munro wrote: > On Tue, May 7, 2019 at 11:02 AM Bruce Momjian wrote: > > https://git.postgresql.org/pg/commitdiff/bdf595adbca195fa54a909c74a5233ebc30641a1 > > > +Use pread() and pwrite() for random I/O (Thomas Munro) > > Hi Bruce, > > For this one

pgsql: Repair issues with faulty generation of merge-append plans.

2019-05-09 Thread Tom Lane
Repair issues with faulty generation of merge-append plans. create_merge_append_plan failed to honor the CP_EXACT_TLIST flag: it would generate the expected targetlist but then it felt free to add resjunk sort targets to it. This demonstrably leads to assertion failures in v11 and HEAD, and it's

pgsql: Repair issues with faulty generation of merge-append plans.

2019-05-09 Thread Tom Lane
Repair issues with faulty generation of merge-append plans. create_merge_append_plan failed to honor the CP_EXACT_TLIST flag: it would generate the expected targetlist but then it felt free to add resjunk sort targets to it. This demonstrably leads to assertion failures in v11 and HEAD, and it's

pgsql: Repair issues with faulty generation of merge-append plans.

2019-05-09 Thread Tom Lane
Repair issues with faulty generation of merge-append plans. create_merge_append_plan failed to honor the CP_EXACT_TLIST flag: it would generate the expected targetlist but then it felt free to add resjunk sort targets to it. This demonstrably leads to assertion failures in v11 and HEAD, and it's

pgsql: Repair issues with faulty generation of merge-append plans.

2019-05-09 Thread Tom Lane
Repair issues with faulty generation of merge-append plans. create_merge_append_plan failed to honor the CP_EXACT_TLIST flag: it would generate the expected targetlist but then it felt free to add resjunk sort targets to it. This demonstrably leads to assertion failures in v11 and HEAD, and it's

pgsql: doc: update PG 12 release notes, v2

2019-05-09 Thread Bruce Momjian
doc: update PG 12 release notes, v2 Adjustments requested by reviewers. Reported-by: Amit Kapila, Thomas Munro, Andrew Gierth, Amit Langote, Oleg Bartunov, Michael Paquier, Alvaro Herrera, Tatsuo Ishii Discussion: https://postgr.es/m/20190506233029.ozwged67i7s4q...@momjian.us Branch -- ma

pgsql: Last-minute updates for release notes.

2019-05-09 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2019-10129, CVE-2019-10130 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1760514e73e942dcb73231b6d65f6c2ef210c7da Modified Files -- doc/src/sgml/release-9.5.sgml | 39

pgsql: Add tests for error message generation in partition tuple routin

2019-05-09 Thread Michael Paquier
Add tests for error message generation in partition tuple routing This adds extra tests for the error message generated for partition tuple routing in the executor, using more than three levels of partitioning including partitioned tables with no partitions. These tests have been added to fix CVE

pgsql: Last-minute updates for release notes.

2019-05-09 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2019-10129, CVE-2019-10130 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/585e8ffd195d868f23318caaed6fd586f8d56a0e Modified Files -- doc/src/sgml/release-10.sgml | 39 +

pgsql: Last-minute updates for release notes.

2019-05-09 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2019-10129, CVE-2019-10130 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/02814c381bbae9d23b19042fe356c000ae31d975 Modified Files -- doc/src/sgml/release-11.sgml | 74 +

pgsql: Fix security checks for selectivity estimation functions with RL

2019-05-09 Thread Dean Rasheed
Fix security checks for selectivity estimation functions with RLS. In commit e2d4ef8de8, security checks were added to prevent user-supplied operators from running over data from pg_statistic unless the user has table or column privileges on the table, or the operator is leakproof. For a table wit

pgsql: Fix security checks for selectivity estimation functions with RL

2019-05-09 Thread Dean Rasheed
Fix security checks for selectivity estimation functions with RLS. In commit e2d4ef8de8, security checks were added to prevent user-supplied operators from running over data from pg_statistic unless the user has table or column privileges on the table, or the operator is leakproof. For a table wit

pgsql: Last-minute updates for release notes.

2019-05-09 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2019-10129, CVE-2019-10130 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a70f2e4cdfb5a8a05ab178037ba39cf3ac190246 Modified Files -- doc/src/sgml/release-9.6.sgml | 39

pgsql: Last-minute updates for release notes.

2019-05-09 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2019-10129, CVE-2019-10130 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ffe69b4afdae8284ad3f0d4c57640f077799cfa9 Modified Files -- doc/src/sgml/release-9.4.sgml | 17 + 1 file

pgsql: Fix tuple printing in error message of tuple routing for partiti

2019-05-09 Thread Michael Paquier
Fix tuple printing in error message of tuple routing for partitions With correctly crafted DDLs, this could lead to disclosure of arbitrary backend memory a user may have no right to access. This impacts only REL_11_STABLE, as the issue has been introduced by 34295b8. On HEAD, add regression tes

pgsql: Fix security checks for selectivity estimation functions with RL

2019-05-09 Thread Dean Rasheed
Fix security checks for selectivity estimation functions with RLS. In commit e2d4ef8de8, security checks were added to prevent user-supplied operators from running over data from pg_statistic unless the user has table or column privileges on the table, or the operator is leakproof. For a table wit

pgsql: Fix security checks for selectivity estimation functions with RL

2019-05-09 Thread Dean Rasheed
Fix security checks for selectivity estimation functions with RLS. In commit e2d4ef8de8, security checks were added to prevent user-supplied operators from running over data from pg_statistic unless the user has table or column privileges on the table, or the operator is leakproof. For a table wit

pgsql: Fix security checks for selectivity estimation functions with RL

2019-05-09 Thread Dean Rasheed
Fix security checks for selectivity estimation functions with RLS. In commit e2d4ef8de8, security checks were added to prevent user-supplied operators from running over data from pg_statistic unless the user has table or column privileges on the table, or the operator is leakproof. For a table wit

pgsql: Doc: Update FDW documentation about GetForeignUpperPaths().

2019-05-09 Thread Etsuro Fujita
Doc: Update FDW documentation about GetForeignUpperPaths(). In commit d50d172e51, which added support for LIMIT/OFFSET pushdown in postgres_fdw, a new struct was introduced as the extra parameter of GetForeignUpperPaths() set for UPPERREL_FINAL, but I forgot to update the documentation to mention

pgsql: postgres_fdw: Fix cost estimation for aggregate pushdown.

2019-05-09 Thread Etsuro Fujita
postgres_fdw: Fix cost estimation for aggregate pushdown. In commit 7012b132d0, which added support for aggregate pushdown in postgres_fdw, the expense of evaluating the final scan/join target computed by make_group_input_target() was not accounted for at all in costing aggregate pushdown paths wi

pgsql: Fix SxactGlobalXmin tracking.

2019-05-09 Thread Thomas Munro
Fix SxactGlobalXmin tracking. Commit bb16aba50 broke the code that maintains SxactGlobalXmin. It could get stuck when a well-timed READ ONLY transaction runs. If SxactGlobalXmin stops advancing, transactions on the FinishedSerializableTransactions queue are never cleaned up, so resources are eff

pgsql: Fix grammar in error message

2019-05-09 Thread Peter Eisentraut
Fix grammar in error message Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/02daece4ab4cd85b80d04469056e5b631918c9d6 Modified Files -- doc/src/sgml/plpgsql.sgml | 4 ++-- src/pl/plpgsql/src/pl_exec.c | 8 src/test/regress/e

pgsql: pg_controldata: Add common gettext flags

2019-05-09 Thread Peter Eisentraut
pg_controldata: Add common gettext flags So it picks up strings in pg_log_* calls. This was forgotten when it was added to all other relevant subdirectories. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cd805f46d857291b26ba6eb491ce11b6e0fc9ad3 Modified Files --