On Fri, Oct 25, 2019 at 09:32:29AM +0530, Amit Kapila wrote:
> One possible reason could be that pgtypeslib_extern.h has define like below:
> #ifndef bool
> #define bool char
> #endif /* ndef bool */
Possible. I have not looked closely.
> It is possible that all the functions that have bool has
Revert part of commit dddf4cdc3.
The commit dddf4cdc3 tries to ensure that the Postgres header file
inclusions are in order based on their ASCII value. However, in one of
the case there is a header file dependency due to which we can't maintain
such order.
Author: Amit Kapila
Discussion: https:/
On Fri, Oct 25, 2019 at 9:32 AM Amit Kapila wrote:
>
> On Fri, Oct 25, 2019 at 8:54 AM Amit Kapila wrote:
> >
> > > And the cause is visibly this portion of the commit:
> > > --- a/src/interfaces/ecpg/pgtypeslib/dt_common.c
> > > +++ b/src/interfaces/ecpg/pgtypeslib/dt_common.c
> > > @@ -7,9 +7,9
On Fri, Oct 25, 2019 at 8:54 AM Amit Kapila wrote:
>
> On Fri, Oct 25, 2019 at 8:47 AM Michael Paquier wrote:
> >
> > Hi Amit,
> >
> > On Fri, Oct 25, 2019 at 02:24:50AM +, Amit Kapila wrote:
> > > Make the order of the header file includes consistent in non-backend
> > > modules.
> > >
> >
On Fri, Oct 25, 2019 at 8:47 AM Michael Paquier wrote:
>
> Hi Amit,
>
> On Fri, Oct 25, 2019 at 02:24:50AM +, Amit Kapila wrote:
> > Make the order of the header file includes consistent in non-backend
> > modules.
> >
> > Similar to commit 7e735035f2, this commit makes the order of header fi
Hi Amit,
On Fri, Oct 25, 2019 at 02:24:50AM +, Amit Kapila wrote:
> Make the order of the header file includes consistent in non-backend modules.
>
> Similar to commit 7e735035f2, this commit makes the order of header file
> inclusion consistent for non-backend modules.
>
> In passing, fix t
Make the order of the header file includes consistent in non-backend modules.
Similar to commit 7e735035f2, this commit makes the order of header file
inclusion consistent for non-backend modules.
In passing, fix the case where we were using angle brackets (<>) for the
local module includes inste
Handle interrupts within a transaction context in REINDEX CONCURRENTLY
Phases 2 (building the new index) and 3 (validating the new index)
checked for interrupts outside a transaction context, having as
consequence to not release session-level locks taken on the parent
relation and the old and new
Handle interrupts within a transaction context in REINDEX CONCURRENTLY
Phases 2 (building the new index) and 3 (validating the new index)
checked for interrupts outside a transaction context, having as
consequence to not release session-level locks taken on the parent
relation and the old and new
