pgsql: Update description of spilled counters in pg_stat_replication_sl

2020-10-26 Thread Amit Kapila
Update description of spilled counters in pg_stat_replication_slots view. This is to make the description of spilled counters clear. Author: Amit Kapila Reviewed-by: Sawada Masahiko Discussion: https://postgr.es/m/ca+fd4k5_ppayrtdro2pbttoe0ehqpbvuqmcr8ic39utnmr4...@mail.gmail.com Branch --

pgsql: doc: simplify wording of function error affects

2020-10-26 Thread Bruce Momjian
doc: simplify wording of function error affects Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/209e8e4c8

pgsql: doc: simplify wording of function error affects

2020-10-26 Thread Bruce Momjian
doc: simplify wording of function error affects Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a645c0883

pgsql: doc: simplify wording of function error affects

2020-10-26 Thread Bruce Momjian
doc: simplify wording of function error affects Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7868b6d0d

pgsql: doc: simplify wording of function error affects

2020-10-26 Thread Bruce Momjian
doc: simplify wording of function error affects Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/98529445a

pgsql: doc: simplify wording of function error affects

2020-10-26 Thread Bruce Momjian
doc: simplify wording of function error affects Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2f17fe431860fc43

pgsql: doc: simplify wording of function error affects

2020-10-26 Thread Bruce Momjian
doc: simplify wording of function error affects Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3b8976423

pgsql: doc: simplify wording of function error affects

2020-10-26 Thread Bruce Momjian
doc: simplify wording of function error affects Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/589478695

Re: pgsql: Extend PageIsVerified() to handle more custom options

2020-10-26 Thread Michael Paquier
On Mon, Oct 26, 2020 at 09:29:46PM -0400, Tom Lane wrote: > Hm, I suspect what Alvaro meant was > > #define PageIsVerified(page, blkno) \ > - PageIsVerifiedExtended(page, blkno, \ > + PageIsVerifiedExtended((page), (blkno), \ > > But IMV that's not necessary: if the argument parsed as a

Re: pgsql: Extend PageIsVerified() to handle more custom options

2020-10-26 Thread Tom Lane
Michael Paquier writes: > On Mon, Oct 26, 2020 at 11:39:33AM -0300, Alvaro Herrera wrote: >> Please remember that in the macro definition, the arguments should be >> enclosed in parens. No bug here at present, but it seems better to be >> cautious. > Indeed, I can see similar changes in the hist

Re: pgsql: Extend PageIsVerified() to handle more custom options

2020-10-26 Thread Michael Paquier
On Mon, Oct 26, 2020 at 11:39:33AM -0300, Alvaro Herrera wrote: > Please remember that in the macro definition, the arguments should be > enclosed in parens. No bug here at present, but it seems better to be > cautious. Indeed, I can see similar changes in the history of the tree. Do you think t

pgsql: doc: make blooms docs match reality

2020-10-26 Thread Bruce Momjian
doc: make blooms docs match reality Parallel execution changed the way bloom queries are executed, so update the EXPLAIN output, and restructure the docs to be clearer and more accurate. Reported-by: Daniel Westermann Discussion: https://postgr.es/m/zr0p278mb0122119fae78721a694c30c8d2...@zr0p2

pgsql: doc: make blooms docs match reality

2020-10-26 Thread Bruce Momjian
doc: make blooms docs match reality Parallel execution changed the way bloom queries are executed, so update the EXPLAIN output, and restructure the docs to be clearer and more accurate. Reported-by: Daniel Westermann Discussion: https://postgr.es/m/zr0p278mb0122119fae78721a694c30c8d2...@zr0p2

pgsql: doc: make blooms docs match reality

2020-10-26 Thread Bruce Momjian
doc: make blooms docs match reality Parallel execution changed the way bloom queries are executed, so update the EXPLAIN output, and restructure the docs to be clearer and more accurate. Reported-by: Daniel Westermann Discussion: https://postgr.es/m/zr0p278mb0122119fae78721a694c30c8d2...@zr0p2

pgsql: doc: make blooms docs match reality

2020-10-26 Thread Bruce Momjian
doc: make blooms docs match reality Parallel execution changed the way bloom queries are executed, so update the EXPLAIN output, and restructure the docs to be clearer and more accurate. Reported-by: Daniel Westermann Discussion: https://postgr.es/m/zr0p278mb0122119fae78721a694c30c8d2...@zr0p2

pgsql: doc: make blooms docs match reality

2020-10-26 Thread Bruce Momjian
doc: make blooms docs match reality Parallel execution changed the way bloom queries are executed, so update the EXPLAIN output, and restructure the docs to be clearer and more accurate. Reported-by: Daniel Westermann Discussion: https://postgr.es/m/zr0p278mb0122119fae78721a694c30c8d2...@zr0p2

pgsql: doc: make blooms docs match reality

2020-10-26 Thread Bruce Momjian
doc: make blooms docs match reality Parallel execution changed the way bloom queries are executed, so update the EXPLAIN output, and restructure the docs to be clearer and more accurate. Reported-by: Daniel Westermann Discussion: https://postgr.es/m/zr0p278mb0122119fae78721a694c30c8d2...@zr0p2

pgsql: In INSERT/UPDATE, use the table's real tuple descriptor as targe

2020-10-26 Thread Tom Lane
In INSERT/UPDATE, use the table's real tuple descriptor as target. Previously, ExecInitModifyTable relied on ExecInitJunkFilter, and thence ExecCleanTypeFromTL, to build the target descriptor from the query tlist. While we just checked (in ExecCheckPlanOutput) that the tlist produces compatible o

Re: pgsql: Extend PageIsVerified() to handle more custom options

2020-10-26 Thread Alvaro Herrera
On 2020-Oct-26, Michael Paquier wrote: > Extend PageIsVerified() to handle more custom options > > This is useful for checks of relation pages without having to load the > pages into the shared buffers, and two cases can make use of that: page > verification in base backups and the online, lock-s

pgsql: docs: Remove notes about incompatibilies with very old versions.

2020-10-26 Thread Heikki Linnakangas
docs: Remove notes about incompatibilies with very old versions. These are old enough that they'll cause more confusion and distraction to new readers, than they could help anyone upgrade from very old servers. Discussion: https://www.postgresql.org/message-id/fd93f1c5-7818-a02c-01e5-1075ac0d4de