pgsql: Fix some typos, grammar and style in docs and comments

2021-02-23 Thread Michael Paquier
Fix some typos, grammar and style in docs and comments The portions fixing the documentation are backpatched where needed. Author: Justin Pryzby Discussion: https://postgr.es/m/20210210235557.gq20...@telsasoft.com backpatch-through: 9.6 Branch -- master Details --- https://git.postgresq

pgsql: Fix some typos, grammar and style in docs and comments

2021-02-23 Thread Michael Paquier
Fix some typos, grammar and style in docs and comments The portions fixing the documentation are backpatched where needed. Author: Justin Pryzby Discussion: https://postgr.es/m/20210210235557.gq20...@telsasoft.com backpatch-through: 9.6 Branch -- REL_13_STABLE Details --- https://git.po

pgsql: Fix some typos, grammar and style in docs and comments

2021-02-23 Thread Michael Paquier
Fix some typos, grammar and style in docs and comments The portions fixing the documentation are backpatched where needed. Author: Justin Pryzby Discussion: https://postgr.es/m/20210210235557.gq20...@telsasoft.com backpatch-through: 9.6 Branch -- REL9_6_STABLE Details --- https://git.po

pgsql: Fix some typos, grammar and style in docs and comments

2021-02-23 Thread Michael Paquier
Fix some typos, grammar and style in docs and comments The portions fixing the documentation are backpatched where needed. Author: Justin Pryzby Discussion: https://postgr.es/m/20210210235557.gq20...@telsasoft.com backpatch-through: 9.6 Branch -- REL_10_STABLE Details --- https://git.po

pgsql: Fix some typos, grammar and style in docs and comments

2021-02-23 Thread Michael Paquier
Fix some typos, grammar and style in docs and comments The portions fixing the documentation are backpatched where needed. Author: Justin Pryzby Discussion: https://postgr.es/m/20210210235557.gq20...@telsasoft.com backpatch-through: 9.6 Branch -- REL_12_STABLE Details --- https://git.po

pgsql: Fix some typos, grammar and style in docs and comments

2021-02-23 Thread Michael Paquier
Fix some typos, grammar and style in docs and comments The portions fixing the documentation are backpatched where needed. Author: Justin Pryzby Discussion: https://postgr.es/m/20210210235557.gq20...@telsasoft.com backpatch-through: 9.6 Branch -- REL_11_STABLE Details --- https://git.po

pgsql: Message style fix

2021-02-23 Thread Peter Eisentraut
Message style fix Don't quote type name placeholders. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8ec8fe0f31712c62b761da9ef6d32214e08340d1 Modified Files -- src/backend/partitioning/partbounds.c | 2 +- src/test/regress/expected/hash_part.out | 2 +

pgsql: doc: Improve description of wal_receiver_status_interval

2021-02-23 Thread Michael Paquier
doc: Improve description of wal_receiver_status_interval This parameter description was previously confusing, telling that a value of 0 disabled completely status updates. This is not true as there are cases where an update is sent while ignoring this parameter value. The documentation is improv

pgsql: Fix confusion in comments about generate_gather_paths

2021-02-23 Thread Alvaro Herrera
Fix confusion in comments about generate_gather_paths d2d8a229bc58 introduced a new function generate_useful_gather_paths to be used as a replacement for generate_gather_paths, but forgot to update a couple of places that referenced the older function. This is possibly not 100% complete (ref. cre

pgsql: Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed

2021-02-23 Thread Alvaro Herrera
Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed Commit 866e24d47db1 added an assert that HEAP_XMAX_LOCK_ONLY and HEAP_KEYS_UPDATED cannot appear together, on the faulty assumption that the latter necessarily referred to an update and not a tuple lock; but that's wrong, because SELECT FO

pgsql: Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed

2021-02-23 Thread Alvaro Herrera
Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed Commit 866e24d47db1 added an assert that HEAP_XMAX_LOCK_ONLY and HEAP_KEYS_UPDATED cannot appear together, on the faulty assumption that the latter necessarily referred to an update and not a tuple lock; but that's wrong, because SELECT FO

pgsql: Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed

2021-02-23 Thread Alvaro Herrera
Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed Commit 866e24d47db1 added an assert that HEAP_XMAX_LOCK_ONLY and HEAP_KEYS_UPDATED cannot appear together, on the faulty assumption that the latter necessarily referred to an update and not a tuple lock; but that's wrong, because SELECT FO

pgsql: Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed

2021-02-23 Thread Alvaro Herrera
Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed Commit 866e24d47db1 added an assert that HEAP_XMAX_LOCK_ONLY and HEAP_KEYS_UPDATED cannot appear together, on the faulty assumption that the latter necessarily referred to an update and not a tuple lock; but that's wrong, because SELECT FO

pgsql: Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed

2021-02-23 Thread Alvaro Herrera
Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed Commit 866e24d47db1 added an assert that HEAP_XMAX_LOCK_ONLY and HEAP_KEYS_UPDATED cannot appear together, on the faulty assumption that the latter necessarily referred to an update and not a tuple lock; but that's wrong, because SELECT FO

pgsql: Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed

2021-02-23 Thread Alvaro Herrera
Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed Commit 866e24d47db1 added an assert that HEAP_XMAX_LOCK_ONLY and HEAP_KEYS_UPDATED cannot appear together, on the faulty assumption that the latter necessarily referred to an update and not a tuple lock; but that's wrong, because SELECT FO

pgsql: Suppress compiler warning in new regex match-all detection code.

2021-02-23 Thread Tom Lane
Suppress compiler warning in new regex match-all detection code. gcc 10 is smart enough to notice that control could reach this "hasmatch[depth]" assignment with depth < 0, but not smart enough to know that that would require a badly broken NFA graph. Change the assert() to a plain runtime test t

pgsql: VACUUM: ignore indexing operations with CONCURRENTLY

2021-02-23 Thread Alvaro Herrera
VACUUM: ignore indexing operations with CONCURRENTLY As envisioned in commit c98763bf51bf, it is possible for VACUUM to ignore certain transactions that are executing CREATE INDEX CONCURRENTLY and REINDEX CONCURRENTLY for the purposes of computing Xmin; that's because we know those transactions ar

pgsql: Simplify printing of LSNs

2021-02-23 Thread Peter Eisentraut
Simplify printing of LSNs Add a macro LSN_FORMAT_ARGS for use in printf-style printing of LSNs. Convert all applicable code to use it. Reviewed-by: Ashutosh Bapat Reviewed-by: Kyotaro Horiguchi Reviewed-by: Michael Paquier Discussion: https://www.postgresql.org/message-id/flat/caexhw5ub5natel