pgsql: Fix incorrect format placeholders

2021-12-21 Thread Peter Eisentraut
Fix incorrect format placeholders Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/dfaa346c7c00ff8a3fd8ea436a7d5be7527e67cb Modified Files -- src/backend/utils/mmgr/aset.c | 2 +- src/backend/utils/mmgr/generation.c | 2 +- src/backend/utils/mmgr/mcxt

pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN

2021-12-21 Thread Michael Paquier
Correct comment and some documentation about REPLICA_IDENTITY_INDEX catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING. The behavior exists si

pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN

2021-12-21 Thread Michael Paquier
Correct comment and some documentation about REPLICA_IDENTITY_INDEX catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING. The behavior exists si

pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN

2021-12-21 Thread Michael Paquier
Correct comment and some documentation about REPLICA_IDENTITY_INDEX catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING. The behavior exists si

pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN

2021-12-21 Thread Michael Paquier
Correct comment and some documentation about REPLICA_IDENTITY_INDEX catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING. The behavior exists si

pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN

2021-12-21 Thread Michael Paquier
Correct comment and some documentation about REPLICA_IDENTITY_INDEX catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING. The behavior exists si

pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN

2021-12-21 Thread Michael Paquier
Correct comment and some documentation about REPLICA_IDENTITY_INDEX catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING. The behavior exists si

pgsql: Fix typo in code comment

2021-12-21 Thread Peter Eisentraut
Fix typo in code comment Reported-by: Kevin Zheng <[email protected]> Discussion: https://www.postgresql.org/message-id/flat/17341-d913ddb626c5c08c%40postgresql.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/962951be3ce319052df014e0d23b6e7626df587f Modified F

pgsql: Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTL

2021-12-21 Thread Michael Paquier
Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTLY One code path related to this flavor of ALTER TABLE was checking that the relation to detach has to be a normal table or a partitioned table, which would fail if using the command with a different relation kind. Views, sequences an

pgsql: Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTL

2021-12-21 Thread Michael Paquier
Remove assertion for ALTER TABLE .. DETACH PARTITION CONCURRENTLY One code path related to this flavor of ALTER TABLE was checking that the relation to detach has to be a normal table or a partitioned table, which would fail if using the command with a different relation kind. Views, sequences an

pgsql: Move index vacuum routines to vacuum.c.

2021-12-21 Thread Amit Kapila
Move index vacuum routines to vacuum.c. An upcoming patch moves parallel vacuum code out of vacuumlazy.c. This code restructuring will allow both lazy vacuum and parallel vacuum to use index vacuum functions. Author: Masahiko Sawada Reviewed-by: Hou Zhijie, Amit Kapila Discussion: https://www.po

pgsql: Add help & tab-complete support for psql's \getenv.

2021-12-21 Thread Tom Lane
Add help & tab-complete support for psql's \getenv. I forgot about these details in 33d3eeadb :-(. Noted by Christoph Berg. Discussion: https://postgr.es/m/YcI8i/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0f2abd05441f524a67bc58ef5f0cc32

pgsql: Add missing EmitWarningsOnPlaceholders() calls.

2021-12-21 Thread Tom Lane
Add missing EmitWarningsOnPlaceholders() calls. Extensions that define any custom GUCs should call EmitWarningsOnPlaceholders after doing so, to help catch misspellings. Many of our contrib modules hadn't gotten the memo on that, though. Also add such calls to src/test/modules extensions that hav