pgsql: Fix typo in pg_walinspect.c

2022-04-25 Thread Michael Paquier
Fix typo in pg_walinspect.c Spotted while looking at the surroundings, introduced by 2258e76. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/06cafd6f577ba251ac10d4f009fc3be424705a37 Modified Files -- contrib/pg_walinspect/pg_walinspect.c | 2 +- 1 file

pgsql: Add some isolation tests for CLUSTER

2022-04-25 Thread Michael Paquier
Add some isolation tests for CLUSTER This commit adds two isolation tests for CLUSTER, using: - A normal table, making sure that CLUSTER blocks and completes if the table is locked by a concurrent session. - A partitioned table with a partition owned by a different user. If the partitioned table

pgsql: Inhibit mingw CRT's auto-globbing of command line arguments

2022-04-25 Thread Andrew Dunstan
Inhibit mingw CRT's auto-globbing of command line arguments For some reason by default the mingw C Runtime takes it upon itself to expand program arguments that look like shell globbing characters. That has caused much scratching of heads and mis-attribution of the causes of some TAP test failures

pgsql: Inhibit mingw CRT's auto-globbing of command line arguments

2022-04-25 Thread Andrew Dunstan
Inhibit mingw CRT's auto-globbing of command line arguments For some reason by default the mingw C Runtime takes it upon itself to expand program arguments that look like shell globbing characters. That has caused much scratching of heads and mis-attribution of the causes of some TAP test failures

pgsql: Inhibit mingw CRT's auto-globbing of command line arguments

2022-04-25 Thread Andrew Dunstan
Inhibit mingw CRT's auto-globbing of command line arguments For some reason by default the mingw C Runtime takes it upon itself to expand program arguments that look like shell globbing characters. That has caused much scratching of heads and mis-attribution of the causes of some TAP test failures

pgsql: Inhibit mingw CRT's auto-globbing of command line arguments

2022-04-25 Thread Andrew Dunstan
Inhibit mingw CRT's auto-globbing of command line arguments For some reason by default the mingw C Runtime takes it upon itself to expand program arguments that look like shell globbing characters. That has caused much scratching of heads and mis-attribution of the causes of some TAP test failures

pgsql: Inhibit mingw CRT's auto-globbing of command line arguments

2022-04-25 Thread Andrew Dunstan
Inhibit mingw CRT's auto-globbing of command line arguments For some reason by default the mingw C Runtime takes it upon itself to expand program arguments that look like shell globbing characters. That has caused much scratching of heads and mis-attribution of the causes of some TAP test failures

pgsql: Inhibit mingw CRT's auto-globbing of command line arguments

2022-04-25 Thread Andrew Dunstan
Inhibit mingw CRT's auto-globbing of command line arguments For some reason by default the mingw C Runtime takes it upon itself to expand program arguments that look like shell globbing characters. That has caused much scratching of heads and mis-attribution of the causes of some TAP test failures

pgsql: Drop unlogged table after test is done

2022-04-25 Thread Alvaro Herrera
Drop unlogged table after test is done Another test is constructed on top of regression tests, which does not work correctly with unlogged tables. For now, cope with that by making sure no unlogged table is left behind. Per buildfarm pink after 4fb5c794e586. Branch -- master Details --

Re: pgsql: Remove some recently-added pg_dump test cases.

2022-04-25 Thread Robert Haas
On Fri, Apr 22, 2022 at 7:08 PM Tom Lane wrote: > Robert Haas writes: > > Remove some recently-added pg_dump test cases. > > Um ... you needed to do that in v14, too. Sorry, Tom. Done now. -- Robert Haas EDB: http://www.enterprisedb.com

pgsql: Remove some recently-added pg_dump test cases.

2022-04-25 Thread Robert Haas
Remove some recently-added pg_dump test cases. Commit d2d35479796c3510e249d6fc72adbd5df918efbf included a pretty extensive set of test cases, and some of them don't work on all of our Windows machines. This happens because IPC::Run expands its arguments as shell globs on a few machines, but doesn'

pgsql: Cover brin/gin/gist/spgist ambuildempty routines in regression t

2022-04-25 Thread Alvaro Herrera
Cover brin/gin/gist/spgist ambuildempty routines in regression tests Changing some TEMP or permanent tables to UNLOGGED is sufficient to invoke these ambuildempty routines, which were all not uncovered by any tests. These changes do not otherwise affect the test suite. Author: Amul Sul Discussi

pgsql: Always pfree strings returned by GetDatabasePath

2022-04-25 Thread Alvaro Herrera
Always pfree strings returned by GetDatabasePath Several places didn't do it, and in many cases it didn't matter because it would be a small allocation in a short-lived context; but other places may accumulate a few (for example, in CreateDatabaseUsingFileCopy, one per tablespace). In most databa