Use locale-aware value for \watch in 005_timeouts.pl
Reported-by: Alexander Lakhin
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/605062227fdc8331f2ffa0f60e7a8724b6e56480
Modified Files
--
src/test/modules/test_misc/t/005_timeouts.pl | 18
Fix handling of expecteddir in pg_regress
Commit c855872074b introduced a new parameter to pg_regress to set
the directory where to look for expected files, but accidentally
only implemented it for when compiling pg_regress for ECPG tests.
Fix by adding support for the parameter to the main
Fix handling of expecteddir in pg_regress
Commit c855872074b introduced a new parameter to pg_regress to set
the directory where to look for expected files, but accidentally
only implemented it for when compiling pg_regress for ECPG tests.
Fix by adding support for the parameter to the main
Fix backstop in gin test if injection point is not reached
Per Tom Lane's observation that the test got stuck in infinite loop if
the injection_points module was not loaded. It was supposed to give up
after 1 iterations, but the backstop was broken.
Discussion:
Try to unbreak injection-fault tests in the buildfarm
The buildfarm script attempts to run all tests marked as
NO_INSTALLCHECK under src/test/modules without paying attention to
whether they are enabled or disabled in the parent Makefile. That
hasn't been a problem so far, because all the tests
On Fri, Mar 15, 2024 at 2:25 PM Andrey M. Borodin wrote:
> > On 15 Mar 2024, at 16:30, Alexander Korotkov wrote:
> >
> > Maybe, but do you see any negative side effects of the unconditionally
> > unset of flags?
>
> Nope, just expressed possible option.
>
> > If not, I would prefer to keep the
Fix wordings in timeouts TAP test
Reported-by: Kyotaro Horiguchi
Discussion:
https://postgr.es/m/20240315.104235.1835366724413653745.horikyota.ntt%40gmail.com
Author: Andrey Borodin
Branch
--
master
Details
---
Fix race condition in transaction timeout TAP tests
The interruption handler within the injection point can get stuck in an
infinite loop while handling transaction timeout. To avoid this situation
we reset the timeout flag before invoking the injection point.
Author: Alexander Korotkov
> On 15 Mar 2024, at 16:30, Alexander Korotkov wrote:
>
> Maybe, but do you see any negative side effects of the unconditionally
> unset of flags?
Nope, just expressed possible option.
> If not, I would prefer to keep the code simple.
IMO that's fine. Let's incorporate wording improvement
On Fri, Mar 15, 2024 at 1:27 PM Andrey M. Borodin wrote:
>
> > On 15 Mar 2024, at 15:44, Alexander Korotkov wrote:
> >
> > We loop in the interrupt checking, given that the injection point handler
> > checks for interrupts internally. I propose to unset the timeout flag
> > before the
> On 15 Mar 2024, at 15:44, Alexander Korotkov wrote:
>
> We loop in the interrupt checking, given that the injection point handler
> checks for interrupts internally. I propose to unset the timeout flag before
> the injection point (see the attached patch).
Oh, cool.
As far as I
Improve log messages referring to background worker processes
"Worker" could also mean autovacuum worker or slot sync worker, so
let's be more explicit.
Per Tristan Partin's suggestion.
Discussion:
https://www.postgresql.org/message-id/czm6wdx5h4qi.nzg1yuck...@neon.tech
Branch
--
master
Disable tests using injection points in installcheck
The 'gin' test injections faults to GIN index build. If another test
running concurrently in the same cluster also tries to create a GIN
index, it will hit the fault, too.
To fix, disable tests using injection points when running against an
On Fri, Mar 15, 2024 at 9:44 AM Michael Paquier wrote:
> On Fri, Mar 15, 2024 at 11:20:49AM +0500, Andrey M. Borodin wrote:
> > And hachi sometimes pass this test too [0].
> >
> > I’ll look more on this. Do I understand right that we have only 2
buildfarm members with injection points?
>
> I have
On Fri, Mar 15, 2024 at 11:20:49AM +0500, Andrey M. Borodin wrote:
> And hachi sometimes pass this test too [0].
>
> I’ll look more on this. Do I understand right that we have only 2 buildfarm
> members with injection points?
I have added --enable-injection-points to three of them: hachi,
> On 15 Mar 2024, at 11:20, Andrey M. Borodin wrote:
>
> The failure seems to be Perl-related.
It’s not Perl-related. This is how wait_for_log() times out.
timed out waiting for match: terminating connection due to transaction
timeout at t/005_timeouts.pl line 58.
But it did not
Kyotaro, thanks for your corrections. I agree that wordings should be improved.
But let’s deal with failures first.
> On 15 Mar 2024, at 10:28, Michael Paquier wrote:
>
> On Fri, Mar 15, 2024 at 10:42:35AM +0900, Kyotaro Horiguchi wrote:
>> In 005_timeouts.pl, I found the following comment.
>
17 matches
Mail list logo
