Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-15 Thread Bruce Momjian
On Sun, Sep 15, 2024 at 06:07:21PM -0400, Andrew Dunstan wrote: > > On 2024-09-15 Su 4:36 PM, Bruce Momjian wrote: > > On Sun, Sep 15, 2024 at 04:33:49PM -0400, Andrew Dunstan wrote: > > > I understand perfectly what the warning is about. > > > > > > But the project's perlcritic policy is express

pgsql: Perl scripts: revert 43ce181059d

2024-09-15 Thread Bruce Momjian
Perl scripts: revert 43ce181059d Small improvement not worth the code churn. Reported-by: Andrew Dunstan Discussion: https://postgr.es/m/42f2242a-422b-4aa3-8d60-d67b229c4...@dunslane.net Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/

Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-15 Thread Andrew Dunstan
On 2024-09-15 Su 4:36 PM, Bruce Momjian wrote: On Sun, Sep 15, 2024 at 04:33:49PM -0400, Andrew Dunstan wrote: I understand perfectly what the warning is about. But the project's perlcritic policy is expressed at src/tools/perlcheck/ perlcriticrc. It's basically severity 5 plus some additions

Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-15 Thread Bruce Momjian
On Sun, Sep 15, 2024 at 04:33:49PM -0400, Andrew Dunstan wrote: > I understand perfectly what the warning is about. > > But the project's perlcritic policy is expressed at src/tools/perlcheck/ > perlcriticrc. It's basically severity 5 plus some additions and one exception. > We shouldn't be imposi

Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-15 Thread Andrew Dunstan
On 2024-09-15 Su 4:16 PM, Bruce Momjian wrote: On Sun, Sep 15, 2024 at 02:30:47PM -0400, Andrew Dunstan wrote: On 2024-09-15 Su 10:56 AM, Bruce Momjian wrote: Perl scripts: eliminate "Useless interpolation" warnings Eliminate warnings of Perl Critic from src/tools. Backpatch

Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-15 Thread Bruce Momjian
On Sun, Sep 15, 2024 at 02:30:47PM -0400, Andrew Dunstan wrote: > > > On 2024-09-15 Su 10:56 AM, Bruce Momjian wrote: > > Perl scripts: eliminate "Useless interpolation" warnings > > Eliminate warnings of Perl Critic from src/tools. > > Backpatch-through: master > > > > I don't

Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-15 Thread Andrew Dunstan
On 2024-09-15 Su 10:56 AM, Bruce Momjian wrote: Perl scripts: eliminate "Useless interpolation" warnings Eliminate warnings of Perl Critic from src/tools. Backpatch-through: master I don't understand this commit. The buildfarm members crake and koel regularly run the perl critic checks

pgsql: Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile().

2024-09-15 Thread Tom Lane
Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile(). In existing releases of libxml2, xmlXPathCompile can be driven to stack overflow because it fails to protect itself against too-deeply-nested input. While there is an upstream fix as of yesterday, it will take years for that to propa

pgsql: Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile().

2024-09-15 Thread Tom Lane
Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile(). In existing releases of libxml2, xmlXPathCompile can be driven to stack overflow because it fails to protect itself against too-deeply-nested input. While there is an upstream fix as of yesterday, it will take years for that to propa

pgsql: Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile().

2024-09-15 Thread Tom Lane
Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile(). In existing releases of libxml2, xmlXPathCompile can be driven to stack overflow because it fails to protect itself against too-deeply-nested input. While there is an upstream fix as of yesterday, it will take years for that to propa

pgsql: Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile().

2024-09-15 Thread Tom Lane
Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile(). In existing releases of libxml2, xmlXPathCompile can be driven to stack overflow because it fails to protect itself against too-deeply-nested input. While there is an upstream fix as of yesterday, it will take years for that to propa

pgsql: Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile().

2024-09-15 Thread Tom Lane
Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile(). In existing releases of libxml2, xmlXPathCompile can be driven to stack overflow because it fails to protect itself against too-deeply-nested input. While there is an upstream fix as of yesterday, it will take years for that to propa

pgsql: Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile().

2024-09-15 Thread Tom Lane
Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile(). In existing releases of libxml2, xmlXPathCompile can be driven to stack overflow because it fails to protect itself against too-deeply-nested input. While there is an upstream fix as of yesterday, it will take years for that to propa

pgsql: Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile().

2024-09-15 Thread Tom Lane
Replace usages of xmlXPathCompile() with xmlXPathCtxtCompile(). In existing releases of libxml2, xmlXPathCompile can be driven to stack overflow because it fails to protect itself against too-deeply-nested input. While there is an upstream fix as of yesterday, it will take years for that to propa

pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-15 Thread Bruce Momjian
Perl scripts: eliminate "Useless interpolation" warnings Eliminate warnings of Perl Critic from src/tools. Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/43ce181059d4ecbb1b14b75e7f38a7dda9f80225 Modified Files -- src/tools/c