Fix const-simplification for index expressions and predicate
Similar to the issue with constraint and statistics expressions fixed
in 317c117d6, index expressions and predicate can also suffer from
incorrect reduction of NullTest clauses during const-simplification,
due to unfixed varnos and the u
Fix LOCK_TIMEOUT handling in slotsync worker.
Previously, the slotsync worker relied on SIGINT for graceful shutdown
during promotion. However, SIGINT is also used by the LOCK_TIMEOUT handler
to cancel queries. Since the slotsync worker can lock catalog tables while
parsing libpq tuples, this over
Fix LOCK_TIMEOUT handling in slotsync worker.
Previously, the slotsync worker relied on SIGINT for graceful shutdown
during promotion. However, SIGINT is also used by the LOCK_TIMEOUT handler
to cancel queries. Since the slotsync worker can lock catalog tables while
parsing libpq tuples, this over
Fix LOCK_TIMEOUT handling in slotsync worker.
Previously, the slotsync worker relied on SIGINT for graceful shutdown
during promotion. However, SIGINT is also used by the LOCK_TIMEOUT handler
to cancel queries. Since the slotsync worker can lock catalog tables while
parsing libpq tuples, this over
Remove unnecessary casts in printf format arguments (%zu/%zd)
Many of these are probably left over from before use of %zu/%zd was
portable.
Reviewed-by: Bertrand Drouvot
Discussion:
https://www.postgresql.org/message-id/flat/07fa29f9-42d7-4aac-8834-197918cbbab6%40eisentraut.org
Branch
--
m
Remove useless casts in format arguments
There were a number of useless casts in format arguments, either
where the input to the cast was already in the right type, or
seemingly uselessly casting between types instead of just using the
right format placeholder to begin with.
Reviewed-by: Bertrand
Clean up int64-related format strings
Remove some gratuitous uses of INT64_FORMAT. Make use of
PRIu64/PRId64 were appropriate, remove unnecessary casts.
Reviewed-by: Bertrand Drouvot
Discussion:
https://www.postgresql.org/message-id/flat/07fa29f9-42d7-4aac-8834-197918cbbab6%40eisentraut.org
B
Use palloc_object() and palloc_array() in more areas of the tree
The idea is to encourage more the use of these new routines across the
tree, as these offer stronger type safety guarantees than palloc().
The following paths are included in this batch, treating all the areas
proposed by the author
Improve documentation for pg_atomic_unlocked_write_u32()
After my recent commit 7902a47c20b, Nathan noticed that
pg_atomic_unlocked_write_u64() was not accurately described by the comments
for the 32bit version. Turns out the 32bit version has suffered from
copy-and-paste-itis since its introducti
Doc: fix typo in hash index documentation
Plus a similar fix to the README.
Backpatch as far back as the sgml issue exists. The README issue does
exist in v14, but that seems unlikely to harm anyone.
Author: David Geier
Discussion: https://postgr.es/m/ed3db7ea-55b4-4809-86af-81ad3bb2c...@gmail
Doc: fix typo in hash index documentation
Plus a similar fix to the README.
Backpatch as far back as the sgml issue exists. The README issue does
exist in v14, but that seems unlikely to harm anyone.
Author: David Geier
Discussion: https://postgr.es/m/ed3db7ea-55b4-4809-86af-81ad3bb2c...@gmail
Doc: fix typo in hash index documentation
Plus a similar fix to the README.
Backpatch as far back as the sgml issue exists. The README issue does
exist in v14, but that seems unlikely to harm anyone.
Author: David Geier
Discussion: https://postgr.es/m/ed3db7ea-55b4-4809-86af-81ad3bb2c...@gmail
Doc: fix typo in hash index documentation
Plus a similar fix to the README.
Backpatch as far back as the sgml issue exists. The README issue does
exist in v14, but that seems unlikely to harm anyone.
Author: David Geier
Discussion: https://postgr.es/m/ed3db7ea-55b4-4809-86af-81ad3bb2c...@gmail
Doc: fix typo in hash index documentation
Plus a similar fix to the README.
Backpatch as far back as the sgml issue exists. The README issue does
exist in v14, but that seems unlikely to harm anyone.
Author: David Geier
Discussion: https://postgr.es/m/ed3db7ea-55b4-4809-86af-81ad3bb2c...@gmail
libpq: Refactor logic checking for exit() in shared library builds
This commit refactors the sanity check done by libpq to ensure that
there is no exit() reference in the build, moving the check from a
standalone Makefile rule to a perl script.
Platform-specific checks are now part of the script,
Fix minor portability issue in pg_resetwal.c.
The argument of isspace() (like other functions)
must be cast to unsigned char to ensure portable results.
Per NetBSD buildfarm members. Oversight in 636c1914b.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/c004d68c
Avoid pointer chasing in _bt_readpage inner loop.
Make _bt_readpage pass down the current scan direction to various
utility functions within its pstate variable. Also have _bt_readpage
work off of a local copy of scan->ignore_killed_tuples within its
per-tuple loop (rather than using scan->ignore
Unify some more messages
No backpatch here because of message wording changes.
Author: Álvaro Herrera
Reviewed-by: Nathan Bossart
Discussion: https://postgr.es/m/[email protected]
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/d0d0ba6cf66c
Relocate _bt_readpage and related functions.
Quite a bit of code within nbtutils.c is only called by _bt_readpage.
Move _bt_readpage and all of the nbtutils.c functions it depends on into
a new .c file, nbtreadpage.c. Also reorder some of the functions within
the new file for clarity.
This commi
Unify error messages
No visible changes, just refactor how messages are constructed.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/502e256f2262351e92994878eea3332da64834b0
Modified Files
--
src/backend/catalog/aclchk.c| 6 +++--
src/ba
Unify error messages
No visible changes, just refactor how messages are constructed.
Branch
--
REL_18_STABLE
Details
---
https://git.postgresql.org/pg/commitdiff/5278222853cab4d9779b707eaea5878856e2471e
Modified Files
--
src/backend/catalog/aclchk.c| 6 +++--
pg_resetwal: Reject negative and out of range arguments
The strtoul() function that we used to parse many of the options
accepts negative values, and silently wraps them to the equivalent
unsigned values. For example, -1 becomes 0x, on platforms
where unsigned long is 32 bits wide. Also, o
pg_resetwal: Use separate flags for whether an option is given
Currently, we use special values that are otherwise invalid for each
option to indicate "option was not given". Replace that with separate
boolean variables for each option. It seems more clear to be explicit.
We were already doing th
Make ecpg parse.pl more robust with braces
When parse.pl processes braces, it does not take into account that
braces could also be their own token if single quoted ('{', '}').
This is not currently used but a future patch wants to make use of it.
This fixes that by using lookaround assertions to
Use PGAlignedXLogBlock for some code simplification
The code in BootStrapXLOG() and in pg_test_fsync.c tried to align WAL
buffers in complicated ways. Also, they still used XLOG_BLCKSZ for
the alignment, even though that should now be PG_IO_ALIGN_SIZE. This
can now be simplified and made more co
On Sun, Dec 07, 2025 at 11:57:34PM -0500, Tom Lane wrote:
> Nah, hold off till we have a discussion about whether the test is
> correct to expect compatibility. We can afford to have a couple
> of BF animals unhappy for a day or two while we come to a decision.
By the way, while looking at the bu
26 matches
Mail list logo
