pgsql: Specify locale provider for pg_regress --no-locale

cale provider is not 'builtin'. This commit makes 'pg_regress --no-locale' specify both LOCALE='C' and LOCALE_PROVIDER='builtin'. Discussion: https://postgr.es/m/b54921f95e23b4391b1613e9053a3d58%40postgrespro.ru Author: Oleg Tselebrovskiy Reviewed-by: Alex

pgsql: Improve RowMark handling during Self-Join Elimination

Improve RowMark handling during Self-Join Elimination The Self-Join Elimination SJE feature messes up keeping and removing RowMark's in remove_self_joins_one_group(). That didn't lead to user-level error, because the planned RowMark is only used to reference a rtable entry in later execution stag

pgsql: Refactor variable names in remove_self_joins_one_group()

Refactor variable names in remove_self_joins_one_group() Rename inner and outer to rrel and krel, respectively, to highlight their connection to r and k indexes. For the same reason, rename imark and omark to rmark and kmark. Discussion: https://postgr.es/m/18c6bd6c-6d2a-419a-b0da-dfedef34b585%4

pgsql: Refactor variable names in remove_self_joins_one_group()

Refactor variable names in remove_self_joins_one_group() Rename inner and outer to rrel and krel, respectively, to highlight their connection to r and k indexes. For the same reason, rename imark and omark to rmark and kmark. Discussion: https://postgr.es/m/18c6bd6c-6d2a-419a-b0da-dfedef34b585%4

pgsql: Further clarify documentation for the initcap function

note about the purpose of the function. Discussion: https://postgr.es/m/804cc10ef95d4d3b298e76b181fd9437%40postgrespro.ru Author: Oleg Tselebrovskiy Co-authored-by: Alexander Korotkov Reviewed-by: Jeff Davis Reviewed-by: Peter Eisentraut Branch -- master Details --- https

pgsql: Improve RowMark handling during Self-Join Elimination

Improve RowMark handling during Self-Join Elimination The Self-Join Elimination SJE feature messes up keeping and removing RowMark's in remove_self_joins_one_group(). That didn't lead to user-level error, because the planned RowMark is only used to reference a rtable entry in later execution stag

pgsql: Revert "Get rid of WALBufMappingLock"

Revert "Get rid of WALBufMappingLock" This reverts commit bc22dc0e0ddc2dcb6043a732415019cc6b6bf683. It appears that conditional variables are not suitable for use inside critical sections. If WaitLatch()/WaitEventSetWaitBlock() face postmaster death, they exit, releasing all locks instead of PANI

pgsql: Revert "Get rid of WALBufMappingLock"

Revert "Get rid of WALBufMappingLock" This reverts commit bc22dc0e0ddc2dcb6043a732415019cc6b6bf683. It appears that conditional variables are not suitable for use inside critical sections. If WaitLatch()/WaitEventSetWaitBlock() face postmaster death, they exit, releasing all locks instead of PANI

pgsql: Fix checkpointer shared memory allocation

the comment. Reported-by: Tom Lane Discussion: https://postgr.es/m/1439188.1754506714%40sss.pgh.pa.us Author: Xuneng Zhou Co-authored-by: Alexander Korotkov Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7f872ae7020e6772ea7a6355c8d3c3be648016a2 Modified Fi

pgsql: Fix checkpointer shared memory allocation

the comment. Reported-by: Tom Lane Discussion: https://postgr.es/m/1439188.1754506714%40sss.pgh.pa.us Author: Xuneng Zhou Co-authored-by: Alexander Korotkov Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c5d66fc12b0891fd5f2a830ab9fa9feb8df94171 Modified Fi

pgsql: Fix checkpointer shared memory allocation

the comment. Reported-by: Tom Lane Discussion: https://postgr.es/m/1439188.1754506714%40sss.pgh.pa.us Author: Xuneng Zhou Co-authored-by: Alexander Korotkov Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/73f897ba5836c1341bec460c618ac76264d986c8 Modified Fi

pgsql: Fix checkpointer shared memory allocation

the comment. Reported-by: Tom Lane Discussion: https://postgr.es/m/1439188.1754506714%40sss.pgh.pa.us Author: Xuneng Zhou Co-authored-by: Alexander Korotkov Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2ac50f1187c2007f6ed581db6ee7240c5e5a37e6 Modified Fi

pgsql: Fix checkpointer shared memory allocation

the comment. Reported-by: Tom Lane Discussion: https://postgr.es/m/1439188.1754506714%40sss.pgh.pa.us Author: Xuneng Zhou Co-authored-by: Alexander Korotkov Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6058900348059255a8a8da6df46ff8606ca1c612 Modified Fi

pgsql: Fix checkpointer shared memory allocation

the comment. Reported-by: Tom Lane Discussion: https://postgr.es/m/1439188.1754506714%40sss.pgh.pa.us Author: Xuneng Zhou Co-authored-by: Alexander Korotkov Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5cfbff48a4fdd1437ff06fcebdc2dade477ed4b8 Modified Fi

pgsql: Fix checkpointer shared memory allocation

the comment. Reported-by: Tom Lane Discussion: https://postgr.es/m/1439188.1754506714%40sss.pgh.pa.us Author: Xuneng Zhou Co-authored-by: Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/466c5435fd45209546c502bd1e8ee5b76b1cc0a1 Modified Fi

pgsql: Revert "Clarify documentation for the initcap function"

Revert "Clarify documentation for the initcap function" This reverts commit 1fe9e3822c4e574aa526b99af723e61e03f36d4f. That commit was a documentation improvement, not a bug fix. We don't normally backpatch such changes. Discussion: https://postgr.es/m/d8eacbeb8194c578a98317b86d7eb2ef0b6eb0e0.c

pgsql: Revert "Clarify documentation for the initcap function"

Revert "Clarify documentation for the initcap function" This reverts commit 1fe9e3822c4e574aa526b99af723e61e03f36d4f. That commit was a documentation improvement, not a bug fix. We don't normally backpatch such changes. Discussion: https://postgr.es/m/d8eacbeb8194c578a98317b86d7eb2ef0b6eb0e0.c

pgsql: Revert "Clarify documentation for the initcap function"

Revert "Clarify documentation for the initcap function" This reverts commit 1fe9e3822c4e574aa526b99af723e61e03f36d4f. That commit was a documentation improvement, not a bug fix. We don't normally backpatch such changes. Discussion: https://postgr.es/m/d8eacbeb8194c578a98317b86d7eb2ef0b6eb0e0.c

pgsql: Revert "Clarify documentation for the initcap function"

Revert "Clarify documentation for the initcap function" This reverts commit 1fe9e3822c4e574aa526b99af723e61e03f36d4f. That commit was a documentation improvement, not a bug fix. We don't normally backpatch such changes. Discussion: https://postgr.es/m/d8eacbeb8194c578a98317b86d7eb2ef0b6eb0e0.c

pgsql: Revert "Clarify documentation for the initcap function"

Revert "Clarify documentation for the initcap function" This reverts commit 1fe9e3822c4e574aa526b99af723e61e03f36d4f. That commit was a documentation improvement, not a bug fix. We don't normally backpatch such changes. Discussion: https://postgr.es/m/d8eacbeb8194c578a98317b86d7eb2ef0b6eb0e0.c

pgsql: Revert "Clarify documentation for the initcap function"

Revert "Clarify documentation for the initcap function" This reverts commit 1fe9e3822c4e574aa526b99af723e61e03f36d4f. That commit was a documentation improvement, not a bug fix. We don't normally backpatch such changes. Discussion: https://postgr.es/m/d8eacbeb8194c578a98317b86d7eb2ef0b6eb0e0.c

pgsql: Clarify documentation for the initcap function

Clarify documentation for the initcap function This commit documents differences in the definition of word separators for the initcap function between libc and ICU locale providers. Backpatch to all supported branches. Discussion: https://postgr.es/m/804cc10ef95d4d3b298e76b181fd9437%40postgrespr

pgsql: Clarify documentation for the initcap function

Clarify documentation for the initcap function This commit documents differences in the definition of word separators for the initcap function between libc and ICU locale providers. Backpatch to all supported branches. Discussion: https://postgr.es/m/804cc10ef95d4d3b298e76b181fd9437%40postgrespr

pgsql: Clarify documentation for the initcap function

Clarify documentation for the initcap function This commit documents differences in the definition of word separators for the initcap function between libc and ICU locale providers. Backpatch to all supported branches. Discussion: https://postgr.es/m/804cc10ef95d4d3b298e76b181fd9437%40postgrespr

pgsql: Clarify documentation for the initcap function

Clarify documentation for the initcap function This commit documents differences in the definition of word separators for the initcap function between libc and ICU locale providers. Backpatch to all supported branches. Discussion: https://postgr.es/m/804cc10ef95d4d3b298e76b181fd9437%40postgrespr

pgsql: Clarify documentation for the initcap function

Clarify documentation for the initcap function This commit documents differences in the definition of word separators for the initcap function between libc and ICU locale providers. Backpatch to all supported branches. Discussion: https://postgr.es/m/804cc10ef95d4d3b298e76b181fd9437%40postgrespr

pgsql: Clarify documentation for the initcap function

Clarify documentation for the initcap function This commit documents differences in the definition of word separators for the initcap function between libc and ICU locale providers. Backpatch to all supported branches. Discussion: https://postgr.es/m/804cc10ef95d4d3b298e76b181fd9437%40postgrespr

pgsql: Clarify documentation for the initcap function

Clarify documentation for the initcap function This commit documents differences in the definition of word separators for the initcap function between libc and ICU locale providers. Backpatch to all supported branches. Discussion: https://postgr.es/m/804cc10ef95d4d3b298e76b181fd9437%40postgrespr

pgsql: Limit checkpointer requests queue size

Limit checkpointer requests queue size If the number of sync requests is big enough, the palloc() call in AbsorbSyncRequests() will attempt to allocate more than 1 GB of memory, resulting in failure. This can lead to an infinite loop in the checkpointer process, as it repeatedly fails to absorb t

pgsql: Limit checkpointer requests queue size

Limit checkpointer requests queue size If the number of sync requests is big enough, the palloc() call in AbsorbSyncRequests() will attempt to allocate more than 1 GB of memory, resulting in failure. This can lead to an infinite loop in the checkpointer process, as it repeatedly fails to absorb t

pgsql: Limit checkpointer requests queue size

Limit checkpointer requests queue size If the number of sync requests is big enough, the palloc() call in AbsorbSyncRequests() will attempt to allocate more than 1 GB of memory, resulting in failure. This can lead to an infinite loop in the checkpointer process, as it repeatedly fails to absorb t

pgsql: Limit checkpointer requests queue size

Limit checkpointer requests queue size If the number of sync requests is big enough, the palloc() call in AbsorbSyncRequests() will attempt to allocate more than 1 GB of memory, resulting in failure. This can lead to an infinite loop in the checkpointer process, as it repeatedly fails to absorb t

pgsql: Limit checkpointer requests queue size

Limit checkpointer requests queue size If the number of sync requests is big enough, the palloc() call in AbsorbSyncRequests() will attempt to allocate more than 1 GB of memory, resulting in failure. This can lead to an infinite loop in the checkpointer process, as it repeatedly fails to absorb t

pgsql: Limit checkpointer requests queue size

Limit checkpointer requests queue size If the number of sync requests is big enough, the palloc() call in AbsorbSyncRequests() will attempt to allocate more than 1 GB of memory, resulting in failure. This can lead to an infinite loop in the checkpointer process, as it repeatedly fails to absorb t

pgsql: Process sync requests incrementally in AbsorbSyncRequests

: https://postgr.es/m/db4534f83a22a29ab5ee2566ad86ca92%40postgrespro.ru Author: Maxim Orlov Co-authored-by: Xuneng Zhou Reviewed-by: Andres Freund Reviewed-by: Heikki Linnakangas Reviewed-by: Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Update comment for ReplicationSlot.last_saved_restart_lsn

%40mail.gmail.com Author: Hayato Kuroda Co-authored-by: Amit Kapila Reviewed-by: Vignesh C Reviewed-by: Amit Kapila Reviewed-by: Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0810fbb02dbe70b8a7a7bcc51580827b8bbddbdc Modified Files

pgsql: Fix infinite wait when reading a partially written WAL record

/CALDaNm34m36PDHzsU_GdcNXU0gLTfFY5rzh9GSQv%3Dw6B%2BQVNRQ%40mail.gmail.com Author: Vignesh C Reviewed-by: Hayato Kuroda Reviewed-by: Dilip Kumar Reviewed-by: Michael Paquier Reviewed-by: Alexander Korotkov Backpatch-through: 13 Branch -- REL_17_STABLE Details --- https

pgsql: Fix infinite wait when reading a partially written WAL record

/CALDaNm34m36PDHzsU_GdcNXU0gLTfFY5rzh9GSQv%3Dw6B%2BQVNRQ%40mail.gmail.com Author: Vignesh C Reviewed-by: Hayato Kuroda Reviewed-by: Dilip Kumar Reviewed-by: Michael Paquier Reviewed-by: Alexander Korotkov Backpatch-through: 13 Branch -- REL_13_STABLE Details --- https

pgsql: Fix infinite wait when reading a partially written WAL record

/CALDaNm34m36PDHzsU_GdcNXU0gLTfFY5rzh9GSQv%3Dw6B%2BQVNRQ%40mail.gmail.com Author: Vignesh C Reviewed-by: Hayato Kuroda Reviewed-by: Dilip Kumar Reviewed-by: Michael Paquier Reviewed-by: Alexander Korotkov Backpatch-through: 13 Branch -- REL_14_STABLE Details --- https

pgsql: Improve the stability of the recovery test 047_checkpoint_physic

%2ByHveNDNQk2gM82WBU5A%40mail.gmail.com Discussion: https://postgr.es/m/aHXLep3OaX_vRTNQ%40paquier.xyz Author: Alexander Korotkov Reviewed-by: Michael Paquier Backpatch-through: 17 Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Fix infinite wait when reading a partially written WAL record

/CALDaNm34m36PDHzsU_GdcNXU0gLTfFY5rzh9GSQv%3Dw6B%2BQVNRQ%40mail.gmail.com Author: Vignesh C Reviewed-by: Hayato Kuroda Reviewed-by: Dilip Kumar Reviewed-by: Michael Paquier Reviewed-by: Alexander Korotkov Backpatch-through: 13 Branch -- REL_15_STABLE Details --- https

pgsql: Fix infinite wait when reading a partially written WAL record

/CALDaNm34m36PDHzsU_GdcNXU0gLTfFY5rzh9GSQv%3Dw6B%2BQVNRQ%40mail.gmail.com Author: Vignesh C Reviewed-by: Hayato Kuroda Reviewed-by: Dilip Kumar Reviewed-by: Michael Paquier Reviewed-by: Alexander Korotkov Backpatch-through: 13 Branch -- REL_16_STABLE Details --- https

pgsql: Improve the stability of the recovery test 047_checkpoint_physic

%2ByHveNDNQk2gM82WBU5A%40mail.gmail.com Discussion: https://postgr.es/m/aHXLep3OaX_vRTNQ%40paquier.xyz Author: Alexander Korotkov Reviewed-by: Michael Paquier Backpatch-through: 17 Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Improve recovery test 046_checkpoint_logical_slot

://postgr.es/m/CALDaNm34m36PDHzsU_GdcNXU0gLTfFY5rzh9GSQv%3Dw6B%2BQVNRQ%40mail.gmail.com Author: Alexander Korotkov Co-authored-by: Hayato Kuroda Reviewed-by: Michael Paquier Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Fix infinite wait when reading a partially written WAL record

/CALDaNm34m36PDHzsU_GdcNXU0gLTfFY5rzh9GSQv%3Dw6B%2BQVNRQ%40mail.gmail.com Author: Vignesh C Reviewed-by: Hayato Kuroda Reviewed-by: Dilip Kumar Reviewed-by: Michael Paquier Reviewed-by: Alexander Korotkov Backpatch-through: 13 Branch -- REL_18_STABLE Details --- https

pgsql: Reintroduce test 046_checkpoint_logical_slot

creation of a record that spawns across two pages. - Make the logic wait for the checkpoint completion. Author: Alexander Korotkov Co-authored-by: Hayato Kuroda Reviewed-by: Michael Paquier Backpatch-through: 18 Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg

pgsql: Fix infinite wait when reading a partially written WAL record

/CALDaNm34m36PDHzsU_GdcNXU0gLTfFY5rzh9GSQv%3Dw6B%2BQVNRQ%40mail.gmail.com Author: Vignesh C Reviewed-by: Hayato Kuroda Reviewed-by: Dilip Kumar Reviewed-by: Michael Paquier Reviewed-by: Alexander Korotkov Backpatch-through: 13 Branch -- master Details --- https://git.postgresql.org/pg

pgsql: Reintroduce test 046_checkpoint_logical_slot

creation of a record that spawns across two pages. - Make the logic wait for the checkpoint completion. Author: Alexander Korotkov Co-authored-by: Hayato Kuroda Reviewed-by: Michael Paquier Backpatch-through: 18 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Improve the stability of the recovery test 047_checkpoint_physic

%2ByHveNDNQk2gM82WBU5A%40mail.gmail.com Discussion: https://postgr.es/m/aHXLep3OaX_vRTNQ%40paquier.xyz Author: Alexander Korotkov Reviewed-by: Michael Paquier Backpatch-through: 17 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Fix a typo in the deparseArrayCoerceExpr() header comment

Fix a typo in the deparseArrayCoerceExpr() header comment Discussion: https://postgr.es/m/CAHewXNn%3D_ykCtcTw5SCfZ-eVr4m%2BCuc804rGeMsKuj%3DD4xpL4w%40mail.gmail.com Author: Tender Wang Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4c5159a2d8c01e6f08ce20a51bb2dca

pgsql: Support for deparsing of ArrayCoerceExpr node in contrib/postgre

.ru Author: Alexander Pyhalov Reviewed-by: Maxim Orlov Reviewed-by: Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/62c3b4cd9ddc6d3066e3f6e43b68fd00c620d9ad Modified Files -- contrib/postgres_fdw/deparse.c

pgsql: Fix CheckPointReplicationSlots() with max_replication_slots == 0

Fix CheckPointReplicationSlots() with max_replication_slots == 0 ca307d5cec90 made CheckPointReplicationSlots() unconditionally call ReplicationSlotsComputeRequiredLSN(). It causes an assertion trap when max_replication_slots equals 0. This commit makes CheckPointReplicationSlots() call Replicat

pgsql: Temporarily remove 046_checkpoint_logical_slot.pl

Temporarily remove 046_checkpoint_logical_slot.pl This new test was intended to check the handling of the replication slot's restart lsn fixed in ca307d5cec90. However, it also reveals another issue related to logical decoding. This commit temporarily removes this test to keep the buildfarm and

Re: pgsql: Improve runtime and output of tests for replication slots checkp

On Mon, Jun 23, 2025 at 4:33 PM Amit Kapila wrote: > On Mon, Jun 23, 2025 at 6:01 PM Alexander Korotkov > wrote: > > > > On Mon, Jun 23, 2025 at 3:00 PM Jelte Fennema-Nio > > wrote: > > > On Mon, 23 Jun 2025 at 12:24, Alexander Korotkov > > > wrot

pgsql: Remove excess assert from InvalidatePossiblyObsoleteSlot()

Remove excess assert from InvalidatePossiblyObsoleteSlot() ca307d5cec90 introduced keeping WAL segments by slot's last saved restart LSN. It also added an assertion that the slot's restart LSN never goes backward. However, situations when the restart LSN goes backward have been spotted by buildfar

Re: pgsql: Improve runtime and output of tests for replication slots checkp

On Mon, Jun 23, 2025 at 3:00 PM Jelte Fennema-Nio wrote: > On Mon, 23 Jun 2025 at 12:24, Alexander Korotkov wrote: > > On Mon, Jun 23, 2025 at 3:29 AM Michael Paquier wrote: > > > > Yeah, that's what I think too. The unintentional omission of a > > > >

Re: pgsql: Improve runtime and output of tests for replication slots checkp

> the test is unstable as written. Exactly. I've proposed the fix with wait_for_log() in [1]. Nevertheless, both cases (immediate stop before checkpoint completion, and immediate stop after checkpoint completion) must work without hang. Links. 1. https://www.postgresql.org/message-id/CAPpHfdurV-j_e0pb%3DUFENAy3tyzxfF%2ByHveNDNQk2gM82WBU5A%40mail.gmail.com -- Regards, Alexander Korotkov Supabase

Re: pgsql: Improve runtime and output of tests for replication slots checkp

On Sat, Jun 21, 2025 at 2:42 AM Tom Lane wrote: > > Alexander Korotkov writes: > > And I see the following variable values. > > > (lldb) p/x targetPagePtr > > (XLogRecPtr) 0x29004000 > > (lldb) p/x RecPtr > > (XLogRecPtr) 0x29002138 > &g

Re: pgsql: Improve runtime and output of tests for replication slots checkp

On Sat, Jun 21, 2025 at 1:40 AM Alexander Korotkov wrote: > On Sat, Jun 21, 2025 at 1:25 AM Tom Lane wrote: > > I wrote: > > > But in the buildfarm failures I don't see any 'checkpoint complete' > > > before the shutdown. > > > > Ooops, I lie

Re: pgsql: Improve runtime and output of tests for replication slots checkp

hatever is going on here > is a bit subtle and platform-dependent. I think this indicates unfinished intention to wait for checkpoint completion. But I think both cases (checkpoint finished and unfinished) should work correctly. So, I believe there is a backend problem. I'm trying to reproduce this locally. Sorry for the confusion. -- Regards, Alexander Korotkov Supabase

Re: pgsql: Improve runtime and output of tests for replication slots checkp

On Fri, Jun 20, 2025, 19:10 Melanie Plageman wrote: > > On Thu, Jun 19, 2025 at 7:31 PM Alexander Korotkov < > akorot...@postgresql.org> wrote: > >> Improve runtime and output of tests for replication slots checkpointing. >> >> The TAP tests that verify l

pgsql: Improve runtime and output of tests for replication slots checkp

ld-farm logs and looked odd. Also, remove excessive 'shared_preload_libraries' GUC from the config and add a check for 'injection_points' extension availability. Reported-by: Alexander Lakhin Reported-by: Tom Lane Author: Alexander Korotkov Author: Vitaly Davydov Re

pgsql: Improve runtime and output of tests for replication slots checkp

ld-farm logs and looked odd. Also, remove excessive 'shared_preload_libraries' GUC from the config and add a check for 'injection_points' extension availability. Reported-by: Alexander Lakhin Reported-by: Tom Lane Author: Alexander Korotkov Author: Vitaly Davydov Re

pgsql: Keep WAL segments by the flushed value of the slot's restart LSN

ra in the discussion. Unlike 291221c46575, this fix doesn't affect ABI and is intended for back branches. Discussion: https://postgr.es/m/flat/1d12d2-67235980-35-19a406a0%4063439497 Author: Vitaly Davydov Reviewed-by: Tomas Vondra Reviewed-by: Alexander Korotkov Reviewed-by: Amit Kapila

pgsql: Keep WAL segments by the flushed value of the slot's restart LSN

ra in the discussion. Unlike 291221c46575, this fix doesn't affect ABI and is intended for back branches. Discussion: https://postgr.es/m/flat/1d12d2-67235980-35-19a406a0%4063439497 Author: Vitaly Davydov Reviewed-by: Tomas Vondra Reviewed-by: Alexander Korotkov Reviewed-by: Amit Kapila

pgsql: Keep WAL segments by the flushed value of the slot's restart LSN

ra in the discussion. Unlike 291221c46575, this fix doesn't affect ABI and is intended for back branches. Discussion: https://postgr.es/m/flat/1d12d2-67235980-35-19a406a0%4063439497 Author: Vitaly Davydov Reviewed-by: Tomas Vondra Reviewed-by: Alexander Korotkov Reviewed-by: Amit Kapila

pgsql: Keep WAL segments by the flushed value of the slot's restart LSN

ra in the discussion. Unlike 291221c46575, this fix doesn't affect ABI and is intended for back branches. Discussion: https://postgr.es/m/flat/1d12d2-67235980-35-19a406a0%4063439497 Author: Vitaly Davydov Reviewed-by: Tomas Vondra Reviewed-by: Alexander Korotkov Reviewed-by: Amit Kapila

pgsql: Keep WAL segments by the flushed value of the slot's restart LSN

ra in the discussion. Unlike 291221c46575, this fix doesn't affect ABI and is intended for back branches. Discussion: https://postgr.es/m/flat/1d12d2-67235980-35-19a406a0%4063439497 Author: Vitaly Davydov Reviewed-by: Tomas Vondra Reviewed-by: Alexander Korotkov Reviewed-by: Amit Kapila

pgsql: Add TAP tests to check replication slot advance during the check

next WAL segment. Discussion: https://postgr.es/m/flat/1d12d2-67235980-35-19a406a0%4063439497 Author: Vitaly Davydov Author: Tomas Vondra Reviewed-by: Alexander Korotkov Reviewed-by: Amit Kapila Backpatch-through: 17 Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg

pgsql: Keep WAL segments by slot's last saved restart LSN

thor: Vitaly Davydov Author: Alexander Korotkov Reviewed-by: Amit Kapila Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ca307d5cec90a4fde62a50fafc8ab607ff1d8664 Modified Files -- src/backend/replication/slot.c | 57 ++

pgsql: Add TAP tests to check replication slot advance during the check

next WAL segment. Discussion: https://postgr.es/m/flat/1d12d2-67235980-35-19a406a0%4063439497 Author: Vitaly Davydov Author: Tomas Vondra Reviewed-by: Alexander Korotkov Reviewed-by: Amit Kapila Backpatch-through: 17 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Fix tuple_fraction calculation in generate_orderedappend_paths()

Fix tuple_fraction calculation in generate_orderedappend_paths() 6b94e7a6da adjusted generate_orderedappend_paths() to consider fractional paths. However, it didn't manage to interpret the tuple_fraction value correctly. According to the header comment of grouping_planner(), the tuple_fraction >

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

note that it is not the only PG18 Open Item left after beta1, and fixing Open Items usually requires changes besides docs and whitespaces. This commit changes ABI, but this should be OK. We do preserve ABI only for stable releases. -- Regards, Alexander Korotkov Supabase

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

is commit is not the only one on master branch after tag REL_18_BETA1. -- Regards, Alexander Korotkov Supabase

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

de handling to be kept within the analyzejoins.c. > > I believe this was pushed by mistake. Why it should be mistake this time? At least, this time I managed to wait till the end of release freeze. -- Regards, Alexander Korotkov Supabase

pgsql: Refactor ChangeVarNodesExtended() using the custom callback

%3DHqgZZmX0tdNbzVNJxqc8yg-8kDQQ%40mail.gmail.com Author: Andrei Lepikhov Author: Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ab42d643c14509cf1345588f55d798284b11a91e Modified Files -- src/backend/optimizer/plan/analyzejoins.c | 160

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

On Sat, May 3, 2025 at 11:06 PM Tom Lane wrote: > > Alexander Korotkov writes: > > On Sat, May 3, 2025 at 10:34 PM Tom Lane wrote: > >> You are aware that we are in release freeze, no? > > > I missed that. Should I revert this commit now? > > Yes, I think s

pgsql: Revert "Refactor ChangeVarNodesExtended() using the custom callb

Revert "Refactor ChangeVarNodesExtended() using the custom callback" This reverts commit 250a718aadad68793e82103282247556a46a3cfc. It shouldn't be pushed during the release freeze. Reported-by: Tom Lane Discussion: https://postgr.es/m/E1uBIbY-000owH-0O%40gemulon.postgresql.org Branch -- mast

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

On Sat, May 3, 2025 at 10:34 PM Tom Lane wrote: > > Alexander Korotkov writes: > > Refactor ChangeVarNodesExtended() using the custom callback > > You are aware that we are in release freeze, no? I missed that. Should I revert this commit now? -- Regards, Alexander Korotkov Supabase

pgsql: Refactor ChangeVarNodesExtended() using the custom callback

%3DHqgZZmX0tdNbzVNJxqc8yg-8kDQQ%40mail.gmail.com Author: Andrei Lepikhov Author: Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/250a718aadad68793e82103282247556a46a3cfc Modified Files -- src/backend/optimizer/plan/analyzejoins.c | 160

pgsql: Fixes for ChangeVarNodes_walker()

-by: Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2260c7f6d90ecf76d3806d32890a0890688b41e8 Modified Files -- src/backend/rewrite/rewriteManip.c | 28 src/test/regress/expected/join.out | 16

pgsql: Restore comments in ChangeVarNodesExtended()

Restore comments in ChangeVarNodesExtended() This commit restores comments in ChangeVarNodesExtended(), which were accidentally removed by fc069a3a6319. Reported-by: Richard Guo Discussion: https://postgr.es/m/CAMbWs49PE3CvnV8vrQ0Dr%3DHqgZZmX0tdNbzVNJxqc8yg-8kDQQ%40mail.gmail.com Branch --

pgsql: Disallow removing placeholders during Self-Join Elimination.

happen that we skip the removal of some PHVs that could be removed. However, the overhead of extra PHVs is small compared to the complexity of analysis needed to remove them. Reported-by: Alexander Lakhin Author: Alena Rybakina Author: Andrei Lepikhov Reviewed-by: Alexander Korotkov Reviewed-by

pgsql: Maintain RelIdToTypeIdCacheHash in TypeCacheOpcCallback()

Maintain RelIdToTypeIdCacheHash in TypeCacheOpcCallback() b85a9d046efd introduced a new RelIdToTypeIdCacheHash, whose entries should exist for typecache entries with TCFLAGS_HAVE_PG_TYPE_DATA flag set or any of TCFLAGS_OPERATOR_FLAGS set or tupDesc set. However, TypeCacheOpcCallback(), which rese

pgsql: Properly prepare varinfos in estimate_multivariate_bucketsize()

operly. Reported-by: Robins Tharakan Discussion: https://postgr.es/m/18885-da51324078588253%40postgresql.org Author: Andrei Lepikhov Reviewed-by: David Rowley Reviewed-by: Tomas Vondra Reviewed-by: Alexander Korotkov Branch -- master Details --- https://git.postgres

Re: pgsql: Use extended stats for precise estimation of bucket size in hash

On Thu, Apr 10, 2025 at 3:37 AM Robins Tharakan wrote: > On Mon, 10 Mar 2025 at 22:18, Alexander Korotkov > wrote: > > > > Use extended stats for precise estimation of bucket size in hash join > > > After this commit, I see a recurrence of an error

Re: pgsql: Convert 'x IN (VALUES ...)' to 'x = ANY ...' then appropriate

{1,2}'::oid[])) > > + -> Sort > > + Sort Key: a.oid > > + -> Seq Scan on pg_am a > > +(7 rows) > > Are these failures from patches applied to master prior to 3ba2cdaa? Yes, these failures appears before 3ba2cdaa. Tom committed 3ba2cdaa to fix the problem before I get into it [1]. Links. 1. https://www.postgresql.org/message-id/srnuqlttuimzmvoulhsrbgvj4vnul6b65osswvua7sfkqsvmuy%40yg7apybpxp34 -- Regards, Alexander Korotkov Supabase

pgsql: Remove GUC_NOT_IN_SAMPLE from enable_self_join_elimination

Remove GUC_NOT_IN_SAMPLE from enable_self_join_elimination fc069a3a6319 implements Self-Join Elimination (SJE) and provides a new GUC variable: enable_self_join_elimination. This new GUC variable was marked as GUC_NOT_IN_SAMPLE. However, enable_self_join_elimination is documented and is not diff

Re: pgsql: Convert 'x IN (VALUES ...)' to 'x = ANY ...' then appropriate

On Fri, Apr 4, 2025 at 6:47 PM Melanie Plageman wrote: > > On Fri, Apr 4, 2025 at 9:17 AM Alexander Korotkov > wrote: > > > > Convert 'x IN (VALUES ...)' to 'x = ANY ...' then appropriate > > > > This commit implements the automatic convers

Re: pgsql: Put enable_self_join_elimination into postgresql.conf.sample

On Sun, Apr 6, 2025 at 2:10 PM Daniel Gustafsson wrote: > > > On 6 Apr 2025, at 12:27, Alexander Korotkov > > wrote: > > > > Put enable_self_join_elimination into postgresql.conf.sample > > > > fc069a3a6319 implements Self-Join Elimination (S

pgsql: Revert "Put enable_self_join_elimination into postgresql.conf.sa

Revert "Put enable_self_join_elimination into postgresql.conf.sample" This reverts commit c2d329260cd8. Reported-by: Daniel Gustafsson Discussion: https://postgr.es/m/D292EB44-806E-439A-82A4-491A1BA59E7A%40yesql.se Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3

pgsql: Put enable_self_join_elimination into postgresql.conf.sample

Put enable_self_join_elimination into postgresql.conf.sample fc069a3a6319 implements Self-Join Elimination (SJE) and provides a new GUC variable: enable_self_join_elimination. This commit adds enable_self_join_elimination to the postgresql.conf.sample, as it was forgotten in the original commit.

pgsql: postgres_fdw: Remove redundant check in semijoin_target_ok()

postgres_fdw: Remove redundant check in semijoin_target_ok() If a var belongs to the innerrel of the joinrel, it's not possible that it belongs to the outerrel. This commit removes the redundant check from the if-clause but keeps it as an assertion. Discussion: https://postgr.es/m/flat/CAHewXN=

pgsql: Get rid of WALBufMappingLock

ura Sokolov Co-authored-by: Alexander Korotkov Reviewed-by: Pavel Borisov Reviewed-by: Tomas Vondra Tested-by: Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bc22dc0e0ddc2dcb6043a732415019cc6b6bf683 Modified Files -- src/backend/access

pgsql: Convert 'x IN (VALUES ...)' to 'x = ANY ...' then appropriate

Rybakina Author: Andrei Lepikhov Reviewed-by: Ivan Kush Reviewed-by: Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c0962a113d1f2f94cb7222a7ca025a67e9ce3860 Modified Files -- src/backend/optimizer/plan/subselect.c| 80 ++

pgsql: Extract make_SAOP_expr() function from match_orclause_to_indexco

ena Rybakina Author: Andrei Lepikhov Reviewed-by: Ivan Kush Reviewed-by: Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d48d2e2dc8be50d3ca13305b5699384329b15433 Modified Files -- src/backend/optimizer/path/indxpath.c | 62 +--

pgsql: Make group_similar_or_args() reorder clause list as little as po

Make group_similar_or_args() reorder clause list as little as possible Currently, group_similar_or_args() permutes original positions of clauses independently on whether it manages to find any groups of similar clauses. While we are not providing any strict warranties on saving the original order

pgsql: postgres_fdw: Remove redundant check in semijoin_target_ok()

postgres_fdw: Remove redundant check in semijoin_target_ok() If a var belongs to the innerrel of the joinrel, it's not possible that it belongs to the outerrel. This commit removes the redundant check from the if-clause but keeps it as an assertion. Discussion: https://postgr.es/m/flat/CAHewXN=

pgsql: postgres_fdw: Avoid pulling up restrict infos from subqueries

ssion: https://postgr.es/m/CAEP4nAzryLd3gwcUpFBAG9MWyDfMRX8ZjuyY2XXjyC_C6k%2B_Zw%40mail.gmail.com Author: Alexander Pyhalov Reviewed-by: Alexander Korotkov Backpatch-through: 17 Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/729fe699e61231a01d834078c0566830638

pgsql: postgres_fdw: Avoid pulling up restrict infos from subqueries

ssion: https://postgr.es/m/CAEP4nAzryLd3gwcUpFBAG9MWyDfMRX8ZjuyY2XXjyC_C6k%2B_Zw%40mail.gmail.com Author: Alexander Pyhalov Reviewed-by: Alexander Korotkov Backpatch-through: 17 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/023fb512755ffb64949eb6de8464c259ca7

  1   2   3   4   5   6   7   8   9   >