Re: pgsql: Optimize btree insertions for common case of increasing values

2018-04-10 Thread Pavan Deolasee
use extent based storage, there would be many other things that will break and require changes, no? Apart from that, other changes requested are included in the patch. This also takes care of Heikki's observation regarding UNLOGGED tables on the other thread. Thanks, Pavan -- Pavan Deolasee

Re: pgsql: Fix comment on B-tree insertion fastpath condition.

2018-04-10 Thread Pavan Deolasee
age". That is what > we check here, not "greater than or equal". > > This was part of the follow-on patch that I'd sent (which needs a little more adjustments based on Peter's feedback). But thanks for taking care of it anyways. Thanks, Pavan -- Pavan Deolasee

Re: pgsql: Optimize btree insertions for common case of increasing values

2018-04-05 Thread Pavan Deolasee
alidated, but only when we happen to > recycle a page that once again becomes the rightmost leaf page. > > Can I borrow that almost verbatim, after adding details about the optimisation itself? Looks like I'm too tired to think sensibly. > Once those changes are made, this shou

Re: pgsql: New files for MERGE

2018-04-04 Thread Pavan Deolasee
On Thu, Apr 5, 2018 at 12:16 AM, Andres Freund <and...@anarazel.de> wrote: > Hi, > > On 2018-04-05 00:02:06 +0530, Pavan Deolasee wrote: > > Apologies from my end. Simon checked with me regarding your referenced > > email. I was in the middle of responding to it (wi

Re: pgsql: New files for MERGE

2018-04-04 Thread Pavan Deolasee
ch to take care of your review comments), but got side tracked by some high priority customer escalation. I shall respond soon. Thanks, Pavan -- Pavan Deolasee http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services

Re: pgsql: Optimize btree insertions for common case of increasing values

2018-04-04 Thread Pavan Deolasee
plit is needed? But isn't page split is only needed if the page doesn't have enough free space? If so, we have checked for that before setting "fastpath". > * The indentation of the main _bt_doinsert() test does not follow > project guidelines. Please tweak that, too. > O

Re: pgsql: Modified files for MERGE

2018-04-02 Thread Pavan Deolasee
d-on patch to fix whatever I could spot before the patch was reverted. I see Andres has already started discussion about displaying memory usage which was one other thing I'd spotted while the build farm was red. Thanks, Pavan -- Pavan Deolasee http://www.2ndQuadrant.com/ Postgre