Re: pgsql: Implement pipeline mode in libpq

2021-04-06 Thread David Rowley
On Wed, 7 Apr 2021 at 01:53, Alvaro Herrera wrote: > I did not intend to have the define defined at all times. Leaving it > there was an oversight. Let's just remove the #define line; users > interested in that output can turn it on when they need it. Removing it > means less clutter in the bui

Re: pgsql: Implement pipeline mode in libpq

2021-04-06 Thread Alvaro Herrera
On 2021-Apr-06, David Rowley wrote: > I'm still not really sure why this code does #define directly followed > by an #ifdef for that define. However, just to clear up the final > compiler warning that's currently being produced on MSVC, I've > attached a proposed patch to fix it. Hi David, sorry

Re: pgsql: Implement pipeline mode in libpq

2021-04-06 Thread David Rowley
On Tue, 30 Mar 2021 at 20:19, David Rowley wrote: > On Tue, 16 Mar 2021 at 10:20, Alvaro Herrera wrote: > > > > Implement pipeline mode in libpq > > > src/test/modules/libpq_pipeline/libpq_pipeline.c | 1303 > > > > I'm wondering if you meant to leave the "#define DEBUG" li

Re: pgsql: Implement pipeline mode in libpq

2021-03-30 Thread David Rowley
Hi Alvaro, On Tue, 16 Mar 2021 at 10:20, Alvaro Herrera wrote: > > Implement pipeline mode in libpq > src/test/modules/libpq_pipeline/libpq_pipeline.c | 1303 I'm wondering if you meant to leave the "#define DEBUG" line at line 34 in the above file? It seems pretty strang

Re: pgsql: Implement pipeline mode in libpq

2021-03-16 Thread Alvaro Herrera
On 2021-Mar-15, Tom Lane wrote: > Alvaro Herrera writes: > > Implement pipeline mode in libpq > > So jacana and fairywren are unhappy about this, and the failure reports > are totally uninformative: Yeah. This is the main clue: > Mar 15 21:14:41 # Looks like you planned 8 tests but ran 15. >

Re: pgsql: Implement pipeline mode in libpq

2021-03-15 Thread Tom Lane
Alvaro Herrera writes: > Implement pipeline mode in libpq So jacana and fairywren are unhappy about this, and the failure reports are totally uninformative: Mar 15 21:14:33 cd /home/pgrunner/bf/root/HEAD/pgsql.build/../pgsql/src/test/modules/libpq_pipeline && TESTDIR='/home/pgrunner/bf/root/H