Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-16 Thread Andrew Dunstan
On 2024-09-15 Su 9:28 PM, Bruce Momjian wrote: On Sun, Sep 15, 2024 at 06:07:21PM -0400, Andrew Dunstan wrote: On 2024-09-15 Su 4:36 PM, Bruce Momjian wrote: On Sun, Sep 15, 2024 at 04:33:49PM -0400, Andrew Dunstan wrote: I understand perfectly what the warning is about. But the project's pe

Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-15 Thread Bruce Momjian
On Sun, Sep 15, 2024 at 06:07:21PM -0400, Andrew Dunstan wrote: > > On 2024-09-15 Su 4:36 PM, Bruce Momjian wrote: > > On Sun, Sep 15, 2024 at 04:33:49PM -0400, Andrew Dunstan wrote: > > > I understand perfectly what the warning is about. > > > > > > But the project's perlcritic policy is express

Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-15 Thread Andrew Dunstan
On 2024-09-15 Su 4:36 PM, Bruce Momjian wrote: On Sun, Sep 15, 2024 at 04:33:49PM -0400, Andrew Dunstan wrote: I understand perfectly what the warning is about. But the project's perlcritic policy is expressed at src/tools/perlcheck/ perlcriticrc. It's basically severity 5 plus some additions

Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-15 Thread Bruce Momjian
On Sun, Sep 15, 2024 at 04:33:49PM -0400, Andrew Dunstan wrote: > I understand perfectly what the warning is about. > > But the project's perlcritic policy is expressed at src/tools/perlcheck/ > perlcriticrc. It's basically severity 5 plus some additions and one exception. > We shouldn't be imposi

Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-15 Thread Andrew Dunstan
On 2024-09-15 Su 4:16 PM, Bruce Momjian wrote: On Sun, Sep 15, 2024 at 02:30:47PM -0400, Andrew Dunstan wrote: On 2024-09-15 Su 10:56 AM, Bruce Momjian wrote: Perl scripts: eliminate "Useless interpolation" warnings Eliminate warnings of Perl Critic from src/tools. Backpatch

Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-15 Thread Bruce Momjian
On Sun, Sep 15, 2024 at 02:30:47PM -0400, Andrew Dunstan wrote: > > > On 2024-09-15 Su 10:56 AM, Bruce Momjian wrote: > > Perl scripts: eliminate "Useless interpolation" warnings > > Eliminate warnings of Perl Critic from src/tools. > > Backpatch-through: master > > > > I don't

Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings

2024-09-15 Thread Andrew Dunstan
On 2024-09-15 Su 10:56 AM, Bruce Momjian wrote: Perl scripts: eliminate "Useless interpolation" warnings Eliminate warnings of Perl Critic from src/tools. Backpatch-through: master I don't understand this commit. The buildfarm members crake and koel regularly run the perl critic checks