Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-21 Thread Andrew Dunstan
On 10/20/21 5:48 PM, Tom Lane wrote: > Andrew Dunstan writes: >> OK, it turns out that it's better to put the addition at the end of the >> PATH, otherise initdb complains that it can't find postgres in the same >> directory. > That seems horribly unsafe, or at least prone to pulling in the > pro

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-20 Thread Tom Lane
Andrew Dunstan writes: > OK, it turns out that it's better to put the addition at the end of the > PATH, otherise initdb complains that it can't find postgres in the same > directory. That seems horribly unsafe, or at least prone to pulling in the program from some other versuion of Postgres. Ho

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-20 Thread Andrew Dunstan
On 10/20/21 3:09 PM, Andres Freund wrote: > Hi, > > On 2021-10-20 14:30:49 -0400, Andrew Dunstan wrote: >> On 10/20/21 12:31 PM, Andres Freund wrote: >>> ISTM that we should just make the "test invocation framework" responsible to >>> put the relevant directory onto PATH? I.e. Makefile.global shou

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-20 Thread Andres Freund
Hi, On 2021-10-20 14:30:49 -0400, Andrew Dunstan wrote: > On 10/20/21 12:31 PM, Andres Freund wrote: > > ISTM that we should just make the "test invocation framework" responsible to > > put the relevant directory onto PATH? I.e. Makefile.global should add the > > build directory of the test to PAT

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-20 Thread Andrew Dunstan
On 10/20/21 12:31 PM, Andres Freund wrote: > > ISTM that we should just make the "test invocation framework" responsible to > put the relevant directory onto PATH? I.e. Makefile.global should add the > build directory of the test to PATH, and vcregress.pl should put the relevant > $configuration/$

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-20 Thread Andres Freund
Hi, On 2021-10-18 11:39:08 -0400, Andrew Dunstan wrote: > On 10/18/21 10:23 AM, Alvaro Herrera wrote: > > On 2021-Oct-17, Andrew Dunstan wrote: > > > >> +sub find_built_program > >> +{ > >> + my $program = shift; > >> + my $path; > >> + > >> + if (defined $ENV{MSBUILDDIR}) > >> + { > >> +

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-18 Thread Andrew Dunstan
On 10/18/21 10:23 AM, Alvaro Herrera wrote: > On 2021-Oct-17, Andrew Dunstan wrote: > >> +sub find_built_program >> +{ >> +my $program = shift; >> +my $path; >> + >> +if (defined $ENV{MSBUILDDIR}) >> +{ >> +# vcregress.pl sets MSBUILDDIR which is the root of all the >

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-18 Thread Alvaro Herrera
On 2021-Oct-17, Andrew Dunstan wrote: > +sub find_built_program > +{ > + my $program = shift; > + my $path; > + > + if (defined $ENV{MSBUILDDIR}) > + { > + # vcregress.pl sets MSBUILDDIR which is the root of all the > build dirs > + my $wanted = sub { $_ eq

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-17 Thread Andrew Dunstan
On 10/8/21 8:33 PM, Andrew Dunstan wrote: > On 10/8/21 5:14 PM, Andres Freund wrote: >> Hi, >> >> On 2021-10-08 11:41:50 -0400, Andrew Dunstan wrote: >>> On 10/1/21 6:34 PM, Andres Freund wrote: Reference test binary using TESTDIR in 001_libpq_pipeline.pl. The previous approach didn

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-08 Thread Andrew Dunstan
On 10/8/21 5:14 PM, Andres Freund wrote: > Hi, > > On 2021-10-08 11:41:50 -0400, Andrew Dunstan wrote: >> On 10/1/21 6:34 PM, Andres Freund wrote: >>> Reference test binary using TESTDIR in 001_libpq_pipeline.pl. >>> >>> The previous approach didn't really work on windows, due to the PATH >>> se

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-08 Thread Andres Freund
Hi, On 2021-10-08 11:41:50 -0400, Andrew Dunstan wrote: > On 10/1/21 6:34 PM, Andres Freund wrote: > > Reference test binary using TESTDIR in 001_libpq_pipeline.pl. > > > > The previous approach didn't really work on windows, due to the PATH > > separator > > being ';' not ':'. Instead of making

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-08 Thread Andrew Dunstan
On 10/8/21 11:41 AM, Andrew Dunstan wrote: > On 10/1/21 6:34 PM, Andres Freund wrote: >> Reference test binary using TESTDIR in 001_libpq_pipeline.pl. >> >> The previous approach didn't really work on windows, due to the PATH >> separator >> being ';' not ':'. Instead of making the PATH change m

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-08 Thread Andrew Dunstan
On 10/1/21 6:34 PM, Andres Freund wrote: > Reference test binary using TESTDIR in 001_libpq_pipeline.pl. > > The previous approach didn't really work on windows, due to the PATH separator > being ';' not ':'. Instead of making the PATH change more complicated, > reference the binary using the TEST