On 2019-12-03 05:12, Michael Paquier wrote:
On Mon, Dec 02, 2019 at 10:11:40AM -0500, Tom Lane wrote:
One way would be to provide a variant expected-file, but that's not going
to be fun for future maintenance of the test script. Another simple
answer is to crank up client_min_messages for this
On Mon, Dec 02, 2019 at 10:11:40AM -0500, Tom Lane wrote:
> One way would be to provide a variant expected-file, but that's not going
> to be fun for future maintenance of the test script. Another simple
> answer is to crank up client_min_messages for this one test to hide the
> WARNING, but you c
Peter Eisentraut writes:
> On 2019-11-29 17:09, Tom Lane wrote:
>> But using a different name isn't going to invalidate the test case,
> The test case is specifically testing tablespace names starting with "pg_":
> -- reserved tablespace name
> CREATE TABLESPACE pg_foo LOCATION '/no/suc
On 2019-11-29 17:09, Tom Lane wrote:
+WARNING: tablespaces created by regression test cases should have names starting with
"regress_"
I agree that this is somewhat pointless in the case of an "unsafe" test.
But using a different name isn't going to invalidate the test case,
so there's not rea
On Fri, Nov 29, 2019 at 11:09:06AM -0500, Tom Lane wrote:
> I agree that this is somewhat pointless in the case of an "unsafe" test.
> But using a different name isn't going to invalidate the test case,
> so there's not really a reason to not follow the convention. And
> trying to have an exceptio
Peter Eisentraut writes:
> On 2019-11-29 16:27, Tom Lane wrote:
>> Oooh ... some of the buildfarm members are pointing out that this
>> didn't follow a project convention:
> Um, yes, that's why it's in unsafe_tests. Is there a way around this?
Sure, just change the test tablespace's name to fol
On 2019-11-29 16:27, Tom Lane wrote:
Peter Eisentraut writes:
Add a regression test for allow_system_table_mods
Oooh ... some of the buildfarm members are pointing out that this
didn't follow a project convention:
Um, yes, that's why it's in unsafe_tests. Is there a way around this?
@@
Peter Eisentraut writes:
> Add a regression test for allow_system_table_mods
Oooh ... some of the buildfarm members are pointing out that this
didn't follow a project convention:
@@ -153,6 +153,7 @@
ROLLBACK;
-- reserved tablespace name
CREATE TABLESPACE pg_foo LOCATION '/no/such/location';
+
Add a regression test for allow_system_table_mods
Add a regression test file that exercises the kinds of commands that
allow_system_table_mods allows.
This is put in the "unsafe_tests" suite, so it won't accidentally
create a mess if someone runs the normal regression tests against an
instance th
